Activity
From 10/31/2024 to 11/06/2024
11/06/2024
-
11:53 PM Feature #20864: Allow `Kernel#warn` to accept `**options` and pass these to `Warning.warn`.
- > We should also have a description of how the structured logging information should be handled by default.
Regarding the default behaviour, I propose no changes.
As an alternative, I'd also be open to dumping it, e.g. using `pp`.
... -
11:38 PM Feature #20864: Allow `Kernel#warn` to accept `**options` and pass these to `Warning.warn`.
- @ioquatix asked for my feedback on this. I'm against `Warning.warn` taking `**opts` for structured logging. We have an existing `category` keyword option that it would conflict with, and it would prevent the backwards compatible additi...
-
- According to the discussion I've updated the proposal.
-
10:56 PM Revision 6bc61426 (git): We should run Check Dependencies always for required status
- 10:32 PM Revision 46d25055 (git): Update default gems list at e4c15b8ace76d2a27191fe275b81d7 [ci skip]
-
10:31 PM Revision e4c15b8a (git): [ruby/json] Release 2.8.0
- https://github.com/ruby/json/commit/8071cc6f09
-
- `rb_cstr2inum` isn't very fast because it handles tons of
different scenarios, and also require a NULL terminated string
which forces us to copy the number into a secondary buffer.
But since the parser already computed the length, we ca... -
10:31 PM Revision 29d76d8c (git): [ruby/json] Fix right shift warnings
- Ignoring `CHAR_BITS` > 8 platform, as far as `ch` indexes
`escape_table` that is hard-coded as 256 elements.
```
../../../../src/ext/json/generator/generator.c(121): warning C4333: '>>': right shift by too large amount, data loss
../../... -
- If we assume most string don't contain any escape sequence we can avoid
a lot of costly operations when it holds true.
Before:
```
== Parsing activitypub.json (58160 bytes)
ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. https... -
- https://github.com/ruby/json/commit/1acce7aceb
-
10:03 PM Feature #20350: Return chilled string from Symbol#to_s
- As one data point in favour of this we swapped Symbol#to_s for Symbol#name (`Symbol.alias_method :to_s, :name`) to GitHub.com last week and it reduced allocations by about 5% on our web requests. So there should be pretty significant sav...
-
- ## Background
I found issues with `zlib.c` calling `rb_` functions without holding the GVL: <https://bugs.ruby-lang.org/issues/20863>. The GVL must be held before many of Ruby's C functions can be called. However, few functions check ... -
- Updated proposal: https://bugs.ruby-lang.org/issues/20876
-
- After discussing this with @ko1, we are going to (1) update the name to `blocking_operation_wait` and (2) introduce a flag to `rb_nogvl` to take a conservative approach to offloading work to the fiber scheduler. Once that's done I'll upd...
-
09:12 PM Feature #20770: A *new* pipe operator proposal
- mame (Yusuke Endoh) wrote in https://bugs.ruby-lang.org/issues/20781#note-9 at DevMeeting:
> AlexandreMagro (Alexandre Magro) wrote in #note-8:
> ...
Yes, `r |> q |> p` was just an abstract notation to explicitly show the order of meth... -
08:58 PM Revision fdc82cca (git): Update to ruby/spec@54c391e
-
-
- Thanks for your work and research about the performance cost.
-
08:55 PM Bug #20745 (Closed): IO::Buffer#copy triggers UB when src/dest buffers overlap
- Applied in changeset commit:git|35bf6603372360c7680653328274a670fa1d9f38.
----------
io_buffer.c: Allow copies between overlapping buffers with #copy and #set_string (#11640)
The current implementation of `IO::Buffer#copy` and `#set_st... -
- The current implementation of `IO::Buffer#copy` and `#set_string` has
an undefined behavior when the source and destination memory overlaps,
due to the underlying use of the `memcpy` C function.
This patch guarantees the methods to be s... -
06:21 PM Feature #20792: String#with_encoding(encoding)
- Hmm, I see what you mean. In that case I'm convinced. I have changed the title of this request to be String#with_encoding.
-
05:41 PM Feature #20859: Make Base64 to core class
- I agree with everything you said @mame. I didn't know the final goal of gemification of the standard library was to make all default gems either stdlib or bundled gems. I like that and I support it.
-
02:31 AM Feature #20859: Make Base64 to core class
- My understanding is that default gems are transitional to eventually being promoted to bundled gems. So, I didn't think there was an option to make it a default gem permanently. As a matter of fact, mirroring repositories is a pain.
I... -
04:58 PM Bug #20869: IO buffer handling is inconsistent when seeking
- Considering a parallel, the [manpage for the fseek(3) function](https://linux.die.net/man/3/fseek) clearly states that the effects of ungetc(3) are undone on successful calls to fseek(3).
-
- I'll add this to the next developer meeting.
-
- I think your code change highlights another bug caused by the current behavior where `IO#pos` can report negative values. Oddly, `IO#seek(0, :CUR)` still returns 0:
```ruby
require 'tempfile'
Tempfile.open do |f|
f.write('0123... -
04:48 PM Feature #20794: Expose information about the currently running GC module
- I agree that parsing a string from `GC.active_gc_name` might not be good. My concern with `GC.config` is that these keys are not configurable at runtime, so the corresponding `GC.config(implementation: "something else")` will not work. I...
-
- Would a dedicated method like `active_gc_name` be good? I guess there will be variants and configurations like "mmtk-immix". It does not look good to me to add the information into a string, like HTTP user agent. How about adding key-val...
-
- * [Bug #20869] IO buffer handling is inconsistent when seeking (byroot)
* The ticket show multiple weirdness around `IO#ungetbyte / IO#ungetc` and `#IO#seek`.
* This is very clearly a bug, but what the right behavior should be isn'... -
- Applied in changeset commit:git|56ecc243e230e8e99761ec0ffc5116601f094bb0.
----------
[Bug #20868] Fix Method#hash to not change after compaction
The hash value of a Method must remain constant after a compaction, otherwise
it may not w... -
- The hash value of a Method must remain constant after a compaction, otherwise
it may not work as the key in a hash table.
For example:
def a; end
# Need this method here because otherwise the iseq may be on the C stack
# w... - 02:58 PM Revision 96e695ad (git): Fix flakiness in TestGc#test_thrashing_for_young_objects
- I caught a reproduction of this test failing under rr, and was able to
replay it to isolate the failure. The call to
`before_stat_heap = GC.stat_heap` is itself allocating a hash, which in
unlucky circumstances can result in a new page b... -
- https://github.com/rubygems/rubygems/commit/5e933968a2
-
- https://github.com/rubygems/rubygems/commit/6fa94b5d72
-
- https://github.com/rubygems/rubygems/commit/f2e0a72291
-
- https://github.com/rubygems/rubygems/commit/92196ccfdb
-
- https://github.com/rubygems/rubygems/commit/4168a7f488
-
- https://github.com/rubygems/rubygems/commit/8fac200ded
-
- https://github.com/rubygems/rubygems/commit/a4dd06f095
-
12:59 PM Revision cb49ed26 (git): Update ext/openssl/depend
- This is a follow-up to commit e5860e565467cb330f2c7b9ae140a1e4b89c0b71.
-
- This is an evolution of the previous proposal: https://bugs.ruby-lang.org/issues/20855
## Background
The current Fiber Scheduler performance can be significantly impacted by blocking operations that cannot be deferred to the event ... -
- nobu (Nobuyoshi Nakada) wrote in #note-1:
> It looks no hurt to remove the conditional already.
Ah, yes. That should be right. -
- It looks no hurt to remove the conditional already.
-
11:57 AM Revision 84a8b911 (git): Store precomputed hash when there's capacity
- Co-authored-by: Jean Boussier <byroot@ruby-lang.org>
-
- If a gem package is built from a specification whose platform has been
modified, it will include metadata using the old platform.
This change should fix the problem by making sure `original_platform` is
always properly set.
https://git... -
- When using the `bundler/setup` entrypoint, Bundler prints the following
warnings in JRuby in `-w` is passed to Ruby.
```
/path/to/bundler/shared_helpers.rb:10: warning: constant Bundler::WINDOWS is deprecated
/path/to/bundler/shared_hel... -
10:17 AM Revision e5860e56 (git): [ruby/openssl] move ractor safe macro to ossl.h
- in order to import or define the RUBY_TYPED_FROZEN_SHAREABLE macro.
https://github.com/ruby/openssl/commit/b8504c2215 - 09:19 AM Revision 3b9896ac (git): Revert "Introduce Fiber Scheduler `blocking_region` hook. (#11963)" (#12013)
- This reverts some of commit 87fb44dff6409a19d12052cf0fc07ba80a4c45ac.
We will rename and propose a slightly different interface. -
09:03 AM Feature #20782: Introduction of Happy Eyeballs Version 2 (RFC8305) in TCPSocket.new
- +1
-
- +1
- 08:59 AM Revision 74834fd7 (git): Update default gems list at 82008d38e01f8b0b3f808a91841b8d [ci skip]
-
- https://github.com/ruby/shellwords/commit/ee08b981ac
- 08:38 AM Revision 6cb43375 (git): Update default gems list at 8f4227b664d8e74fc81adf0b31b295 [ci skip]
-
- https://github.com/ruby/open-uri/commit/8f5a4ef6f9
-
08:28 AM Feature #20875 (Closed): Atomic initialization for Ractor local storage
- ## Motivation
Now there is no way to initialize Ractor local storage in multi-thread.
For example, if we want to introduce per-Ractor counter, which should be protected with a per-Ractor Mutex for multi-threading support.
```rub... - 08:27 AM Revision 81b30797 (git): Update default gems list at 0c59048b3a981a80d57d2318c37b36 [ci skip]
-
- https://github.com/ruby/timeout/commit/2f52522994
- 08:06 AM Revision 201e1c6c (git): Update default gems list at 7d9e9eabe7d6c53f5a24297b6275d8 [ci skip]
-
- https://github.com/ruby/tmpdir/commit/ef9ca591cf
- 07:48 AM Revision 348e9256 (git): Update default gems list at 7e167b3225312410dcd8c303aa1ca9 [ci skip]
-
- https://github.com/ruby/tempfile/commit/2ff9b3ccef
- 07:33 AM Revision 9b287d3b (git): Update default gems list at a3a0c675c1e701d88b5d0cbcea54f1 [ci skip]
-
- https://github.com/ruby/yaml/commit/5e9bfff132
- 07:10 AM Revision 6e4fcddc (git): Update default gems list at 0949c586c05e7513497fd2e84edb03 [ci skip]
-
- https://github.com/ruby/pathname/commit/b020cbde46
-
-
-
-
- We should fix this later
-
-
-
-
-
- ```
clang: error: unknown argument '-emit-pch'; did you mean '-Xclang -emit-pch'?
MJIT warning: Making precompiled header failed on compilation. Stopping MJIT worker...
Successful MJIT finish
``` -
05:45 AM Bug #20874 (Open): Difference in documentation for `irb -U` between `man irb` and `irb --help`
- There is a difference in documentation for `irb -U` between `man irb` and `irb --help`.
* `man irb`: Same as `ruby -U' . Sets the default value for internal encodings (Encoding.default_internal) to UTF-8.
* `irb --help`: Set externa... -
- Applied in changeset commit:git|d71be7274bd2623bb521be72c245c08fc38d6ae4.
----------
[Bug #20873] Consider `-FIXNUM_MIN` overflow
`-FIXNUM_MIN` is usually greater than `FIXNUM_MAX` on platforms using
two's complement representation. -
- Since the beginning, ruby 2.3.
```ruby
require 'rbconfig/sizeof'
fmin, fmax = RbConfig::LIMITS.values_at("FIXNUM_MIN", "FIXNUM_MAX")
sprintf("%f", Rational(fmin, fmax)) #=> --1.000000
```
-
- `-FIXNUM_MIN` is usually greater than `FIXNUM_MAX` on platforms using
two's complement representation. - 04:30 AM Revision c7c895ce (git): * 2024-11-06 [ci skip]
-
-
04:30 AM Revision 279fb008 (git): Skip tests that suddenly started failing for MinGW
- These test failures first appeared on irrelevant changes. It probably
came from changes in GitHub Actions instead of CRuby's.
Until we figure out how to fix these tests, let's skip them to make the
CI usable. -
-
-
- ```
clang: error: unknown argument '-emit-pch'; did you mean '-Xclang -emit-pch'?
MJIT warning: Making precompiled header failed on compilation. Stopping MJIT worker...
Successful MJIT finish
``` -
-
- Fix as the compiler orders:
```
warning: unused return value of `into_raw_fd` that must be used
--> ../src/yjit/src/disasm.rs:123:21
|
123 | file.into_raw_fd(); // keep the fd open
| ^^^... -
- Applied in changeset commit:git|ab7ab9e4508c24b998703824aa9576fb2e092065.
----------
`Warning[:strict_unused_block]`
to show unused block warning strictly.
```ruby
class C
def f = nil
end
class D
def f = yield
end
[C.new, D.new]... -
- to show unused block warning strictly.
```ruby
class C
def f = nil
end
class D
def f = yield
end
[C.new, D.new].each{|obj| obj.f{}}
```
In this case, `D#f` accepts a block. However `C#f` doesn't
accept a block. There are some cas... -
- Please ask the rubygems upstream.
-
- `Bundler::SharedHelpers#set_rubylib` sets `RUBYLIB` to include `bundler_ruby_lib`.
So it may work by just setting `RUBYOPT` to `-rbundler/setup` in `Bundler::SharedHelpers#set_rubyopt`.
I don't know why it sets the absolute path, ple... -
- > probably defined in `Bundler::SharedHelpers#set_rubyopt`.
11/05/2024
-
- I just noticed that C++ compilers warn for undefined RUBY_API_VERSION_MAJOR/RUBY_API_VERSION_MINOR macros in `<ruby/backward/cxxanyargs.hpp>` when preprocessing `<ruby.h>`.
```
% cat test.cpp
#include <ruby.h>
% clang++ -Wundef -... -
-
- Fixes [Bug #20856]
Co-Authored-By: Aaron Patterson <tenderlove@ruby-lang.org> -
- Thanks for your feedback. The proposal is deliberately thin - as I said, I don't know exactly how we should adjust the internal interface to handle this (actually I don't have a strong opinion about it). The main point is, to allow for a...
-
04:14 PM Feature #20864: Allow `Kernel#warn` to accept `**options` and pass these to `Warning.warn`.
- I think I agree with the general idea but I'm not sure if the proposal is what I think it is. It's a bit thin about what happens with this "error" keyword exactly. So is the idea that this meta-information would be forwarded to another m...
-
- > I wonder why error: in particular, and not just warn(text, **any_structured_metadata)?..
I'd be okay with that, in fact I was thinking of making that proposal but I wasn't sure it would be accepted if it was too general.
> ...
Good q... -
- Why not include the error directly in the warning message?
It seems that would just work better with the whole `Warning.warn` system and existing handling of warnings. -
12:26 PM Feature #20864: Allow `Kernel#warn` to accept `**options` and pass these to `Warning.warn`.
- I wonder why `error:` in particular, and not just `warn(text, **any_structured_metadata)`?..
-
- ## Background
Structured logging is a practice that organizes log data in a consistent, easily parseable format. Unlike traditional unstructured logs, which often consist of plain text entries, structured logs format information in ke... -
- > Zlib.deflate is a CPU-bound operation right? So it makes sense for Fibers of the same Thread to execute the 10 operations sequentially.
Yes, `Zlib.deflate` with a big enough input can become significantly CPU bound. Yes, executing t... -
04:56 PM Feature #20855: Introduce `Fiber::Scheduler#blocking_region` to avoid stalling the event loop.
- > If rb_nogvl is called in the fiber scheduler, it can introduce latency, as releasing the GVL will prevent the event loop from progressing while nogvl function is executing
I definitely understand the problem here. But… dealing with ... -
- I also don't understand this patch. `Zlib.deflate` is a CPU-bound operation right? So it makes sense for Fibers of the same Thread to execute the 10 operations sequentially. That's what Fibers are about. If you want parallelism you need ...
-
- > I don't introduce blocking_region.
I am not strongly attached to the name, I just used `blocking_region` as it is quite commonly used internally for handling of blocking operations and has existed for 13 years (https://github.com/ruby... -
- In terms of naming, `blocking_region` sounds too internal to me.
I think the C API talks about `blocking_function` (`rb_thread_call_without_gvl`, `rb_blocking_function_t` although that type shouldn't be used) and `unblock_function` (`rb... -
- I against this proposal because
* I can't understand what happens on this description. I couldn't understand the control flow with a given func for rb_nogvl.
* I'm not sure what is the `work` for `blocking_region()` callback.
* I don't ... -
08:25 PM Bug #20871: Including methods in Enumerable doesn't make them available in Array
- Forgot to mention.
We use the `parallel_tests` gem to speed up our specs in CI.
On my local environment, with synchronous tests, I haven't been able to reproduce the same behaviour either. -
- Today, our CI pipeline started failing after the automatic update from v3.3.5 to v3.3.6.
After researching, it turned out that our core extensions to the `Array` class weren't loaded anymore.
The core-extensions code looks like thi... -
- Yes, quite certain it's a duplicate of [Bug #20799] that I reported to Aaron a couple weeks back and that he already fixed.
-
04:00 PM Bug #20865: `Stack consistency error` running ActiveSupport test
- Can you try with the latest master? I suspect this is already fixed.
-
02:22 PM Bug #20865: `Stack consistency error` running ActiveSupport test
- And this is shorter reproducer:
~~~
$ ruby -Ilib:test -e 'Dir.glob "./test/**/current_attributes_test.rb", &method(:require)' -- -v
/usr/share/gems/gems/minitest-5.25.1/lib/minitest/mock.rb:33: warning: redefining 'object_id' may cause ... -
- Was able to reproduce with debuginfo installed:
~~~
-- C level backtrace information -------------------------------------------
/lib64/libruby.so.3.4(rb_print_backtrace+0x21) [0x7fcf39c5eaf1] /usr/src/debug/ruby-3.4.0~20241016git3d... -
- Trying to build ActiveSupport package for Fedora Rawhide, I have hit the following error for the second time:
~~~
+ ruby -Ilib:test -e 'Dir.glob "./test/**/*_test.rb", &method(:require)'
/usr/share/gems/gems/minitest-5.25.1/lib/mini... -
- Just a quick proof of concept that fixes the first case: https://github.com/ruby/ruby/commit/7481a12fef3df934ab0d9db7f8f2d36341a1562e
But I think a lot more codepath would need to consider and update that new offset for the entire cla... -
- I just looked into this a bit, I'm not quite familiar enough with the code to really propose a fix, but I get what is happening:
ungetbyte just shift the buffer offset, but the FD offset in unchanged.
```c
static void
io_ungetbyte(VALU... -
- When performing any of the seek based operations on IO (IO#seek, IO#pos=, or IO#rewind), the read buffer is inconsistently cleared:
```ruby
require 'tempfile'
Tempfile.open do |f|
f.write('0123456789')
f.rewind
# Callin... -
05:40 PM Feature #20870 (Third Party's Issue): GEM_ROOT -
- I know we can set GEM_HOME. If I have multiple rubies installed I would like GEM_HOME to be GEM_ROOT/#{RUBY_ENGINE}/#{RUBY_VERSION} without requiring an external script or wrappper script to run ruby and change environment variables
-
- I don't have RUBYOPT set in my environment -Is bundler setting it?
-
- dsisnero (Dominic Sisneros) wrote:
> Trying to run bundle exec rspec or bundle exec hanami. My username on my work computer has space in it "Dominic E Sisneros" (not by choice). When trying to run I get the following output
> ...
It ... -
- Trying to run bundle exec rspec or bundle exec hanami. My username on my work computer has space in it "Dominic E Sisneros" (not by choice). When trying to run I get the following output
```
C:\windows_home\ruby\ruby-3.3.4-1\bin\ru... -
- https://github.com/ruby/json/commit/bc2c970ce4
-
- https://github.com/ruby/json/commit/e85107197b
-
-
-
- https://github.com/ruby/json/commit/82d21f01c5
-
- Ref: https://github.com/ruby/json/pull/674
Ref: https://github.com/ruby/json/pull/668
The behavior on such case it quite unclear, the goal here is to
figure out whatever was the behavior on Cext version of `json 2.7.0`
and get all imple... -
- https://github.com/ruby/json/commit/90c8aaaa6a
-
- This is somewhat dead code as unless you are using `JSON::Parser.new`
direcltly we never allocate `JSON::Ext::Parser` anymore.
But still, we should mark all its reference in case some code out there
uses that.
Followup: #675
https://g... -
-
- https://github.com/rubygems/rubygems/commit/b282668d9d
-
- Fix: https://github.com/ruby/ruby/pull/12004
The hash value of a Method may change after a compaction but must remain constant because otherwise it may not work as the key in a hash table.
For example:
```ruby
def a; end
# N... -
- Thanks for your report, this is now fixed.
-
03:36 PM Bug #20762 (Closed): `make test-basic` with -DRGENGC_FORCE_MAJOR_GC is always failure
- Applied in changeset commit:git|01e509c45bca9ca5800df36690904f4b883d3292.
----------
Remove RGENGC_FORCE_MAJOR_GC flag
[Bug #20762] -
- Nobody uses `RGENGC_FORCE_MAJOR_GC` so I'm okay to remove this flag.
-
- [Bug #20762]
-
03:15 PM Bug #20866 (Closed): Prism assertion when running simplecov with branch coverage and requiring certain code
- I stumbled upon the following bug report against simplecov: https://github.com/simplecov-ruby/simplecov/issues/1113
I reduced the error down to the following:
```rb
# Gemfile
source "https://rubygems.org"
gem "simplecov"
```
... -
- Mingw crt-git 12.0.0.r369.g0d4221712-1 now prohibits "command line
contains characters that are not supported in the active code page".
https://sourceforge.net/p/mingw-w64/mingw-w64/ci/0d42217123d3aec0341b79f6d959c76e09648a1e/
Already R... -
01:53 PM Revision ed06f018 (git): [ruby/irb] windows does not support Process.kill("TERM", pid)
- (https://github.com/ruby/irb/pull/1026)
https://github.com/ruby/irb/commit/7bbb885163 -
-
- `lib/json/ext/generator/state.rb` should actually be
`ext/json/lib/json/ext/generator/state.rb` -
- - [Bug #20863] `zlib.c` calls `rb_str_set_len` and `rb_str_modify_expand`(and others) without holding the GVL (ioquatix)
- Is the PR (https://github.com/ruby/zlib/pull/88) to zlib acceptable?
- [Feature #20877] Introduce (public) debug... -
- AlexandreMagro (Alexandre Magro) wrote in #note-8:
> * Improves readability by transforming `p(q(r))` into a more natural `r |> q |> p`, matching how we think.
Do you mean `r |> q(_) |> p(_)`? -
- rb_fiber_scheduler_current() may return nil depending on whether the
scheduler is being prevented for some reason, e.g., Fiber.blocking{}.
Co-Authored-By: Samuel Williams <samuel.williams@oriontransfer.co.nz> -
- ## Background
I was working on https://bugs.ruby-lang.org/issues/20876 and was investigating some problems with `zlib.c` and GVL, and noticed that `zstream_run_func` is executed without the GVL, but can invoke various `rb_` string fun... -
- And run on the latest ubuntu.
-
-
- ... just for the case.
-
07:53 AM Feature #20861: Add an environment variable for tuning the default thread quantum
- https://github.com/ivoanjo/gvl-tracing/blob/master/examples/rubykaigi2023/rk-example6.rb (from [here](https://ivoanjo.me/rubykaigi2023/#:~:text=Observing%20the%20GVL%20%236)) is probably a good example without `sleep` -- the thread doing...
-
- This example doesn't make sense for the real app because nobody repeat sleeping for the constant.
Do you have any example similar to the example?
But the current 100ms is not based on strong opinion (it equals to Linux time quantum), so... -
- I think this is really nice first step and worth having to enable experimentation as well.
Having said that, I'm not sure there's ever going to be a good value single (even per-thread). It may be worth considering on the medium/long-t... -
- Maybe fixed by commit:783dde2159a3689ad2d3ef6b7d0005a7cf80adba
-
- https://github.com/ruby/ruby/blob/v3_3_5/gc.c#L7529C1-L7530C1
It seems marking `T_STRUCT` fields.
Marking miss for that? -
-
-
- Fixed by commit:773d140f65c1c8b726e107915bc003c186f38677
-
-
- When ungetting the string same as the same buffer string, extending
the buffer can move the pointer in the argument. Reported by manun
Manu (manun) at https://hackerone.com/reports/2805165.
https://github.com/ruby/stringio/commit/95c11... -
- https://github.com/ruby/date/commit/e677e99a86
-
- https://github.com/ruby/date/commit/f277463439
-
- https://github.com/ruby/date/commit/1970b740d0
- 03:38 AM Revision ee4599db (git): [ruby/date] Fix incorrect argc2 decrement in datetime_s_iso8601 function
- Replace the decrement (argc2--) with an increment (argc2++) for
the correct number of arguments when opt is provided.
https://github.com/ruby/date/commit/b6974b00d8 -
- https://github.com/actions/runner-images/issues/10686
-
-
-
- These test failures first appeared on irrelevant changes. It probably
came from changes in GitHub Actions instead of CRuby's.
Until we figure out how to fix these tests, let's skip them to make the
CI usable.
11/04/2024
-
11:58 PM Revision b1fc1af4 (git): Stop syncing json benchmarks.
-
- https://github.com/actions/runner-images/issues/10721
-
- https://github.com/actions/runner-images/issues/10721
-
- ruby_3_3 commit:6db39f4677ff50aacfe54bd9dda052c09e1c6ab0 merged revision(s) commit:29c480dd6fca993590c82078ba797e2c4e876ac7.
-
- [Bug #20853] Fix Proc#hash to not change after compaction
The hash value of a Proc must remain constant after a compaction, otherwise
it may not work as the key in a hash table. -
- ruby_3_3 commit:edeb0319f7a95dfe3f9b895bcf32371dd8514726 merged revision(s) commit:6118e8a47394409b53164b60e79fadf348b97db3.
-
- Fix method caching bug when including/prepend module A that prepends module B
Fix by always adding the generated iclass to the subclasses list,
otherwise the method cache for the iclass is not cleared when
the me... -
- I feel the same about it. This is gonna be a WONTFIX for `ruby_3_3` too.
-
- ruby_3_3 commit:5ce0ba0d415deb99527c409cc5f1df16ce02ef3e merged revision(s) commit:35e124832e29b65c84d4e0e4e434616859f9bdf5.
-
- [Bug #20755] Frozen string should not be writable via IO::Buffer
-
- ruby_3_3 commit:12ea98e8c8af0ed6778aad26e7ec5f95e2c239e5 merged revision(s) commit:637067440f74043c6d79fc649ab8acf1afea25a5.
-
- [Bug #20752] Slice of readonly `IO::Buffer` also should be readonly
-
- ruby_3_3 commit:34a0f41d0aaff190f1647a6fa0e905690d0eff98 merged revision(s) commit:c1862cbb89a6bf42dcd07d92fe4f4bfeebca5775.
-
- [Bug #20719] `Float` argument must be ASCII compatible
-
- ruby_3_3 commit:2b713dcb89c620daa55d672d2933ffde333ca5de merged revision(s) commit:d33e3d47b84a73b38644f2a3d41881ce9be6ef18.
-
- [Bug #20704] Win32: Fix chdir to non-ASCII path
On Windows, `chdir` in compilers' runtime libraries uses the active
code page, but command line arguments in ruby are always UTF-8, since
commit:33ea2646b98adb49ae2... -
- Backporting this patch (https://github.com/ruby/ruby/pull/11554) to `ruby_3_3` causes a lot of conflicts. Please file a PR to `ruby_3_3` branch on GitHub for this ticket to be backported.
-
- ruby_3_3 commit:e7c939aea1034a463226635e11117ade42cba4e4 merged revision(s) commit:76ea5cde2a0f4834a5228104249b6b3346ddfc94.
-
- Refactor RUBY_DESCRIPTION assertions in test_rubyoptions
-
- ruby_3_3 commit:7446f7cdd103b129b8b750f577efd29e069176c0 merged revision(s) commit:0d16c36d0ab2afa2ec79b72b229e69c141ebdaba.
-
10:26 PM Revision 7446f7cd (git): merge revision(s) 0d16c36d0ab2afa2ec79b72b229e69c141ebdaba: [Backport #13831]
- [win32/registry] Fallback to UTF-8 for unknown codepages
There are some codepages like cp708 for which no ruby encoding exists:
$ ruby -e "Encoding.find('cp708')"
Traceback (most recent call last):
... -
- ruby_3_3 commit:5b6009870dff883a8e71a05e60f175cea1d00d55.
-
- rubygems v3.5.19 has been merged to `ruby_3_3` https://github.com/ruby/ruby/pull/11682, which addresses this issue.
-
- ruby_3_3 commit:55ddfd58dd6e67e88cf9a3e55bf99550affe8b3f.
-
- Thanks for the report, it should be fixed by https://github.com/ruby/ruby/pull/11993.
-
05:34 PM Revision 7ae4b858 (git): [ruby/rdoc] Display class ancestors in the sidebar #1183
- https://github.com/ruby/rdoc/commit/50dda13426
-
- * YJIT: Replace Array#each only when YJIT is enabled
* Add comments about BUILTIN_ATTR_C_TRACE
* Make Ruby Array#each available with --yjit as well
* Fix all paths that expect a C location
* Use method_basic_definition_p to detect pa... -
-
- The temporary directory is the second argument.
-
- When a fake string is interned, use the capa field to store the string
hash. This lets us compute it once for hash lookup and embedding the
hash in the interned string.
Co-authored-by: Jean Boussier <byroot@ruby-lang.org> -
- Mingw crt-git 12.0.0.r369.g0d4221712-1 now prohibits "command line
contains characters that are not supported in the active code page".
https://sourceforge.net/p/mingw-w64/mingw-w64/ci/0d42217123d3aec0341b79f6d959c76e09648a1e/
Provision... -
- Thanks for the reply, I appreciate that! It's not urgent or anything, I was just a bit uncertain if musl may be some other issue entirely. I'll follow https://github.com/llvm/llvm-project/issues/114720 and be on the lookout for something...
-
- I think these are two separate issues, so maybe better implement/discuss in two separate steps?
* One would be something like "Making `base64` a bundled gem caused too much trouble, let's revert that". This seems straightforward to fi... -
- If the user has the encoding of her system messed up, she may end up
sending us incorrectly encoding input, causing "invalid byte sequence in
UTF-8" errors at random places.
These errors can be forced on a system without encoding issues... -
- If a command requires two MFA authenticated requests, and webauthn is
enabled, then first one will succeed but the second one will fail
because it tries to reuse the OTP code from the first request and that
does not work.
This happens w... -
- The `gem owner` command rescues standard errors, but does not rescue
SystemExit errors. If TermError is a standard error, not a system exit,
tests don't behave like realworld for this command.
https://github.com/rubygems/rubygems/commit... -
- https://github.com/rubygems/rubygems/commit/15930fe126
-
- https://github.com/rubygems/rubygems/commit/d478ec403f
-
- > Thread priority is good because it is more abstract, which gives flexibility on implementation.
Then we should document what it does, even if stated that the behavior may change between version. Because in its current state it's pre... -
- I don't think we should expose the quantum per-thread inside Ruby. I worry it will prevent future improvements. The fact that Thread scheduling and priorities are currently done by giving a shorter/longer quantum is an implementation det...
11/03/2024
-
- I tested 1.82.0 from rustup and [rust-lang/rust#125619](https://github.com/rust-lang/rust/issues/125619)
does reproduce when targeting aarch64-unknown-linux-musl. I was under the
impression that we've worked around the issue for all targ... -
- Yes, guilty as charged. I apologize, I only saw the failure for one variant and assumed the same for others.
Can you say if what I wrote above is correct for musl? I guess I'll see when the next version releases regardless.
Edit: Hm, I... -
- @Earlopain Are you using musl through e.g. Alpine Linux? The workaround rust PR is <https://github.com/rust-lang/rust/pull/125999>, it shipped in 1.81.0 and we've seen it [work](https://github.com/Shopify/ruby/issues/559#issuecomment-241...
-
- Small update, I believe https://github.com/rust-lang/rust/pull/131221 will fix this, which is slated for Rust 1.83. Not so sure about that since the actual fix seems to have been applied in llvm https://github.com/llvm/llvm-project/pull/...
-
- * [Feature #20770] (Re)Introduce pipe operator (AlexandreMagro)
* Initially proposed as syntactic sugar for `.then`, and later refined after discussion to work as a statement separator (like `;`) with a variable carrying the LHS expres... -
- https://github.com/ruby/prism/commit/232a02acef
11/02/2024
-
-
08:34 PM Feature #20861: Add an environment variable for tuning the default thread quantum
- byroot (Jean Boussier) wrote in #note-6:
> > Are you thinking something different (like specify quantum in time rather than priority?)
> ...
Makes sense, and I agree.
> But perhaps a `Thread.default_quantum = XX` would be needed too... -
- > Are you thinking something different (like specify quantum in time rather than priority?)
Yes, quite literally: `Thread.current.quantum = 20` or something like that.
Which IMO is much easier to reason about than priorities. And g... -
- ioquatix (Samuel Williams) wrote in #note-2:
> This can be useful, so I agree with adding it.
> ...
Thank you for the feedback, but I think these points should be addressed as a different feature. I do think the default quantum should... -
- This was discussed a few times at Kaigi, and IMO a quantum value on a per thread basis would make more sense.
-
- Your patch misses pthread_win32.c, and if we add a new environment variable, man/ruby.1 must be updated as well.
-
- This can be useful, so I agree with adding it.
For the sake of providing feedback, some thoughts:
1. Does the default value of 100ms make sense? Should we update the default too?
2. Should we mark this as experimental in the first... -
02:34 PM Bug #20862 (Closed): gem install --document=rdoc,ri fails with some gem
- With using commit:24f7829abfd29fc226e38829caaecaa76885afbf , trying `$ gem install --document=rdoc,ri foo.gem` fails with some (not one) gem like:
```
$ gem install -V --document=rdoc,ri tk
...
...
ERROR: While executing gem ... ... -
-
- `RUBY_VM_CRITICAL_SECTION` is not used anywhere.
- 01:44 AM Revision 4031beb0 (git): Add documentation for `RUBY_ASSERT_CRITICAL_SECTION`. (#11982)
-
11/01/2024
-
- hsbt (Hiroshi SHIBATA) wrote in #note-2:
> @matz I propose @shioimm as a Ruby committer. She is best person to maintain HEv2 and Socket related feature. It's good time to commit https://github.com/ruby/ruby/pull/11653 by herself.
> ...
+1 -
- @matz I propose @shioimm as a Ruby committer. She is best person to maintain HEv2 and Socket related feature. It's good time to commit https://github.com/ruby/ruby/pull/11653 by herself.
I'll support and mentor her. -
- I think I did my math a little wrong. It should be 50ms rather than 500ms, but the measurements are correct. Specifying the 10ms quantum reduces waste by ~3.5 seconds. 😅
-
- The default thread quantum is currently [hard coded at 100ms](https://github.com/ruby/ruby/blob/c7708d22c33040a74ea7ac683bf7407d3759edfe/thread_pthread.c#L323). This can impact multithreaded systems that are trying to process Ruby level...
-
06:16 PM Misc #20781: DevMeeting-2024-11-07
- * [Feature #20818] Allow passing a block to Hash#store to update current value (furunkel)
* currently, to update a value in a hash we have to call `#[]` followed by `#[]=`
* this calls `#hash` twice (on key), and requires two loo... -
- - [Feature #20860] Merge Optional Experimental Feature MMTk into Ruby
- We are proposing to merge MMTk into the `ruby/mmtk` repository, which will be mirrored into `ruby/ruby`.
- This implementation uses the GC API (introduced ... -
- * [Feature #20859] Make Base64 to core class
* It's useful and helpful for gemification.
-
- * [Feature #20782] Introduction of Happy Eyeballs Version 2 (RFC8305) in TCPSocket.new
* Propose shioimm as a Ruby committer
* How about it?
-
05:42 PM Bug #20858: multiple parallel assignments are inconsistent
- mame (Yusuke Endoh) wrote in #note-1:
> Currently, `a, b = c, d = 3, 4` is interpreted as `a, b = c, (d = 3, 4)`. Whether it is good or not.
Ah - that's a good point. So it can be fixed with: `a, b = (c, d = 3, 4)`
I didn't see t... -
- Currently, `a, b = c, d = 3, 4` is interpreted as `a, b = c, (d = 3, 4)`. Whether it is good or not.
-
- I may have terminology wrong, so apologies. For this bug I'm going to use "multiple assignment" to refer to using multiple assignment operators in a line, such as:
``` ruby
a = b = c = 1
```
And then parallel assignment to refer... -
- I also think the general sentiment about this extraction is that the dependency is too small to justify adding it. For most users it's pretty much a one liner.
That said, is there a problem in just keeping it as a "default gem"? Now t... -
- Why make it built-in all at once, rather than moving it back to the standard library?
-
- Just FTR, some usage of base64 was already removed, but I think that other projects already added the base64 dependency (or are about to add it [1]).
[1]: https://github.com/cucumber/cucumber-ruby/pull/1762 -
- From https://bugs.ruby-lang.org/issues/20857#note-12
I also heard that `base64` gem has some issue for eco-system like https://github.com/ddnexus/pagy/pull/618. My fist intention is simply added `base64` gem into gem dependency by `Ge... -
05:25 PM Bug #20722: curious search result order on docs.ruby-lang.org
- I have reported it here:
https://github.com/ruby/rdoc/issues/1194
This one can probably be closed. -
- mame (Yusuke Endoh) wrote in #note-12:
> # 8: cucumber?
> ...
Once I have fixed rubygem-cucumber, rpsec-its moved into `backtick` category:
https://github.com/rspec/rspec-its/blob/6dec295173dfd245fd844f76e3908fcc3f84df10/features/it... -
- mame (Yusuke Endoh) wrote in #note-12:
> # 8: cucumber?
> ...
This seems to be fixed upstream:
https://github.com/cucumber/cucumber-ruby/pull/1757
But something is IMHO wrong if the change needs to explain the formatting.
> ru... -
- mame (Yusuke Endoh) wrote in #note-12:
> I took a quick look at all the failures of packages starting with "ruby"
Just FTR, all packages in the repository has dependency on Ruby, even those without `ruby` prefix. Some of them might u... -
- FWIW, I was fine with this change, but it broke some of my tests.
The solution was to not use string equality, but instead do this:
```ruby
# Before
expect(thing).to be == '{"x"=>10}'
# After
expect(thing).to be == {"x"=>10}.to_s
```
... -
03:28 AM Bug #20857: Ruby 3.4 seems to have backwards compatibility issues more than its predecessors
- (Let me change the subject of this thread. It is not only the matter of Hash#inspect anymore.)
-
- I took a quick look at all the failures of packages starting with "ruby" in https://copr.fedorainfracloud.org/coprs/vondruch/mpb/packages/, and categorized them. Please forgive me if this is not accurate.
* 38 of them seemed to be dep... -
- GitHub PR: https://github.com/ruby/ruby/pull/11979
## Summary
In this ticket, we're proposing upstreaming the current MMTk implementation into the `ruby/mmtk` repository. This repository will be mirrored into `ruby/ruby` and adds t... - 03:42 PM Revision 6b3a0b4f (git): Bump REXML to 3.3.9 for Ruby 3.3 (#11972)
-
- Applied in changeset commit:git|29c480dd6fca993590c82078ba797e2c4e876ac7.
----------
[Bug #20853] Fix Proc#hash to not change after compaction
The hash value of a Proc must remain constant after a compaction, otherwise
it may not work ... -
-
-
-
- The hash value of a Proc must remain constant after a compaction, otherwise
it may not work as the key in a hash table. -
-
-
- 05:05 AM Revision 4cd7e801 (git): Update default gems list at 314b556cc57d93a6e0e2b120fb7e7a [ci skip]
-
- https://github.com/ruby/fileutils/commit/c138e67613
- 04:43 AM Revision fcbaaf3d (git): Update default gems list at bb5f28c8f7e692571a30359e08b539 [ci skip]
-
- https://github.com/ruby/date/commit/94f8e51e65
- 04:33 AM Revision 8ebca9b4 (git): Update default gems list at 8a768890f7f480b58814f64bbc3ff4 [ci skip]
-
- https://github.com/ruby/win32ole/commit/31bd08aa9c
- 04:10 AM Revision 5e6f0f73 (git): Update default gems list at c866fb7caf3d7921f0ecd1b8a06116 [ci skip]
-
- https://github.com/ruby/etc/commit/0d2f76ffb4
-
-
- Rather than to copy into a buffer to unescape and then copy that
buffer into the final string, we can directly copy into the final
string.
The downside is that if the string contains a lot of escaping, we
end up returning a string that'... -
- Followup: https://github.com/ruby/json/commit/6382c231b0b8
https://github.com/ruby/json/commit/0c797b4a11 -
- Fix: https://github.com/ruby/json/issues/667
This is yet another behavior on which the various implementations
differed, but the C implementation used to call `to_json` on String
subclasses used as keys.
This was optimized out in e1250... -
- Now that older rubies have been droped, we no longer need to check
for all that.
https://github.com/ruby/json/commit/35cf2b84e0 -
- If that assumption holds true, then we don't need to copy the
string into a buffer to unescape it. For small string is just saves
copying, but for large ones it also saves a malloc/free combo.
Before:
```
== Parsing twitter.json (56791... -
- https://github.com/ruby/json/commit/7e557ee291
-
- * rb_str_conv_enc() returns the source string unmodified
if the conversion did not work. But we should be consistent with
the generator here and only accept BINARY or convertible to UTF-8.
https://github.com/ruby/json/commit/1344ad6f66 -
- Because of it's Ruby 1.8 heritage, the C extension doesn't care
much about strings encoding. We should get stricter over time.
https://github.com/ruby/json/commit/42402fc13f -
- [Feature #19528]
Ref: https://bugs.ruby-lang.org/issues/19528
`load` is understood as the default method for serializer kind of libraries, and
the default options of `JSON.load` has caused many security vulnerabilities over the
years.
... -
- Fix: https://github.com/ruby/json/issues/655
For very small documents, the biggest performance gap with alternatives is
that the API impose that we allocate the `State` object. In a real world app
this doesn't make much of a difference,... -
- https://github.com/ruby/json/commit/0f0b16b3f5
-
- https://github.com/ruby/json/commit/850bd077c4
-
- Hoping it might find the leak reported in https://github.com/ruby/json/issues/460
https://github.com/ruby/json/commit/08635312e5 -
- While less nice, this open the door to eluding the State object
allocation when possible.
https://github.com/ruby/json/commit/5c0d428d4c -
- Given we expect these to almost always be null, we might as
well keep them in RString.
And even when provided, assuming we're passed frozen strings
we'll save on copying them.
This also reduce the size of the struct from 112B to 72B.
... -
- https://github.com/ruby/json/commit/97b61edce1
-
- With the extra logic added for stack allocation, and especially the
memcpy, it became harder for compilers to inline.
This doesn't fully reclaim the speed lost with the stack allocation,
but it's getting closer.
Before:
```
== Encodin... -
- Ref: https://github.com/ruby/json/issues/655
Followup: https://github.com/ruby/json/issues/657
Assuming the generator might be used for fairly small documents
we can start with a reasonable buffer size of the stack, and if
we outgrow it... -
- Fix: https://github.com/ruby/json/issues/460
The various `to_json` methods must rescue exceptions
to free the buffer.
```
require 'json'
data = 10_000.times.to_a << BasicObject.new
20.times do
100.times do
begin
data.to_js... -
- `me->defined_class` should be 0 for method entries of
Modules.
This patch checks this condition
and fix https://github.com/ruby/ruby/pull/11965#issuecomment-2448291790 -
- 01:16 AM Revision 19c93a5c (git): * 2024-11-01 [ci skip]
-
10/31/2024
-
- It's a bug of 3.4.0-preview2 and specifically of the Prism compiler, 3.3 and earlier and `--parser=parse.y` succeed for all cases.
The order is:
* parse that file:
* execute it
* in that new thread eval is called
* that parses `a == b`,... -
08:30 AM Bug #20856 (Closed): Incorrect and inconsistent multi-thread eval execution with Prism compiler
- Consider example:
```
s = Thread.new {
a = 5
puts eval("a == b")
x = 6
}
s.join
b = 11
```
As far as I see it, it should not work. Because at the moment of eval, b is unknown and not even declared (it can even be in c... -
-
- The following code crashes with assertions enabled because envval could
be Qundef:
{}.to_proc.dup -
-
-
-
-
- So that rubygems can find them as gems. However, the `--install-dir`
option of `gem install` seems to exclude prerelease gems, even already
installed in that directory, from the dependencies for some reasons;
use the `GEM_HOME` environm... - 05:10 PM Revision 80fd8463 (git): [rubygems/rubygems] Add useful error message for plugin load
- If a plugin has previously been installed, but the path is no longer
valid, `rake setup` will fail with an unexpected error due to the file
not existing.
Instead, we want to present the user with what the issue is and how to
resolve the... -
- byroot (Jean Boussier) wrote in #note-8:
> I know, that's why I'm always puzzled at why distributions are trying to re-package rubygems... Like most of the failure I'm seeing on your CI are things already fixed upstream. But I suppose t... -
04:10 PM Bug #20857: Ruby 3.4 seems to have backwards compatibility issues more than its predecessors
- vo.x (Vit Ondruch) wrote in #note-9:
> byroot (Jean Boussier) wrote in #note-8:
> ...
I think that we should make such a place, because *in the past* it has caused no small amount of difficulty for upstream maintainers (both in how dis... -
- byroot (Jean Boussier) wrote in #note-8:
> >This is the repository I am using: https://copr.fedorainfracloud.org/coprs/vondruch/mpb/builds/
> ...
This remark is more in general "compatibility" context the specifically to `Hash#inspect`... -
- >This is the repository I am using: https://copr.fedorainfracloud.org/coprs/vondruch/mpb/builds/
Thank you. I went over a dozen or so, and couldn't find any other than ASCIIDoctor for which the failure cause was the change in `Hash#in... -
- byroot (Jean Boussier) wrote in #note-6:
> > there have failed to build 127 out of 528 packages.
> ...
This is the repository I am using:
https://copr.fedorainfracloud.org/coprs/vondruch/mpb/builds/
From there, click on the "Buil... -
- > there have failed to build 127 out of 528 packages.
Could you share the package names and failures? I think it's an important data point.
Personally as stated on https://bugs.ruby-lang.org/issues/20433 I really love this change, ... -
- I ran the asciidoctor test and he have already fixed it. Awesome.
To my knowledge, this change has never required any substantive modification other than updating expectation values of test cases. And in principle, you know, it is not... -
-
- Just FTR, speaking of testing in Fedora, after initial rebuild with Ruby 3.4, there have failed to build 127 out of 528 packages.
-
- Testing Ruby 3.4 in Fedora, I just hit issue like this in AsciiDoctor test suite:
~~~
1) Failure:
Minitest::Test::TestExtensions::TestIntegration#test_should_assign_captures_correctly_for_inline_macros [test/extensions_test.rb:138... -
-
-
10:05 AM Revision 53df2a3c (git): [ruby/rdoc] Use thicker fonts with high contrast to improve
- readability
(https://github.com/ruby/rdoc/pull/1197)
https://github.com/ruby/rdoc/commit/7fb0e509ec -
- Require that users explicitly specify the desired algorithm. In my
opinion, we are not in a position to specify the default cipher.
When OpenSSL::PKCS7.encrypt is given only two arguments, it uses
"RC2-40-CBC" as the symmetric cipher al... -
- The SSL ex_data index is used for storing the verify_callback Proc. The
only user of it, ossl_ssl_verify_callback(), can find the callback by
looking at the SSLContext object which is always known.
https://github.com/ruby/openssl/commit... - 08:26 AM Revision 772a213a (git): [ruby/openssl] [DOC] better wording for OpenSSL::Config document.
- https://github.com/ruby/openssl/commit/26370636f3
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com> - 08:26 AM Revision 9d94a3b8 (git): [ruby/openssl] [DOC] Replace removed method in example for OpenSSL::Config#to_s
- https://github.com/ruby/openssl/commit/93c7bf52ac
-
-
- Merged in https://github.com/ruby/ruby/commit/87fb44dff6409a19d12052cf0fc07ba80a4c45ac
-
- The current Fiber Scheduler performance can be significantly impacted by blocking operations that cannot be deferred to the event loop, particularly in high-concurrency environments where Fibers rely on non-blocking operations for effici...
- 04:26 AM Revision 87fb44df (git): Introduce Fiber Scheduler `blocking_region` hook. (#11963)
- 03:44 AM Revision 550ac2f2 (git): [DOC] Fix typos
-
- instead of `method()`.
There is a bug around `define_method`, so this patch is workaround.
https://github.com/ruby/error_highlight/commit/4d04537f58