Activity
From 04/29/2021 to 05/05/2021
05/05/2021
-
10:28 PM Feature #17844: Support list of methods to test with respond_to?
- I would be confused whether it should respond to ALL of the params, or just ANY of them. It could be just me, though.
Maybe adding a `respond_to_any?` would solve that. -
09:54 PM Revision b655a3fa (git): Fall back to sysconf to determine page size during runtime
- On some platforms the PAGE_SIZE macro does not exist so we can fall back
to `sysconf` to determine the page size at runtime. -
- The current fix for PAGE_SIZE macro detection in autoconf does not work
correctly. I see the following output with running configure on Linux:
```
checking PAGE_SIZE is defined... no
```
Linux has PAGE_SIZE macro. This is happening bec... -
05:12 PM Bug #15928: Constant declaration does not conform to JIS 3017:2013
- jeremyevans0 (Jeremy Evans) wrote in #note-11:
> Stating absolutes without confirming them is risky. Looking through the commits to `spec`, commit:c881678cd75432f47903a5d1d8b86a7a723cb023 just removed specs stating `It is not a spec [..... -
04:47 PM Bug #15928: Constant declaration does not conform to JIS 3017:2013
- Eregon (Benoit Daloze) wrote in #note-10:
> > This is a bug fix, not a feature change, and should be treated like other bug fixes.
> ...
Stating absolutes without confirming them is risky. Looking through the commits to `spec`, commit:... -
- Thank you for the context.
IMHO changing single assignment order is a lot simpler, and would bring consistency too.
I feel consistency also has rather low value here, multiple assignment is different to multiple single assignments, n... -
- Eregon (Benoit Daloze) wrote in #note-7:
> jeremyevans0 (Jeremy Evans) wrote in #note-6:
> ...
You're wrong since commit:50c54d40a81bb2a4794a6be5f1861152900b4fed (bug fix for #4443).
> That's simple and there is no need to switch ba... -
- jeremyevans0 (Jeremy Evans) wrote in #note-6:
> If the behavior was a deliberate feature in older versions, I agree. If the behavior was not deliberate in old versions, and changing it is just fixing a bug (as it is in this case), I di... -
- Eregon (Benoit Daloze) wrote in #note-5:
> No, the spec should be kept for older versions/other implementations, and we should have a spec for the new behavior.
If the behavior was a deliberate feature in older versions, I agree. If... -
- jeremyevans0 (Jeremy Evans) wrote in #note-4:
> Like many specs, the added spec describes the actual behavior of CRuby at the time it was added, without regard for whether the behavior was intentional or not.
If users depend on it an... -
04:19 PM Bug #17850 (Closed): `PAGE_SIZE` is no longer a constant for macOS
- @nobu seemed to fix this issue by 3d5b6ddff8def49e59fb9a9ddd28a653498ae861 and 192150051144c0242ee44df26952dfe31b83cac2
-
- Thank you. I'm looking into this.
-
- I wonder why Apple didn't simply define PAGE_SIZE conditionally based on the architecture.
-
03:51 AM Bug #17850 (Closed): `PAGE_SIZE` is no longer a constant for macOS
- [Build failure for macOS Big Sur (ARM)](http://rubyci.s3.amazonaws.com/osx1100arm/ruby-master/log/20210505T014504Z.log.html.gz) due to `-Wundef` (#17752).
It is said in https://www.wwdcnotes.com/notes/wwdc20/10214/ that:
* Native p... -
04:01 PM Revision 19215005 (git): PAGE_SIZE is used only when mmap is available
-
- I wrote some concerns over this change in https://bugs.ruby-lang.org/issues/15928#note-10.
I think the previous semantics of multiple assignments are better for various reasons.
We could change single assignment order, always evaluate ... -
- I think Fiddle::MemoryView is not needed for this.
String#[] can already avoid copying, on CRuby I think only if taking a substring until the end (the case here).
Also if Fiddle::MemoryView returns a mutable/non-read-only view, it se... -
01:57 PM Feature #17851 (Open): ruby extension for memoryview
- add an extension to ruby for memoryview - (just like Fiddle::MemoryView but in ruby assuming Fiddle::MemoryView gets slices)
add a method in Kernel to get initialize a memoryview on an object that is a c memoryview
lets say we want t... -
- Thank you for the doc update!
- 03:03 PM Revision d2afb032 (git): * 2021-05-06 [ci skip]
-
- As PAGE_SIZE may not be a preprocessor constant, dispatch at
runtime in that case. -
- @byroot I marked this for backporting. Here's the guide for how to do that: https://bugs.ruby-lang.org/projects/ruby/wiki/HowToRequestBackport
-
08:27 AM Bug #17467: What makes strip() and lstrip() not stripping \u0000 from beginning of the string?
- I believe this fix should be backported.
-
- This is a separate request #17851 to allow memoryview extension in ruby - this request is so that IO doesn't require a separate copy
to string when writing a memoryview object -
01:58 PM Feature #17848 (Closed): inline rbs either by rdoc comments or changing syntax
- Ruby is not going to add new syntax for type annotation. Allowing `yard` comments in RBS syntax may be a (good) choice, but it's up to `yard` side.
Matz.
-
- @eregon No worries. This change revealed an actual issue #17850 anyway, great! I think other issues than #17850 are all addressed, so I'm closing this ticket.
-
- https://rubyci.org/ looks good now except `macOS Big Sur (ARM)`, thank you @mame, @nobu, @xtkoba, @peterzhu2118 for the fixes, and sorry for the breakage (the CI on GitHub passed).
-
- * @nobu fixed the error on old GCC: 5bde2e61db8148cd5a7974f640aee38be60bf368
* I think I fixed the error on icc (but not confirmed yet): e71c9ca529f1dce2c3816653cd974ce786eea7d8
* @nobu is now creating a patch fo M1 macOS. -
- I missed one more error, for which a new ticket is open now (#17850).
-
- The remaining problems seem due to insufficient simulation of `RBIMPL_HAS_*` in `include/ruby/internal/has/*` for GCC <= 4.x and ICC.
My temporary patch would not be necessary if errors did not manifest themselves one after another. -
- I'll take a look tomorrow.
If we need a fix faster, I think it's OK to merge @xtkoba's PR. -
- > We could automatically mask Thread#raise within ensure so it only happens after the ensure body completes.
As said on the other issue, I don't think it would fix *all* issues, but it would certainly be a huge improvement. -
01:41 AM Feature #17849 (Assigned): Fix Timeout.timeout so that it can be used in threaded Web servers
- Making this a separate issue from #17837
Eregon (Benoit Daloze) wrote in https://bugs.ruby-lang.org/issues/17837#note-10 (which is about timeouts for regular expressions):
> I think fixing Timeout.timeout might be possible.
> ...
-
- include/ruby/internal/has/builtin.h uses HAVE_BUILTIN___BUILTIN_EXPECT
for icc but previously it was not defined.
This is a follow up of 8b32de2ec9b72d4c9ede19b70ec9497718fb25a6 and this
will fix the following failures:
http://rubyci.s... -
- Eregon (Benoit Daloze) wrote in #note-10:
> I think fixing Timeout.timeout might be possible.
> ...
I created a separate issue for the improvement of Timeout.timeout: #17849. Please feel free to discuss there. My guess is that there ... -
- False positive `-Wundef` in `#elif` after `#if defined`.
-
-
- USE_WIN32_MUTEX flag may not be defined.
-
- __FreeBSD_version is defined in sys/param.h.
-
- __LITTLE_ENDIAN is not defined.
-
- ENUM_OVER_INT is sometimes not defined. Use #ifdef instead if #if.
05/04/2021
-
- I propose `-Wundef` warnings not be made into errors for the time being.
PR: https://github.com/ruby/ruby/pull/4455 -
- Maybe [icc 2021.2 x64](http://rubyci.s3.amazonaws.com/icc-x64/ruby-master/log/20210504T190003Z.fail.html.gz) is also broken.
-
- I think this change broke the following servers on RubyCI.
* [Ubuntu armv7l eabihf](http://rubyci.s3.amazonaws.com/scw-9d6766/ruby-master/log/20210504T221708Z.fail.html.gz)
* [CentOS 7.6(1810) x86_64](http://rubyci.s3.amazonaws.com/c... -
- Applied in changeset commit:git|8b32de2ec9b72d4c9ede19b70ec9497718fb25a6.
----------
Add -Werror=undef to default warnflags for core
* See [Feature #17752]
* For external extensions it's transformed to just warn and not error (-Wundef)... -
11:40 PM Bug #17846: Percent mode changes the output from ERB beyond what is documented
- k0kubun (Takashi Kokubun) wrote in #note-4:
> [..] writing a comment in the middle of `<% %>` is currently not supported.
I don't really have an issue with this resolution, however, is it documented
somewhere? I cannot find this men... -
02:12 AM Bug #17846 (Rejected): Percent mode changes the output from ERB beyond what is documented
- So the trick is:
```rb
$ erb -x repro.erb
#coding:UTF-8
_erbout = +''; # ; _erbout.<< "x\n".freeze
; _erbout.<< "y\n".freeze
; _erbout
```
```rb
$ erb -x -P repro.erb
#coding:UTF-8
_erbout = +''; # ; _erbout.<< "x\ny\n".freeze
; _er... -
- Oh sorry, I guess that's why it shouldn't change the output lol. will take a look
-
- ```
-P disable ruby code evaluation for lines beginning with %
```
"lines beginning with `%`" means lines beginning with `%`. Your lines start with `<` or `y`, so `-P` is irrelevant to your input. -
08:49 PM Revision 370949aa (git): test/net/ftp/test_ftp.rb - fix intermittent MinGW failure
- Fixes intermittent error as below:
[242/838] 5316=test_ftp
#<Thread:0x0000020aa8733f20 D:/a/ruby/ruby/src/test/net/ftp/test_ftp.rb:2532 run> terminated with exception (report_on_exception is true):
D:/a/ruby/ruby/src/tool/lib/minitest/u... -
06:59 PM Revision fd3a2034 (git): What's Here for class IO (#4440)
- * What's Here for class IO
-
06:25 PM Bug #14400 (Closed): IO#ungetc and IO#ungetbyte documentation is inconsistent with the behavior
- Applied in changeset commit:git|c809a8cae8c2c8e64fd2d1b0fe8571faf443b8cd.
----------
Fix documentation for IO#unget{byte,c}
Fixes [Bug #14400] -
- Fixes [Bug #14400]
-
- I submitted a pull request to fix this: https://github.com/ruby/ruby/pull/4450
Like @mame, I think this is a real bug. Constant assignment evaluation order should be consistent with attribute assignment evaluation order.
The spec ... -
- I like gradual typing - I like the syntax of rbs files but for coding - convenience it would be nice if we had inline syntax for types.
I know that steep allows you to define types inline but because it is valid ruby syntax - the code ... -
- For debugging purposes, it would be nice if we could modify the content of view directly from Ruby code without any third-party C extension, although I cannot tell whether `IO` is suitable for that.
-
- any comments on this feature request?
- 03:46 PM Revision 14c932e5 (git): * 2021-05-05 [ci skip]
-
- Reallocating to a smaller size in the transient heap may result in no
change in the actual capacity but the capacity of the array is still
updated to the smaller value.
This commit changes `ary_heap_realloc` to return the new capacity w... -
- > The main/major issue is it can trigger within ensure, right? Is there anything else?
That would fix most issues, but not all. It can also trigger in places where exception are entirely unexpected, so there's just no `ensure`.
Als... -
12:55 PM Feature #17837: Add support for Regexp timeouts
- duerst (Martin Dürst) wrote in #note-9:
> I very strongly suggest that this feature be voluntary, e.g. as an additional flag on the regular expression.
If you have to turn it on for each regexp, that would make the feature kinda useless... -
- sam.saffron (Sam Saffron) wrote in #note-6:
> Sort of, it gets complicated. Unicorn is easy cause it is single threaded. Killing off threads in Puma is much more fraught, in Sidekiq the old pattern of killing off was nuked by Mike cause... -
- sam.saffron (Sam Saffron) wrote in #note-6:
> > Or is it too difficult to detect them / the problematic patterns evolve over time?
> ...
In general, yes. But for an extremely large set of regular expressions, it's easy to predict tha... -
- * See [Feature #17752]
* Defining explicitly to 0 seems the best solution, see https://github.com/ruby/ruby/pull/4428
* For example:
./include/ruby/internal/has/builtin.h:49:33: error: "RBIMPL_HAS_BUILTIN___builtin_assume" is not defined... -
- * See [Feature #17752]
-
- * See [Feature #17752]
* Using this to detect them:
git grep -P 'if\s+HAVE' | grep -Pv 'HAVE_LONG_LONG|/ChangeLog|HAVE_TYPEOF' -
- * See [Feature #17752]
-
- * See [Feature #17752]
-
- * It evaluated to 0 before, revealed by -Wundef
* See [Feature #17752]
Co-authored-by: xtkoba (Tee KOBAYASHI) <xtkoba+ruby@gmail.com> -
- * See [Feature #17752]
Co-authored-by: xtkoba (Tee KOBAYASHI) <xtkoba+ruby@gmail.com> -
- * See [Feature #17752]
Co-authored-by: xtkoba (Tee KOBAYASHI) <xtkoba+ruby@gmail.com> -
- * HAVE_ macros should only be defined or undefined, not used for their value.
* See [Feature #17752]
Co-authored-by: xtkoba (Tee KOBAYASHI) <xtkoba+ruby@gmail.com> -
- * See [Feature #17752]
* For external extensions it's transformed to just warn and not error (-Wundef)
like other other -Werror in warnflags. -
- to try to suppress a failure on Solaris. This is the same as
19504d115dc09558255fcb5213f80dd8454ab189
http://rubyci.s3.amazonaws.com/solaris11-sunc/ruby-master/log/20210504T070007Z.fail.html.gz
```
1) Error:
IMAPTest#test_idle_done_no... -
- It's hard to remove that class because of marshal compatibility.
```diff
diff --git a/ext/date/lib/date.rb b/ext/date/lib/date.rb
index 65c34ace492..e96d102d7da 100644
--- a/ext/date/lib/date.rb
+++ b/ext/date/lib/date.rb
@@ -9,6... -
05/03/2021
-
-
-
09:11 PM Revision 9a6226c6 (git): Eagerly allocate instance variable tables along with object
- This allows us to allocate the right size for the object in advance,
meaning that we don't have to pay the cost of ivar table extension
later. The idea is that if an object type ever became "extended" at
some point, then it is very like... -
- Just for the record, there turns out to be a Clang/LLVM bug in its `__builtin_longjmp` implementation for ARM Linux (more specifically for non-Darwin and non-Windows) for which there seems to be no reliable workaround on user's side.
... -
- Apologies if intentional, but it seems that whitespace between `<%` and `#` can be troublesome:
https://makandracards.com/makandra/3533-erb-templates-and-comments
-
-
04:26 PM Feature #11963: Add a simple static web server to `ruby`
- I guess this one can be closed, I've just ran my first `ruby -run -e httpd . -p 8080` using ruby 2.7!
- 04:00 PM Revision a6ff1dc6 (git): * 2021-05-04 [ci skip]
-
-
-
- > I admit that this is less important than per-request timeout.
I'd like to second what Sam said on this. With what is now the most common way of deploying Ruby in production, namely a threaded web-server like Puma, there is no good w... -
- Eregon (Benoit Daloze) wrote in #note-5:
> Shouldn't an app have a global timeout per request anyway, and that would catch regexps and other things too?
I agree that it is much better to have. Still, I think this proposal is good-to-... -
07:57 AM Feature #17837: Add support for Regexp timeouts
- > Shouldn't an app have a global timeout per request anyway
Sort of, it gets complicated. Unicorn is easy cause it is single threaded. Killing off threads in Puma is much more fraught, in Sidekiq the old pattern of killing off was nuk... -
- +1
-
12:56 PM Feature #17847 (Closed): `ruby -run -e httpd` displays URL
- The current version of un.rb `httpd` shows port number only:
```
$ ruby -run -e httpd
[2021-05-03 21:55:09] INFO WEBrick 1.7.0
[2021-05-03 21:55:09] INFO ruby 3.1.0 (2021-05-03) [x86_64-linux]
[2021-05-03 21:55:09] INFO WEBrick... -
- Another use-case I found: https://github.com/rubyjs/mini_racer#fork-safety
That gem (and others of course) could provide some helpers methods based on the chosen strategy if there is a common hook.
Right now providing fork safety (if... -
12:46 AM Bug #17843: Ruby on Rails error[BUG] Segmentation fault at 0x0000000000000110 ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-darwin15] (#42110)
- Apologies about my misleading statement about support for the OS.
It doesn't seem to be receiving security updates anymore so I had assumed it reached end of life.
Looking at the report, the crash happens after fork.
There was a Ruby cr...
05/02/2021
-
- The latest version of Xcode (12.5 beta) seems to support macOS 10.9 or later: https://developer.apple.com/support/xcode/
-
- OS X El Capitan is no longer supported by Apple.
I'm not sure about Ruby's policy for trying to support OSes that the vendor no longer supports.
In any case, I would suggest upgrading to a newer OS to deal with the crash. - 11:17 PM Revision a0296448 (git): * 2021-05-03 [ci skip]
-
-
- @larskanis
Sorry, I meant to ping you immediately, but got distracted. Also, I saw your changes to ridk, but didn't see your patch file.
Anyway, I agree that there needs to be some way to distinguish between mingw and ucrt builds.... -
08:11 PM Feature #17845: Windows Ruby - ucrt build?
- > I wonder if there is a standard target triplet for MinGW + UCRT.
The compiler triplet for MINGW with UCRT is still 'x86_64-w64-mingw32'. This is defined in MSYS2 [here](https://github.com/msys2/MSYS2-packages/blob/master/filesystem... -
- ```
/ # cat repro.erb
<% # %>x
y
/ # erb repro.erb
y
/ # erb -P repro.erb
/ #
```
Based on documentation of -P (disabling percent mode), this change in behavior
is unexpected.
05/01/2021
-
08:06 PM Bug #17774: Quantified empty group causes regex to fail
- sawa (Tsuyoshi Sawada) wrote in #note-3:
> wanabe (_ wanabe) wrote in #note-2:
> ...
Oh I'm very sorry, I wrote it wrong.
I was aware of it, but I simply used the wrong word.
-
12:50 PM Bug #17774: Quantified empty group causes regex to fail
- wanabe (_ wanabe) wrote in #note-2:
> ... Oniguruma, a derivative of Onigmo
I believe it is the other way around.
-
- The reproduction example could be a bit shorter.
```
$ ruby -ve 'p "xxxx" =~ /(?:x(){5})*$/, "xxxx" =~ /(?:x(){4})*$/'
ruby 3.1.0dev (2021-05-01T02:04:17Z origin/master 121fa24a34) [x86_64-linux]
3
0
```
This problem has already... -
- MinGW `msvcrt` packages have a prefix of `mingw-w64-x86_64`,
MinGW ` ucrt ` packages have a prefix of `mingw-w64-ucrt-x86_64`. -
- I wonder if there is a standard target triplet for MinGW + UCRT. I came up with `x86_64-w64-mingw32-ucrt`, but when googled it hits only one page. I suppose something like `x64-mingw32-ucrt` is acceptable for `target_os` in `configure`, ...
-
- Currently, Windows Ruby is normally compiled two ways.
The first, mswin, is compiled using Microsoft's current Visual C compiler, and links to the universal runtime (ucrt).
The second, mingw, is compiled using MinGW gcc. This link... -
- I wonder if the problem disappears by backporting commit:4ea96f1d4f8a50c204c4367c994cdbf12cd97b64 which modifies `fill_random_bytes_syscall` so that it calls `CCRandomGenerateBytes` instead for newer environments (probably for macOS >= 1...
-
- The stack trace shows that the crash occurred at:
```
libdispatch.dylib(_dispatch_queue_wakeup_with_qos_slow+126) [0x00007fff90ff9b06]
libcorecrypto.dylib(ccrng_CommonCrypto_generate+309) [0x00007fff9e03bddc]
libruby.3.0.dylib(ruby_f... -
08:03 AM Bug #17843 (Closed): Ruby on Rails error[BUG] Segmentation fault at 0x0000000000000110 ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-darwin15] (#42110)
- following tutorial
https://www.youtube.com/watch?v=nlKIJfv50U0
On this command
$ rails g scaffold Survey name:text laptop:binary os:text
the following error was generated with the following instruction
[BUG] Segmentation fault... -
01:01 PM Feature #17844 (Open): Support list of methods to test with respond_to?
- Not sure whether this is a good idea at all, but I guess it doesn't hurt to put it up for debate.
The preferred way to check e.g. whether an argument is acceptable is by use of `respond_to?`:
```ruby
# Don't
def notify(recipien... -
- Applied in changeset commit:git|121fa24a3451b45c41ac0a661b64e9fc8600e589.
----------
Adjust struct member offset for i386 Cygwin
Fixes [Bug #17606] -
- Fixes [Bug #17606]
-
12:13 AM Revision f64d7674 (git): Fix example for custom warn method
- Regexp has a match? method.
[ci skip]
04/30/2021
-
- Thanks for the fix! I merged your pull request.
-
10:46 PM Misc #17842 (Closed): Example incorrect in documentation for Hash#dig
- Applied in changeset commit:git|a9824a3113ee5342e7ac90387de9f3b9d5ec9e0a.
----------
Correct documentation example on Hash#dig
Fixes [Misc #17842]. The current documentation suggests that:
{foo: {bar: {baz: 2}}}.dig(:foo, :bar... -
- Here is a pull request that fixes the comment: https://github.com/ruby/ruby/pull/4441
-
- In the current examples for Hash#dig, we have:
```
h = {foo: {bar: {baz: 2}}}
h.dig(:foo) # => {:bar=>{:baz=>2}}
h.dig(:foo, :bar) # => {:bar=>{:baz=>2}} <-- incorrect return value
```
This should be:
```
h = {foo: {bar: {baz: ... - 10:46 PM Revision a867d552 (git): * 2021-05-01 [ci skip]
-
- Fixes [Misc #17842]. The current documentation suggests that:
{foo: {bar: {baz: 2}}}.dig(:foo, :bar) # => {:bar=>{:baz=>2}}
when it should be:
{foo: {bar: {baz: 2}}}.dig(:foo, :bar) # => {:baz=>2} -
- Shouldn't an app have a global timeout per request anyway, and that would catch regexps and other things too?
Capturing the time in regexp interrupt checks is easy but sounds fairly expensive.
Could such regexps emit a warning since ... -
03:06 PM Bug #17840: `make install` overriding file permission with 644
- You are right! Thank you for your detailed explanation! I confirmed the files permissions were changed by your steps.
> As for package management, for example Gentoo Portage [removes bundled gems](https://gitweb.gentoo.org/repo/gentoo... -
02:45 PM Bug #16798: ENV.replace on Windows with a variable name not respecting case will clear it
- The backport breaks on RHEL7:
~~~
hash.c: In function 'keylist_delete':
hash.c:5661:5: error: 'for' loop initial declarations are only allowed in C99 mode
for (long i=0; i<RARRAY_LEN(keys); i++) {
^
hash.c:5661:5: note:... -
- PR: https://github.com/ruby/ruby/pull/4439
-
- PR: https://github.com/ruby/ruby/pull/4438
The second patch is omitted from the PR, because it turns out to be not very useful. The corresponding source file name should be easily guessable from the symbol name. -
- PR: https://github.com/ruby/ruby/pull/4437
-
- ```
../strftime.c: In function 'rb_strftime_with_timespec':
../strftime.c:392:39: warning: comparison is always false due to limited range of data type [-Wtype-limits]
392 | if (vtm->wday < 0 || vtm->wday > 6)
... -
11:46 AM Revision b2c54f53 (git): [ruby/irb] Need reline >= 0.1.6
- irb 1.3.5 need reline >= 0.1.6 because irb use `Reline::IOGate.in_pasting?`.
This method defined after reline 0.1.6.
fix #228.
https://github.com/ruby/irb/commit/6b7b8fc324 -
- PR: https://github.com/ruby/ruby/pull/4436
-
04/29/2021
-
10:35 PM Misc #17828 (Closed): Deprecate use of master and slave
- We should only update the documentation and code on `etc/pty`. I totally agreed the Matz's opinion.
-
05:00 PM Misc #17828: Deprecate use of master and slave
- For reference, the Rust project decided to switch to `main` because it is the tools default and running on defaults has value.
Still, it's doing so on a relaxed timeline: https://internals.rust-lang.org/t/changing-the-default-branch-fro... -
- I've traced this to an off-by-one in `ruby_float_step_size`. I've submitted a pull request to fix this: https://github.com/ruby/ruby/pull/4434
@Eregon Unfortunately, you can't get `#each` to work like repeated edition without breaking... -
- user:jaruga That is because what you changed is the default value of `data_mode` which is overwritten by command-line options:
```
./miniruby -I../lib -I. -I.ext/common ../tool/runruby.rb --extout=.ext -- --disable-gems -r./x86_64-li... -
Thanks for checking. I assumed the data_mode (0644) might cause this situation.
However after editing `rbinstall.rb` to change the data_mode from 0644 to 0755, I still saw the installed files permissions were still 644.
```
$ vi...-
- Seems intentionally done at [tool/rbinstall.rb:774](https://github.com/ruby/ruby/blob/dfca24af82e7d06adcb57f625573b0e558d9e5dc/tool/rbinstall.rb#L774). Files having pattern `libexec/*` are chmodded to `prog_mode` (0755), otherwise to `da...
-
- On the current latest master `b0b5a4e86ef2740c427f9356a4173a1debf4f79c`, by the following steps, I can see the difference between files permission between installed Ruby's gems directory installed by `make install` and gems directory ins...
-
07:13 PM Revision 5a451c4b (git): lldb: Warn when attempting to dump invalid pages
-
- This is probably caused by the fix to #15830. Here's a pull request that should fix it: https://github.com/ruby/ruby/pull/4432, though I didn't test with rbtree. Closing and marking for backport.
-
06:32 PM Bug #17841 (Closed): The first instance of SortedSet doesn't sort when rbtree is present
- If the `rbtree` gem is present, then in ruby 2.7, the first instance of `SortedSet` will return entries in insertion order. Future instances of `SortedSet` correctly return sorted entries.
Given:
```
require 'rbtree'
require 'set... - 04:40 PM Revision dfca24af (git): * 2021-04-30 [ci skip]
-
- On Solaris, Socket.tcp seems to fail with EINVAL if the server closes
the connection immediately after accpeted. I think this is a bug of
Socket.tcp, but seems difficult to fix soon.
http://rubyci.s3.amazonaws.com/solaris11-sunc/ruby-ma... -
- PR: https://github.com/ruby/ruby/pull/4430
This should be trivial. -
- PR: https://github.com/ruby/ruby/pull/4429
-
- user:Eregon Thank you very much. I have just learnt how to use GitHub. I will do it by myself next time.
-
- I made a PR with @xtkoba's patches and additional fixes, as well as enabling undef warnings:
https://github.com/ruby/ruby/pull/4428
@xtkoba Importing patches is quite time-consuming, it would be better if you can already make commits... -
- +1 wonderful and useful idea
Even without the DoS aspect, it's all too easy to create regexps with pathological performance that only manifests in certain edge cases, usually in production. It would be very useful if some kind of time... -
- Invoking a thread implicitly in the interpreter is troublesome. Previously, Ruby had a timer thread, but as far as I know, it was (almost) abundaned by @normalperson. If you try to revive a timer thread, you should learn the complex hist...
-
- Note I am planing to check this ticket after reviving Travis s390x (#17818).
-
08:53 AM Bug #17787: Four AIX build issues with xlc compiler and ruby-3.0.1
- ruby_3_0 3e07a4edc92f18dec4806961c1b724ac5cf4d6b2 merged revision(s) 3a3033c138c0951ad5edbf02b5c233b58a190d2f.
-
- get rid of using `__builtin_unreachable` directly [Bug #17787]
As it is an independent feature from `clz`, `ctz` and `popcount`,
it might be unavailable even if the latters are built in.
---
internal/bit... -
- Avoid using inconsistent coding style
Other `_mjit_compile_*.erb` files don't use goto. These files'd better
be consistent for readability.
---
tool/ruby_vm/views/_mjit_compile_getinlinecache.erb | 14 ++... -
- [ruby/net-ftp] Reduce resource cosumption of Net::FTP::TIME_PARSER
Reported by Alexandr Savca as a DoS vulnerability, but Net::FTP is a
client library and the impact of the issue is low, so I have decided
to fix ... -
- ioquatix (Samuel Williams) wrote in #note-4:
> Thanks for looking into this.
> ...
My git blame magic ball shows that Ruby has always done this. It was temporarily changed in commit:6f1edacc010c48c5762598fed74ff4f1e62d1b20 and then qu... -
12:21 AM Feature #16962: Make IO.for_fd autoclose option default to false
- Thanks for looking into this.
Not being able to close some file descriptors when using `IO.for_fd` is almost certainly a bug.
```
/* need to keep FILE objects of stdin, stdout and stderr */
```
Why? -
- I looked into this and I think it's because stdin, stdout, and stderr are special cased:
```c
if (IS_PREP_STDIO(fptr) || fd <= 2) {
/* need to keep FILE objects of stdin, stdout and stderr */
}
```
This Ruby pro...