Activity
From 03/03/2020 to 03/09/2020
03/09/2020
-
11:47 PM Bug #16683 (Closed): Regression in ruby 2.7 File.realpath return ASCII-8BIT for string literal with invalid characters instead of UTF-8
- lamont (Lamont Granquist) wrote in #note-2:
> on ruby 2.6.5 this is the behavior of File.realpath when fed a string with invalid bytes:
> ...
This is intentional. The native realpath(3) function is now used in most cases (#15797), and... -
11:39 PM Bug #16683: Regression in ruby 2.7 File.realpath return ASCII-8BIT for string literal with invalid characters instead of UTF-8
- Hmm, I was trying to update the body of the bug report with that.
Turns out that File.open was a large wild goose chase and we appear to have other bugs that I wound up chasing down. The behavior on mac and linux also does appear to ... -
11:37 PM Bug #16683: Regression in ruby 2.7 File.realpath return ASCII-8BIT for string literal with invalid characters instead of UTF-8
- on ruby 2.6.5 this is the behavior of File.realpath when fed a string with invalid bytes:
```
[2] pry(main)> File.realpath("/tmp/chef-test-\xFDmlaut").encoding
=> #<Encoding:UTF-8>
```
on ruby 2.7.0 this is the behavior:
```
... -
08:21 PM Bug #16683: Regression in ruby 2.7 File.realpath return ASCII-8BIT for string literal with invalid characters instead of UTF-8
- I can't recreate this failure on OpenBSD with 2.7.0 or the master branch, with or without a UTF-8 locale:
```
$ ruby28 -ve 'p Encoding.default_external; File.open("chef-test-\xFDmlaut", "w+")'
ruby 2.8.0dev (2020-03-09) [x86_64-open... -
07:49 PM Bug #16683 (Closed): Regression in ruby 2.7 File.realpath return ASCII-8BIT for string literal with invalid characters instead of UTF-8
Real simple repro case:
```
[1] pry(main)> fp = File.open("/tmp/chef-test-\xFDmlaut", "w+")
Errno::EILSEQ: Illegal byte sequence @ rb_sysopen - /tmp/chef-test-�mlaut
from (pry):1:in `initialize'
```
This used to work in ruby ...-
06:34 PM Misc #16661: DevelopersMeeting20200316Japan
- * [Bug #16677] Negative integer powered (**) to a float number results in a complex (alanwu)
* Currently `-2 ** 2` is parsed as `-(2 ** 2)` but `-2.itself ** 2` is parsed as `((-2).itself) ** 2` which seems inconsistent to me
* Since... -
04:06 PM Misc #16661: DevelopersMeeting20200316Japan
- * [Bug #16175] Object#clone(freeze: true) is inconsistent with Object#clone(freeze: false) (jeremyevans0)
* Do we want Object#clone(freeze: true) to return a frozen clone if receiver is unfrozen?
* [Feature #15357] Proc#parameters re... -
04:49 PM Bug #4436: FileUtils verbose mode prints output to stderr
- I've submitted a pull request upstream for this: https://github.com/ruby/fileutils/pull/49
-
03:53 PM Bug #16682: Ruby 2.7.0p0 crash on exit if there is an active RUBY_INTERNAL_EVENT_GC_EXIT tracepoint
- So apparently the TracePoint instance type is set to `T_NONE`. So I presume it means it was collected?
-
12:58 PM Bug #16682: Ruby 2.7.0p0 crash on exit if there is an active RUBY_INTERNAL_EVENT_GC_EXIT tracepoint
- > fails the type check, exception is raised, which allocs a String for the message.
Yep, the `allocation during garbage collection phase` is merely a fallout following a previous issue.
So I patched my ruby a bit further to get t... -
12:50 PM Bug #16682: Ruby 2.7.0p0 crash on exit if there is an active RUBY_INTERNAL_EVENT_GC_EXIT tracepoint
- The tracepoint instance appears to not be of type TypedData anymore, fails the type check, exception is raised, which allocs a String for the message.
```
#15 0x000055935811e737 in tpptr (tpval=94091343800880) at vm_trace.c:771
771 ... -
12:29 PM Bug #16682: Ruby 2.7.0p0 crash on exit if there is an active RUBY_INTERNAL_EVENT_GC_EXIT tracepoint
- I patched my ruby to print the exception message before it tries to allocate, and ran it a few times:
```
.wrong argument type 140351662971400
(expected tracepoint)
.wrong argument type 140321... -
11:27 AM Bug #16682 (Closed): Ruby 2.7.0p0 crash on exit if there is an active RUBY_INTERNAL_EVENT_GC_EXIT tracepoint
- ```
[BUG] object allocation during garbage collection phase
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-darwin19]
-- Crash Report log information --------------------------------------------
See Crash Report log file u... - 03:13 PM Revision 62d82b6d (git): * 2020-03-10 [ci skip]
-
03:11 PM Revision 9034cbd3 (git): Update NEWS for autosplatting change [ci skip]
-
02:57 PM Bug #15608 (Closed): What should be the correct output for Method#inspect with singleton methods?
-
02:57 PM Revision e02bd0e7 (git): Don't display singleton class in Method#inspect unless method defined there
- Previously, if an object has a singleton class, and you call
Object#method on the object, the resulting string would include
the object's singleton class, even though the method was not
defined in the singleton class.
Change this so the... -
02:39 PM Feature #16615: Group style access scope for macros
- Maybe a more concrete example would be helpful:
```ruby
def defc
define_method(:c){ }
end
class Foo
private
def a; end
attr_accessor :b
defc
end
Foo.new.a #=> NoMethodError (private method `a' called)
Foo.new.b #=... -
02:16 PM Bug #16044 (Closed): Float::ROUNDS (FLT_ROUNDS) should not be a constant.
-
02:06 PM Misc #16678: Array#values_at has unintuitive behavior when supplied a range starting with negative index
- Negative indices have always meant "offset from the end" in ruby. So if you take a negative index and add the size of the array you get the "normal index" and then I think you'll see everything is pretty intuitive.
```ruby
a = (1..5)... -
01:39 PM Revision ecef163c (git): Remove Float::ROUNDS
- Fixes [Bug #16044]
-
01:31 PM Feature #16665: Add an Array#except_index method
- That implementation would return an empty array for `[true,nil,nil].except_index(0)`
Probably something a bit more like this:
```ruby
@@undef = Object.new #using Qundef in C
def except_index(*indexes)
result = dup
ind... -
01:28 PM Revision d019cac0 (git): Clarify Time::at documentation for in: argument
-
05:34 AM Revision d8fcc676 (git): Skip test_06_timeout for --jit-wait CI
- This test has been too unstable on trunk-mjit-wait
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2782206 -
04:39 AM Revision 544ebc66 (git): Use https for downloading Unicode data.
- Retry with 90de118a75921a08497b41de2950971073b3c924
[Bug #13962][ruby-core:83074] -
03:50 AM Feature #16166 (Closed): Remove exceptional treatment of *foo when it is the sole block parameter
-
12:55 AM Feature #16166: Remove exceptional treatment of *foo when it is the sole block parameter
- I've rebased the pull request (https://github.com/ruby/ruby/pull/2502) on current master. Assuming it passes CI, I plan to commit it, as matz has already indicated his support for the change, and keyword argument separation means that t...
-
03:49 AM Revision f4394bbc (git): Do not autosplat when calling procs that accept rest and keywords
- When providing a single array to a block that takes a splat, pass the
array as one argument of the splat instead of as the splat itself,
even if the block also accepts keyword arguments. Previously, this
behavior was only used for block... -
12:47 AM Revision 040cfc89 (git): Do not set USE_FFI_CLOSURE_ALLOC=1 in fiddle on OpenBSD
- On OpenBSD, USE_FFI_CLOSURE_ALLOC was always set to 0 previously. In
633a1f15d8228236094ddee12e4e169d655ec49e, the code was modified in a
way that it ended up being set to 1 on OpenBSD. However, that results
in SIGABRT when running make...
03/08/2020
- 05:57 PM Revision fe3514ae (git): * 2020-03-09 [ci skip]
-
05:53 PM Revision dff69bb4 (git): Cast properly for shift operand
- `(int) << RHASH_LEV_SHIFT` can be negative integer.
-
12:20 PM Bug #16677: Negative integer powered (**) to a float number results in a complex
- It seems rather unexpected that `-2 ** 2.2` is parsed as `-(2 ** 2.2)`, I would expect `(-2) ** 2.2` as well.
-
08:39 AM Revision daa04c55 (git): Word array instead of splitting
-
08:38 AM Revision 2b7409a2 (git): Specify explicit separator not to be affected by $;
-
01:48 AM Bug #16681: Backport commit related libffi url
- ruby_2_6 r67842 merged revision(s) 86022167461dc90b70164e2bb23316959bbfd6ba,47a1872cd8b901b8aab6dedce7fa3807c97d290d.
-
01:48 AM Revision 981e83d2 (git): merge revision(s) 86022167461dc90b70164e2bb23316959bbfd6ba,47a1872cd8b901b8aab6dedce7fa3807c97d290d: [Backport #16681]
- Switch to download libffi source package to github releases from
sourceware.org
Use osuosl instead of GitHub releases
Because the package provided by GitHub releases is different from sourceware.
git-svn-id... - 01:19 AM Revision 53efe632 (git): * 2020-03-08 [ci skip]
-
01:18 AM Revision 2b6ec768 (git): Fix rbinstall bugs (#2930)
- * Fix incorrect calls to `Gem.ensure_gem_subdirectories`
This method doesn't take keyword args.
* Remove stuff no longer necessary
Now `Gem.ensure_gem_subdirectories` is doing its job, so some stuff is
no longer needed.
* Use the pro...
03/07/2020
-
11:40 PM Bug #16677: Negative integer powered (**) to a float number results in a complex
- Ah thanks for catching that.
Interesting, `-2 ** 2.2` is parsed as `-(2 ** 2.2)` whereas `-2.to_i ** 2.2` is parsed as `((-2).to_i) ** 2.2`.
It looks like whether it is a literal of negative two changes depending on the presence of the... -
06:12 PM Bug #16677: Negative integer powered (**) to a float number results in a complex
- > Negative integers are atomic tokens
If that was the case then `-2 ** 2.2` would be parsed as `(-2) ** 2.2`, which is not the case as shown above. -
05:05 PM Bug #16677: Negative integer powered (**) to a float number results in a complex
- > So it looks like there's something special about how negative integers are parsed?
Negative integers are atomic tokens whereas the expression `-x` applies the unary `-` operator to `x`.
`-x.to_i` is parsed as `-(x.to_i)`:
```
$ ruby ... -
04:56 PM Bug #16677 (Open): Negative integer powered (**) to a float number results in a complex
-
04:25 PM Bug #16677: Negative integer powered (**) to a float number results in a complex
- It's actually a bit more complicated than that.
```ruby
-2.to_i ** 2.2 #=> (3.717265962412589+2.7007518095995264i)
x = 2
-x.to_i ** 2.2 #=> -4.59479341998814
```
So it looks like there's something special about how negative int... -
02:25 PM Bug #16677 (Closed): Negative integer powered (**) to a float number results in a complex
- This is just operator precedence, ** has higher precedence than unary minus.
-
01:22 PM Bug #16677: Negative integer powered (**) to a float number results in a complex
- Oh sorry, I just notice that this is an expected behaviour in the documentation (example) given in Integer.
I guess the to-i attribute assignment is a bit confusing that it changes the behaviour but probably not a bug! -
05:15 AM Bug #16677 (Closed): Negative integer powered (**) to a float number results in a complex
- Not sure if this is an unexpected behavior.
This works as I expect:
```
-2 ** 2.2 # => -4.59479341998814
```
But when I change the code a bit, it gives me a complex:
```ruby
-2.to_i ** 2.2 # => (3.717265962412589+2.7007518... -
11:06 PM Bug #16681 (Closed): Backport commit related libffi url
- Please backport the following commits for fixing download error of libffi.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian8/ruby-2.7/log/20200307T214956Z.fail.html.gz
* 47a1872cd8 : Use osuosl instead of GitHub releases
* 8... -
11:01 PM Bug #16462 (Closed): Ruby 2.7 autoload not working with $RUBYLIB (maybe circular dependency error)
-
05:59 PM Bug #16462: Ruby 2.7 autoload not working with $RUBYLIB (maybe circular dependency error)
- Sorry for confusing, i find the really reason caused this issue, i will create a new issue #16680 for make reproduce more clearly.
I don't know how to close this issue, can you help on this?
-
06:31 PM Bug #16680 (Closed): Symlink folder in $LOAD_PATH does not work with autoload
- The following is a full reproducible process. I will use a gem named 'looksee' to reproduce this.
1. Do `gem install looksee`
2. Go to `gem` folder and copy `lib` content into `/tmp/test_looksee` so that we have a folder like this:... -
02:29 PM Bug #16679 (Closed): Test of Ruby fails under multiple OS user userland installations
- I do user land installations where each of multiple installations of a complex system under it's own OS user installs it's own version of tools from sources if the OS installed version doesn't match necessary criteria.
The system has to... -
02:23 PM Misc #16678: Array#values_at has unintuitive behavior when supplied a range starting with negative index
- You can easily achieve wrap-around behavior with:
```ruby
> (1..5).to_a.values_at(*(-1..3))
=> [5, 1, 2, 3, 4]
```
Using a Range for `values_at` is like taking a slice with `Array#[]/slice`, and Array slices never wrap around (a g... -
10:42 AM Misc #16678: Array#values_at has unintuitive behavior when supplied a range starting with negative index
- Actually .values_at() confused me when I tried to use my go-to method for
obtaining a slice from an Array:
a[3..5] # => [4, 5]
There I wondered why it did not return the same. :-)
But anyway; I believe the question is what... -
06:21 AM Misc #16678 (Open): Array#values_at has unintuitive behavior when supplied a range starting with negative index
- Consider the following:
``` ruby
# frozen_string_literal: true
a = (1..5).to_a
p a.values_at(3..5) # => [4, 5, nil]
p a.values_at(-1..3) # => []
```
When the range begins with a negative `(-1, 0, 1, 2, 3)`, it returns an ... -
11:45 AM Revision 47a1872c (git): Use osuosl instead of GitHub releases
- Because the package provided by GitHub releases is different from sourceware.
-
10:57 AM Revision 86022167 (git): Switch to download libffi source package to github releases from sourceware.org
-
10:06 AM Revision ada2f71c (git): rb_check_safe_obj no longer exists
- Commit e91c39f1c0f7d5e670266d9593d533fd444957f6 deleted definition of it.
Though I'm not sure if we can delete public API like this, it no longer
works nontheless. Having declaration without definiton is worse than
having nothing at all... -
10:03 AM Bug #16138: Backport Struct.new empty option hash fix to 2.5 and 2.6
- ruby_2_6 r67841 merged revision(s) 77596fb7a91cc119b25ac9e19b3c8682709765b4.
-
10:03 AM Revision 7c9bd12a (git): merge revision(s) 77596fb7a91cc119b25ac9e19b3c8682709765b4: [Backport #16138]
- Do not turn on keyword_init for Struct subclass if keyword hash is
empty
This was accidentally turned on because there was no checking for
Qundef.
Also, since only a single keyword is currently supporte... -
09:57 AM Bug #16641: Backport request: MJIT crashes on a certain flow of branches
- ruby_2_6 r67840 merged revision(s) c4794ed73ad348a61a7cfbe3da0a7eb49ba46eb9.
-
09:57 AM Revision 4ccfb9d1 (git): merge revision(s) c4794ed73ad348a61a7cfbe3da0a7eb49ba46eb9: [Backport #16641]
- Avoid jumping to a wrong destination
when the next insn is already compiled by former branches.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67840 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:44 AM Bug #16619: Error message of "x = return 1" is doubled
- ruby_2_6 r67839 merged revision(s) 6e6844320de989cb88a154e2ac75066ccea1bba2.
-
09:44 AM Revision 773b45bc (git): merge revision(s) 6e6844320de989cb88a154e2ac75066ccea1bba2: [Backport #16619]
- Fixed duplicated warning
As `command_rhs` is always a "value expression", `command_asgn`
does not need the same check.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67839 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
09:38 AM Bug #16508: Segmentation fault with Regexp in ruby 2.7.0preview2
- ruby_2_6 r67838 merged revision(s) 4f19666e8b144600e959e4673f79d63f98bd637d.
-
09:38 AM Bug #16508: Segmentation fault with Regexp in ruby 2.7.0preview2
- backported into ruby_2_7 was done at db4d136889afbf59e69efcfd495fd91cd401f378.
-
09:38 AM Revision ca74f62a (git): merge revision(s) 4f19666e8b144600e959e4673f79d63f98bd637d: [Backport #16508]
- `Regexp` in `MatchData` can be `nil`
`String#sub` with a string pattern defers creating a `Regexp`
until `MatchData#regexp` creates a `Regexp` from the matched
string. `Regexp#last_match(group_name)` accessed it... -
09:22 AM Bug #16034: Backport 5d33f787169bcc3594d2264726695d58c4a06899 to Ruby 2.6
- Backport was done at r67745. https://bugs.ruby-lang.org/issues/14834#note-13
-
09:11 AM Bug #16675: Regression on Ripper in Ruby 2.7 when parsing new line
- For example,
```ruby
<<FOO.chomp
foo
FOO
```
Here-doc beginning token is just followed by its content and terminator. -
08:34 AM Revision f9f3510e (git): Hook an experimental alert from Actions
-
08:21 AM Revision b9d45d3a (git): Hook an experimental alert from Travis
-
08:04 AM Revision 108f7536 (git): Removed unnecessary `chomp`
- As `String#split` with the default argument drops trailing newline
as a separator, preceding `String#chomp` is futile. -
07:46 AM Revision 65aa68b0 (git): Hook an experimental alert from AppVeyor
-
06:39 AM Feature #16665: Add an Array#except_index method
- There needs to be more discussion on the behavior of this method.
Logically, `except_indices` should be the complement of `values_at`, so for the purpose of writing test cases I added this stopgap:
```ruby
def except_indices(*idx)
se... -
12:58 AM Feature #16665: Add an Array#except_index method
- In my opinion `omit_indices` is the best name in the thread so far, but I'm not a huge fan of making my methods verbs. I propose `arr.except_indices(1, 2, 3)` as an alternative.
The negation of `values_at()` is a semi-common occurrenc... -
04:49 AM Revision fcd60502 (git): Fix a typo
-
04:19 AM Revision 9745e901 (git): Propagate JIT skip to all tests
-
01:03 AM Feature #16673: total_timeout for Net::HTTP
- `+1`. This is something I'd love to see implemented because this is actually the most common use case for me.
Could be implemented in a backwards compatible way (set `open_timeout` and `read_timeout` to `total_timeout` and abort appro...
03/06/2020
-
09:48 PM Bug #15608: What should be the correct output for Method#inspect with singleton methods?
- I rebased my patch against the current master branch and added a pull request for it: https://github.com/ruby/ruby/pull/2949
-
09:39 PM Bug #14119 (Closed): IPAddr#include? does not seem to support the subnet mask
-
09:36 PM Bug #15244 (Closed): Method #extname return empty string if filename is dot ('.')
-
09:31 PM Bug #9242 (Closed): Rdoc detection of aliases
-
09:16 PM Bug #11304 (Closed): [PATCH] Kernel.global_variables should observe $~.
-
09:15 PM Bug #16675: Regression on Ripper in Ruby 2.7 when parsing new line
- > Ripper doesn't fire the events in the order of the source, typically around here-documents.
Can you explain issue with here-documents? AFAIK, having used Ripper for over a decade now, this is the first time we've identified Ripper fir... -
02:25 PM Bug #16675: Regression on Ripper in Ruby 2.7 when parsing new line
- lsegal (Loren Segal) wrote in #note-2:
> 4) Finally, comments have always been allowed to separate expressions, but this only broke as of 2.7.0. Ripper even all the way back in Ruby 2.3.3 was able to handle the "fluent dot" scenario jus... -
02:23 PM Bug #16675 (Closed): Regression on Ripper in Ruby 2.7 when parsing new line
- Feel free to comment on this issue. But do not change the status of tracker's issue without the maintainer's decision.
-
09:42 AM Bug #16675 (Open): Regression on Ripper in Ruby 2.7 when parsing new line
- I'm not sure why this was closed so quickly. There is a real bug here affecting many users who indirectly rely on this core library.
It may be the case that comments can be placed between dots, but that should not affect parsing order... -
04:43 AM Bug #16675 (Closed): Regression on Ripper in Ruby 2.7 when parsing new line
- This is because comment lines can be placed between fluent dot.
That means it is undecidable if a newline before a comment line is ignored until comment lines end. -
12:03 AM Bug #16675 (Closed): Regression on Ripper in Ruby 2.7 when parsing new line
- Hello
While using migrating RSpec documentation to last Yard. I noticed an issue in code parsing and Ripper. The regression appears on Ruby 2.7 and Head.
``` ruby
require 'pp'
require 'ripper'
SOURCE = "def name\n # comment\n... -
09:06 PM Revision f991340e (git): Document defined? and global_variables handling of regexp global variables [ci skip]
- Fixes [Bug #11304]
-
08:17 PM Misc #15893: open-uri: URI.open status
- Thank you. So I gather
`URI.open(url, **options)`
becomes
`URI(url).open(**options)`
(Re the deprecation of old Ruby versions: users of gems often want to use them with whatever is on their OS, and that currently means we re... -
06:00 AM Misc #15893: open-uri: URI.open status
- cabo (Carsten Bormann) wrote in #note-3:
> So what is code that needs to be portable to older Rubies supposed to call now? `URI.open` only works since 2.5. We need to support 2.3 and 2.4 as well.
> ...
You can use URI#open.
```
%... -
05:37 AM Misc #15893: open-uri: URI.open status
- So what is code that needs to be portable to older Rubies supposed to call now? `URI.open` only works since 2.5. We need to support 2.3 and 2.4 as well.
`OpenURI.open_uri` ?
-
07:08 PM Bug #16676 (Closed): `#hash` can change Hash object from ar_table to st_table
- 4c019f5a626523e99e2827ed917802e3097c380d
c3584dfacce4d0f2058d8403de6fdce4fd4d686b -
06:31 PM Bug #16676 (Closed): `#hash` can change Hash object from ar_table to st_table
- # Points
* Hash representation `ar_table` has a problem from Ruby 2.6 (need to backport)
# Problem
From Ruby 2.6 `Hash` object is represented by `ar_table` (for small (<=8) pairs) and `st_table`.
To lookup hash table, `Object#h... -
06:55 PM Revision c3584dfa (git): check ar_table first.
- RHASH_AR_TABLE_SIZE() has assertion that it is a ar_talbe.
The last commit breaks this assumption so check ar_table first. -
06:34 PM Revision 4c019f5a (git): check ar_table after `#hash` call
- ar_table can be converted to st_table just after `ar_do_hash()`
function which calls `#hash` method. We need to check
the representation to detect this mutation.
[Bug #16676] - 05:39 PM Revision 44462d32 (git): * 2020-03-07 [ci skip]
-
05:38 PM Revision 87ad5ea7 (git): Skip jit_test on some new RubyCI envs for now
-
03:38 PM Bug #10167 (Closed): Prime#include?(mod) hangs up
-
12:41 PM Revision 0256e4f0 (git): thread_pthread.c: allocate sigaltstack before pthread_create
- A new (not-initialized-yet) pthread attempts to allocate sigaltstack by
using xmalloc. It may cause GC, but because the thread is not
initialized yet, ruby_native_thread_p() returns false, which leads to
"[FATAL] failed to allocate memo... -
11:55 AM Revision baaf6815 (git): Improve docs for Prime.{prime_division,int_from_prime_division} (#8)
- Move explanation for the decomposition array from the Example section
to the method description. Mention the term "multiplicity".
Use examples that also demonstrate factors with multiplicity
other than 1, and avoid factors/multiplicitie... -
11:54 AM Revision e92fbaf6 (git): [ruby/prime] Fix typo
- https://github.com/ruby/prime/commit/549c1b86f1
-
11:54 AM Revision f236f608 (git): [ruby/prime] Improve docs for Prime.include? (#7)
- https://github.com/ruby/prime/commit/230a5af325
-
11:54 AM Revision e79fc05a (git): [ruby/prime] Fix Prime.include?
- Previously, it would be an infinite loop if passed a non-prime
integer.
Also, Prime.include? should also provide similar results to
Module#include? if passed a Module, so handle that.
For consistency with Enumerable#include?, return fa... -
06:50 AM Feature #16615: Group style access scope for macros
- shevegen (Robert A. Heiler) wrote in #note-1:
> Two comments from me in regards to the proposal:
> ...
The `attr_*` family of methods currently enjoys special treatment here, as they are the only methods
which define instance methods ... -
06:32 AM Bug #16674 (Assigned): Build issue of FreeBSD 12
- See https://rubyci.org/logs/rubyci.s3.amazonaws.com/freebsd12/ruby-master/log/20200306T043002Z.fail.html.gz
-
12:09 AM Bug #16383: TracePoint does not report calls to attribute reader methods
- > On microbenchmark, it is 30% slower, so we need to invent a hack to support it.
In JRuby, that hack is called the `--debug` flag, which enables the full set of traces. At some point CRuby's probably going to have to do something sim...
03/05/2020
- 10:49 PM Revision 2630757f (git): * 2020-03-06 [ci skip]
-
10:49 PM Revision e57dd8c2 (git): Mask RubyVM-specific test
-
09:51 PM Bug #16383: TracePoint does not report calls to attribute reader methods
- Are there plans to implement this in master, any timeline?
Andy Maleh wants to add specs for this in https://github.com/ruby/spec/pull/761 which is nice but we would need an expected fix version. -
01:59 PM Bug #16672: net/http leaves original content-length header intact after inflating response
- jeremyevans0 (Jeremy Evans) wrote in #note-8:
> `total_out` doesn't give you the full size of the output until after the input is fully processed. So if there is an exception or other early exit from the block passed to `inflater` befo... -
05:54 AM Bug #16672: net/http leaves original content-length header intact after inflating response
- jmreid (Justin Reid) wrote in #note-7:
> > Modifying the Content-Length header is tricky because you do not know the decoded size until after decoding
> ...
`total_out` doesn't give you the full size of the output until after the input... -
04:42 AM Bug #16672: net/http leaves original content-length header intact after inflating response
- jeremyevans0 (Jeremy Evans) wrote in #note-6:
> I don't think net/http should be modifying the response headers. I think the response headers should remain exactly as sent by the server.
I do agree in general. However, in this case net/... -
04:04 AM Bug #16672: net/http leaves original content-length header intact after inflating response
- jmreid (Justin Reid) wrote in #note-5:
> > So the method appears to be operating exactly as documented.
> ...
I think I understand your reasoning better now. net/http is currently deleting the `Content-Encoding` header, so deleting or... -
02:56 AM Bug #16672: net/http leaves original content-length header intact after inflating response
- > So the method appears to be operating exactly as documented.
I'm not saying that method isn't working as intended. It's working as intended and I'm just using it to show the size of the header for the request net/http made. My comment... -
02:19 AM Bug #16672: net/http leaves original content-length header intact after inflating response
- jmreid (Justin Reid) wrote in #note-3:
> The issue here is that this ` "content-length"=>["2733"]` value is 2733. The `res.body` at this point is 9995, so `content-length` needs to match that or not exist. Otherwise it causes browsers t... -
01:40 AM Bug #16672: net/http leaves original content-length header intact after inflating response
- ioquatix (Samuel Williams) wrote in #note-2:
> Are you using `res.content_length`? Why can't you just use `res.body.to_s.bytesize`?
`res.content_length` is just the `content-length` response header from the net/http request:
```
... -
09:25 AM Revision 17d5efa4 (git): spec/ruby/core/process/exec_spec.rb: remove a guard for openbsd
- openbsd current seems to behave the same as other OSs.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20200305T063005Z.fail.html.gz -
08:19 AM Revision 7d05f98a (git): Renamed `lex_flags` as `lex_context`
-
06:45 AM Bug #16674 (Closed): Build issue of FreeBSD 12
- The current master branch and 2.7, 2.6 and 2.5 couldn't build with FreeBSD 12
see https://github.com/rbenv/ruby-build/issues/1272#issuecomment-455836665
We can build with `--disable-dtrace` flag on FreeBSD 12. -
04:31 AM Revision e4a9e926 (git): Fixed a typo
-
03:03 AM Revision 43a3c881 (git): [win32] get rid of redefinition of reserved macro
- ```
warning C4117: macro name '_INTEGRAL_MAX_BITS' is reserved, '#define' ignored
``` - 02:31 AM Revision 74051183 (git): * 2020-03-05 [ci skip]
-
02:31 AM Revision 261569d4 (git): [ruby/fiddle] always use ffi_closure_alloc on Windows
-
01:11 AM Misc #16671: BASERUBY version policy
- I'm not against this issue but for record: commit 8a72c77c7920d129818b7b83bb4fa669cd7e3f7d says "as requested by devs, support for BASERUBY prior to 2.1". and the "devs" here included ko1. At that time his machine was a Panasonic laptop...
-
12:16 AM Feature #16673 (Open): total_timeout for Net::HTTP
- `Net::HTTP` allows setting `open_timeout` and `read_timeout`, but sometimes I just want to make sure an API call will finish within a set amount of time, and am not concerned with how long opening the connection takes and reading the con...
03/04/2020
-
11:42 PM Bug #16660: Struct#deconstruct_keys inconsistent behavior
- (For some reason cannot edit the original post).
> Prior to that change an empty hash was returned in both cases.
I think, the less confusing behavior would be to ignore the unknown keys without "failing fast" (i.e., returning an empt... -
10:25 PM Bug #16672: net/http leaves original content-length header intact after inflating response
- Are you using `res.content_length`? Why can't you just use `res.body.to_s.bytesize`?
-
09:22 PM Bug #16672 (Closed): net/http leaves original content-length header intact after inflating response
- When using net/http to make a request to a resource, the default request headers are the following (when you have ZLIB available):
`"accept-encoding"=>["gzip;q=1.0,deflate;q=0.6,identity;q=0.3"], "accept"=>["*/*"], "user-agent"=>["Ruby"... -
02:26 PM Revision f08cd708 (git): Fixed FD leak
-
02:19 PM Revision 528a3a17 (git): [ruby/fiddle] use ffi_closure_alloc only with 3.2 or later
-
02:13 PM Revision 5bb80b76 (git): [win32] suppress false warning by mingw gcc
-
12:43 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- I think it's important to realize that it's the goal of pattern matching to be similar to data constructors. It proved itself to be a good solution in the long run, this is why languages mentioned above chose this approach. Of course, I'...
-
04:16 AM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- The pattern syntax looks very close to hash literals, but its semantics is quite different.
So I think it is very hard to distinguish them without a preceding mark (`in` keyword for now). -
12:02 PM Revision 364526cd (git): [win32] suppress false warning by MSVC
-
12:00 PM Revision 502d9bcd (git): Fixed never-defined symbol name
-
09:47 AM Misc #16671: BASERUBY version policy
- naruse (Yui NARUSE) wrote in #note-2:
> Through the discussion around CI, I reached a conclusion "Runtime environment and development environment are different".
Note that it is true for years, for instance, Windows 9x was supported ... -
08:24 AM Misc #16671: BASERUBY version policy
- Through the discussion around CI, I reached a conclusion "Runtime environment and development environment are different".
Though CentOS and macOS bundles very old ruby, but it's no problem because they are just runtime environment.
I... -
06:40 AM Misc #16671 (Closed): BASERUBY version policy
- Ruby 2.7 (MRI) requires Ruby 2.2 or later (== BASERUBY) to build from repository.
Tarball does not need any installed Ruby.
To build latest Ruby from repository, you need to build Ruby 2.2 and later from a tarball.
Can we make the B... -
09:41 AM Revision 95f387f6 (git): [ruby/fiddle] ffi_closure_free is available in the bundled libffi
-
09:14 AM Revision 633a1f15 (git): [ruby/fiddle] Use ffi_closure_free if available
-
08:28 AM Revision d732bc51 (git): Revert "Revert "Revert "[ruby/fiddle] Use ffi_closure_free by default. (#20)"""
- This reverts commit 87f6154bb4c67ca77ee353bb1fe25a922036c0e5.
It turned out that the change fails to build on macOS
https://rubyci.org/logs/rubyci.s3.amazonaws.com/osx1014/ruby-master/log/20200304T074503Z.fail.html.gz
```
+ make 'TESTS... -
06:46 AM Revision 87f6154b (git): Revert "Revert "[ruby/fiddle] Use ffi_closure_free by default. (#20)""
- This reverts commit efd641ffab34e433a8d8a7d78914576f2425aa90.
This changeset seems to be needed to suppress a warning on Ubuntu 20.04
https://rubyci.org/logs/rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20200304T033004Z.log.html.gz
``... -
03:31 AM Revision 16415fef (git): test/lib/jit_support.rb: The path to icc was changed
-
03:30 AM Revision aa44b290 (git): suppress uninitialized variable warnings
- Starting GCC 7, warnings about uninitialized variables are issued around
them. Such warnings could be false positives (all versions of clang do
not warn), but adding initializers there could never be bad things. -
03:30 AM Revision f7048f9d (git): tool/lib/test/unit: support TESTS='-- -ext-' again
- There is a test directory named test/-ext-. Because this directry
starts with a hyphen, we have to cheat test/unit in order for it to
run the tests underneath. TESTS='-- -ext' worked for a long time.
Let's not break that maneuver. -
03:30 AM Revision f12b9a33 (git): %p is for void *
- See also
35eb12c06397e770392a41343cbffc4b204e15c9
6f5eb285077d9abf8f97056531996c58674b570c
687308cf0dab0af675e40da2b6ab8ccd5f77c072
b6a2d63eb3dbc31e110e8cb95e054dd71d49a611 -
03:30 AM Revision 23250174 (git): fix compile error w/ -DUSE_TRANSIENT_HEAP=0
- rb_transient_heap_managed_ptr_p is available only when USE_TRANSIENT_HEAP.
Need #if guards. -
03:30 AM Revision 97fa6468 (git): fix compile error w/ -DCALC_EXACT_MALLOC_SIZE
-
02:36 AM Revision ce586107 (git): fix 6e271e4cbbe6a8bc4d4f75dc553ce054eae7af00
-
02:33 AM Revision 02705b27 (git): Run major GC to make sure the minor GC reason
- GC.latest_gc_info[:major_by] can return `oldmalloc` because of
last GC status. -
02:31 AM Revision 6e271e4c (git): Run major GC to make sure the minor GC next time.
- `GC.start(full_mark: false)` can run full GC because of last
GC status. Just after major GC, the possibility to run major GC
next time is too small (not a zero, but too small possibility). -
02:25 AM Revision cf52f37c (git): Narrow the check target.
- Call GC.verify_internal_consistency only for Gem related test
on i386-solaris. -
12:40 AM Bug #16423 (Closed): Ruby Crash
-
12:39 AM Bug #16474 (Closed): [ASYNC BUG]
-
12:39 AM Bug #16556 (Closed): Showing rails aborted message while running rails s
03/03/2020
-
11:14 PM Bug #16668: Syntax error in tool/vcs.rb
- Thanks for your response!
I realised it didn't affect the build, but for me a proper configure is showcasing the quality of a package.
Whenever I am confronted with sloppy configuration I am doubting the quality of everything else. -
09:05 PM Bug #16668: Syntax error in tool/vcs.rb
- I was able to reproduce this by building from the 2.6.5 tarball, and making `ruby` be ruby 1.8.7, without any use of `--with-baseruby`. The tarball automatically sets `BASERUBY` based on `ruby` even though it isn't needed in most tarbal...
-
03:01 PM Bug #16668: Syntax error in tool/vcs.rb
- Thanks for the info, though I am wondering, why configure doesn't take care of that automatically.
Isn't this a tarball what I get by downloading via https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.5.tar.gz? -
12:26 PM Bug #16668: Syntax error in tool/vcs.rb
- Build from a tarball, or configure with `--with-baseruby=no` option.
-
10:51 AM Bug #16668: Syntax error in tool/vcs.rb
- Yes, ruby -v:
ruby 1.8.1 (2003-12-25) [i386-linux-gnu]
which ruby:
/usr/bin/ruby
Extract from my log file:
```
BASERUBY = /usr/bin/ruby
CC = gcc
LD = ld
LDSHARED = gcc -shared
CFLAGS = -O3 -ggdb3 -Wall -Wdeclaration-after-stateme... -
07:29 AM Bug #16668 (Feedback): Syntax error in tool/vcs.rb
- Probably you use ruby 1.9 or earlier as `BASERUBY`, right?
-
08:17 PM Feature #15605: json library needs more frequent releases
- > I tried to make a step in that direction 2 weeks ago
Thanks for the link, I had no idea. I suppose I'll subscribe there and wait.
-
08:04 PM Feature #15605: json library needs more frequent releases
- I tried to make a step in that direction 2 weeks ago in https://github.com/flori/json/pull/402#issuecomment-586585888
But no answer yet from flori (even on such a trivial PR).
The current maintainer doesn't answer frequently enough for ... -
07:23 PM Bug #16138 (Closed): Backport Struct.new empty option hash fix to 2.5 and 2.6
-
07:19 PM Bug #16641 (Closed): Backport request: MJIT crashes on a certain flow of branches
-
07:19 PM Bug #16664 (Closed): Backport request: MJIT unloads methods used in a main thread when calling a Fiber
-
04:49 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- ....and also, one more example, now just in Ruby:
```ruby
# that's what we always had:
a, b = [1, 2, 3]
# could be pretty complicated:
a, (b, c), *d = [1, [2, 3], 4, 5]
# ...but now let's imagine we need to unpack a simple Hash... -
04:39 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- For the record, both Haskell and OCaml have let expressions. And yes, both have patterns on the left side, just like in F# or Rust.
-
04:15 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- In favor of the proposal, standalone match looks this way in other languages:
```
# Rust:
let (x, y, z) = (1, 2, 3);
# Erlang:
{X, Y} = {1, 2}.
# Elixir:
{a, b, c} = {:hello, "world", 42}
# F#:
let {First=first} = alice
# Swi... -
03:31 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- I do not think reddit discussions are that useful, largely because it is difficult to find
what is really going on (content-to-noise ratio), and the article title was actually
"2.7's pattern matching official docs (recently merged)". z... -
03:14 PM Feature #16670 (Closed): Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- Currently the 1-line syntax for pattern matching is:
```
# Usage: <expression> in <pattern>
expression = {
pattern: "Example"
}
expression in {pattern: something}
# something => "Example"
```
Is it technically possible... -
03:40 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- Hanmac (Hans Mackowiak) wrote in #note-8:
> @jgomo3 i found my old Symbol#call code
> ...
Great helper.
Well, that is another way.
So yes, the whole point of this ticket is to propose to allow that kind of expressions.
In other words,... -
02:27 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- @jgomo3 i found my old Symbol#call code
~~~ ruby
class Symbol
class SymbolHelper
def initialize(obj,methId,*args)
@obj= obj
@args=args
@methId=methId
end
def method_missing(methId,*args)
... -
01:37 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- Hanmac (Hans Mackowiak) wrote in #note-5:
> i tried `ary.map.with_object(:id,&:dig)` but it just returned `:id`
> ...
Amazing this approach.
Sadly, it will work only for Arity-1 functions.
If you want to dig more, how to do it? e.g, su... -
12:56 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- sawa (Tsuyoshi Sawada) wrote in #note-4:
> I already know that. That does not make `ary.map(:dig.to_proc(:id))` work. You seemed to have missed my point.
Ok, it would be actually `ary.map(&:dig.to_proc(:id))`.
But that is not the impor... -
09:58 AM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- i tried `ary.map.with_object(:id,&:dig)` but it just returned `:id`
but this one would work: `ary.each_with_object(:id).map(&:dig)` -
05:34 AM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- jgomo3 (Jesús Gómez) wrote in #note-3:
> The idea is to extend **to_proc** so it creates a **Proc** that calls the method on the given object using as arguments the parameters set in **to_proc** call.
> ...
I already know that. That do... - 03:11 PM Revision 14dd377e (git): * 2020-03-04 [ci skip]
-
02:42 PM Revision 03f9e874 (git): Don't tweak RubyVM compile options if it's not defined
-
12:00 PM Revision 43ed4eb6 (git): Limit the debug code conditon so that it runs only under i386-solaris
-
11:54 AM Revision 501f2c44 (git): Suppress an "assigned but unused variable" warning
-
11:28 AM Bug #16669 (Assigned): Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
- Great report.
-
11:07 AM Bug #16669: Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
- Thanks for the information. I was aware it reproduces with Action View also but unable to create some smaller steps to reproduce. Let me try to provide some smaller test cases with Action View.
-
10:45 AM Bug #16669: Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
- Action Text has much dependencies, and the failure is hard to understand which line is the cause of failure since that result show no stacktrace.
Action View failure is more ease to understand which line is the cause of failure.
http... -
10:30 AM Bug #16669 (Closed): Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
- This issue has been reported at Rails repository https://github.com/rails/rails/issues/38613
It always reproduces since https://github.com/ruby/ruby/commit/b9007b6c548f91e88fd3f2ffa23de740431fa969
but I do not know how to create minim... -
08:38 AM Revision a8c5b9a2 (git): [DOC] Separated parenthesized notes from subsection headings
- As the headings become link anchors, remove less useful notes.
[ci skip] -
07:19 AM Revision c8d0bf01 (git): Preserve `kwarg` flag and fix up f5c904c2a9
-
06:53 AM Revision 1ad93644 (git): add debug code for Solaris
- Check heap consistency after each test to debug.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11x/ruby-master/log/20200303T012406Z.fail.html.gz -
06:27 AM Revision aa9a38c0 (git): Ignore incompatible convert of symbols
-
05:43 AM Revision 91440ff1 (git): Convert incompatible encoding symbol names