Activity
From 02/27/2020 to 03/04/2020
03/04/2020
-
11:42 PM Bug #16660: Struct#deconstruct_keys inconsistent behavior
- (For some reason cannot edit the original post).
> Prior to that change an empty hash was returned in both cases.
I think, the less confusing behavior would be to ignore the unknown keys without "failing fast" (i.e., returning an empt... -
10:25 PM Bug #16672: net/http leaves original content-length header intact after inflating response
- Are you using `res.content_length`? Why can't you just use `res.body.to_s.bytesize`?
-
09:22 PM Bug #16672 (Closed): net/http leaves original content-length header intact after inflating response
- When using net/http to make a request to a resource, the default request headers are the following (when you have ZLIB available):
`"accept-encoding"=>["gzip;q=1.0,deflate;q=0.6,identity;q=0.3"], "accept"=>["*/*"], "user-agent"=>["Ruby"... -
02:26 PM Revision f08cd708 (git): Fixed FD leak
-
02:19 PM Revision 528a3a17 (git): [ruby/fiddle] use ffi_closure_alloc only with 3.2 or later
-
02:13 PM Revision 5bb80b76 (git): [win32] suppress false warning by mingw gcc
-
12:43 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- I think it's important to realize that it's the goal of pattern matching to be similar to data constructors. It proved itself to be a good solution in the long run, this is why languages mentioned above chose this approach. Of course, I'...
-
04:16 AM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- The pattern syntax looks very close to hash literals, but its semantics is quite different.
So I think it is very hard to distinguish them without a preceding mark (`in` keyword for now). -
12:02 PM Revision 364526cd (git): [win32] suppress false warning by MSVC
-
12:00 PM Revision 502d9bcd (git): Fixed never-defined symbol name
-
09:47 AM Misc #16671: BASERUBY version policy
- naruse (Yui NARUSE) wrote in #note-2:
> Through the discussion around CI, I reached a conclusion "Runtime environment and development environment are different".
Note that it is true for years, for instance, Windows 9x was supported ... -
08:24 AM Misc #16671: BASERUBY version policy
- Through the discussion around CI, I reached a conclusion "Runtime environment and development environment are different".
Though CentOS and macOS bundles very old ruby, but it's no problem because they are just runtime environment.
I... -
06:40 AM Misc #16671 (Closed): BASERUBY version policy
- Ruby 2.7 (MRI) requires Ruby 2.2 or later (== BASERUBY) to build from repository.
Tarball does not need any installed Ruby.
To build latest Ruby from repository, you need to build Ruby 2.2 and later from a tarball.
Can we make the B... -
09:41 AM Revision 95f387f6 (git): [ruby/fiddle] ffi_closure_free is available in the bundled libffi
-
09:14 AM Revision 633a1f15 (git): [ruby/fiddle] Use ffi_closure_free if available
-
08:28 AM Revision d732bc51 (git): Revert "Revert "Revert "[ruby/fiddle] Use ffi_closure_free by default. (#20)"""
- This reverts commit 87f6154bb4c67ca77ee353bb1fe25a922036c0e5.
It turned out that the change fails to build on macOS
https://rubyci.org/logs/rubyci.s3.amazonaws.com/osx1014/ruby-master/log/20200304T074503Z.fail.html.gz
```
+ make 'TESTS... -
06:46 AM Revision 87f6154b (git): Revert "Revert "[ruby/fiddle] Use ffi_closure_free by default. (#20)""
- This reverts commit efd641ffab34e433a8d8a7d78914576f2425aa90.
This changeset seems to be needed to suppress a warning on Ubuntu 20.04
https://rubyci.org/logs/rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20200304T033004Z.log.html.gz
``... -
03:31 AM Revision 16415fef (git): test/lib/jit_support.rb: The path to icc was changed
-
03:30 AM Revision aa44b290 (git): suppress uninitialized variable warnings
- Starting GCC 7, warnings about uninitialized variables are issued around
them. Such warnings could be false positives (all versions of clang do
not warn), but adding initializers there could never be bad things. -
03:30 AM Revision f7048f9d (git): tool/lib/test/unit: support TESTS='-- -ext-' again
- There is a test directory named test/-ext-. Because this directry
starts with a hyphen, we have to cheat test/unit in order for it to
run the tests underneath. TESTS='-- -ext' worked for a long time.
Let's not break that maneuver. -
03:30 AM Revision f12b9a33 (git): %p is for void *
- See also
35eb12c06397e770392a41343cbffc4b204e15c9
6f5eb285077d9abf8f97056531996c58674b570c
687308cf0dab0af675e40da2b6ab8ccd5f77c072
b6a2d63eb3dbc31e110e8cb95e054dd71d49a611 -
03:30 AM Revision 23250174 (git): fix compile error w/ -DUSE_TRANSIENT_HEAP=0
- rb_transient_heap_managed_ptr_p is available only when USE_TRANSIENT_HEAP.
Need #if guards. -
03:30 AM Revision 97fa6468 (git): fix compile error w/ -DCALC_EXACT_MALLOC_SIZE
-
02:36 AM Revision ce586107 (git): fix 6e271e4cbbe6a8bc4d4f75dc553ce054eae7af00
-
02:33 AM Revision 02705b27 (git): Run major GC to make sure the minor GC reason
- GC.latest_gc_info[:major_by] can return `oldmalloc` because of
last GC status. -
02:31 AM Revision 6e271e4c (git): Run major GC to make sure the minor GC next time.
- `GC.start(full_mark: false)` can run full GC because of last
GC status. Just after major GC, the possibility to run major GC
next time is too small (not a zero, but too small possibility). -
02:25 AM Revision cf52f37c (git): Narrow the check target.
- Call GC.verify_internal_consistency only for Gem related test
on i386-solaris. -
12:40 AM Bug #16423 (Closed): Ruby Crash
-
12:39 AM Bug #16474 (Closed): [ASYNC BUG]
-
12:39 AM Bug #16556 (Closed): Showing rails aborted message while running rails s
03/03/2020
-
11:14 PM Bug #16668: Syntax error in tool/vcs.rb
- Thanks for your response!
I realised it didn't affect the build, but for me a proper configure is showcasing the quality of a package.
Whenever I am confronted with sloppy configuration I am doubting the quality of everything else. -
09:05 PM Bug #16668: Syntax error in tool/vcs.rb
- I was able to reproduce this by building from the 2.6.5 tarball, and making `ruby` be ruby 1.8.7, without any use of `--with-baseruby`. The tarball automatically sets `BASERUBY` based on `ruby` even though it isn't needed in most tarbal...
-
03:01 PM Bug #16668: Syntax error in tool/vcs.rb
- Thanks for the info, though I am wondering, why configure doesn't take care of that automatically.
Isn't this a tarball what I get by downloading via https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.5.tar.gz? -
12:26 PM Bug #16668: Syntax error in tool/vcs.rb
- Build from a tarball, or configure with `--with-baseruby=no` option.
-
10:51 AM Bug #16668: Syntax error in tool/vcs.rb
- Yes, ruby -v:
ruby 1.8.1 (2003-12-25) [i386-linux-gnu]
which ruby:
/usr/bin/ruby
Extract from my log file:
```
BASERUBY = /usr/bin/ruby
CC = gcc
LD = ld
LDSHARED = gcc -shared
CFLAGS = -O3 -ggdb3 -Wall -Wdeclaration-after-stateme... -
07:29 AM Bug #16668 (Feedback): Syntax error in tool/vcs.rb
- Probably you use ruby 1.9 or earlier as `BASERUBY`, right?
-
08:17 PM Feature #15605: json library needs more frequent releases
- > I tried to make a step in that direction 2 weeks ago
Thanks for the link, I had no idea. I suppose I'll subscribe there and wait.
-
08:04 PM Feature #15605: json library needs more frequent releases
- I tried to make a step in that direction 2 weeks ago in https://github.com/flori/json/pull/402#issuecomment-586585888
But no answer yet from flori (even on such a trivial PR).
The current maintainer doesn't answer frequently enough for ... -
07:23 PM Bug #16138 (Closed): Backport Struct.new empty option hash fix to 2.5 and 2.6
-
07:19 PM Bug #16641 (Closed): Backport request: MJIT crashes on a certain flow of branches
-
07:19 PM Bug #16664 (Closed): Backport request: MJIT unloads methods used in a main thread when calling a Fiber
-
04:49 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- ....and also, one more example, now just in Ruby:
```ruby
# that's what we always had:
a, b = [1, 2, 3]
# could be pretty complicated:
a, (b, c), *d = [1, [2, 3], 4, 5]
# ...but now let's imagine we need to unpack a simple Hash... -
04:39 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- For the record, both Haskell and OCaml have let expressions. And yes, both have patterns on the left side, just like in F# or Rust.
-
04:15 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- In favor of the proposal, standalone match looks this way in other languages:
```
# Rust:
let (x, y, z) = (1, 2, 3);
# Erlang:
{X, Y} = {1, 2}.
# Elixir:
{a, b, c} = {:hello, "world", 42}
# F#:
let {First=first} = alice
# Swi... -
03:31 PM Feature #16670: Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- I do not think reddit discussions are that useful, largely because it is difficult to find
what is really going on (content-to-noise ratio), and the article title was actually
"2.7's pattern matching official docs (recently merged)". z... -
03:14 PM Feature #16670 (Closed): Reverse order of `expression` in `pattern` for 1-line pattern matching while it's still experimental
- Currently the 1-line syntax for pattern matching is:
```
# Usage: <expression> in <pattern>
expression = {
pattern: "Example"
}
expression in {pattern: something}
# something => "Example"
```
Is it technically possible... -
03:40 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- Hanmac (Hans Mackowiak) wrote in #note-8:
> @jgomo3 i found my old Symbol#call code
> ...
Great helper.
Well, that is another way.
So yes, the whole point of this ticket is to propose to allow that kind of expressions.
In other words,... -
02:27 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- @jgomo3 i found my old Symbol#call code
~~~ ruby
class Symbol
class SymbolHelper
def initialize(obj,methId,*args)
@obj= obj
@args=args
@methId=methId
end
def method_missing(methId,*args)
... -
01:37 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- Hanmac (Hans Mackowiak) wrote in #note-5:
> i tried `ary.map.with_object(:id,&:dig)` but it just returned `:id`
> ...
Amazing this approach.
Sadly, it will work only for Arity-1 functions.
If you want to dig more, how to do it? e.g, su... -
12:56 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- sawa (Tsuyoshi Sawada) wrote in #note-4:
> I already know that. That does not make `ary.map(:dig.to_proc(:id))` work. You seemed to have missed my point.
Ok, it would be actually `ary.map(&:dig.to_proc(:id))`.
But that is not the impor... -
09:58 AM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- i tried `ary.map.with_object(:id,&:dig)` but it just returned `:id`
but this one would work: `ary.each_with_object(:id).map(&:dig)` -
05:34 AM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- jgomo3 (Jesús Gómez) wrote in #note-3:
> The idea is to extend **to_proc** so it creates a **Proc** that calls the method on the given object using as arguments the parameters set in **to_proc** call.
> ...
I already know that. That do... - 03:11 PM Revision 14dd377e (git): * 2020-03-04 [ci skip]
-
02:42 PM Revision 03f9e874 (git): Don't tweak RubyVM compile options if it's not defined
-
12:00 PM Revision 43ed4eb6 (git): Limit the debug code conditon so that it runs only under i386-solaris
-
11:54 AM Revision 501f2c44 (git): Suppress an "assigned but unused variable" warning
-
11:28 AM Bug #16669 (Assigned): Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
- Great report.
-
11:07 AM Bug #16669: Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
- Thanks for the information. I was aware it reproduces with Action View also but unable to create some smaller steps to reproduce. Let me try to provide some smaller test cases with Action View.
-
10:45 AM Bug #16669: Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
- Action Text has much dependencies, and the failure is hard to understand which line is the cause of failure since that result show no stacktrace.
Action View failure is more ease to understand which line is the cause of failure.
http... -
10:30 AM Bug #16669 (Closed): Rails Action Text unit tests fail since b9007b6c548f91e88fd3f2ffa23de740431fa969
- This issue has been reported at Rails repository https://github.com/rails/rails/issues/38613
It always reproduces since https://github.com/ruby/ruby/commit/b9007b6c548f91e88fd3f2ffa23de740431fa969
but I do not know how to create minim... -
08:38 AM Revision a8c5b9a2 (git): [DOC] Separated parenthesized notes from subsection headings
- As the headings become link anchors, remove less useful notes.
[ci skip] -
07:19 AM Revision c8d0bf01 (git): Preserve `kwarg` flag and fix up f5c904c2a9
-
06:53 AM Revision 1ad93644 (git): add debug code for Solaris
- Check heap consistency after each test to debug.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11x/ruby-master/log/20200303T012406Z.fail.html.gz -
06:27 AM Revision aa9a38c0 (git): Ignore incompatible convert of symbols
-
05:43 AM Revision 91440ff1 (git): Convert incompatible encoding symbol names
03/02/2020
-
09:42 PM Feature #16665: Add an Array#except_index method
- Hello, I was part of this discussion on Railstalk and the Rails-core issue, you can peek for additional context here: https://github.com/rails/rails/pull/38611#issuecomment-593627540
It was closed on Rails-core and suggested to be pro... -
07:19 PM Feature #16665: Add an Array#except_index method
- sawa (Tsuyoshi Sawada) wrote in #note-2:
> For the positive counterpart, we have `Array#values_at`. I think the method name to be proposed should be somehow aligned with that.
May I ask you to check my answer to Robert A. Heiler? -
07:18 PM Feature #16665: Add an Array#except_index method
- shevegen (Robert A. Heiler) wrote in #note-1:
> I can not comment on how useful this may be; I think I may have added something similar
> ...
I also thought a lot about naming and have a few variants:
``` ruby
omit_indices
omit_in... -
09:01 AM Feature #16665: Add an Array#except_index method
- Isn't this easily solvable with `select` and `with_index`?
``` ruby
%w( a b c d e f).select.with_index{|l,index| index > 1 } # => ["c", "d", "e", "f"]
```
-
08:14 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- > I am not sure how allowing parameters to Symbol#to_proc and Method#to_proc would make:
> ...
Currently, **to_proc** on symbols creates a **Proc** that receives an object and calls on it the method with name equal to the symbol.
The id... - 05:44 PM Revision 485ef0bd (git): * 2020-03-03 [ci skip]
-
05:44 PM Revision 91de0daa (git): method_missing_reason should be set.
- send() has special method launcher in VM and it has special
method_missing caller. This path doesn't set
ec->method_missing_reason which is used at exception creation,
so setup this information. Without this setting, NoMethodError
except... -
04:03 PM Bug #16668: Syntax error in tool/vcs.rb
- something might be wrong with your ruby version, because `def self.detect(path, uplevel_limit: 0)` is valid ruby code
-
01:06 PM Bug #16668 (Closed): Syntax error in tool/vcs.rb
- ```
./tool/file2lastrev.rb:10:in `require': /home/imptst/ruby/ruby-2.6.5/tool/vcs.rb:127: syntax error (SyntaxError)
```
```ruby
def self.detect(path, uplevel_limit: 0)
```
Should be:
```ruby
def self.detect(path, uplevel_limit... -
01:37 PM Revision 65dd50fc (git): Suppress "assigned but unused variable" warnings
-
07:45 AM Revision 85620ffa (git): Reduced parser stack usage by merging non-result actions
-
07:34 AM Revision 20a2ab08 (git): Packed stacked bit flags into one struct
-
07:05 AM Revision 761528e8 (git): Add `#write` and `#binwrite` to IO section [ci skip]
-
06:49 AM Revision f5c904c2 (git): Allow newlines inside braced pattern
-
05:53 AM Revision 0711ceeb (git): .github/workflows: name the configure runs
- Explicit `name:` entry was requested by @nobu.
-
05:53 AM Revision 2bfa1025 (git): .github: let "make leaked-globals" run in parallel
- This target can be a build matrix. Also it does not make sense to test
it on mjit. -
05:53 AM Revision 888e7365 (git): .github: make use of working-directory
- One can specify working directory of a step, no by `cd foo` inside of
the run. See also
https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsrun -
05:53 AM Revision e06ad731 (git): .github: less verbose on: specifier
- The `branch:` specifier was necessary before, to prevent double-testing
master and trunk. Now that we no longer have trunk, we can slim the
expressions.
See also: https://help.github.com/en/actions/reference/workflow-syntax-for-github-... -
05:53 AM Revision bdf2d913 (git): .travis.yml, .github: delete environmental dumps
- They were necessary when developing YAMLs, but not useful any longer.
-
05:53 AM Revision f4a3830f (git): .travis.yml: favor >- over |- and backslash
-
05:53 AM Revision 01fc48c2 (git): .travis.yml: mandate UBSAN
- It seems UBSAN is quite stable now.
-
05:53 AM Revision 9086f6bf (git): .travis.yml delete darwin debug code
- Darwin is no longer tested using Travis CI. See also commit
91aa8bfff8a9f9c0af96915c120d863fc474e8d5 -
05:53 AM Revision cdf8471a (git): .travis.yml: ruby_2_7 is travis ready.
-
05:42 AM Revision 648eb31b (git): Reset Reline.point
- TestRelineAsReadline#test_insert_text expects Readline.point == 0
at the beginning of the test, but a test violate this assumption. -
05:25 AM Revision 4fd51f84 (git): vm_cc_fill() need to clear aux.
- vm_cc_fill() fills CC information into stack allocated memory so
it is not cleared. So we need to clear CC->aux. -
04:42 AM Revision d348b4ad (git): skip test if Reline.completion_proc is nil.
- Some other tests can set Reline.completion_proc, so if it is nil,
simply skip this test. -
04:16 AM Revision fb377e8f (git): Revert "show debug info."
- This reverts commit 0bfee2397ba59112902d2b49f08461db3a637b46.
-
04:14 AM Revision 31c55b67 (git): need to restore $stdin.
- 02:44 AM Revision 5d3b38d6 (git): * 2020-03-02 [ci skip]
-
02:43 AM Revision 0bfee239 (git): show debug info.
- https://gist.github.com/ko1/a71f7cbcfbd61ba004bffdfedab9f5f2#file-brlog-trunk-random0-20200302-020213-L2127
03/01/2020
-
11:08 PM Misc #16452 (Closed): Document pattern matching
-
08:38 PM Feature #16666: 'string' - 'str' as a shortcut for 'string'.gsub('str', '')?
- > Does anyone else think the same syntax would be beneficial for Strings?
I do not doubt that it can be useful. One advantage of your proposal is that it
is very short and succinct.
Personally, though, I prefer .gsub() or .gsub!()... -
07:07 AM Feature #16666: 'string' - 'str' as a shortcut for 'string'.gsub('str', '')?
- For removing a set of characters, there is already `String#delete`. And for your other cases, there is a similar proposal https://bugs.ruby-lang.org/issues/12698.
-
08:32 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- I think this or something similar was suggested in the past, even aside from
the two linked in proposals. So this may even be older than 5 years. :)
I do not remember what the conclusion was in all these proposals (and perhaps
I mis... -
05:31 PM Feature #16667: Allow parameters to Symbol#to_proc and Method#to_proc
- I am not sure how allowing parameters to `Symbol#to_proc` and `Method#to_proc` would make:
```ruby
ary.map(:dig.to_proc(:id))
```
possible as `Array#map` does not take an argument. What do you want it to return?
Needless to say, it i... -
04:07 PM Feature #16667 (Open): Allow parameters to Symbol#to_proc and Method#to_proc
- Allow parameters to Symbol#to_proc and Method#to_proc
So we can say:
``` ruby
ary.map(:dig.to_proc(:id))
```
Instead of
``` ruby
ary.map { |e| e.dig(:id) }
```
Oppening the posibilities to refine the `&` operator i... -
07:03 AM Feature #16665: Add an Array#except_index method
- For the positive counterpart, we have `Array#values_at`. I think the method name to be proposed should be somehow aligned with that.
-
05:35 AM Revision d25a4f41 (git): Allow trailing comma in hash pattern
02/29/2020
-
09:12 PM Feature #16666 (Open): 'string' - 'str' as a shortcut for 'string'.gsub('str', '')?
- Sorry if this has been brought up before, but I couldn't find anything.
I love how we can substract arrays (`[1,2,3] - [1,2]`). Does anyone else think the same syntax would be beneficial for Strings?
Some possible scenarios could b... -
08:19 PM Feature #14145 (Closed): Proposal: Better Method#inspect
-
07:59 PM Revision 356e032e (git): require enc/trans/single_byte in advance.
- enc/trans/single_byte is needed to run some tests, however
it will fail to require because $: is empty. -
06:27 PM Feature #16648: improve GC performance by 5% with builtin_prefetch
- alanwu (Alan Wu) wrote in #note-1:
> I ran the patch on some included GC benchmarks in the repo and it doesn't seem to be a pure win (built-ruby is the patched version):
Thanks! I hadn't seen these. I see roughly similar results loc... -
06:23 PM Misc #16636 (Closed): DevelopersMeeting before RubyKaigi2020
- Thanks shevegen.
RubyKaigi 2020 is postponed and this meeting is also postponed.
I'll re-arrange in Sep. -
06:18 PM Misc #16636: DevelopersMeeting before RubyKaigi2020
- There has been an announcement recently about kaigi being delayed.
https://esa-pages.io/p/sharing/68/posts/1006/b15a58c675f5a69d06e5.html
In particular:
"All the events that were planned for April 9th-11th will be rescheduled
t... -
06:05 PM Feature #16665: Add an Array#except_index method
- I can not comment on how useful this may be; I think I may have added something similar
once in a while, but I can not say how useful or common that would be. IMO we should
see to determine how common the above idiom is, before we can... -
02:46 PM Feature #16665 (Open): Add an Array#except_index method
- The main idea is to implement a method that we can use to exclude elements from the array by their indices.
For example:
``` ruby
%w( a b c d e f).except_index(0, -1)
=> ["b", "c", "d", "e"]
%w( a b c d e f g h ).except_index... - 06:03 PM Revision a70aa599 (git): * 2020-03-01 [ci skip]
-
06:02 PM Revision 413c9800 (git): show backtrace.
- assert_nothing_raised doesn't show the backtrace if an exception
is thrown in a block. This patch shows this backtrace. -
12:42 PM Revision af186373 (git): Adjust types
-
12:42 PM Revision 403675e8 (git): Named `tLABEL` token
-
08:16 AM Bug #16664 (Closed): Backport request: MJIT unloads methods used in a main thread when calling a Fiber
- ## Problem
The following script SEGVs with `ruby --disable-gems --jit-min-calls=1 --jit-max-cache=10 --jit-wait script.rb`.
```ruby
def a1() a2(false); a2(true) end
def a2(a) a3(a) end
def a3(a) a4(a) end
def a4(a) a5(a) end
def... -
07:58 AM Revision adcf0316 (git): Prevent unloading methods used in root_fiber while calling another Fiber (#2939)
- Fixing SEGVs like:
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2744905
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2744420
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2741400 -
07:25 AM Feature #15722: `Kernel#case?`
- osyo (manga osyo) wrote in #note-6:
> I think this is closer to the syntax of `case when`.
> ...
As a `case expr` statement doesn't need a terminator (newline or semicolon) before `when`, it conflicts with the current syntax. -
07:20 AM Revision a8dcab72 (git): Avoid infinite loop on --jit-wait
-
06:42 AM Revision 5e897227 (git): Added more benchmarks for String
-
06:14 AM Revision f5b78969 (git): Fix a typo [ci skip]
-
05:05 AM Revision 7da11ed7 (git): Suppress security alerts
- https://github.com/advisories/GHSA-jppv-gw3r-w3q8
-
04:24 AM Revision 2b855919 (git): Fix up mark-ups in NEWS [ci skip]
-
03:20 AM Revision 0333f3c0 (git): Missing links in NEWS [ci skip]
-
12:12 AM Revision 99ff4d61 (git): Update NEWS [ci skip]
02/28/2020
-
10:27 PM Feature #16663 (Closed): Add block or filtered forms of Kernel#caller to allow early bail-out
- There are many libraries that use `caller` or `caller_locations` to gather stack information for logging or instrumentation. These methods generate an array of informational stack frames based on the current call stack.
Both methods a... -
07:22 PM Revision b3983c68 (git): should not expose hidden object.
- Hidden object (T_CLASS) can be exposed (BUG).
Also rename rb_mInternalObjectWrapper to rb_cInternalObjectWrapper
because it is a class. -
06:32 PM Revision b621c9ab (git): Set Readline.completion_append_character = nil always
- GNU Readline add a white space when Readline.completion_append_character is
not initialized. - 06:13 PM Revision 02a3e276 (git): Bump rake from 10.5.0 to 12.3.3 in /spec/mspec (#2942)
- Bumps [rake](https://github.com/ruby/rake) from 10.5.0 to 12.3.3.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](https://github.com/ruby/rake/comp... -
06:07 PM Revision a0f5ff4c (git): Update to ruby/spec@41bf282
-
06:07 PM Revision 5d210501 (git): Update to ruby/mspec@a514ad7
- 03:49 PM Revision a8687f3e (git): * 2020-02-29 [ci skip]
-
03:43 PM Revision cb681c20 (git): restore server[:DocumentRootOptions] setting.
- Surprisingly (at least for me), `server[:DocumentRootOptions]`
on Webrick is global information and it affect the result of
test_short_filename. Random order test fails because of global
information change. I doubt it is bug, but to fix ... -
02:32 PM Revision f7be85a2 (git): support random order test.
- test_readline:
HISTORY should be empty.
test_using_quoting_detection_proc:
test_using_quoting_detection_proc_with_multibyte_input:
Readline.completer_quote_characters= and
Readline.completer_word_break_characters= doesn't accept n... -
01:44 PM Feature #14145: Proposal: Better Method#inspect
- This can be closed now, I believe.
-
01:43 PM Misc #16452: Document pattern matching
- Can be closed, as PR is merged :)
-
12:26 PM Bug #16662 (Closed): lchmod available in linux since glibc 2.31.9000
- Applied in changeset commit:git|72c02aa4b79731c7f25c9267f74b347f1946c704.
----------
Moved not-implemented method tests [Bug #16662]
Test not-implemented method with the dedicated methods, instead of
platform dependent features. -
11:11 AM Bug #16662: lchmod available in linux since glibc 2.31.9000
- Reverting [1] does not really help, because then I see the `Errno::ENOTSUP` reported for several test cases :/
[1]: https://github.com/ruby/ruby/commit/a19228f878d955eaf2cce086bcf53f46fdf894b9 -
10:42 AM Bug #16662 (Closed): lchmod available in linux since glibc 2.31.9000
- Testing of Fedora Rawhide, it seems that lchmod(2) is available and therefore the `TestNotImplement#test_respond_to_lchmod` test fails. You can check the build here [1] or the full build log including dumped configure.log is in attachmen...
-
12:15 PM Revision 72c02aa4 (git): Moved not-implemented method tests [Bug #16662]
- Test not-implemented method with the dedicated methods, instead of
platform dependent features. -
11:44 AM Feature #16557: Deduplicate Regexp literals
- From the developers meeting notes:
> Preliminary discussion:
> ...
My opinion on this:
> ko1: The patch creates a regexp object, and then find already-existing instance. It is slightly suboptimal
Yes, my plan was to improve tha... -
11:10 AM Revision 07f27383 (git): Refined argument name
-
10:28 AM Revision 6df8cfb7 (git): Omit test_using_quoting_detection_proc_with_multibyte_input temporarily for random order test
-
09:37 AM Bug #16656 (Closed): Fix wrong RegExp in rbinstall to install the default gems from expanded sources again
- Fixed in https://github.com/ruby/ruby/commit/9bede6e942e7726d320d734fead741672d060625
-
08:58 AM Revision 6787ccf2 (git): setup Other class.
- Some tests need to setup Other class with OtherSetup proc.
-
08:44 AM Revision 28399e4e (git): respect --test-order=random
- Now --test-order=random is simply ignored. This patch respect
this option. -
08:09 AM Feature #16644: qualified const init (self::CONST1 = 1) should be allowed in methods
- @bughit i think you are looking for `#const_missing` instead?
- 05:32 AM Revision 9bede6e9 (git): Fix wrong RegExp.
- The missing `\` in PR #2922 causes the default gems to be installed from
the .gem packages instead from the expanded sources. -
05:27 AM Bug #12251: DelegateClass(OpenStruct) behavior in 2.3.0 different from 2.2
- The [pull-request] and [commit].
[pull-request]: https://github.com/ruby/ruby/pull/1033
[commit]: https://bugs.ruby-lang.org/projects/ruby-master/repository/git/revisions/7fa21558051e5412dcb790f528e392476edd4389
-
03:38 AM Misc #16661 (Closed): DevelopersMeeting20200316Japan
- # The next dev meeting
**Date: 2020/03/16 13:00-17:00**
Place/Sign-up/Agenda/Log: https://docs.google.com/document/d/1Qi8eIfWh2khVzSvHsVqO10pgmJdUTbEu9vL-S5mb2fE/edit#
- Dev meeting *IS NOT* a decision-making place. All decisions ... -
03:35 AM Misc #16561 (Closed): DevelopersMeeting20200227Japan
02/27/2020
-
10:13 PM Bug #16660 (Rejected): Struct#deconstruct_keys inconsistent behavior
- Here is an example of a kind of surprising (at least to me) `Struct#deconstruct_keys` behaviour:
```ruby
klass = Struct.new(:a, :b)
s = klass.new(1, 2)
```
1) When some keys are not recognized and the total number of the keys is... -
09:56 PM Feature #16597: missing poll()
- Updated patch
-
07:08 PM Bug #9573 (Open): descendants of a module don't gain its future ancestors, but descendants of a class, do
-
07:03 PM Bug #9573 (Closed): descendants of a module don't gain its future ancestors, but descendants of a class, do
- Applied in changeset commit:git|3556a834a2847e52162d1d3302d4c64390df1694.
----------
Make Module#include affect the iclasses of the module
When calling Module#include, if the receiver is a module,
walk the subclasses list and include t... -
08:23 AM Bug #9573: descendants of a module don't gain its future ancestors, but descendants of a class, do
- The patch for `include` looks OK to me. To ensure there are no unseen compatibility issues, I'd like to experiment with it during the 2.8 development cycle. I am not yet sure how `prepend` should work here. I need to think about it more ...
-
07:03 PM Revision 3556a834 (git): Make Module#include affect the iclasses of the module
- When calling Module#include, if the receiver is a module,
walk the subclasses list and include the argument module in each
iclass.
This does not affect Module#prepend, as fixing that is significantly
more involved.
Fixes [Bug #9573] -
06:18 PM Bug #13675 (Closed): Should Zlib::GzipReader#ungetc accept nil?
- Applied in changeset commit:git|54499d78109037d7c37bc09a8c3ffa0050da5aca.
----------
Remove support for passing nil to IO#ungetc
Fixes [Bug #13675] -
05:13 AM Bug #13675: Should Zlib::GzipReader#ungetc accept nil?
- `IO#ungetc` should be fixed. The patch looks good to me.
Matz.
- 06:18 PM Revision 1ca3a221 (git): * 2020-02-28 [ci skip]
-
06:17 PM Revision 54499d78 (git): Remove support for passing nil to IO#ungetc
- Fixes [Bug #13675]
-
04:31 PM Feature #16644: qualified const init (self::CONST1 = 1) should be allowed in methods
- > I'd rather make all const re-assignment error
I don't disagree, actual const re-assignment, dynamically detected, probably should be an error. But then especially, there is no reason that a qualified const initialization (`mod::CONS... -
07:11 AM Feature #16644 (Rejected): qualified const init (self::CONST1 = 1) should be allowed in methods
-
07:11 AM Feature #16644: qualified const init (self::CONST1 = 1) should be allowed in methods
- Use `const_set`. I'd rather make all const re-assignment error if compatibility does not matter.
Matz.
-
04:16 PM Misc #16659 (Open): Documentation on Regexp missing for absence pattern (?~pat)
- The absence pattern `(?~pat)` available since Ruby 2.4.1 is [not yet documented on `Regexp`](https://git.ruby-lang.org/ruby.git/tree/doc/regexp.rdoc) as of today.
(Found it by coincidence reading [this article by Peter Cooper](https:... -
11:08 AM Feature #16652: Use RubyGems facilities to install Gems during Ruby installation
- Since the first PR was merged, I have updated the second PR [1] to apply cleanly.
[1]: https://github.com/ruby/ruby/pull/2545 -
10:49 AM Feature #15605: json library needs more frequent releases
- What's the status on this ?
I understand that a part of the gem is now edited from ruby/ruby, but that exclude the `pure` and `java` implementations. So this doesn't sounds like a good long term solution, and more like a temporary w... -
10:14 AM Bug #16656: Fix wrong RegExp in rbinstall to install the default gems from expanded sources again
- Also found the same error myself and fixed it at https://github.com/ruby/ruby/pull/2930.
-
06:42 AM Bug #16656 (Closed): Fix wrong RegExp in rbinstall to install the default gems from expanded sources again
- I have submitted [1] to fix the wrong RegExp from [2].
[1]: https://github.com/ruby/ruby/pull/2933
[2]: https://github.com/ruby/ruby/pull/2922 -
09:52 AM Misc #16630: Deprecate pub/ruby/*snapshot* and use pub/ruby/snapshot/* instead
- I created [pull request to change links to snapshot](https://github.com/ruby/www.ruby-lang.org/pull/2379).
-
09:48 AM Bug #16658 (Closed): `method__cache__clear` DTrace hook was dropped without replacement
- The PR #2888 [1] dropped DTrace `method__cache__clear` hook without replacement. Was this intentional? If yes, then the probes.d [3] should be updated appropriately. If this was not intentional, the hook should be reintroduced.
[1... -
08:08 AM Bug #15409: OpenStruct error when attribute is called 'method'
- @marcandre
I talked with matz about this ticket, and he said it would be good to revert 3bf9b2f0473550caa73468908ac3e18e0f431b85 because the change brought a compatibility issue (#12055, #12136, #15409). The final decision is left to y... -
08:00 AM Bug #12251: DelegateClass(OpenStruct) behavior in 2.3.0 different from 2.2
- Hmm, it was caused by OpenStruct performance pull-request. Maybe we should revert the PR?
Matz.
-
07:59 AM Feature #16605 (Rejected): Support argument delegation (...) with blocks/define_method
- You may think it's handy. But it's far more complicated than you think. For example, `define_method` may be called from a method with argument forwarding. At least for the moment, it does not worth the cost of implementation/complexity....
-
07:08 AM Feature #16378: Support leading arguments together with ...
- We have found out that `#method_missing` (and `#send`) needed leading arguments otherwise we cannot use argument forwarding for them. I changed my mind. Accepted.
Matz.
-
06:50 AM Feature #16657 (Assigned): Don't ship bundled gems as .gem files as well as in expanded form
- Working at #16651, I wonder why the release tarball ships with the bundled gem in form of .gem packages as well as the expanded sources. It would be nice, if one option is chosen. Ideally just the .gem packages, because these are vanilla...
-
06:07 AM Feature #16476 (Assigned): Socket.getaddrinfo cannot be interrupted by Timeout.timeout
- We discussed this issue at the dev-meeting, and it requires @Glass_saga's review.
Note:
* It is uninterruptable under a platform that getaddrinfo_a is unavailable, but this problem is not only this proposal but also `timeout:` opti... -
05:54 AM Feature #15722 (Feedback): `Kernel#case?`
- It is not obvious to me that `#case?` is useful. We need a real-world use-case.
* I don't like the name `case?`
* IMO, just use `case` statement
Matz.
-
04:51 AM Feature #15722: `Kernel#case?`
- What about using `#when?` instead of `#case?`?
```ruby
bar # => "bar"
flag1 = case bar; when "foo", "bar", "baz"; true; end # => true
flag2 = case bar; when Symbol, String; true; end # => true
# Proposal by sawa
flag1 = bar.cas... -
05:19 AM Bug #11304: [PATCH] Kernel.global_variables should observe $~.
- The current behavior should be as it is. If there can be a clearer description in the document, PR welcome.
Matz. -
05:16 AM Misc #16483 (Closed): How about stopping new *.tar.bz2 releases?
- From Ruby 2.8, I'll provide only .zip, .gz, and .xz (not provide .bz2).
For 2.7.x or prior we'll still provide also .bz2.
In general we provide
* .zip for Windows
* .gz for general Unix environments
* .xz (or most efficient compre... -
04:33 AM Revision 229ba121 (git): Merge racc from upstream repository.
- * Support Ruby 2.4's frozen string literals.
* Remove VCS revisions headers. -
02:08 AM Revision 9a422fc0 (git): Update docs for Time#at method [ci skip]
- Add docs about all possible options for the `in` argument.
-
01:50 AM Revision 18674aef (git): check imemo_type
- check imemo_type to debug
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/2744755 -
12:49 AM Revision 1d81baf3 (git): st.c: remove variables that are no longer used
- to suppress a warning "variable 'check' set but not used"