Activity
From 08/03/2019 to 08/09/2019
08/09/2019
-
11:59 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- Another +1 for no merge commits.
> Therefore, we have not been able to make a pull request "Merged" when a pull request's branch needs to be rebased before pushing it to the master branch.
I'm probably missing something, but Github... -
05:39 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- I updated the description according to my further investigation of the history. Thank you @mame for helping it.
I also prepared a patch to keep a consistent linear history (step 2 of the "Solution") in https://github.com/ruby/ruby-commi... -
- Apologies, according to the chat history, it turned out that @mame was not the only person opposed to merge commits. I'll update the description to reflect the facts later.
> keep a true linear history, as I find it makes reviewing th... -
04:18 PM Misc #16093: Prohibit a "foxtrot merge" instead of a merge commit
- I prefer rebasing commits on master instead of merging to keep a true linear history, as I find it makes reviewing the history simpler. In my opinion, the "Problem" as specified in the post is not a significant issue, and the disadvanta...
-
- ## Background
* When we migrated the canonical Ruby repository from Subversion to Git [Misc #14632], in that ticket nobody had objected to allowing a merge commit in the repository.
* At first, we decided to prohibit merge commits beca... -
11:33 PM Revision 9d298b9d (git): Allow Array#join to allocate smaller strings
- rb_str_buf_new always allocates at least 127 bytes of capacity, even
when less is requested.
> ObjectSpace.dump(%w[a b c].join)
{"address":"0x7f935f06ebf0", "type":"STRING", "class":"0x7f935d8b7bb0", "bytesize":3, "capacity":127... -
- From the general problem statement, and looking at the regexp's nested use of `*` and `+` along with `\g`, this regexp probably exhibits exponential backtracking. See https://docs.ruby-lang.org/en/2.6.0/Regexp.html#class-Regexp-label-Per...
-
11:23 PM Revision b1678338 (git): Fix typo: duplicated the [skip-ci]
-
- This is not a bug. Ruby treats `\&` in a replacement string specially, representing the entire matched string (note that `"\\&"` is the same as `'\&'`):
```ruby
"test ?".sub("?", "1\\&2")
=> "test 1?2"
```
So `"\\&"` as a replac... -
10:54 PM Misc #16091: gsub
- @thiaguerd I don't understand - the `String#replace` method only takes one argument - you're calling it with two so that's not going to work for a start. Secondly, the method doesn't replace occurrences of one string with another, which ...
-
10:47 PM Misc #16091: gsub
- shyouhei (Shyouhei Urabe) wrote:
> Really sorry that I have to say I don't understand this report at all. Please tell us about your problem a bit more in detail.
the replacement doesn't happen
try in python and see the diff
```
... -
02:30 PM Misc #16091: gsub
- Really sorry that I have to say I don't understand this report at all. Please tell us about your problem a bit more in detail.
-
10:36 AM Misc #16091 (Feedback): gsub
-
- ```ruby
a = "test ?"
b = "?"
c = "\\&"
a.gsub(b,c)
``` -
- This issue appears to be specific to Windows, and the master branch still has the same behavior as Ruby 2.0. I do not think this is a bug. Windows appears to allow multiple TCP OOB bytes, where most other implements support only a singl...
-
09:24 PM Bug #16087: Signal.trap(:INT) doesn't work on msys2 mingw64 ?
- I checked:
```
ruby 2.7.0dev (2019-08-09T15:04:06Z master 8d7e0159c0) [x64-mingw32] ruby-loco
ruby 2.6.3p62 (2019-04-16 revision 67580) [x64-mingw32] RubyInstaller2 / OneClick
```
JFYI, tried both in a PowerSh... -
06:51 PM Bug #16092 (Feedback): [doc] precedence of modifier-rescue
- Ok, I'm starting to see. The difference between statements and expressions is why we get this
```ruby
puts( 1 if 2 ) #=> SyntaxError
puts((1 if 2)) #=> 1
puts(if 2;1;end) #=> 1 ...interesting
puts( 1 rescue 2 ) #=> SyntaxErr... -
02:48 PM Bug #16092 (Rejected): [doc] precedence of modifier-rescue
- The current doc about precedence is correct. The behavior you showed is not caused by precedence, but by the grammer itself.
The point is, that `<stmt> rescue <stmt>` is a statement, not an expression. The right side of modifier-if ... -
- The docs state that modifier-rescue has higher precedence than assignments which have higher precedence than modifier-if. This is true for
`v = expr rescue $! if condition` but not for
`v = expr if condition rescue $!` which is treated... -
-
04:38 PM Bug #14689: bootsnap gets object index out of range: 266287972352 (IndexError) since r63113
- Would it be possible to backport this patch for ruby2.5? Debian has unfortunately not yet updated to 2.6 and the bug affects Debian's sparc64 port.
The patch as-is doesn't apply to the 2.5 tree. -
04:28 PM Feature #8239 (Closed): Inline rescue bug
- Applied in changeset commit:git|53b3be5d58a9bf1efce229b3dce723f96e820c79.
----------
Fix parsing of mutiple assignment with rescue modifier
Single assignment with rescue modifier applies rescue to the RHS:
a = raise rescue 1 # a = (... -
- Applied in changeset commit:git|53b3be5d58a9bf1efce229b3dce723f96e820c79.
----------
Fix parsing of mutiple assignment with rescue modifier
Single assignment with rescue modifier applies rescue to the RHS:
a = raise rescue 1 # a = (... -
- Thank you, it seems fine. I've missed this at all.
-
- This bug is still present in the master branch. Attached is a patch that fixes it, so that multiple assignment with rescue modifier is consistent with single assignment with rescue modifier. After the patch:
```
a = raise rescue 1 #... -
- Single assignment with rescue modifier applies rescue to the RHS:
a = raise rescue 1 # a = (raise rescue 1)
Previously, multiple assignment with rescue modifier applied rescue
to the entire expression:
a, b = raise rescue [1, 2] #... -
-
- 03:04 PM Revision 8d7e0159 (git): * 2019-08-10
-
- This reverts commit c9eb8f82e9febeb634a23bec6aeea915eb25fe26.
The change caused "implicit declaration" warning and actual segfault.
```
/tmp/ruby/v2/src/trunk-gc-asserts/enc/gb2312.c: In function ‘Init_gb2312’:
/tmp/ruby/v2/src/trunk-g... -
02:28 PM Bug #15952: Issue with Array#unshift, sometimes doesn't respect frozenness of array
- ruby_2_6 r67740 merged revision(s) ec8e5f5aa64e2a54cf1e303f2b012c98e8d521ba,5a187e26adc8aa32367f294c1496935c7356d386.
-
- array.c: always check frozenness in Array#unshift. Fixes [Bug #15952]
Closes: https://github.com/ruby/ruby/pull/2251
array.c add back shared array optimization to
ary_ensure_room_for_unshift
Bug fix in... -
-
-
- ef64ab917eec02491f6bf7233a4031a8c35385e3 didn't fix the issue, so the
size seems not enough yet.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/osx1014/ruby-master/log/20190809T114503Z.fail.html.gz -
- ruby_2_6 r67739 merged revision(s) 8f51da5d41f0642d5a971e4223d1ba14643c6398.
-
- Get rid of undefined behavior
* string.c (rb_str_sub_bang): str and repl can be same.
[Bug #15946]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67739 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r67738 merged revision(s) 28678997e40869f5591eae60edd9757334426ffb,8797f48373dcfa3ff8e748667732dea8aea4347e.
-
- Preserve the string content at self-copying
* string.c (rb_str_init): preserve the embedded content when
self-copying with a capacity. [Bug #15937]
New buffer for shared string
* string.c (rb_str_ini... -
10:04 AM Feature #16090: RUBY_ON_BUG envval to debug
- In general I think this is fine (if we don't forget to document it :) ).
It would give people a way to influence the behaviour there, if they need to,
e. g. the example you gave via using "gdb -p". So this is a convenience
feature ... -
08:43 AM Feature #16090 (Closed): RUBY_ON_BUG envval to debug
- How about to introduce `RUBY_ON_BUG` environment variable which specify the command launched at `rb_bug()`?
`RUBY_ON_BUG='gdb -p' ruby ...`
In this case, `gdb -p [PID]` is invoked when `rb_bug()` is called.
after that, we can spy ... -
-
- On macOS Mojave, the child process invoked in TestFiber#test_stack_size
gets stuck because the stack overflow detection is too late.
(ko1 figured out the mechanism of the failure.)
This change attempts to detect stack overflow earlier. -
- Thank you, I've missed it.
-
07:36 AM Bug #16086 (Closed): OpenStruct method access with a block does not raise
-
- > That is OpenStruct, an undefined key does not raise an exception.
> ...
Right, this behavior seems to be universal:
```ruby
> { foo: :bar }[:foo] { 'hello' }
=> :bar
> ...
=> 1
```
> I haven't seen such behavior.
> ...
Hm... -
07:29 AM Revision a4a2dd79 (git): Revert a6e32855d079e8f3806d8be8a5f5cf7b3a967133 partially
- Fix TypeError when typing `''.[TAB]`
-
- `make test-all TESTS=name` can specify running test files by name.
name can be dirname ('dir/') or a file ('.../test_foo.rb'). This
patch complement `test_` prefix for a test. So we only need to
specify `TESTS=ruby/hash` which means `TES... -
-
- thread.c requires gc.h on mswin build. Sorry.
-
- debug utility macro rp() (rp_m()) and bp() are introduced.
* rp(obj) shows obj information w/o any side-effect to STDERR.
* rp_m(m, obj) is similar to rp(obj), but show m before.
* bp() is alias of ruby_debug_breakpoint(), which is regis... -
04:15 AM Revision cb390e87 (git): Add more runners
- Closes: https://github.com/ruby/ruby/pull/2327
-
- This commit sets up the CI integration on GitHub Actions. We should
give it a try because queue times are lower and I think we get more
CPUs.
Closes: https://github.com/ruby/ruby/pull/2327
Co-Authored-By: John Hawthorn <john@hawthorn.... -
-
- On test with MJIT, sometimes it fails like:
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/2189967 -
- just fix CI failure
https://travis-ci.org/ruby/ruby/jobs/569625233 -
- Good news is, yesterday I discussed this issue with @mame who was the person opposed to having a merge commit, and we got an idea to solve his problems.
Once it's implemented (work in progress; @mame implemented one, and I'm going to ... -
- > solve "duplicate :raise event" [Bug #15877]
sorry my mistake :p -
- Applied in changeset commit:git|71efad1ed391ee0c5398a76306fdbaaadd4dc52e.
----------
introduce RCLASS_CLONED flag for inline cache.
Methods on duplicated class/module refer same constant inline
cache (IC). Constant access lookup should... - 02:11 AM Revision 4e9382a8 (git): * expand tabs.
-
- Methods on duplicated class/module refer same constant inline
cache (IC). Constant access lookup should be done for cloned
class/modules but inline cache doesn't check it.
To check it, this patch introduce new RCLASS_CLONED flag which
ar...
08/08/2019
-
- I submitted a pull request upstream to remove the `OpenSSL::PKCS7::SignerInfo#name` method: https://github.com/ruby/openssl/pull/266
-
11:18 PM Bug #14972: Net::HTTP inconsistently raises EOFError when peer closes the connection
- When a range is requested, the content-length of the response is the number of bytes in the partial response, so I would still expect an exception to be raised if the partial response is truncated:
```
$ curl -s -v -r 0-100 -O http... -
-
- This bug is still present in the master branch. I've updated drbrain's patch to apply to the master branch, including adding some additional exceptions to rescue.
-
09:38 PM Feature #15939: Dump symbols reference to their fstr in ObjectSpace.dump()
- > Do you need a list of String objects referenced from static symbols?
It would be useful yes. Because otherwise you might see strings with only one reference and thing that you could reclaim there by removing that reference, but in r... -
- Do you need a list of String objects referenced from static symbols?
-
- This appears to have been fixed between Ruby 2.4 and 2.5:
```
D:\テスト>c:\Ruby24-x64\bin\ruby a.rb
a.rb: No such file or directory @ realpath_rec - D:/??? (Errno::ENOENT)
D:\テスト>c:\Ruby25-x64\bin\ruby a.rb
No Problem.
``` -
- This bug is still present in the master branch. I've updated nobu's patch to apply to the master branch, which required a significant rewrite. The updated patch is attached.
-
- I had a go at this, and a naive implementation is quite simple. The only issue really is where to store the list of unicode properties.
```ruby
class String
def unicode_properties(*categs)
@@props ||= Hash.new.tap do |hash|
... -
- This just enables GitHub actions on our repository so we can try it out.
-
- This is still a bug in the master branch. I think the main problem in this example is that when calling `Module#include`, you can get a module inserted before the receiver in the lookup chain instead of behind the receiver.
mame correc... -
- I've updated the wiki to reflect this. If you think additional changes are needed, please reply.
-
04:20 PM Misc #16089: Explain that github prs do not get merged
- I actually realize that this is wrong & that technically it's "accepted pull requests are _often_ closed, not merged, because..."
-
- The fact that fixes which are accepted still get closed, rather than being merged, is confusing. The (easiest) solution is to modify
https://bugs.ruby-lang.org/projects/ruby/wiki/HowToContribute
Change submit section to something l... -
04:32 PM Bug #16088 (Closed): [patch] Call #to_binary on iseq containing pattern match crashes
- Applied in changeset commit:git|050b932152fb3004c78af223186afe1aa397f06f.
----------
Iseq#to_binary: Add support for NoMatchingPatternError and TypeError
Binary dumping the iseq for `case foo in []; end` used to crash as
there was no h... -
- Crasher: `miniruby -e 'RubyVM::InstructionSequence.compile("case foo in []; end").to_binary'`
It crashes since there is no handling for dumping `TypeError` and `NoMatchingPatternError` in the binary dumper.
Patch: https://github.com/ru... - 04:32 PM Revision 57288f5d (git): * expand tabs.
-
- Binary dumping the iseq for `case foo in []; end` used to crash as
there was no handling for these exception classes.
Pattern matching generates these classes as operands to `putobject`.
[Bug #16088]
Closes: https://github.com/ruby/rub... -
- 03:16 PM Revision c0f49438 (git): * 2019-08-09
-
-
02:35 PM Bug #16087 (Third Party's Issue): Signal.trap(:INT) doesn't work on msys2 mingw64 ?
- My environment is Windows 10 msys2 mingw64
```
yama@JPC00183513 ~/b/p/sample> uname -a
MINGW64_NT-10.0-17763 JPC00183513 3.0.7-338.x86_64 2019-05-27 06:58 UTC x86_64 Msys
yama@JPC00183513 ~/b/p/sample> ruby --version
ruby 2.6.3p62... -
-
- This reverts commit b1594ca3d6b72edb60927418482652ce93209499.
Revert "Debug appveyor mingw failure"
This reverts commit fa29f65416f1fb3d734a279855728bb0616dbb34.
Though I preserved V=1 for future debugging. -
- I copied the wrong commit log, sorry.
-
- Applied in changeset commit:git|76bd0714cf1140ffd64bf564446c76c54f2c4870.
----------
solve "duplicate :raise event" in require too [Bug #15877] -
- Re-open. This ticket has been closed accidentally by b004d3e8.
I'll correct commit link. -
- Applied in changeset commit:git|b004d3e8300ba803d4a499148fa4fc6a690149e6.
----------
solve "duplicate :raise event" [Bug #15877]
Without this patch, "raise" event invoked twice when raise an
exception in "load"ed script.
This patch by ... -
-
- kke (Kimmo Lehto) wrote:
> This can cause confusion.
> ...
That is `OpenStruct`, an undefined key does not raise an exception.
And an unused block is silently ignored in common.
> A defined key with a block seems to yield the value... -
- This can cause confusion.
```ruby
> OpenStruct.new(hello: 'world').each { |k, v| puts k.upcase } # there's no "each" method
=> nil
> OpenStruct.new(hello: 'world').eahc_pair { |k, v| puts k.upcase } # each_pair typo
=> nil... -
- to fix a build error like:
https://ci.appveyor.com/project/ruby/ruby/builds/26547644/job/4j7n41e7in97a9kx
Basically copy-pasted what's currently done in MSP-Greg/ruby-loco.
Co-Authored-By: MSP-Greg <greg.mpls@gmail.com> -
-
-
-
- The patch seems committed at b004d3e8300ba803d4a499148fa4fc6a690149e6. (ticket number reference miss).
- 08:59 AM Revision 29bdfeb0 (git): * expand tabs.
-
- Without this patch, "raise" event invoked twice when raise an
exception in "load"ed script.
This patch by danielwaterworth (Daniel Waterworth).
[Bug #15877] -
- The document is experimentally produced in:
https://rubyci.s3.amazonaws.com/doxygen/modules.html -
08:19 AM Revision b39efb16 (git): Aliases capture_output to capture_io for test-unit compatiblity.
-
- In this case, your solution (allow fire different type of trace) because the problematic case `:line` event and `:class` event are different.
However, maybe it is accidentally. Someone can use `:line` event as usual.
`reopen` will al... -
- Thank you, committed!
1ad0f4e593563d460e3015fc4a2542ce1bb80d6e -
05:22 AM Revision 1ad0f4e5 (git): Add *_clear methods to VM_COLLECT_USAGE_DETAILS API
- Add RubyVM::USAGE_ANALYSIS_INSN_CLEAR, RubyVM::USAGE_ANALYSIS_OPERAND_CLEAR,
and RubyVM::USAGE_ANALYSIS_REGISTER_CLEAR to clear VM instruction hash constants.
Closes: https://github.com/ruby/ruby/pull/2258 -
- Add RubyVM::USAGE_ANALYSIS_INSN_START, RubyVM::USAGE_ANALYSIS_OPERAND_START,
and RubyVM::USAGE_ANALYSIS_REGISTER_START to begin collecting VM instructions.
Add RubyVM::USAGE_ANALYSIS_INSN_RUNNING, RubyVM::USAGE_ANALYSIS_OPERAND_RUNNING,... -
-
12:14 AM Bug #16085 (Third Party's Issue): when running rspec I get this issue
- Attached the crash log, Not much initial investigation done yet..
08/07/2019
-
- I think this was changed in #15394. Since the symbol and the string both refer to the same header, I think it's reasonable to treat them the same.
-
02:25 PM Bug #16052 (Closed): net/http get_fields doesn't return correct value for set-cookie
- This is the code that reproduces the problem:
``` ruby
require 'net/http'
require 'net/https'
path = "/authorize?client_id=kbyuFDidLLm280LIwVFiazOqjO3ty8KH&response_type=code"
http = Net::HTTP.new('samples.auth0.com', 44... -
- This is still a bug in the master branch. Attached is a patch that fixes the issue. It's a decent size patch as there are many parts of drb that need to be modified to handle BasicObject instances. This patch also fixes a bug in the r...
-
- I am trying to study debug counters inside a Rails application.
Accessing debug counters by killing the process is hard because child
processes don't get the same TRAP as the parent, and Rails seems to
intercept calls to `exit`. Adding ... -
-
- This was fixed between Ruby 2.4 and 2.5:
```
$ ruby24 -e '
> def foo(x); 99; end
> ...
a: 99 b: 9
$ ruby25 -e '
> def foo(x); 99; end
> ...
a: 99 b: 99
``` -
- I don't think this is a bug, I think this is expected behavior. When parsing `-p -1`, where `-p` accepts an optional argument, OptionParser correctly treats the `-1` as a new option, and raises an error as the parser does not accept that...
-
- ruby_2_6 r67737 merged revision(s) ae2a904ce9bffedee7d110dc60fd51c0a2879a5b,165ddfda20f6db8a3149d14c4f431fc242ddab70,fa7a768fdfe5223a29db4fa71b3e6101fb02ad51.
-
- Ah, the following 3 commits may be also required for rubygems tests.
https://github.com/ruby/ruby/commit/ae2a904ce9bffedee7d110dc60fd51c0a2879a5b
https://github.com/ruby/ruby/commit/165ddfda20f6db8a3149d14c4f431fc242ddab70
https://g... -
- ruby_2_6 r67735 merged revision(s) 1e54903684aa3c9ea3fe54520157846a1b1f07be.
-
- This is a ticket for backport management.
Re-generate stronger certifications and private keys to pass tests on OpenSSL 1.1.1.
43730256e800dd8e0c5cc482e9861868590ae037 for open-uri tests.
1e54903684aa3c9ea3fe54520157846a1b1f07be f... -
- Update the certificate files to make the test pass on Debian 10
The old certificate files (for example, test/rubygems/ca_cert.pem) were
signed by SHA1. This message digest is considered too weak and rejected
by ... -
- This issue still exists in the master branch, and while it isn't a bug, I think we should make the change. This change should cause no issues for BigDecimal and Complex, since those instances are already frozen. It could potentially ca...
-
-
-
-
- `require_relative` works in irb starting in Ruby 2.0:
```
$ irb19
irb(main):001:0> require_relative "test.rb"
LoadError: cannot infer basepath
from (irb):1:in `require_relative'
from (irb):1
from /usr/loc... - 03:11 PM Revision 2f379511 (git): * 2019-08-08
-
- It has been unstable for recent builds:
https://ci.appveyor.com/project/ruby/ruby/builds/26531442/job/0ycp7woekqqx97x9
https://ci.appveyor.com/project/ruby/ruby/builds/26531687/job/xui3rctcvi7r49iv
https://ci.appveyor.com/project/ruby/ru... -
- I don't think this is a bug. Just because `:@iv` is valid syntax does not imply that `:@` should also be valid syntax. You should use a quoted symbol (note that `Symbol#inspect` quotes the symbol):
```ruby
:'@'
# => :"@"
'@'.to_s... -
10:56 AM Bug #16050 (Rejected): :@ is not parsed correctly
- Symbol literal allows `@` as the first character:
```ruby
:@foo # => :@foo
```
Nevertheless, it does not allow `@` by itself:
```ruby
:@ # >> SyntaxError: `@' without identifiers is not allowed as an instance variable name
`... -
-
-
-
-
-
- Closes: https://github.com/ruby/ruby/pull/2323
-
- transient_heap.h is no longer needed.
-
- as I already started to use --runner=block introduced in v0.14.20 like:
https://github.com/ruby/ruby/pull/2321#issuecomment-518638663 -
- This was a missed carry-over on the last month.
* [Bug #15908] Detecting BOM with non-UTF encoding -
- Schedule was changed!!
Before: 2019/08/20 (Thu) 13:00-17:00 (JST)
After: 2019/08/29 (Thu) 13:00-17:00 (JST)
Thanks,
Koichi -
- ruby_2_6 r67736 merged revision(s) 5931857281ce45c1c277aa86d1588119ab00a955,76e2370f132f83c16c9de39a0a9356579f364527.
-
- I accidentally backported 53e9908d8a with this issue. I'll backport additional fixes.
-
- Fix dangling path name from fstring
* parse.y (yycompile): make sure in advance that the `__FILE__`
object shares a fstring, to get rid of dangling path name.
Fixed up 53e9908d8afc7f03109b0aafd1698ab35f512b05... -
- Not using official travis_retry.bash, because it's not supporting to
modify backoff seconds.
https://github.com/travis-ci/travis-build/blob/0ad8f1886b2c31994d847e126dc5842b7b3513e3/lib/travis/build/bash/travis_retry.bash
Not using offic... -
- test/openssl: Support OpenSSL 1.1.1
OpenSSL 1.1.1 rejects some shorter keys, which caused some failures of
`make test-all TESTS=openssl`.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian/ruby-master/log/20... -
- open-uri: Regenerate server certificates for tests
OpenSSL 1.1.1 requires 2048 bits or more. This change will fix:
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian/ruby-master/log/20190527T003004Z.fail.html.gz#tes... -
- ruby_2_6 r67733 merged revision(s) 9dec4e8fc3a6018261834b5ac9b9877f787b97ca.
-
- String#b: Don't depend on dependent string
Registering a string that depend on a dependent string as fstring
can lead to use-after-free. See c06ddfe and 3f95620 for details.
The following script triggers use-aft... -
- ruby_2_6 r67732 merged revision(s) 53e9908d8afc7f03109b0aafd1698ab35f512b05.
-
- Fix memory leak
* string.c (str_replace_shared_without_enc): free previous buffer
before replaced.
* parse.y (gettable): make sure in advance that the `__FILE__`
object shares a fstring, to get rid o... -
- ruby_2_6 r67731 merged revision(s) 3f9562015e651735bfc2fdd14e8f6963b673e22a,c06ddfee878524168e4af07443217ed2f8d0954b,3b3b4a44e57dfe03ce3913009d69a33d6f6100be.
-
- Get rid of indirect sharing
* string.c (str_duplicate): share the root shared string if the
original string is already sharing, so that all shared strings
refer the root shared string directly. indirect shar... -
- Backported into ruby_2_6 at r67730.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:13 AM Feature #16049: optimization for frozen dynamic string literals "#{exp}".dup and +"#{exp}"
- Part of the explanation:
String#freeze never allocates a new String, it just freezes the receiver in place.
String#-@ deduplicates/interns the String, to do so it needs to return a new String instance (unless it's already an interned S... -
-
- The document states that "the limit should be a date object".
-
- Yes we could do that, and enable it always as that'd be cheap.
-
- Ah, good point.
But maybe `ObjectSpace.define_finalizer(obj, aProc)` should raise an error if `aProc.binding.receiver.equal?(obj)`, because that's a reference that can never be cleared. -
- Co-Authored-By: Nobuyoshi Nakada <nobu@ruby-lang.org>
-
08/06/2019
-
- > Question: shouldn't this be an error rather than a warning?
No, because it's possible to have a reference from the finaliser to the object when the finaliser is created, but then to later clear that reference and the finaliser to wo... -
- Question: shouldn't this be an error rather than a warning? Defining a finalizer that immortalizes its object and can never run seems like an outright bug, not something that you should merely warn about in verbose mode only.
-
- Ruby started allowing `clone` on immediate values (true, false, nil, symbol, integer, float) in Ruby 2.4:
```
$ ruby23 -e 'p true.clone'
-e:1:in `clone': can't clone TrueClass (TypeError)
from -e:1:in `<main>'
$ ruby24 -e ... -
- I agree this is a bug that violates RFC 2616 and RFC 7230 and have submitted a pull request to fix this issue: https://github.com/ruby/webrick/pull/23
-
- When the decision was made that `frozen_string_literal: true` should also apply to dynamic string literals, it was mitigated with the following explanation:
> "#{exp}".dup can be optimized so it won’t allocate extra objects like "..."... -
- I have been using `Hash#clear` to clear the constants, but that's because a `clear` method doesn't exist. I will add the following to the PR:
```
rb_define_singleton_method(rb_cRubyVM, "USAGE_ANALYSIS_INSN_CLEAR", usage_analysis_insn... -
- instead of <<. All the other callsites use `push`.
-
- The target method name is a typo.
-
- > Ruby already optimizes this case
TIL indeed. I should have used a random method call instead.
-
- byroot (Jean Boussier) wrote:
> The speedup mostly come from reduced GC pressure. Consider the following snippet:
> ...
Unfortunately, this is not a good example, because even without `frozen_string_literal: true`, Ruby already optimiz... -
- > I am interested in the claimed/perceived speedup. I had seen some benchmarks that claimed no difference in speed. And that made sense to me since deduplication is a memory optimization, not a significant CPU optimization.
The speedu... -
@shevegen, I didn't suggest what I would like to change because I was mostly looking for insight on people's real-world usage of frozen_string_literal and how it might compare to mine. That's why I put this under the Misc tracker and n...-
-
- Applied in changeset commit:git|e89d9f3debab353d1c5a5162752af8f201d98d49.
----------
Deprecate Float::ROUNDS, which should not be a constant
[Bug #16044] -
01:22 AM Bug #16044: Float::ROUNDS (FLT_ROUNDS) should not be a constant.
- That would be nice.
Matz.
-
- In 614c90fe21cf1d9cf6fb18684187d8c7e2f61de6, I assumed
apt-add-repository has been stable recently, but I saw PR randomly
failed for it today.
This commit only deals with "ubuntu-toolchain-r-test" and does NOT deal
with `llvm-toolchain-... - 03:07 PM Revision 66a13413 (git): * 2019-08-07
-
- [Bug #16044]
-
- * time.c (time_to_r): get rid canonicalize and uncanonicalize
one-denominator rational, by rb_time_unmagnify_to_rational. -
- 11:59 AM Revision 3e6b9926 (git): * expand tabs.
-
- Inspired by 346aa557b31fe96760e505d30da26eb7a846bac9
Closes: https://github.com/ruby/ruby/pull/2321 -
11:28 AM Revision 43b52ac0 (git): Revert "Don't echo results of assignment expressions"
- This reverts commit 1ee88c51b3c319b74b69540e111e4a1c24833cad.
-
11:15 AM Revision 1ee88c51 (git): Don't echo results of assignment expressions
-
11:03 AM Revision 84236479 (git): Use host_os from RbConfig to detect host OS.
- RUBY_PLATFORM on JRuby is always "java", so it will not reflect
the host operating system. This regex appears to be the consensus
way to detect Windows based on a search of Ruby code on Github:
https://github.com/search?q=%2Fmswin%7Cmsy... -
-
-
- ありがとうございます、取り込んでみます。Backport のため status は Closed にします。
-
-
-
12:01 AM Revision 146cf2f4 (git): Removing duplicated assertions on test_array.rb - MINUS method
- Closes: https://github.com/ruby/ruby/pull/1790
-
12:01 AM Revision 4f1a00a7 (git): Improve same directory detection in FileUtils
- Closes: https://github.com/ruby/ruby/pull/1425
08/05/2019
-
-
-
- Applied in changeset commit:git|96cec6b27741cbdeb51ea3acdeba0e813d51035f.
----------
Document that RubyVM::InstructionSequence methods are implementation and version dependent
Fixes [Bug #6785] -
- Applied in changeset commit:git|2b6441196ef32d93c7898764610a913f54f8bc32.
----------
Remove documentation of %m in Syslog
Fixes [Bug #6726] -
- Fixes [Bug #6785]
-
- Fixes [Bug #6726]
-
10:18 PM Misc #16047: Reconsider impact of frozen_string_literal on dynamic strings
- I started using `frozen_string_literal` and I also wish `frozen_literal` (generally applies to Array `[]`, Hash `{}`, etc).
The model I use:
Mutable string: `String.new`
Constant string: `"CONSTANT"`
I've experienced bugs bec... -
- I was also surprised that dynamic strings are also frozen, since the gain there seems minimal.
`"a#{b}c"` is conceptually the same as `"a".dup << b.to_s << "c"` and so freezing that seems artificial and not needed since there was mutati... -
- I'll comment on this, but allow me to make a few partially related/unrelated comments first.
Benoit has in another discussion made a comment about having asked xyz folks about a feature/change, in regards introducing (and accessing) n... -
- The rationale for introducing `frozen_string_literal` was because rubyists were starting to litter their code with `"".freeze` for optimization, and it's ugly.
But by using frozen_string_literal we introduce the opposite problem: we m... -
- The last time we committed this, we were asking the VM to write to the
ep. But VM assertions check if the ENV data is the correct type, which
if it's a T_MOVED pointer it's not the correct type. So the vm
assertions would fail. This t... -
- Module#define_method and #alias_method are public now, so we should change anything?
-
- This may be irrelevant but I would like to point out that proc->lambda conversion was supported in ruby 1.8
```ruby
b = Proc.new{ return 42 }
b.call #=> LocalJumpError: unexpected return
lambda(&b).call #=> 42
```
I'm ... - 03:56 PM Revision c9192ef2 (git): * expand tabs.
-
-
- as it failed https://travis-ci.org/ruby/ruby/jobs/567942969, unlike my
fork CI.
This just rollbacks a minor change in
798474deaf10dbea70c02724b5acf4487bbed660. -
- They have been too unstable.
Revert "Extend sleep before sending USR1 in TestProcess"
This reverts commit aaf69a8ba866193863a7eafe5c6044844bd71bc3.
Revert "Extend sleep before sending USR1 in TestProcess"
This reverts commit 076f3fcf11... - 03:34 PM Revision 48d460d9 (git): * 2019-08-06
-
- because Travis team does not do it for us:
https://github.com/travis-ci/travis-build/pull/1712
The retried part has failed often even in one day:
https://travis-ci.org/ruby/ruby/jobs/567802384
https://travis-ci.org/ruby/ruby/jobs/567802... -
- I would like to add my vote to those in the single-argument camp. I think it's important to remember why this new feature exists in the first place:
mame (Yusuke Endoh) wrote:
> The reason why this feature was introduced, is that peo... -
-
-
- ruby_2_6 r67729 merged revision(s) 5e018214e7435030727a97ac49db038d96438e74.
-
- Fix SystemStackError when calling a method in an unused refinement
Fixes [Bug #15720]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67729 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_6 r67728 merged revision(s) c1d78a7f0ece2004822193a0c1f1fd3dc38c2fdf.
-
- do_mutex_lock: release mutex before checking for interrupts (fixes
issue 15360)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67728 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Expand the timeout of
`test_pstore_files_are_accessed_as_binary_files`
Sometimes causes timeout error on mswin CI
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67727 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby.
* There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION.
https://github.com/rubygems/rubygems/commit/431d0aefdd -
- * If settings constants fail, show that exception instead of getting
another one due to variables being unset and hiding the real cause.
https://github.com/rubygems/rubygems/commit/f38cd67874 -
09:45 AM Revision f9dac1bd (git): [rubygems/rubygems] Cleanup after testing `rake package`
- Sometimes it happens to me that my local tests start failing because I
pull some file removals or renames into my local copy, and those are
still present on my last copy of pkg/. In those cases, the test about
`rake package` will fail wi... -
- https://github.com/rubygems/rubygems/commit/83eced0b39
- 09:44 AM Revision 87bc29fe (git): [rubygems/rubygems] Revert cadb66037d9b58c80fc795f39384d533229a1f73
- https://github.com/rubygems/rubygems/commit/5c3158d975
-
- https://github.com/rubygems/rubygems/commit/b0588a87b1
- 09:44 AM Revision 5a8d8488 (git): [rubygems/rubygems] Remove FIXME comment
- https://github.com/rubygems/rubygems/commit/5a1d3d618d
-
07:10 AM Feature #16045: Calling functions with keyword arguments
- ``` ruby
def fn(a:1,b:2,c:3)
p a,b,c
end
fn(c:4) # 1 2 4
```
did not know. can close -
- https://www.google.com/search?q=ruby+keyword+arguments
-
- Python:
``` python
def fn(a=1,b=2,c=3):
print(a,b,c)
fn() # 1 2 3
fn(c=4) # 1 2 4
```
Ruby:
``` ruby
def fn(a=1, b=2, c=3)
p a,b,c
end
fn(c=4) # 4 2 3
```
A very convenient and necessary thing that you mus... -
- instead of casting a pointer to int.
Follow up of 39622232c7542d062f79277a11f6b8b6b6cfd994. - 03:52 AM Revision 2403f9ac (git): Expand the timeout of `test_pstore_files_are_accessed_as_binary_files`
- Sometimes causes timeout error on mswin CI
-
-
-
- The regexp should be expected to match the error message.
-
- Agree to remove.
Deprecate it for now? -
-
- So EnvUtil does not depends on test/unit.
-
- leaf is true by default. Other insns are not specifying it explicitly.
Also the comment describing why it was not leaf is outdated. -
12:04 AM Revision 6bb3618f (git): n+1 to include n in range
- Python's range stop right before n, which means factL never returns the correct result.
Closes: https://github.com/ruby/ruby/pull/1982 - 12:00 AM Revision 253da5b2 (git): * 2019-08-05
08/04/2019
-
- It caused a significant benchmark fall. Some assertions seem to
use expressions with side-effects which cannot be inlined.
This reverts commit b452c03a14f943ae25338547bd680fce67399d85. -
-
- According to the reference, `FLT_ROUNDS` is not a constant in C.
> `FLT_ROUNDS`
> ...
So it should not be a constant in Ruby too. Or it should be removed altogether. -
- just like 076f3fcf11a061394d3d5f8c671512df1e983023.
This test also hanged on Travis osx
https://travis-ci.org/ruby/ruby/jobs/567547060 -
- ruby_2_6 r67726 merged revision(s) 66977.
-
- Revert r63383, r63248 "compile.c: copy a short insn with leave"
When copying `leave` insn, TRACE also should be copied if it is
present, but this optimization is trivial and not worth the
complexity. [ruby-core:... -
- This reverts commit 7a75baa6e294473f02da512c99f7ef1f76b2d83c.
Revert "Defer skip to avoid errors on ensure"
This reverts commit adfc8d6dbadbccef27d6ec78022650840c7604cc.
because 76e2370f132f83c16c9de39a0a9356579f364527 is hoped to fix... -
- Thanks for having a look and for linking to the original discussion!
-
- > read in the docs and discussion that this method only searches the feature in the LOAD_PATH,
> ...
I had a look at the tracker:
https://bugs.ruby-lang.org/issues/15230
And I agree with you in the sense that mame did not mandate ... -
- When I first tried this method, I was expecting it to return `nil` when the given feature is not found. This is because I read in the docs and discussion that this method only searches the feature in the LOAD_PATH, but does not attempt t...
- 01:27 PM Revision 7817a6fa (git): * expand tabs.
-
- * load.c (rb_require_internal): make sure in advance that the path
to be loaded shares a fstring, to get rid of dangling path name.
Fixed up 5931857281ce45c1c277aa86d1588119ab00a955. [Bug #16041] -
- # Benchmark zero?
```
require 'benchmark/ips'
Numeric.class_eval do
def ruby_zero?
self == 0
end
end
Benchmark.ips do |x|
x.report('0.zero?') { 0.ruby_zero? }
x.report('1.zero?') { 1.ruby_zero? }
x.compare!
end
```
## V... -
- 02:56 AM Revision 2d8c037e (git): [ruby/rexml] gemspec: update
- https://github.com/ruby/rexml/commit/404bd99a7c
- 02:55 AM Revision 310a2a98 (git): [ruby/rexml] xpath: add missing value conversions for equality and relational expressions
- GitHub: fix #18
Reported by Mirko Budszuhn. Thanks!!!
https://github.com/ruby/rexml/commit/0dca2a2ba0 - 02:55 AM Revision 39f275ed (git): [ruby/rexml] xpath number: fix a bug that false is converted to NaN
- GitHub: fix #18
It must be 0.
Reported by Mirko Budszuhn. Thanks!!!
https://github.com/ruby/rexml/commit/b48f3afa3b - 02:55 AM Revision 643344dc (git): [ruby/rexml] xpath local_name: fix a bug that nil is returned for nonexistent case
- It must be an empty string.
https://github.com/ruby/rexml/commit/81bc7cd4f5 - 02:55 AM Revision 5f78b138 (git): [ruby/rexml] xpath boolean: implement
- https://github.com/ruby/rexml/commit/feb8ddb1ec
- 02:55 AM Revision 6ef82943 (git): [ruby/rexml] xpath: fix a bug for equality or relational expressions
- GitHub: fix #17
There is a bug when they are used against node set. They should return
boolean value but they returned node set.
Reported by Mirko Budszuhn. Thanks!!!
https://github.com/ruby/rexml/commit/a02bf38440 - 02:55 AM Revision c46ba8e9 (git): [ruby/rexml] Use PP
- https://github.com/ruby/rexml/commit/185062a4a4
- 02:55 AM Revision 54525fbf (git): [ruby/rexml] xpath: add support for changing to debug mode by environment variable
- https://github.com/ruby/rexml/commit/59378a16ea
- 02:55 AM Revision de55e0a0 (git): [ruby/rexml] Bump version
- https://github.com/ruby/rexml/commit/54452c103a
-
02:55 AM Revision f85caf40 (git): [ruby/rexml] Message less confusing error to human (#16)
- * Message less confusing error to human
* Problem: Following error message is not helpful, because you have to reason
that '' actually means it's in the top-level, and the 'div' (not '</div>') is
an end tag
require "rexml/p... - 02:54 AM Revision 33e4a59b (git): [ruby/rexml] test: compare with real element
- https://github.com/ruby/rexml/commit/9f2908de2e
-
02:54 AM Revision ee8985ef (git): [ruby/rexml] Fix crash with nil XPath variables (#13)
- Patch by Alyssa Ross. Thanks!!!
https://github.com/ruby/rexml/commit/2a53c54f58 -
02:54 AM Revision 982208c6 (git): [ruby/rexml] use #inspect to print meta-characters in error messages
- https://github.com/ruby/rexml/commit/a124a19b9a
- 02:54 AM Revision 81354bbd (git): [ruby/rexml] Bump version
- https://github.com/ruby/rexml/commit/c0e3f14564
- 02:54 AM Revision 0f18bc7f (git): [ruby/rexml] Fix attribute's default namespace behavior
- NOTE: It's a backward incompatible change. If we have any serious
problems with this change, we may revert this change.
The XML namespace specification says the default namespace doesn't
apply to attribute names but it does in REXML wit... - 02:54 AM Revision 9b36f0a7 (git): [ruby/rexml] Format
- https://github.com/ruby/rexml/commit/2384586811
- 02:54 AM Revision 84c37424 (git): [ruby/rexml] Revert "xpath: remove needless nil check"
- This reverts commit 61b73c1bf8dc64d97fba7f0a8c503c24b11313f5.
"*:local_name" becomes prefix=nil.
https://github.com/ruby/rexml/commit/9e7dd4cd4e - 02:54 AM Revision 096e7663 (git): [ruby/rexml] xpath: remove needless nil check
- It must not be nil.
https://github.com/ruby/rexml/commit/61b73c1bf8 - 02:54 AM Revision 27c11892 (git): [ruby/rexml] Add a TODO for Attribute#namespace
- https://github.com/ruby/rexml/commit/70310a06e5
- 02:54 AM Revision 3583fa16 (git): [ruby/rexml] xpath: fix a bug that no namespace attribute isn't matched with prefix
- [ruby-list:50733]
Reported by Yasuhiro KIMURA. Thanks!!!
https://github.com/ruby/rexml/commit/8f3c5c176a - 02:53 AM Revision f76cfb55 (git): [ruby/rexml] Bump version
- https://github.com/ruby/rexml/commit/0f79e71210
-
-
- somehow the test fails only on Wercker in CIs triggered by GitHub.
Actually rubyci and ci.rvm.jp also have issues too, though. -
- I am not a fan of this feature, but by analogy from `Range`, `cover?` may be a better name.
-
- This reverts commit 326c00b6f89e1c86e6fe29ab60da593eb6883a88.
We also confirmed that test_gced_eval_location fails without the changes:
https://travis-ci.org/ruby/ruby/builds/567417818
https://rubyci.org/logs/rubyci.s3.amazonaws.com/arc... - 12:46 AM Revision 2d189a67 (git): yaml few build warning fixes
- Closes: https://github.com/ruby/ruby/pull/2283
- 12:25 AM Revision b6cfacc8 (git): Remove dependency on `openssl/conf_api.h`
- None of the functions defined in this header are actually used in Ruby.
Fixes build against boringssl that does not have this file.
Closes: https://github.com/ruby/ruby/pull/2210 -
12:20 AM Revision 0f601df2 (git): [Doc] Fix Array#to_h call-seq
- Closes: https://github.com/ruby/ruby/pull/2254
-
- Closes: https://github.com/ruby/ruby/pull/2255
-
12:19 AM Revision 4173258f (git): change call CGI methods from :: to .
- Closes: https://github.com/ruby/ruby/pull/1749
-
12:18 AM Revision 8e7df4bb (git): Use the word heredocs in Here Documents docs
- Two advantages:
- higher relevance of the extremely common word "heredocs" which may
help people find this page when searching for "ruby heredocs"
- the anchor link becomes `#label-Here+Documents+-28heredocs-29`, which is
ugly due to the... -
12:03 AM Revision 93116569 (git): Better wording for __ENCODING__
- "locale encoding" is misleading since it doesn't mean Encoding.find("locale")
but the encoding used to interpret the script file. It's therefore better to
call it "script encoding" as in the paragraphs above.
Closes: https://github.com/r... - 12:03 AM Revision 636a4fad (git): README: Add smart URL for joining mailing list
- This adds a couple of parameters to the mailing list link in the README
so that the subject line and body are automatically populated. The body
is populated with the `subscribe` string so that all an individual has
to do is perform the s...
08/03/2019
-
11:58 PM Revision 7614cc5b (git): Fix release post output for tool/format-release
- Different entries should be separated by an empty line.
Closes: https://github.com/ruby/ruby/pull/2137 -
- This reverts commit 5931857281ce45c1c277aa86d1588119ab00a955 temporarily,
leaving `TestEval#test_gced_eval_location` to see the impact for missing
the changes.
That's because too many CIs are failing for `require` behaviors:
http://ruby... -
- [Feature #14187]
-
- Applied in changeset commit:git|9b38c845508a4184882580abb3b6cc4fcd1dd57f.
----------
[DOC] updated about icons in win32/README.win32 [ci skip]
[Bug #13348] -
- [Bug #13348]
- 10:15 PM Revision 586e23c9 (git): * 2019-08-04
-
- [Feature #14187]
-
-
08:40 PM Feature #16039: Array#contains? to check if one array contains another array
- I think this is a great proposal in terms of having one of those nice, useful methods easily available directly on the class you're interacting with, similar to `Array#last` which can quite verbose in other languages.
I would propose ... -
- cha1tanya (Prathamesh Sonpatki) wrote:
> I wanted to avoid creating Set objects just for the purpose of this check so my motivation was to have such method on Array.
`Array#-` and any efficient (O(n+m) and not O(n*m), n the size of t... -
- I think the use case is ok - you want to find out whether an Array or
an Array-like object, is contained in another object (container in a
container in a container ...).
My biggest problem with this is that #contains? is similar in... -
05:50 AM Feature #16039: Array#contains? to check if one array contains another array
- Agree that `superset` is better name. Here is the actual use case:
```ruby
Project.pluck(:id).contains?([1,2,3])
```
Where `Project.pluck` returns an array of integers.
To use set, I have to convert the array to a set.
```... -
-
- ruby_2_6 r67725 merged revision(s) 1ef39d8d099f145222b9352423af16a2bab6e05b.
-
- Fix process not waking up on signals on OpenBSD
When using UBF_TIMER_PTHREAD (the UBF handler on OpenBSD), the
timer_pthread_fn function will not signal the main thread with
SIGVTALRM in cases where timer_pthread... -
08:56 AM Bug #16042: Error compiling ruby 2.7.0: recipe for target 'parse.c' failed
- I successfully installed ruby. Thank you all!
-
- hsbt (Hiroshi SHIBATA) wrote:
> >./tool/pure_parser.rb:7:in popen': No such file or directory - bison (Errno::ENOENT)
> ...
As the OS is Ubuntu, should via apt. -
- >./tool/pure_parser.rb:7:in popen': No such file or directory - bison (Errno::ENOENT)
You should install `bison` software via macports or homebrew. -
- I get an error when compiling ruby from https://github.com/ruby/ruby
### Environment
```
root@instance-2:~/fuzz_ruby/ruby# uname -a
Linux instance-2 4.15.0-1036-gcp #38~16.04.1-Ubuntu SMP Tue Jun 25 15:30:46 UTC 2019 x86_64 x86_64 ... -
-
-
- Highlight failed command and suggest installing the command.
[Bug #16042] -
-
- Applied in changeset commit:git|5931857281ce45c1c277aa86d1588119ab00a955.
----------
Fix dangling path name from fstring
* parse.y (yycompile): make sure in advance that the `__FILE__`
object shares a fstring, to get rid of dangling ... -
- It could reproduce with simpler bug.rb:
```
file = "1.rb"
eval(File.read(file), nil, File.expand_path(file))
eval(File.read(file), nil, File.expand_path(file))
```
```
$ ~/work/ruby/miniruby bug.rb
Traceback (most recent cal... -
- ```
$ pwd
/tmp/bug-0123456789
$ cat bug.rb
require "pathname"
file = "1.rb"
path = Pathname.new(file)
eval(File.read(file), nil, path.expand_path.to_s)
file2 = Dir["1.rb"].first
p file == file2 #=> true
path = Pathname.n... - 04:51 AM Revision cee394eb (git): * expand tabs.
-
- * parse.y (yycompile): make sure in advance that the `__FILE__`
object shares a fstring, to get rid of dangling path name.
Fixed up 53e9908d8afc7f03109b0aafd1698ab35f512b05. [Bug #16041]
* vm_eval.c (eval_make_iseq): ditto. -
02:41 AM Feature #16027: Update Ruby's dtrace / USDT API to match what is exposed via the TracePoint API
- > Could you show us how V8 and Python provide USDT features?
V8 has ustack helpers (which I'd love to try and figure out how to do for MRI) https://www.joyent.com/blog/understanding-dtrace-ustack-helpers which make the type of probing... -
- 01:25 AM Revision fb96bea7 (git): * expand tabs.
-
-
- https://github.com/bundler/bundler/commit/5215ae7fa3
-
- https://github.com/bundler/bundler/commit/ffc5e76335
- 12:32 AM Revision aad7443e (git): [bundler/bundler] Point to CoC which contains the contributor covenant
- https://github.com/bundler/bundler/commit/a94f74682e
-
-
-
-
- And reenable exclusion because the bug why we added them has been fixed.
See https://github.com/rubocop-hq/rubocop/issues/6861.
https://github.com/bundler/bundler/commit/bda63fcffc -
- https://github.com/bundler/bundler/commit/ffb7d6fa53
-
- https://github.com/bundler/bundler/commit/b8ee4aec0b
-
- https://github.com/bundler/bundler/commit/cd1abf8b3f
-
- * Adds an extra artifice task to vendorize new `connection_pool`
dependency.
* Cherry-pick's needed Windows fix not yet merged into master branch of
`net-http-persistent`.
* Update bundler usages to be compatible with the new version, ... -
- So that the behavior is the same regardless of the tested bundler
version.
https://github.com/bundler/bundler/commit/664549427a -
- https://github.com/bundler/bundler/commit/4c6a3c3cf7
-
- And use single quotes consistenly.
https://github.com/bundler/bundler/commit/8b9fbbb2df -
12:30 AM Revision 4dea1356 (git): [bundler/bundler] [CurrentRuby] Say we are ruby? when the generic local platform is Gem::Platform::RUBY
- This allows us to always say we're ruby? when force_ruby_platform is
set, and fixes using gemspec & force_ruby_platform on windows.
https://github.com/bundler/bundler/commit/3cb89b7e5c -
- https://github.com/bundler/bundler/commit/2a7a5daba0
-
- And refactor development setup.
https://github.com/bundler/bundler/commit/f288806d02 -
- https://github.com/bundler/bundler/commit/d6c9196d18
- 12:30 AM Revision d2d6d5c9 (git): [bundler/bundler] Fix typo in binstubs documentation
- https://github.com/bundler/bundler/commit/88dbfa18b4
-
- https://github.com/bundler/bundler/commit/bda0fa02c4
-
- https://github.com/bundler/bundler/commit/428f53bef0
-
- It's affect with rspec examples and broke them.
https://github.com/bundler/bundler/commit/355a922073 -
- To indicate that it can raise.
Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
https://github.com/bundler/bundler/commit/584e841624 -
- Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
https://github.com/bundler/bundler/commit/7b68d86bdd -
- Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
https://github.com/bundler/bundler/commit/027aba0cff -
- https://github.com/bundler/bundler/commit/d845a213ca
- 12:29 AM Revision e1ccaa87 (git): [bundler/bundler] Extract a `print_gems` method
- https://github.com/bundler/bundler/commit/0d8c8d207e
- 12:29 AM Revision 759930dd (git): [bundler/bundler] Less complexity
- https://github.com/bundler/bundler/commit/be9d6e7cfc
-
- Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
https://github.com/bundler/bundler/commit/4335df3e4c -
- It's the only usage of the `options_include_groups` attribute and its
name suggests a boolean, so it fits better now.
Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.n... -
- Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com>
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
https://github.com/bundler/bundler/commit/832fb900f0 - 12:29 AM Revision e33dd659 (git): [bundler/bundler] Move duplicated code to `before` blocks
- https://github.com/bundler/bundler/commit/69bee117fb
-
- https://github.com/bundler/bundler/commit/5b285685a4
-
- These specs are only run on bundler 2, so the compatibility method is
not needed.
https://github.com/bundler/bundler/commit/6cb28e3aeb -
- https://github.com/bundler/bundler/commit/8c83921d08
-
- https://github.com/bundler/bundler/commit/04a04719f0
-
- https://github.com/bundler/bundler/commit/1ee77d9c55
-
- https://github.com/bundler/bundler/commit/ebcb25a3c3
-
- https://github.com/bundler/bundler/commit/b5900e57a4
-
- https://github.com/bundler/bundler/commit/344a881592
-
- In these versions, the `approximate_recommendation` method doesn't
include the prerelease logic.
https://github.com/bundler/bundler/commit/caf13e9e4f -
- https://github.com/bundler/bundler/commit/9ddeeb1fe1
-
- https://github.com/bundler/bundler/commit/72194d1aac
-
- https://github.com/bundler/bundler/commit/50ccdb32c2
-
- https://github.com/bundler/bundler/commit/1d017c3f36
-
- https://github.com/bundler/bundler/commit/7ca4d4e83c
-
- https://github.com/bundler/bundler/commit/2a44090cb6
-
- https://github.com/bundler/bundler/commit/6d0a8f4128
-
- https://github.com/bundler/bundler/commit/6d3b809695
-
- It sounds like this was mistankenly added in
4337a499d0108fc3748084934aaed7591b355a26. Then the forgotten MANPATH key
was added in bf5bf106230772934602768bb31a68dc925691f0, but this one
should've been removed I think.
https://github.com... -
- https://github.com/bundler/bundler/commit/038f0d7c37
-
- https://github.com/bundler/bundler/commit/3e5d4b2c42
-
- PR 7248 incorrectly changed a path calculation. This reverts.
After running Azure Pipelines CI in my ruby/ruby fork and checking the 'bundler' jobs, the error was apparent...
https://github.com/bundler/bundler/commit/811755b413 -
- https://github.com/bundler/bundler/commit/537c0ab712
-
- https://github.com/bundler/bundler/commit/37a1eec8c8
-
- https://github.com/bundler/bundler/commit/33892e1ed2
-
- The additions of the `package` command are not actually backwards
incompatible, so we can do this transition without further care. All
existing specs of `bundle cache` pass when using the `bundle package`
implementation for it.
https://... -
- So that we handle the removal of `bundle cache` just like we'll handle
the removal of `bundle show` and `bundle console`.
https://github.com/bundler/bundler/commit/ff1a669efb -
- Just change the default. The reason to do this is that the deprecation
message talks about the default being changed, not the option being
removed.
https://github.com/bundler/bundler/commit/eca1757792 -
- https://github.com/bundler/bundler/commit/4df9edef95
-
- This is inside a code branch where the condition is already met.
https://github.com/bundler/bundler/commit/8cdd6c37e6 -
- https://github.com/bundler/bundler/commit/8ecd722b9f
-
- It seems to pass under rubygems 2.5.2.
https://github.com/bundler/bundler/commit/062cd2be7c -
- Since it covers the whole range we support.
https://github.com/bundler/bundler/commit/c0b9d4e6c6 -
- We plan to incrementally populate this array in rubygems, so that will
break the test because the first time `find_by_name("rack")` is called
will make the `rack` gem available in the array.
We can test the same thing using some other w... -
- The rubygems integration sets up a `post_reset` hook that resets the
specs back to what bundler knows after `Gem::Specification.reset` is
called (which is what `Gem.refresh` calls under the hood).
https://github.com/bundler/bundler/comm... -
- It contains a typo, so it can't be needed.
https://github.com/bundler/bundler/commit/ef38c97fbf -
- https://github.com/bundler/bundler/commit/98023e25de
-
- Instead of setting the encoding globally, set it when reading the files.
https://github.com/bundler/bundler/commit/e2a5c45e4d -
- https://github.com/bundler/bundler/commit/e31880b1ea
-
- https://github.com/bundler/bundler/commit/78608acf83
-
- https://github.com/bundler/bundler/commit/3a2d2f0250
-
- https://github.com/bundler/bundler/commit/52c5a0eede
-
- https://github.com/bundler/bundler/commit/00b095b98f
-
- https://github.com/bundler/bundler/commit/3dc509e645
-
- https://github.com/bundler/bundler/commit/785c7af1f3
-
- https://github.com/bundler/bundler/commit/60d720eb06
-
- https://github.com/bundler/bundler/commit/9f07207d64
-
- https://github.com/bundler/bundler/commit/3b9abc8932
-
- https://github.com/bundler/bundler/commit/5e08e849ec
-
- And freeze the resulting hash to appease rubocop.
https://github.com/bundler/bundler/commit/f38ebff92f -
- https://github.com/bundler/bundler/commit/babbc112c6
-
- https://github.com/bundler/bundler/commit/1bd9660780
-
- https://github.com/bundler/bundler/commit/e6a03f1102
-
- https://github.com/bundler/bundler/commit/102d6229d4
-
- https://github.com/bundler/bundler/commit/22de94d3b4
-
- 1.0.0 is such a common output, and it was hiding a crash in the test.
https://github.com/bundler/bundler/commit/c688337e24 -
- https://github.com/bundler/bundler/commit/7ac854dea1
-
- https://github.com/bundler/bundler/commit/156629291e
-
- We only want it temporarily during the duration of the cache saving.
https://github.com/bundler/bundler/commit/1e9818c0da -
- https://github.com/bundler/bundler/commit/899aeeebb0
-
- https://github.com/bundler/bundler/commit/723611f6ee
-
- https://github.com/bundler/bundler/commit/e45d2272ea
-
- I'm not sure this test is useful but since it's there, it should be
complete.
https://github.com/bundler/bundler/commit/3e350089db -
- https://github.com/bundler/bundler/commit/0b40b5b784
-
12:29 AM Revision a375a451 (git): [bundler/bundler] Correct default cache path
- The default cache path is `vendor/cache`, not `vendor/bundle`.
https://github.com/bundler/bundler/commit/49256bb3d2 -
- https://github.com/bundler/bundler/commit/ca96316b97
-
- https://github.com/bundler/bundler/commit/b47d23edf5
-
- https://github.com/bundler/bundler/commit/f8584fb864
-
- It's now only used once, and doing it like this is consistent with the
previous line.
https://github.com/bundler/bundler/commit/7d27330fc7 -
- https://github.com/bundler/bundler/commit/02177d0e10
-
- https://github.com/bundler/bundler/commit/3df138318f
-
- https://github.com/bundler/bundler/commit/773203ec5a
-
- https://github.com/bundler/bundler/commit/7da2bf75f5
-
- This reverts commit d9d2bf6d522dd36d1ef2732e87cef8b7cba729fd.
https://github.com/bundler/bundler/commit/eeb2ff1561 -
- https://github.com/bundler/bundler/commit/595dd6af6c
-
- https://github.com/bundler/bundler/commit/efa69583dd
-
- https://github.com/bundler/bundler/commit/1a853ad6ac
- 12:29 AM Revision 884f948a (git): [bundler/bundler] bundler/inline should always install gems to system path
- As discussed in the P/R, when `BUNDLE_PATH` env is set Bundler should
still install gems to the system path. `GEM_HOME` can be used to provide
different location if needed.
The test is added to document expected behavior of `bundler/inl... -
- https://github.com/bundler/bundler/commit/0646f9e286
-
- This spec was not stopping threads after itself. That would cause the
previous spec in the file (that checks that no threads are left behind)
to fail.
https://github.com/bundler/bundler/commit/81ad85b92d - 12:29 AM Revision a12557db (git): [bundler/bundler] Add `required_ruby_version` to gemspec template
- https://github.com/bundler/bundler/commit/f47421f92d
-
- https://github.com/bundler/bundler/commit/ae0ac190aa
-
- https://github.com/bundler/bundler/commit/43ffaab796
-
- https://github.com/bundler/bundler/commit/4a37d66f3f
-
- Co-authored-by: Colby Swandale <me@colby.fyi>
Co-authored-by: Kevin Deisz <kevin.deisz@gmail.com>
https://github.com/bundler/bundler/commit/1b2bbc7364 -
- https://github.com/bundler/bundler/commit/b35d7fc74a
-
- https://github.com/bundler/bundler/commit/7eccba0e52
-
- Windows paths do not start with a slash, so we add an extra slash to
separate the host from the path in file:// urls. Otherwise "D:" is
parsed as the host segment in the URI.
The path for those URLs now starts with "/", so we ignore tha... -
- https://github.com/bundler/bundler/commit/5946d62ad0
-
- https://github.com/bundler/bundler/commit/f694fe7f67
-
- So we can later add more tests with the same setup.
https://github.com/bundler/bundler/commit/21b4b6c49c -
- https://github.com/bundler/bundler/commit/d9d2bf6d52
-
- https://github.com/bundler/bundler/commit/80217bfe0b
-
- https://github.com/bundler/bundler/commit/ca28a04668
-
- ANSI codes don't work there.
https://github.com/bundler/bundler/commit/4f05417ca7 -
- For consistency.
https://github.com/bundler/bundler/commit/279603ab42 -
- https://github.com/bundler/bundler/commit/a4d04506ab
-
- Thor's base shell will be memoized the first time it is set. So if we
instantiate a no-color shell first, further instantiations of a bundler
shell will be initialized with a no-color shell by default. This is
caused some sources specs t... -
- The builtin thor's color shell already checks this before printing, and
if not a tty, prints just the string without added color codes.
https://github.com/bundler/bundler/commit/4f62611c87 -
- https://github.com/bundler/bundler/commit/1892626858
-
- I think this was fixed upstream last year: https://github.com/flori/json/commit/91a24ecac3d722bc3e545fdd0657ed225e91c2df