Activity
From 06/05/2019 to 06/11/2019
06/11/2019
-
10:54 PM Bug #15360 (Closed): "ThreadError: deadlock; recursive locking" error when recursive lock shouldn't be possible
- Fix committed at commit:c1d78a7f0ece2004822193a0c1f1fd3dc38c2fdf
-
- Fix committed at commit:c1d78a7f0ece2004822193a0c1f1fd3dc38c2fdf
-
- Fix committed at commit:c1d78a7f0ece2004822193a0c1f1fd3dc38c2fdf
-
- Eregon (Benoit Daloze) wrote:
> @jeremyevans0 The patch looks wrong, `rb_mutex_lock` should be changed, not `rb_mutex_unlock`.
Correct, apologies for that. It turns out there is a pull request for this that should may the issue (htt... -
08:23 PM Bug #15645: It is possible to escape `Mutex#synchronize` without releasing the mutex
- @jeremyevans0 The patch looks wrong, `rb_mutex_lock` should be changed, not `rb_mutex_unlock`.
-
- lexi.lambda (Alexis King) wrote:
> Therefore, the solution seems simple: **instead of using `rb_mutex_lock` inside of `rb_mutex_synchronize`, use `mutex_lock_uninterruptible`, which sets `interruptible_p` to `FALSE` and avoids the issue... -
10:44 PM Revision c1d78a7f (git): do_mutex_lock: release mutex before checking for interrupts (fixes issue 15360)
-
- This appears to be an issue in the mysql2 library, probably the same issue as https://github.com/brianmario/mysql2/issues/1029, which is a null pointer dereference at the same line as this error.
-
- As nobu stated, the current behavior is expected in regards to not printing a newline if no arguments are given, and the documentation is accurate for the current behavior. It states `converts each of the messages to strings, appends a ...
-
- Unlike Unix, Windows doesn't support execute permissions separately. If the path is a regular file, Ruby currently uses file extensions to determine if a file is executable, and only considers the following extensions as executable: `.ba...
-
- This doesn't appear to be a ruby or ffi issue. The segfault occurs `multi_cleanup`, which is a libcurl method wrapped by ethon (https://github.com/typhoeus/ethon/blob/de60a72552a1ae392705617a45477d93f0f51293/lib/ethon/curls/functions.rb...
-
- * [Feature #15797] Use realpath(3) instead of custom realpath implementation if available (jeremyevans0)
* Is this OK to commit? It may cause regressions on less common Unix not tested by Travis (e.g. FreeBSD, NetBSD, AIX, Solaris), t... -
- shuujii (Shuji KOBAYASHI) wrote:
> @jeremyevans0 Thank you for your comment. About `Complex`, I agree with most of v2 patch, but I have some comments.
> ...
I don't think so, but I don't have a strong opinion. If you would like those ... -
02:09 PM Bug #15857: <=> の右辺が <=> を実装していない場合の振る舞い
- @jeremyevans0 Thank you for your comment. About `Complex`, I agree with most of v2 patch, but I have some comments.
- Should methods from `Comparable` that are currently disabled be enabled?
- `rb_undef_method(rb_cComplex, "<=>")` is... -
04:45 PM Bug #15720 (Closed): SystemStackError when referencing a refinement in a module that isn't used
- Applied in changeset commit:git|5e018214e7435030727a97ac49db038d96438e74.
----------
Fix SystemStackError when calling a method in an unused refinement
Fixes [Bug #15720] -
09:03 AM Bug #15720: SystemStackError when referencing a refinement in a module that isn't used
- Seems fine.
Just rename `test_refining_module_repeatedly` which redefines an existing method. -
- Fixes [Bug #15720]
- 04:16 PM Revision 4f9e7c95 (git): * 2019-06-12
- 04:16 PM Revision 23e3c170 (git): * expand tabs.
-
04:16 PM Revision 6db2d6d8 (git): Add compaction support for more types.
- This commit adds compaction support for:
* Fibers
* Continuations
* Autoload Constants -
02:55 PM Bug #15490: socket.rb - recurring segmentation faults
- I have been experiencing this issue as well, but only on a computer running OSX 10.14.5. I can't seem to recreate this on linux using Fedora 29 or Ubuntu 18.04.
Switching the OSX over to 127.0.0.1 instead of localhost seems to crash l... -
- * test/lib/test/unit/assertions.rb (assert_cpu_usage_low): apply
the timeout scale to measuring period. this assertion is very
runtime environment dependent. -
- * test/lib/test/unit/assertions.rb (Test::Unit::Assertions):
promoted MIN_HZ and MIN_MEASURABLE as constants, which should be
constant through the process. -
- * test/lib/test/unit.rb (Test::Unit::TimeoutOption): renamed
SubprocessOption.
* test/lib/test/unit.rb (Test::Unit::TimeoutOption#setup_options):
prefer `--timeout-scale` option.
* test/lib/test/unit.rb (Test::Unit::TimeoutOption#n... -
-
01:25 PM Feature #15912 (Closed): Allow some reentrancy during TracePoint events
- I got a report in byebug about byebug being incompatible with zeitwerk. This one: https://github.com/deivid-rodriguez/byebug/issues/564. This is a problem because zeitwerk is the default Rails code loader, and byebug is the default Rails...
-
12:55 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
- Quite a long old discussion. I checked before replying, to make sure I don't comment too often
in one particular issue. So this is my first reply; and I will try to make comments that summarize
my opinion.
First, I would like to sta... -
10:08 AM Bug #15911 (Closed): Missing TracePoint return event for ||=
- Thank you for your report.
I can reproduce the issue at ruby 2.6.3, and cannot do at master branch. It looks like the issue is already fixed by 1bc6c3f40777ca10d8e7df38b775b0bb81a25881. Please wait for the backport. -
08:00 AM Bug #15911 (Closed): Missing TracePoint return event for ||=
- While updating ruby-prof, I ran into an issue while profiling rails that caused ruby-prof to show an incorrect method invocation tree. This is caused by the use of the ||= operator in minitest.
Here is a small test case:
```
class... -
- https://hackerone.com/reports/605262
-
03:33 AM Revision 42ac8890 (git): Fail test if load ~/.irbrc
-
03:16 AM Revision e4364dbf (git): Fixed the code-style with the upstream rule.
06/10/2019
-
- I can confirm this issue. I believe it stems from the fact that in `vm_call_method_each_type`, `cc->me` is getting overwritten by `ref_me` even if they already have the same `def` but a different `defined_class`, which results in infini...
-
- CPU usage 1% causes occesional test failure. Try to use 5%.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/gentoo/ruby-master/log/20190604T153002Z.fail.html.gz
https://rubyci.org/logs/rubyci.s3.amazonaws.com/gentoo/ruby-master/log/201... - 09:56 PM Revision fe9701ee (git): * expand tabs.
-
- Sometimes ruby/spec fails when trying to specify local_host and
local_port for TCPSocket.open.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/solaris11s-sunc/ruby-master/log/20190610T192504Z.fail.html.gz -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190610T071910Z.log.html.gz
-
08:41 PM Bug #15910 (Rejected): $. doesn't hold the linenumber anymore when reading a CSV-file using the CSV class
- CSV implementation was changed to improve performance. The new implementation reads data as chunk (`$stdin.gets(nil, 4096)`) instead of lines (`$stdin.gets`) from input. `$.` doesn't work with reading data as chunk.
It's backward inco... -
- I can confirm the behavior change. I bisected it to https://github.com/ruby/csv/commit/8505ff0900a4789dce0740ab23e92de1fb89196e. I would not consider this change a bug, since I don't think the csv library was ever documented as treatin...
-
11:15 AM Bug #15910 (Rejected): $. doesn't hold the linenumber anymore when reading a CSV-file using the CSV class
- Example program:
```
require 'csv'
IFS=';'
CSV_OPTIONS = { col_sep: IFS, external_encoding: Encoding::ISO_8859_1, internal_encoding: Encoding::UTF_8 }
CSV.new($stdin, CSV_OPTIONS).each do
|row|
puts "::::line #{$.} row=#... - 03:25 PM Revision d7e7e998 (git): * 2019-06-11
-
03:20 PM Revision be6b4624 (git): Use checktype for performance
-
02:31 PM Revision f0bfa71a (git): Use UTC for file2lastrev timezone
- 02155da7bad37bd1c8adadd486d2d16eac7af43b got a claim about sacrificing
ability to compare arbitrary `RUBY_DESCRIPTION`s without converting
timezones.
Because most of the people would be familiar with timezone conversion
with UTC but it'... -
- Using the same timezone for all commits is convenient when just looking
dates in RUBY_DESCRIPTION, but usually we also check `git log` when
we're interested in the order of commits.
`git log` shows times in committer's timezone and forci... -
- By the way, this is already improved by nobu:
```
$ benchmark-driver benchmark/irb_exec.yml --rbenv '2.6.3;2.7.0-preview1;before;after' -v
2.6.3: ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-linux]
2.7.0-preview1: ruby 2.7.0preview... -
-
12:38 PM Feature #5400: Remove flip-flops in 2.0
- judofyr (Magnus Holm) wrote:
> Nobody knows them. Nobody uses them. Let's just get rid of flip-flops, shall we?
I'll chip in as a dev who spends a significant amount of time scripting.
First, the description of the issue is false.... -
-
- ```
$ benchmark-driver benchmark/irb_exec.yml --rbenv '2.6.3;2.7.0-preview1'
Calculating -------------------------------------
2.6.3 2.7.0-preview1
irb_exec 11.844 5.171 i/s - 30.... - 10:48 AM Revision b9996b7b (git): * 2019-06-10
-
-
- * https://rubyci.org/logs/rubyci.s3.amazonaws.com/archlinux/ruby-master/log/20190609T153804Z.fail.html.gz
* Thanks @naruse for the tip.
06/09/2019
-
-
-
- I think mame is correct that this is related to Mac OS X getaddrinfo. We have at least 5 separate bug reports for very similar issues. All segmentation faults with similar addresses, all on Mac OS X and either definitely or probably ins...
-
-
04:22 AM Feature #15236: add support for hash shorthand
- PR for alternative syntax `{ a: }`: https://github.com/ruby/ruby/pull/2231
-
- I was reading the presentation slide for the experimental feature for syntax matching.. in which, there's support for "shorthand" matching with hash, in the form of `{ a: }`.. or, following the examples presented above:
```ruby
def f... -
-
-
-
- Pick from 8dd59e3ba97eb80a599f8149f31bf40773b69dc0
-
- Applied in changeset commit:git|66508992483ae5d77b56a98427c50c772341c0ac.
----------
Make Resolv::DNS#each_name accept Resolv::IPv{4,6} arguments
These arguments were previously documented as supported, but not
actually supported.
Pat... -
- Thank you for the report. I was able to confirm the issue and that your patch fixes it. I will apply your patch shortly.
-
- These arguments were previously documented as supported, but not
actually supported.
Patch from Toru Iwase
Fixes [Bug #15900] - 03:30 AM Revision a432c014 (git): * 2019-06-09
-
-
-
- @pitr.ch
Please briefly summarize your proposal first. Use case is important, but explaining a proposal by use case is difficult to read (unless the use case is really simple).
I'm unsure but I guess your proposal:
1) Add a synta... -
12:05 AM Feature #15909 (Open): Improve Thread#exit documentation
- Whilst writing some low-level threading code, I came across a couple of unexpected (though useful) behaviours of `Thread#exit` (aka `#kill`, `#terminate`) that I think are worth documenting for the benefit of future generations. Attache...
06/08/2019
-
01:20 PM Bug #15907: gem bin stub commands are failing
- Hiroshi,
Good evening. A ruby-loco CRON job just happened to run on 3776c48cf4, and it passed.
Thank you, and sorry for the delay, I recently woke up.
JFYI, a while ago I added CLI output to ruby-loco CI, but I didn't add code ... -
- Hi, Greg.
Thanks to your report. I reverted b76630f73e for another reason. Can you try with the current master as https://github.com/ruby/ruby/commit/3776c48cf41950d2cc994676bb2735ee1a0a474e ? -
- Sorry for forgetting (to many hours coding today).
One should be able to repo this by copying the lib/rubygems folder from master/trunk to an existing install, then run a CLI command similar to any of the above... -
- Commands like
```ruby
bundle version
irb --version
rake --version
rdoc --version
```
are failing. All failure are something similar to:
```
bundle : lib/ruby/2.7.0/rubygems/core_ext/kernel_gem.rb:64:in `synchronize': deadlock; ... -
12:58 PM Misc #15874: DevelopersMeeting20190613Japan
- * [Feature #14912] Introduce pattern matching syntax ([pitr.ch](https://twitter.com/pitr_ch))
* Could the pattern matching be made available as a first-class citizen to be used as a filter when searching in data structures and to be a... -
- * [Bug #15908] Detecting BOM with non-UTF encoding
-
- Currently, "bom|" encoding prefix to `File.open` is ignored if the encoding name is not a UTF.
But one usage of BOM is to tell if the stream is a UTF or not, and especially common on Windows, e.g. UTF-16LE or OEMCP.
So I think this res... -
- The patch looks good to me.
-
- Hi, I am really looking forward to this feature. Looks great!
However I'd like to make few suggestions which I believe should be part of the first pattern matching experimental release. I'll include use-cases and try to explain why i... -
- I cannot tell the order just by commit hashes.
-
-
- With the SDK of Xcode 10.2.1, `API_AVAILABLE` and so on macros are
not defined in <os/availability.h> when using a compiler other
than clang (which has `__has_feature` and `__has_attribute`), but
`__API_AVAILABLE` macro and so on are def... -
- * lib/rubygems/commands/unpack_command.rb: 'rubygems/package' is
required here, to fix broken `gem unpack` command. -
-
- I think this is a bug we should fix, even if it breaks code relying on this bug ("all bug fixes are incompatibilities" :)).
I worked on a patch for #15867, before realizing mohsen created a pull request for this. My patch ended up be... -
- This reverts commit b76630f73e8362d3072bfa7178471ddc5d21c235.
It fails with `make test-bundler BUNDLER_SPECS=runtime/setup_spec.rb:1204` -
12:42 AM Feature #15665: Cannot compile socket extension on Mojave
- @nobu This should be a bug, not feature. Please mark it as a bug and backport it into 2.6 branch.
06/07/2019
-
11:44 PM Feature #15894: Remove support for IA64
- Here is a brief overview of one possible plan:
- We remove IA64 from 2.7.
- We retain IA64 in 2.6 which has a theoretical EOL date in 2022. That's 5 years past the last date of the CPU being manufactured, and 3 years past the archite... - 03:15 PM Revision 1696f80f (git): * 2019-06-08
-
03:14 PM Revision 19977cc7 (git): Remove unnecessary variables
-
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-9d6766/ruby-master/log/20190607T051708Z.fail.html.gz
-
- * lib/rubygems/commands/unpack_command.rb: 'rubygems/package' is
required. fix the failure of `gem unpack` command.
* lib/rubygems/source/local.rb: ditto.
* lib/rubygems/source/specific_file.rb: ditto. -
- Does it occur with 2.5.5, 2.6.3, or 2.7.0-preview1?
-
- * lib/rdoc/parser/ripper_state_lex.rb (RDoc::Parser::RipperStateLex):
chomp newline, including CR, from here document terminator.
Closes: ruby/rdoc#694
Closes: ruby/rdoc#697
Closes: ruby/rdoc#705 -
- Applied in changeset commit:git|a6a26e42b15c46f117f4fce07a2050e9d727355d.
----------
compile.c: Partially revert r63870 which caused wrong optimization
[Bug #15906] -
05:20 AM Bug #15906 (Closed): a=a のような式をもつ条件分岐が意図しない挙動をする
- [ruby-list:50781] から一部転載します。
```
下記スクリプトの結果が期待と違います。なぜでしょうか？
a = a は不要ですが、なにもしないことを明示するために書いたものです。
なおOS付属の ruby 2.3.7p456 では期待通りの結果でした。
a = "aaa"
if a == "bbb" || a == "ccc" then
a = a
else
puts "OK"
end
puts "EN... -
- [Bug #15906]
-
- LibreSSL 2.8.0+ does not support multiple elements in the first
argument. -
- Skip Process clockres specs that don't work on either FreeBSD or
Solaris/AIX in addition to OpenBSD.
Run most current String#crypt specs on non-OpenBSD, and add a new
set of crypt specs for OpenBSD, which support bcrypt but not DES
in c... -
- I'm not sure nobu's changesets are bug or feature.
But this issue was marked with "Feature" by nobu. We never backport the new feature to stable versions.
-
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/scw-9d6766/ruby-master/log/20190606T171708Z.fail.html.gz
-
-
-
- This reverts commits:
* 6f9d5fafe040cb02a1278fbfcdcb8063d564824c
* bb3c89b6437049e26669b2156310670d5e06e386
And remove the dependency of Makefile on Makefile.in
transitionally.
06/06/2019
-
-
-
- Hello? Any update? Would it be included in 2.6.4?
- 05:04 PM Revision aee77901 (git): * 2019-06-07
-
- * ext/win32/lib/win32/registry.rb (Win32::Registry#each_value):
advance the index even if an error occurred in #read. -
- knu (Akinori MUSHA) wrote:
> Yeah, that would be the way completely against duck-typing.
Right, to clarify I meant the library would need the extra `.to_a` where it expects an Enumerator method to return an Array and not just some `E... -
01:55 PM Feature #15901: Enumerator::Lazy#eager
- > One argument would be the callee should do take_while {}.to_a if they really want an Array and not just an Enumerable (which has most of Array's methods).
> ...
Yeah, that would be the way completely against duck-typing. In my opinio... -
- knu (Akinori MUSHA) wrote:
> Suppose I want to pass the `enum` to another method that takes an Enumerable object where the passed object is expected to act eagerly. One of the most significant use cases is when the callee uses `take_wh... -
- Suppose I want to pass the `enum` to another method that takes an Enumerable object where the passed object is expected to act eagerly. One of the most significant use cases is when the callee uses `take_while` on a given object expecti...
-
-
- `LINKFORSHARED` means dynamically loaded extension libraries?
If so, `--with-static-linked-ext` configuration option makes all extension libraries linked statically (except for test libraries).
Or uncommenting the `option nodynamic` li... -
- I think maintaining the existing documentations already exceeded our capacity and some of them are still outdated, despite of our day-to-day continuous effort. So adding a new Wiki would be a big burden. Please suggest to delete an unnec...
-
10:36 AM Misc #15905: [Documentation] [Request for the wiki at https://bugs.ruby-lang.org/projects/ruby-trunk/wiki] - Consider adding more information to statically compiled ruby variants
- I think the document should be in doc/ of Ruby repository.
Feel free to create a patch.
Background:
Recently our Redmine wiki is suffered by spam, and I decided to restrict the edit permission.
Therefore it's now not a suitable pla... -
- Hello ruby core team in particular and other ruby folks,
This issue request here is primarily about documentation, in particular in regards to a "statically compiled
ruby". This refers either to a ruby that is completely static (no l... -
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190602T031908Z.fail.html.gz
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable10s/ruby-master/log/20190605T231909Z.fail.html.gz
-
- Eregon (Benoit Daloze) wrote:
> mame (Yusuke Endoh) wrote:
> ...
Oh sorry I missed the point. Fair enough. I'll ask matz's opinion at the next meeting.
> > At least, I don't want to do that until we receive an actual request to ... -
- deep-cover might be interested by this too, cc @marcandre
-
- byroot (Jean Boussier) wrote:
> This is kinda tengential, so sorry if it's shifting the discussion. But if `resolve_feature_path` is to be made a first class public API, I wonder if it could be the occasion to make `Kernel#require` invo... -
- mame (Yusuke Endoh) wrote:
> However, we can't be too careful to add anything to `Kernel` nowadays.
I propose only as a class method, not an instance method, so I think there is literally no chance for conflicts. What's your concern?... -
- Great!
-
- * [Feature #15903] Move RubyVM.resolve_feature_path to Kernel.resolve_feature_path
* matz: is it OK to add `Kernel.resolve_feature_path` (only class method)? I think RubyVM is not a good place for `resolve_feature_path` which is not M... -
- * [Bug #15210] UTF-8 BOM should be removed from String in internal representation
A method to set the encoding on an `IO` by BOM? -
- This reverts commit c2a9c350249588677cf68b506539093504927eac.
It cannot stop `circular require` warning. -
07:32 AM Bug #15904: Ruby crashes when executing Pronto gem with Rubocop
- Update: Interestingly, this crash does not happen when executing `pronto run -c develop` without the `bundle exec` in front.
-
- When running `bundle exec pronto run -c develop` ("develop" is a branch name) on console, Ruby crashed and asked me to report this as a bug. I tried again and the same thing happened.
This project's Pronto is set up with Rubocop. I'm ... -
07:28 AM Misc #15723: Reconsider numbered parameters
- sawa (Tsuyoshi Sawada) wrote:
> I just realized that there can be a rationale for using `@` as (part of) the default block parameter. That is, `@` is already used in method names of unary operators, such as `Numeric#+@`. There, `@` stan... -
07:00 AM Feature #15899: String#before and String#after
- > Using partition looks reasonable, and it can accept regexes.
It also has the problem of creating extra objects that you need to discard with `_` or assign and just leave unused.
> ...
more with time-based operations; and rack/sin... -
-
- Bundler.setup changes Gem::DefaultUserInteraction.ui and does not close
it. This change makes sure that it is closed. -
- OpenSSL 1.1.1 rejects some shorter keys, which caused some failures of
`make test-all TESTS=openssl`.
https://rubyci.org/logs/rubyci.s3.amazonaws.com/debian/ruby-master/log/20190606T003005Z.fail.html.gz
This change merges 6bbc31ddd1 an... -
-
- sawa (Tsuyoshi Sawada) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
Thank you for providing some background on the purpose of the `real?` method. I agree that it doesn't make sense to change `real?`. Attached is a patch that onl...
06/05/2019
-
-
- (I'm an author of `RubyVM.resolve_feature_path`.)
Sorry but I'm not so positive. From perspective of module design, I agree that `Kernel` module looks the best place to add the method. However, we can't be too careful to add anythin... -
10:51 PM Feature #15903: Move RubyVM.resolve_feature_path to Kernel.resolve_feature_path
- This is kinda tengential, so sorry if it's shifting the discussion. But if `resolve_feature_path` is to be made a first class public API, I wonder if it could be the occasion to make `Kernel#require` invoke `Kernel#resolve_feature_path` ...
-
- RubyVM contains mostly MRI-specific features but `resolve_feature_path` is clearly not MRI-specific.
So I propose to move it as a class method of `Kernel`.
I think this makes sense given the related `load` and `require` are defined i... -
- Eregon (Benoit Daloze) wrote:
> @mame should the behavior that @znz reports be fixed?
I hear @nobu has already fixed the issue. (Thanks!) -
- @mame should the behavior that @znz reports be fixed?
`resolve_feature_path` sounds like it should always resolve a feature, no matter if the feature is loaded or not. -
- 07:25 PM Revision fd173372 (git): * 2019-06-06
-
-
05:37 PM Misc #15723: Reconsider numbered parameters
- By this post, I have no intention of expressing my preference to any proposal.
I just realized that there can be a rationale for using `@` as (part of) the default block parameter. That is, `@` is already used in method names of unary... -
- FWIW, we already inline `nil?` in the AST for TruffleRuby:
https://github.com/oracle/truffleruby/commit/57628008#diff-09677670ed37ee212c217374c6468718
Makes sense since it's such a small operation and it's frequently used. -
- I'd like to add a specialized instruction for `.nil?`. We have specialized instructions for `.length` and `.empty?`, and surprisingly our application also calls `.nil?` a lot:
```
[aaron@TC ~/g/github (gc-boot-stats)]$ git grep '.em... -
- shugo (Shugo Maeda) wrote:
> I don't like both proposals, but I prefer `@1` to `it` because `@1` looks ugly and may help prevent overuse.
I think we should never purposefully introduce something ugly in the language.
Preventing over... -
01:20 AM Feature #15897: `it` as a default block parameter
- > Thus, I don't like my own proposal so much, honestly. But it would be much better than Perlish @1.
I don't like both proposals, but I prefer `@1` to `it` because `@1` looks ugly and may help prevent overuse.
Furthermore, the propos... -
- Why not `Enumerator::Lazy#force` (or `to_a`) ?
```ruby
enum = huge_collection.lazy.flat_map(&:children).reject(&:disabled?)
enum.map {|x| ...}.force # an array is returned
``` -
- There are cases where you want to create and pass a normal Enumerable object to a consumer where the methods like map and select are expected to return an array, but the calculation would be so space costly without using Enumerator::Lazy...
-
- See https://github.com/ruby/ruby/pull/2226 for benchmark results.
-
- and switch-case branches.
Buffer allocation optimization using `ALLOCA_N` would be the main
benefit of patch. It eliminates the O(N) buffer extensions.
It also reduces the number of branches using escape table like
https://mattn.kaoriy... -
- Because some `log.*` git configs may change the result of `git log`,
`RUBY_LAST_COMMIT_TITLE` can be wrongly formatted and break version.c
compilation. So the `git log` executions should not respect user's gitconfig. -
11:05 AM Bug #15900 (Closed): Resolv::DNS#each_name doesn't accept Resolv::IPv{4,6} against documents
- In resolv library, document says `Resolv::DNS#each_name` accepts `String`, `Resolv::IPv4` and `Resolv::IPv6`.
But `Resolv::DNS::IPv{4,6}` raises ResolvError.
```ruby
require 'resolv'
dns = Resolv::DNS.new
dns.each_name(Resolv::IPv... -
- I can see where it may be useful, since it could shorten code like this:
first_part = "hello world!".split(' ').first
To:
first_part = "hello world!.before(' ')
It is not a huge improvement in my opinion, though. ... -
- Using `partition` looks reasonable, and it can accept regexes.
```ruby
str = 'application/json; charset=utf-8'
before, _, after = str.partition(/; /)
before # => "application/json"
after # => "charset=utf-8"
``` -
- Since you are mentioning that `String#delete_suffix` and `String#delete_prefix` do not accept regexps and that is a weak point, you should better use regexps in the examples illustrating your proposal.
-
- There seems to be no methods for getting a substring before or after a marker.
Too often I see and have to resort to variations of:
``` ruby
str[/(.+?);/, 1]
str.split(';').first
substr, _ = str.split(';', 2)
str.sub(/.*;/, ''... -
- jeremyevans0 (Jeremy Evans) wrote:
> I think [that] Complex numbers with an imaginary part of zero should be treated as real numbers, and that `Complex#real?` should return `true` for such numbers.
Changing `Complex#real?`'s meaning ... -
- I agree that this is a bug. `Complex#<=>` should be implemented, even if it did return `nil` for all arguments.
However, I think Complex numbers with an imaginary part of zero should be treated as real numbers, and that `Complex#real... -
- When describing "Runtime errors", raise a `RuntimeError` as-is.
-
05:03 AM Revision f2581370 (git): Fix grammar of macro name: ECCESSED -> ECCESSIVE
- Fix the name of the macro variable introduced in 0872ea5330
from NODE_SPECIAL_EXCESSED_COMMA to NODE_SPECIAL_EXCESSIVE_COMMA. -
04:57 AM Bug #15886: return in rescue block breaks Timeout.timeout
- I like this proposed wording, thanks for taking care of this!
-
-
-
- This reverts commit 22cd4027349f803efc7ede284376b7a7013f8dfe.
It did not make sense due to a typo `@srcidr`. -
-
- Committed as commit:f1f04caf60e4fc9dc3b12109e0be831f2d692810
-
- 02:29 AM Revision 7c776038 (git): * expand tabs.
-
- FrozenError#receiver was added recently for getting the related
object programmatically. However, there are cases where FrozenError
is raised and not handled, and in those cases the resulting error
messages lack detail, which makes debu... -
- Documentation requested in [Bug #15886].
-
- I agree this is a bug and the easiest way to fix it is to inline the `SortedSet#initialize` implementation defined by `SortedSet.setup` into the default implementation of `SortedSet#initialize`. Attached is a patch that implements that.
-
-
-
-
- I submitted a pull request to ruby/ipaddr to fix this: https://github.com/ruby/ipaddr/pull/17
- 02:01 AM Revision 6b66a76f (git): * expand tabs.
-
- This reverts commit 8d81e59aa7a62652caf85f9c8db371703668c149.
`ALLOCA_N` does not check stack overflow unlike ALLOCV. I'll fix it and
re-commit it again. - 01:13 AM Revision 804a7907 (git): * 2019-06-05
-
- and switch-case branches.
Buffer allocation optimization using `ALLOCA_N` would be the main
benefit of patch. It eliminates the O(N) buffer extensions.
It also reduces the number of branches using escape table like
https://mattn.kaoriy...