Activity
From 10/31/2018 to 11/06/2018
11/06/2018
-
11:50 PM Revision 92e9f615 (git): Fix build_os:host_os pair
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65586 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:36 PM Feature #14145: Proposal: Better Method#inspect
- It may be possible to procify the arguments to self-contain them without really disturbing their integrity. `method(:name)` already returns a proc, so would it be wholly unexpected that the arguments may do the same?
Thinking out loud... -
11:18 PM Feature #15286 (Rejected): Proposal: Add Kernel.#expand(*args)
- This is a suggestion for Hash shorthand.
* [add support for hash shorthand](https://bugs.ruby-lang.org/issues/15236)
`Kernel.#expand(*args)` is expand `local variable` and `method` to Hash.
`*args` is method or local variable names.... - 10:56 PM Revision ca2e5225 (git): * 2018-11-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65585 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:55 PM Revision 9c40a954 (git): Revert "thread.c (rb_wait_for_single_fd): no point initializing pollfd.revents"
- It may cause an access to uninitialized variables.
The call to ppoll will set the `revents` field, but ppoll is not always
called because it is in the guard `!RUBY_VM_INTERRUPTED(th->ec)`.
This issue was found by Coverity Scan.
git-svn-... -
09:20 PM Bug #15285 (Closed): lambda return behavior regression from #14639
- The change in ea15ceddbef2cc4c459c1ad5796e43ae9fa2cbf1 to use rb_yield_force_blockarg changes the behavior of returns called inside a passed lambda function. In 2.5.1 and below, including before the enum.c change, the attached script wo...
-
08:47 PM Revision e6bf368c (git): Removed VCR cassettes files for reducing package size.
- [Bug #14219]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65583 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:35 PM Feature #15281: Speed up Set#intersect with size check.
- > we can do that as Sets are ordered
IMO if they are, it's an implementation detail that you shouldn't rely on. Also there's more room to optimize unordered sets.
if you need an ordered (or indexed?) set, it should be a subclass th... -
-
03:52 PM Bug #15282: Segfault (null pointer dereference) in variable.c iv_index_tbl_make
- ruby_2_5 r65582 merged revision(s) 65554.
-
03:52 PM Feature #8781 (Closed): Use require_relative() instead of require() if possible
-
- Don't set throw data as cause [Bug #15282]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@65582 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:48 PM Bug #15268: Solarisでtest/drb/test_drbssl.rbが落ちる
- これrubyciのLinux Armv7でも同様の問題が出ていたので、Solaris依存ではない気もしています
-
- ruby_2_5 r65581 merged revision(s) 65460.
-
- parse.y: last location from bison
* parse.y (command): set the last location from the location
managed by bison, so that other nodes are not needed.
[ruby-core:89648] [Bug #15271]
git-svn-id: svn+ssh://ci.ru... -
- Oh, good catch, I should have thought of that...
I modified my script to check if the path with .rb actually exists and it came back with only these two exceptions. -
- ruby_2_5 r65580 merged revision(s) 65350.
-
- compile.c: fix peephole optimization
* compile.c (iseq_peephole_optimize): should `pop` before jump
instruction which succeeds to `newarray` of a literal object,
not after. [ruby-core:89536] [Bug #15245]
gi... -
- ruby_2_5 r65579 merged revision(s) 64786.
-
- parse.y: fix block passing with empty kwargs
* parse.y (arg_blk_pass): preceeding arguments node may be NULL when
an empty keyword argument hash splat is optimized away.
[ruby-core:88890] [Bug #15087]
git-sv... -
02:33 PM Feature #4475: default variable name for parameter
- shevegen (Robert A. Heiler) wrote:
> The first variant, aka the variant with "x", or any other single letter, including
> ...
"_" is special there. it doesn't cause Syntax Error
like you can do this `iterator.each {|a, _, c, _| }`
bu... -
02:15 PM Feature #4475: default variable name for parameter
- I also like the idea in principle, largely because I can relate to the idea. I encounter
this every now and then when writing ruby code, in that I want a simple way to access
a concept or argument.
For example, consider ruby code l... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65577 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:53 AM Revision bb2ee549 (git): workaround C++ism in ASAN header
- See also: https://travis-ci.org/ruby/ruby/jobs/451299690
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65576 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:19 AM Revision 3f97d88a (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65575 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- The only usage of rb_fiber_reset_root_local_storage() is from
ruby_vm_destruct(), where the object space is already terminated.
This `th->self` is not alive. Why not just use `th` itself.
See also: https://travis-ci.org/ruby/ruby/jobs/... -
- These APIs are much like <valgrind/memcheck.h>. Use them to
fine-grain annotate the usage of our memory.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65573 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Recently, I got the following warnings with build time.
```
parse.c:4720:14: warning: incompatible pointer types passing 'FILE *' (aka 'struct __sFILE *') to parameter of type 'struct parser_params *' [-Wincompatible-pointer-types]
... -
08:01 AM Revision dbd90b2d (git): mjit.c: don't use mutex before checking availability
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65572 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:45 AM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
- > Does that seem reasonable as a unit of work to you?
Perfect!
Note that we will release ruby 2.6 in Dec. If you finish (3) "Possibly rb_memerror...", it is easy to introduce. We can continue further improvement on next release. -
- I'm planning to use _one later, but it may be doubly registered by
switching `stop_worker_p` now and so we should not use _one for now.
Otherwise stale job may reject new job registration and
copy_cache_from_main_thread may wait forever... -
- * Makefile.in (mjit_config.h): expand MJIT_CC only if native
build, the path on cross compiling host is useless.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65570 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- -available region. reducing risk of SEGV in mjit_copy_job_handler() like
http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1446117
I'm not sure which exact part is causing "[BUG] Segmentation fault at 0x0000000000000008"
on `(mjit_copy... -
- * Makefile.in (mjit_config.h): convert MJIT_CC to Windows path on
mingw.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65568 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thank you! You are completely right.
applied at r65567 (I forget to add ticket reference on commit log).
-
- When loading iseq from binary while a TracePoint is on, we need to
recompile instructions to their "trace_" variant. Before this commit
we only recompiled instructions in the top level iseq, which meant
that TracePoint was malfunctioning... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65565 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- In these functions we are intentionally reading memory address
not owned by us. These reads should not be diagnosed.
See also [Bug #8680]
See also https://travis-ci.org/ruby/ruby/jobs/451202718
git-svn-id: svn+ssh://ci.ruby-lang.org... -
04:14 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- normalperson (Eric Wong) wrote:
> Do you have any historical info about the pass/fail rate of these tests in parallel?
Yes. Below is a summary of all builds from r64892 2018-10-01 thru r65558, except TestJIT. I assume TestIO & Tes... -
01:03 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
- Greg.mpls@gmail.com wrote:
> The above patch (v5) passed when added to:
>
> ruby 2.6.0dev (2018-11-06 trunk 65555) [x64-mingw32]
>
> It's not uncommon for a few tests to fail during parallel testing, but normally all pass on retr... -
- @normalperson Eric,
The above patch (v5) passed when added to:
ruby 2.6.0dev (2018-11-06 trunk 65555) [x64-mingw32]
It's not uncommon for a few tests to fail during parallel testing, but normally all pass on retry. It occurs wh... -
- * Makefile.in (mjit_build_dir.so): separate MJIT_BUILD_DIR to
eliminate the feature for test-all after installation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65563 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * Makefile.in (mjit_config.h): expand MJIT_CC_COMMON path to
mitigate potential security risks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65562 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.ac (DLDSHARED): `.dylib` (created by `-dynamiclib`)
and `.bundle` (created by `-dynamic -bundle`) on macOS are
different. `LIBRUBY_LDSHARED` should be the former always.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... - 03:18 AM Revision f740687e (git): Fixed compile error introduced at r65558
- * internal.h (ATTRIBUTE_NO_ADDRESS_SAFETY_ANALYSIS): of course, parens around
function signature in its definition is syntax error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65560 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I remember this configuration unveiled several bugs before.
Better check it occasionally.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65559 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Availability of attributes are checked in configure these days,
rather than compiler macros. Also
__attribute__((no_address_safety_analysis)) is considered
deprecated in both GCC and Clang. Use the current best practice
if available. ... -
- Forgot this line, sorry!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65557 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Inspired by [GH-1984], let us add some tests that run only
once a day. These configurations are either slow to compile
or slow to run. But I think they are worth done occasionally.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@6... -
01:21 AM Feature #15236: add support for hash shorthand
- blakewest (Blake West) wrote:
> Hi all,
> ...
osyo (manga osyo) wrote:
> hi, blakewest.
> ...
I like this :+1:
`{ a, b, c }` looks a bit cleaner to me, probably because of my familiarity with es6 syntax, so it require less conte...
11/05/2018
-
- > https://bugs.ruby-lang.org/issues/14968
Updated patch against r65553 with non-blocking socket support:
https://80x24.org/spew/20181105231324.24080-1-e@80x24.org/raw
Greg: It should be hiding errors for Win32 users, but I can'... -
- Applied in changeset trunk|r65554.
----------
Don't set throw data as cause [Bug #15282] -
04:36 PM Bug #15282 (Closed): Segfault (null pointer dereference) in variable.c iv_index_tbl_make
- Reproducer and crash:
~~~
jtruba@dev118:~/rubies/ruby-trunk$ ./ruby -e 'END{n}; END{return}'
-e: unexpected return
-e:1: [BUG] Segmentation fault at 0x0000000000000018
ruby 2.6.0dev (2018-10-31 trunk 65474) [x86_64-linux]
-- Cont... - 11:06 PM Revision cc508b54 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65555 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65554 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:56 PM Revision c076d600 (git): thread.c (rb_wait_for_single_fd): no point initializing pollfd.revents
- poll(2) and ppoll(2) implementations need to check and write to
.revents on the initial scan, anyways. So any poll/ppoll call
which returns a positive result can be expected to have an
initialized .revents value.
git-svn-id: svn+ssh://... - 05:27 PM Revision de753720 (git): * 2018-11-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65552 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * mjit.c (init_header_filename): sticky-mode directory probably
would be less unsafe even if it is not owned.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65551 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- (I think it may be easier to file a separate issue for the predicate methods,
such as Method#public?, Method#protected? or Method#private?).
Kaneko Yuichiro added the issue to the next upcoming developer meeting. Let's
see to the up... -
12:40 AM Feature #11689: Add methods allow us to get visibility from Method and UnboundMethod object.
- Oh, sorry. I missed where you were looking for an example before. Here's a good one from the popular activesupport gem: [here](https://github.com/rails/rails/blob/c823f9252be2552c65bb1370ccf42a14de461439/activesupport/lib/active_support/...
- 08:02 AM Revision 62ebf355 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65550 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * struct.c: should not use `RSTRUCT_CONST_PTR` with method dispatch
because pointers can be obsolete after method dispatch. `rb_equal()`
and so on can dispatch Ruby's methods.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65549... -
07:01 AM Revision 972cf8c9 (git): Fix up r65505 [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65548 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65547 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65546 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65545 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65544 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:14 AM Feature #14836 (Closed): Method to return first/last lineno/column of Proc
- Applied in changeset trunk|r65542.
----------
Implement `RubyVM::AST.of` [Feature #14836] - 02:14 AM Revision 5164e2e4 (git): * expand tabs.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65543 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65542 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65541 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * [Feature #11689] Add methods allow us to get visibility from Method and UnboundMethod object. (yui-knk)
* I want to introduce this feature to help meta programming. I'd like to hear opinions from other committers.
11/04/2018
-
- Thanks for your comment.
Can you show me the use cases where predicate methods are useful?
I think these predicate methods can be implemented by using `#visibility` method, so these predicate methods should not be needed as core features. -
- https://travis-ci.org/ruby/ruby/jobs/450505006
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65540 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
03:39 PM Revision 8b8c374c (git): Fix RubyGems extension build failure after r65470
- Port of upstream patch https://github.com/rubygems/rubygems/pull/2457
Since r65470 (Upstream: https://github.com/rubygems/rubygems/pull/2441),
builds of extension gem had always failed under really_verbose mode.
git-svn-id: svn+ssh://c... -
- > I imagine that the need of calling at_exec is rare though
I think something similar could be said about at_exit. While I
think it is fine that it exists, I found that in larger projects
it can be quite annoying if some other proje... - 03:14 PM Revision 052e45f1 (git): * 2018-11-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65538 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65537 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65536 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65535 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:46 AM Revision 2c62b3fb (git): hash.c: [DOC] add docs for ENV.{filter,filter!}
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65534 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65533 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65532 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65531 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65530 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65529 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65528 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65527 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:01 AM Misc #15007: Let all Init_xxx and extension APIs frequently called from init code paths be considered cold
- ko1 (Koichi Sasada) wrote:
> I agree to introduce cold attribute (I have no idea about the naming).
> ...
Yes, I agree - in retrospect `rb_define` functions would affect startup time, especially for very large Rails applications. I was... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65526 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65525 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Sorry for laziness.
What about https://github.com/nobu/ruby/pull/new/feature/15066-Complex-API ?
- 01:14 AM Revision 356a73e7 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65524 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * It update bundler 2 mode to bundler 3.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65523 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * complex.c (rb_dbl_complex_polar_pi): suffixed with _pi to
clarify that `ang` is not radian, but multiplied by PI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65522 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:08 AM Feature #15281: Speed up Set#intersect with size check.
- marcandre (Marc-Andre Lafortune) wrote:
> I'd be enclined to say that Set should be officially ordered, even if "mathematically" speaking that doesn't make sense. I'm assigning this to Matz.
I'd be inclined to say that Set should b...
11/03/2018
-
- I agree to introduce cold attribute (I have no idea about the naming).
`rb_bug` or `rb_warn` (etc) should be cold functions because they should not be called.
However, I'm not sure `rb_define_...` and so on because it can affect st... -
- * Makefile.in (CC_WRAPPER): use the wrapper to suppress warnings
by Apple's broken packages when linking in the toplevel
directory.
* configure.ac (CC_WRAPPER): separate from CC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65520 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:08 PM Revision 7b845212 (git): * 2018-11-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65519 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- it seems ssl.close doesn't cause EOFError on client side, but just skip
because it breaks test-all.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65518 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby-core@marc-andre.ca wrote:
> normalperson (Eric Wong) wrote:
> > Would this work for subprocesses? (system, spawn, ``,
> > popen, ...)
>
> I'm not sure I understand the question. `exec` effectively
> terminates the Ruby pro... -
- normalperson (Eric Wong) wrote:
> Would this work for subprocesses? (system, spawn, ``, popen, ...)
I'm not sure I understand the question. `exec` effectively terminates the Ruby process although the `at_exit` callbacks are not call... -
- For `lib/racc/parser.rb` I reverted this in r65514 for the require of `racc/cparse.so` (similar to r65511 for `cgi/escape`).
Possibly there might be other C extensions that are required from within `/lib`, where require_relative would... -
- Applied in changeset trunk|r65511.
----------
lib/cgi/util.rb: use require
* lib/cgi/util.rb: reverted r65505. require_relative does not
work for cgi/escape.so, as extension libraries are placed in
other directories than ruby libr... -
- RGBD (Oleg Zubchenko) wrote:
> > Set implements a collection of unordered values with no duplicates. This is a hybrid of Array's intuitive inter-operation facilities and Hash's fast lookup.
Good point.
Note that this documentation... -
05:10 PM Feature #15281: Speed up Set#intersect with size check.
- marcandre (Marc-Andre Lafortune) wrote:
> Thanks for the patch.
> ...
Where in the documentation can I read that?
[this](https://ruby-doc.org/stdlib-2.5.3/libdoc/set/rdoc/Set.html#method-i-to_a) says order is uncertain. I thought it... -
- Thanks for the patch.
Sadly, I don't think we can do that as `Set`s are ordered. That optimization would change the order of the resulting `Set` in some cases. -
- Current implementation computes set intersection s1 & s2 in O(s2.size) time.
It can be reduced to O([s1.size, s2.size].min) time.
Additional speedup comes from using #each instead of #do_with_enum.
See files attached for benchmark... -
- This seems to only affect `bundler`, while `bundle` is working fine. May be similar to `-rubygems` and `-rrubygems`...
-
-
- Something may be amiss with the addition of bundler and `make install`, as `bundle(r) version` is not working. Previously, I installed the bundler gem, and all was fine...
If it's any help, the ruby-loco 7z file (ruby_trunk.7z) is av... -
-
05:48 AM Feature #14151: Make Matrix#[]= public method
- It's been merged and issue can be closed now :)
-
- takashikkbn@gmail.com wrote:
> I close this ticket. Please file another ticket if you work on
> moving to event-based MJIT worker.
Thanks, but I don't know if it can happen in time for 2.6 :<
Judging by how often processes are s... -
- The CIs have been stable since r65495. I think this issue seems to be fixed now. Thank you so much!
I close this ticket. Please file another ticket if you work on moving to event-based MJIT worker. -
- * It enabled `USE_BUNDLER_FOR_GEMDEPS` for using gemdeps of rubygems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65517 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- for integer types
Close https://github.com/ruby/ruby/pull/2001
Co-Authored-By: methodmissing <lourens@methodmissing.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65516 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * internal.h: expose `rb_ary_detransient`. I'm not sure why there are
no many troubles without this patch...
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65515 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/racc/parser.rb: reverted r65505. require_relative does
not work for racc/cparse.so, as extension libraries are placed
in other directories than Ruby libraries.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65514 b2dd03c8-... -
- * hash.c (RHASH_ARRAY_BOUND_RAW): should be unsigned as well as
RHASH_ARRAY_SIZE_RAW.
* hash.c (find_entry): return unsigned for the consistency with
RHASH_ARRAY_SIZE and RHASH_ARRAY_BOUND.
git-svn-id: svn+ssh://ci.ruby-lang.org/ru... -
- Applied in changeset trunk|r65512.
----------
internal.h: RHASH_ARRAY_SIZE_RAW value is unsigned
and get rid of warnings. [ruby-core:89688] [Bug #15279] -
- When trying to compile the latest version of Ruby, I get a lot of warnings such as the following:
```
compiling array.c
In file included from transient_heap.h:12:0,
from array.c:21:
array.c: In function ‘rb_ary_un... -
- and get rid of warnings. [ruby-core:89688] [Bug #15279]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65512 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Sorry, I've missed filling the Backport.
-
- * lib/cgi/util.rb: reverted r65505. require_relative does not
work for cgi/escape.so, as extension libraries are placed in
other directories than ruby libraries. [Bug #15206]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65511... -
04:20 AM Bug #15278 (Closed): Refinements don't work well with Forwardable
- It's intentional. Refinement is **lexical** overriding of methods. That means refined methods (e.g. `origin` in this case) are not called from delegators.
Matz.
-
12:06 AM Bug #15278 (Closed): Refinements don't work well with Forwardable
- Refined methods become unreachable when called through def_delegator.
```ruby
require "forwardable"
module URIExtensions
refine URI::Generic do
def authority
port_string = port == default_port ? nil : ":#{port}"
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65510 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/02/2018
-
- Applied in changeset trunk|r65509.
----------
Added bundler as default gems. Revisit [Feature #12733]
* bin/*, lib/bundler/*, lib/bundler.rb, spec/bundler, man/*:
Merge from latest stable branch of bundler/bundler repository and
... -
- * bin/*, lib/bundler/*, lib/bundler.rb, spec/bundler, man/*:
Merge from latest stable branch of bundler/bundler repository and
added workaround patches. I will backport them into upstream.
* common.mk, defs/gmake.mk: Added `tes... -
10:28 PM Revision 7deb3777 (git): common.mk: --no-ri and --no-rdoc options were removed
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65508 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- ruby-core@marc-andre.ca wrote:
> https://bugs.ruby-lang.org/issues/15277
Would this work for subprocesses? (system, spawn, ``, popen, ...)
(if so, it would defeat vfork optimization we do under Linux)
> There's currently no easy... -
- There's currently no easy way to have code executed before a subsequent call to `exec`. One has to monkey-patch the builtin method.
I'd like to propose a new method `at_exec` that would be very similar to `at_exit`, except that the ca... -
- I would like to use Hash shorthand in the following cases.
```ruby
describe User do
let(:id) { ... }
let(:name) { ... }
let(:age) { ... }
let(:registered_at) { ... }
# I want to hash shorthand!
let(:user) { User.new(id: id, age:... -
- hi, blakewest.
I proposaled it.
https://bugs.ruby-lang.org/issues/14973
I need to consider an implementation that does not use `#eval`. -
08:29 PM Feature #15236: add support for hash shorthand
- Hi all,
I've really wanted a feature like this for a long time. I find myself often using named arguments, which I love for the clarity. But then the callers often have variables of the same name as the parameter name, making it more v... -
07:31 PM Bug #15087: Segmentation fault with splat and block
- This is **still crashing** in Ruby 2.5.3. Is this going to ever be fixed in Ruby 2.5 series?
- 05:52 PM Revision eda970cf (git): lib/matrix.rb: Make Matrix & Vector mutable. Add #[]=, #map!.
- Adapted from patch by Grzegorz Jakubiak. [#14151] [Fix GH-1769] [Fix GH-1905]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65507 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:52 PM Revision b9d42af0 (git): lib/*: Prefer require_relative over require, remove explicit extension
- [#15206] [Fix GH-1976]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65506 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:52 PM Revision e859e668 (git): lib/*: Prefer require_relative over require.
- [#15206] [Fix GH-1976]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65505 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:52 PM Revision c8c66bcf (git): lib/matrix: Use consistent style
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65504 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:52 PM Revision 5ba9a950 (git): lib/matrix: use consistent style
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65503 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:52 PM Revision a1f22c4f (git): lib/matrix.rb: Alias antisymmetric? with skew_symmetric?
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65502 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:51 PM Revision 5a5bf993 (git): * 2018-11-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65501 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 05:51 PM Revision 55961ac9 (git): Revert "Matrix: Add #reflexive? method. [Fix GH-1730]"
- This reverts commit 19fe6552c456e41c0b85816806399ca1609255c0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65500 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- it breaks armv7 CI.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65499 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- and show trunk branch's build status for travis as well
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65498 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:40 AM Revision 2337f0f3 (git): * 2018-11-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65497 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- When we return there, `unit` is already freed.
This is detected by coverity scan.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65496 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Closed at r65461
-
- What name would you suggest? Avdi mentioned the name #merge_path - is this the name
that you suggest? (I ask specifically because finding a good name is not always
easy. And in the proposal no specific name was mentioned as such.)
11/01/2018
-
03:59 PM Bug #15276 (Closed): URI.join behaviour is unintuitive
Hello,
I've been bitten by issue #10075, I actually expected a different behaviour from ::join. It doesn't IMHO resepect the "principle of least suprise".
I agree with avdi who suggests to deprecate ::join and replace it with a m...-
- OK. Preview3's release notes is not gonna be changed so much, but I'll revisit that from user's perspective at preview4, rc1 or the actual release.
Previous releases didn't include that just because it had been a super early stage and... -
- This is a request about documentation, with the specific focus on the new ruby
jit.
The "end user" perspective here means how an average ruby user may look at the
jit; say, someone who may have been using ruby for some time, but may... -
- Thanks for your continuous effort on it. We saw another failure on rb_f_system http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1440570 on r65493, but I hope timer solves the issue as well on r65495.
-
- I wrote:
>>http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1437559
> OK, I think it's the lack of locking/atomics around
> checking waitpid_state.ret and I introduced the bug
> in commit 9d4027b50334ef804f6f138fba1d342fe188826b
... -
- I tried to apply an easy fix similar to `rb_f_system`'s one to `rb_f_spawn` but I got `Errno::ECHILD: No child processes`. So,
> > Made r65465 which should fix rb_f_system.
> ...
I'll just wait for this one for deadlock issue by `rb... -
- Btw thanks to leave compact_units in it. It looks like it's already valuable for cleaning up units by free_list on mjit_unit.
-
- Cool, r65475 looks working on trunk-mjit and trunk-mjit-wait CIs so far. Thanks.
-
- It's intentional. Refinements are only seen from the lexical scope. That means reflection methods does not see any methods defined only in refinements.
Matz.
- 02:10 PM Revision 5de7b3b4 (git): thread_pthread.c (native_ppoll_sleep): new eventfd (or pipe) for ubf
- Relying on ubf_select + ubf_list for main thread is not
guaranteed to wake a process up as it does not acquire
sigwait_fd and all other threads may be sleeping.
native_cond_sleep and the sigwait_fd path are immune to TOCTOU
issues, but n... -
- Failure seems no longer reproductive recently...
Also I wrote a comment about this complicated test matrix and improved
parallelism a little more again.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65494 b2dd03c8-39d4-4d8f-98ff-82... - 08:53 AM Revision cc7fcbbc (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65493 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/ruby.h: intrdocue `USE_TRANSIENT_HEAP` macro
to enable/disable transient heap.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65492 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65491 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:59 AM Feature #14836: Method to return first/last lineno/column of Proc
- Great work!!
What I want is this!
If ruby-trunk merges this patch, I will try to use. -
- If you use location information of proc to get AST nodes, I feel adding class method to AST module which receives proc and return AST nodes directly is useful.
What do you think about it?
For example:
```ruby
def a(&block)
nod... - 07:49 AM Revision 57097949 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65490 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- for now. Investigating.
https://app.wercker.com/ruby/ruby/runs/mjit-test2/5bda979a191eda000655a8d2?step=5bda9fe4591ca80007653f64
wercker.yml: improve parallelism again.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65489 b2dd03c8-3... -
07:42 AM Bug #14253: CSV.generate doesn't wrap a string anymore
- Could you consider backporting this patch to 2.5?
The following code that generates a CSV file with a BOM does not work correctly with Ruby 2.5.
~~~ ruby
require 'csv'
csv_str = "\uFEFF" # BOM
CSV.generate(csv_str) do |csv|
c... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65488 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Fix GH-1999]
From: Takayuki Matsubara <takayuki.1229@gmail.com>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65487 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mjit-test2 is taking more time now.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65486 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:19 AM Revision c4cc4725 (git): Remove wrong spec.
- [Bug#15067] [ruby-core:88828]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65485 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65484 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- because the name "-wait" is no longer distinguishing these pipelines
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65483 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65482 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65481 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It seems to fail randomly:
https://ci.appveyor.com/project/ruby/ruby/builds/19963142/job/8gaxepksa0i3b998
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65480 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * hash.c (linear_copy): remember a hash object to mark pointing objects.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65479 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Currently TracePoint enablement may cancel all JITs. So for now,
separating test executions would reveal more failures.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65478 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- In https://bugs.ruby-lang.org/issues/14867#note-98, it's considered
useless at once. So I emphasized the necessity of it in the comment.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65477 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/31/2018
- 11:55 PM Revision 1fb934e2 (git): * 2018-11-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65476 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 11:55 PM Revision 143776f6 (git): mjit: get rid of rb_mjit_unit_node and use ccan/list
- rb_mjit_unit can either exist in unit_queue or active_units, but
not both. This will make state transitions for event-based MJIT
process management easier.
v2: recheck unit->iseq after GC wakeup
The iseq may be GC-ed while we were wai... -
- takashikkbn@gmail.com wrote:
> Looks good. Please commit that first.
Actually, I'm pretty sure that extra check is a noop because
unit_queue is a GC mark root. The difference is ccan/list
change removes from unit_queue during get... -
- Looks good. Please commit that first.
-
- takashikkbn@gmail.com wrote:
> r65473 didn't work either. So I reverted that again on r65474.
>
> I think doing 2 separate complicated things are hard like this, so the refactoring change (migration to ccan) and behavior change ("rb... -
- r65473 didn't work either. So I reverted that again on r65474.
I think doing 2 separate complicated things are hard like this, so the refactoring change (migration to ccan) and behavior change ("rb_mjit_unit can either exist in unit_q... -
- > I'm too tired to wait for local tests to finish a few times right now...
Take your time!
> ...
Thanks, that looks good for the fix of previous SEGV. To avoid our conflict, I re-applied your work with that fix on r65473. I'm watch... -
- > > Sorry, I missed your message about in_jit. Trying ccan/list now
> > as r65468
>
> Reverted r65468 for now because all MJIT CIs failed (sorry, was
> tired and needed to go afk for a bit)
Possible fix on top of r65468 (if unr... -
- > Sorry, I missed your message about in_jit. Trying ccan/list now
> as r65468
Reverted r65468 for now because all MJIT CIs failed (sorry, was
tired and needed to go afk for a bit) -
- takashikkbn@gmail.com wrote:
> > ubf_select inside ruby_waitpid_locked is safe, but contention on vm->gvl.lock seems wrong. Made r65465 which should fix rb_f_system.
> >
> > Also taking a look at native_ppoll_sleep for spawn;
>
> ... -
- > ubf_select inside ruby_waitpid_locked is safe, but contention on vm->gvl.lock seems wrong. Made r65465 which should fix rb_f_system.
> ...
Thanks for taking a look at them :)
> but I would feel more comfortable investigating issues... -
- > About #system, the way of deadlock seems to be changed after r65437:
> http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1437880
>
> Could you take a look at at least the last one? Is it fine to call `ubf_select` inside `rub... -
- By the way,
> holding vm->waitpid_lock across two Ruby method calls won't work.
first of all I may not need to do this, since just locking from fork/vfork to waiting_pids modification could work. I'll take a look at that part again. -
07:40 PM Bug #15274 (Closed): Reflection does not report methods defined only in refinements
- ~~~ ruby
class C
end
module M
refine C do
def foo
puts "C#foo in M"
end
end
end
using M
c = C.new
c.foo # prints "C#foo in M"
c.send :foo
p c.respond_to? :foo
p c.methods.include?(:foo)
p C.instanc... -
02:27 PM Bug #15273 (Closed): Ruby crashing after updating Mac OS to Mojave (10.14)
- I recently updated my Mac OS to Mojave.
Since then Ruby crashes repeatedly - giving Segmentation fault error.
Attached is the Error Report -
- This reverts commit ff5dc2cbbf9e7b67c8579ef166bf6a4755507304.
Deadlock: http://ci.rvm.jp/results/trunk-mjit@silicon-docker/1438883
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65474 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://bugs.ruby-lang.org/issues/14867#note-112
I wanna touch similar places. To avoid our conflict, let me merge Eric's patch earlier.
Let's watch trunk-mjit / trunk-mjit-wait CIs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65472 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:07 AM Bug #15262: WeakRef::RefError for object that is still in use
- The reference error doesn't appear when `WeakRef` is replaced by `_id2ref` like so:
```ruby
def self.start_adder(oid)
ObjectSpace._id2ref(oid).add
end
```
So it appears to be a bug in `ObjectSpace::WeakMap`. - 06:44 AM Revision dc8a744d (git): Revert "mjit: get rid of rb_mjit_unit_node and use ccan/list"
- This reverts commit c5177fa8464ac304547e384583f9c287e124d34a. r65468
Many CI failures like:
http://ci.rvm.jp/results/trunk-mjit-wait@silicon-docker/1438415
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65471 b2dd03c8-39d4-4d8f-98f... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65470 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- No automatic type promotion is expected for variadic arguments.
You have to do it by hand.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65469 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:02 AM Revision c5177fa8 (git): mjit: get rid of rb_mjit_unit_node and use ccan/list
- rb_mjit_unit can either exist in unit_queue or active_units, but
not both. This will make state transitions for event-based MJIT
process management easier.
[ruby-core:89654]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65468 b2dd... -
- Applied in changeset trunk|r65467.
----------
parse.y: last node of NODE_ARRAY
* parse.y (heredoc_dedent): manage the last node of NODE_ARRAY,
when concatenating dedented literals.
[ruby-core:89649] [Bug #15272] -
- * parse.y (heredoc_dedent): manage the last node of NODE_ARRAY,
when concatenating dedented literals.
[ruby-core:89649] [Bug #15272]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65467 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * variable.c (obj_ivar_set): remove '//' style comments pointed out by the
following build log: https://travis-ci.org/ruby/ruby/jobs/448551951
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65466 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:31 AM Revision 89aaf7db (git): thread_pthread.c (ubf_select): avoid deadlock on contention
- vm->gvl.lock can be held by another thread, we must not wait
on it when called by the MJIT worker thread when it migrates
work to another thread. ubf_select is designed to do retrying
anyways, so it has no obligation to wake up a timer ... -
- * hash.c: remove '//' style comments pointed out by the following
build log: https://travis-ci.org/ruby/ruby/jobs/448551951
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65464 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c (rb_raw_obj_info): fix type mismatch specified by the following
build log: https://travis-ci.org/ruby/ruby/jobs/448634481
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65463 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mame (Yusuke Endoh) wrote:
> `:r` means `.rb` and `:s` means `.so`, I guess :-)
If this information is kept, please make it easier to understand. :rb/:so or :'.rb'/:'.so' at a minimum.
-
- Seems it is failing to compile right now; make it mandatory
so that other devs can be aware of it.
Will revert this change once the source code gets stable.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65462 b2dd03c8-39d4-4d8f-98... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65461 b2dd03c8-39d4-4d8f-98ff-823fe69b080e