Activity
From 08/11/2016 to 08/17/2016
08/17/2016
-
11:55 PM Feature #12020: Documenting Ruby memory model
- > Koichi, would you be open to spend some time discussing it?
Sure! Other than my presentation time, I'll be happy to discuss about it.
Thanks,
Koichi -
09:03 AM Feature #12020: Documenting Ruby memory model
- I am going to RubyKaigi, I would be very interested to have a meeting face to face there to discuss this topic in depth. Koichi, would you be open to spend some time discussing it? Would anybody else be interested? Afaik Charles is not g...
-
09:08 PM Feature #8960: Add Exception#backtrace_locations
- Is there any way to re-raise an exception and propagate `backtrace_locations`? When I want to trap an exception and provide a different exception class and error message, I'm used to doing something like:
~~~ ruby
rescue => e
rais... -
07:32 PM Bug #12548: Rounding modes inconsistency between round versus sprintf
- Nobu: but then, default will still be inconsistent.
Maybe add a parameter and require libraries to supply it if they care? Then later we could change the default from :even to :closest or :biased or whatever we call the common roundin... -
02:54 AM Bug #12548: Rounding modes inconsistency between round versus sprintf
- I agree that round-even is preferable, but it introduces an incompatibility.
Some libraries, e.g., rexml, depend on the current behavior.
So I'm thinking an optional parameter to select rounding mode.
~~~ruby
2.5.round #=> 3... -
07:06 PM Bug #12685 (Closed): malloc error: pointer being freed was not allocated
- ruby crashed
- never seen that before
- should never happen
- looks serious to me
I'm using ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15] from macports
I was running rails in dev mode.
The bug happened while rel... -
06:19 PM Feature #12676: Significant performance increase, and code conciseness, for prime_division method in prime.rb
- By using a faster prime generator than the current one in prime.rb the performance for
the prime_division function can reach the desired 3x performance sought for Ruby 3 (3x3).
```
Timing comparisons for optimal method prime_divisio... -
- Applied in changeset r55952.
----------
skip failed gems
* tool/rbinstall.rb: skip gems which failed to build extensions.
[ruby-dev:49764] [Bug #12683] -
04:12 PM Bug #12683 (Closed): never be able to install trunk
- r55950 以降だと思いますが、bundleされているgemの拡張ライブラリがビルドできない場合、make installが失敗するのでruby自体がinstallできません。
- 05:36 PM Revision 23051126 (git): * 2016-08-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/rbinstall.rb: skip gems which failed to build extensions.
[ruby-dev:49764] [Bug #12683]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:12 PM Bug #12684 (Closed): Delegator#eql? missing
- There is some strange behavior because Delegator is missing an alias of #eql? to #==
```
2.3.1 :001 > s = 'test'
=> "test"
2.3.1 :002 > d = SimpleDelegator.new(s)
=> "test"
2.3.1 :003 > d.eql?(d)
=> false
2.3.1 :004 > d =... -
03:08 PM Bug #12353 (Open): Regression with Marshal.dump on ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]
- I found this backport broke ActiveSupport::Duration of ActiveSupport 4.1.x:
```
% ruby -e '
gem "activesupport", "4.1.16"
require "active_support/time"
10.days'
/PREFIX/lib/ruby/gems/2.3.0/gems/activesupport-4.1.16/lib/active_sup... -
- * gems/bundled_gems (tk): bump up to 0.1.1.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r55950.
----------
gem extensions
* ext/extmk.rb: build gem extensions into separate directories
* tool/rbinstall.rb: install pre-built gem extension files gem
extension directories. [ruby-core:76931] [Bug #12681] -
- * ext/extmk.rb: build gem extensions into separate directories
* tool/rbinstall.rb: install pre-built gem extension files gem
extension directories. [ruby-core:76931] [Bug #12681]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@559... -
01:15 PM Feature #6783: Infinite loop in inspect, not overriding inspect, to_s, and no known circular references. Stepping into inspect in debugger locks it up with 100% CPU.
- I would like to reopen discussion on this subject. I think the default implementation of #inspect tends to hang/explode for complex/large object graphs with lots of cycles. In 10 years of programming Ruby I ran into this twice and had to...
-
- * lib/mkmf.rb (create_makefile): use TARGET_SO consistently.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55949 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:28 AM Bug #8837 (Rejected): net/telnet: strange implementation
- net-telnet has been extracted https://github.com/ruby/net-telnet
-
- net-telnet has been extracted https://github.com/ruby/net-telnet
-
- net-telnet has been extracted https://github.com/ruby/net-telnet
-
- xmlrpc has been extracted http://github.com/ruby/xmlrpc
-
- xmlrpc has been extracted http://github.com/ruby/xmlrpc
-
01:40 AM Bug #12682 (Rejected): Hash#flatten(level) does not recursively flatten inner hashes.
- The documentation of `Array#flatten` is pretty clear:
"...That is, for every element that is an **array**, extract its elements into the new array."
So it follows the documentation and would create massive incompatibilities to change! -
- rdoc depends on json. And gem authors rely on json of stdlib.
ref. http://www.mikeperham.com/2016/02/09/kill-your-dependencies/
I gave up to extract json from stdlib. -
- tk has been extracted https://github.com/ruby/tk from stdlib
-
- tk has been extracted https://github.com/ruby/tk from stdlib
- 01:13 AM Revision 62565598 (git): * 2016-08-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/make-snapshot: remove deprecated environment variable GZIP
to its command line arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/16/2016
-
08:36 PM Bug #12682 (Rejected): Hash#flatten(level) does not recursively flatten inner hashes.
- ~~~
pry
[1] pry(main)> x = {a: {b: 1, c:2}}
=> {:a=>{:b=>1, :c=>2}}
[2] pry(main)> x.flatten(1)
=> [:a, {:b=>1, :c=>2}]
[3] pry(main)> x.flatten(2)
=> [:a, {:b=>1, :c=>2}]
~~~ -
- It looks like floats are rounded via numeric.c, using the flo_round function. That definitely does *not* use round-even. Maybe it should? It already implements a rounding function, so it shouldn't be too hard to implement round-even.
... -
- * tool/make-snapshot (package): propagate UNICODE_VERSION to make
snapshot from the parent make.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * tool/enc-unicode.rb (data_foreach): open in binary mode because
Unicode 9.0.0 contains non-ascii characters.
* template/unicode_norm_gen.tmpl: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55945 b2dd03c8-39d4-4d8f-98ff-8... -
12:43 PM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- Right, sorry for the diversion.
I agree with Marc-Andre, I do not find map_values confusing.
After all we want to take a Hash, change/map its values to something else and return the resulting Hash.
I guess matz meant hash.values.m... -
12:24 PM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- Can we stick to the name of #map_v here? I don't think it's wise to expand the front line in this thread.
-
- Yukihiro Matsumoto wrote:
> `map_values`, `map_keys` and `map_pairs` seems consistent.
> ...
What would be the semantics?
For simple cases there is already Enumerable#to_h for an enumeration of pairs:
~~~ ruby
(1..4).each_cons(2).... -
- >Also, the "gem install tk" does not build the extension, so that is another source of possible issues.
I missed configuration of tk.gemspec. It's fixed at tk-0.1.1 probably. Can you confirm it? -
12:07 PM Bug #12681 (Closed): Gemfied tk issue
- First of all, thank you for moving Tk into independent gem.
Nevertheless, I have one concern. So far, you left the tcltklib.so and tkutil.so under ruby lib directory. This is unfortunately major flaw, since the Tk gem is not one of th... -
- * common.mk (UNICODE_HDR_DIR): make unicode header directory.
[ruby-core:76879] [Bug #12677]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_2 r55943 merged revision(s) 53424,55509.
-
03:00 AM Bug #12517: def_delegators broken on ruby-head?
- ruby_2_3 r55917 merged revision(s) 53424,55509.
- 12:14 PM Revision 81d5b699 (git): merge revision(s) 53424,55509: [Backport #12517]
- * test/coverage/test_coverage.rb: ignored test when enabled to coverage.
It lead to crash with `make test-all`.
* compile.c (ADD_TRACE): ignore trace instruction on non-positive
line.
* parse.y (cove... -
- * common.mk (UNICODE_HDR_DIR): separate unicode header files from
unicode data files. [ruby-core:76879] [Bug #12677]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_2 r55941 merged revision(s) 55563.
-
- ruby_2_3 r55916 merged revision(s) 55563.
- 12:02 PM Revision 4142e34e (git): merge revision(s) 55563: [Backport #12498]
- * lib/uri/mailto.rb (initialize): RFC3986_Parser#split sets opaque
only if the URI has path-rootless, not path-empty.
[ruby-core:76055] [Bug #12498]
patched by Chris Heisterkamp <cheister@squareup.com>
git... -
- ruby_2_2 r55940 merged revision(s) 55410.
- 12:01 PM Revision 673a8b48 (git): merge revision(s) 55410: [Backport #12488]
- * ext/date/date_strftime.c (date_strftime_with_tmx): reject too
large precision to get rid of buffer overflow.
reported by Guido Vranken <guido AT guidovranken.nl>.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branch... -
- ruby_2_2 r55939 merged revision(s) 55562.
- 11:58 AM Revision e6230985 (git): merge revision(s) 55562: [Backport #12454]
- * regcomp.c (noname_disable_map): don't optimize out group 0
Ruby's Regexp doesn't allow normal numbered groups if the regexp
has named groups. On such case it optimizes out related NT_ENCLOSE.
But even on t... -
- ruby_2_2 r55938 merged revision(s) 55233.
- 11:57 AM Revision 6fa7bf5e (git): merge revision(s) 55233: [Backport #12446]
- * missing/crypt.c: fix size macros to use configured values
for platforms long is larger than 32bit.
[ruby-core:75792] [Bug #12446]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55938 b2dd03c8-39d4-4... -
- ruby_2_2 r55937 merged revision(s) 55047.
- 11:55 AM Revision a1af7155 (git): merge revision(s) 55047: [Backport #12441]
- * ext/openssl/ossl_bn.c (try_convert_to_bnptr): Extracted from
GetBNPtr(). This doesn't raise exception but returns NULL on error.
(GetBNPtr): Raise TypeError if conversion fails.
(ossl_bn_eq): Implement BN#... -
- ruby_2_2 r55936 merged revision(s) 55181.
- 11:39 AM Revision b76d7aff (git): merge revision(s) 55181: [Backport #12431]
- * transcode.c (str_transcode0): scrub in the given encoding when
the source encoding is given, not in the encoding of the
receiver. [ruby-core:75732] [Bug #12431]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche... -
- ruby_2_2 r55935 merged revision(s) 55175.
- 11:33 AM Revision ef62988e (git): merge revision(s) 55175: [Backport #12428]
- * ext/openssl/ossl_pkey_dh.c (ossl_dh_compute_key): Check that the DH
has 'p' (the prime) before calling DH_size(). We can create a DH with
no parameter but DH_size() does not check and dereferences NULL.
[r... -
- ruby_2_2 r55934 merged revision(s) 55115.
- 11:28 AM Revision b9892d1b (git): merge revision(s) 55115: [Backport #12411]
- * transcode.c (enc_arg, str_transcode_enc_args, econv_args):
remove volatile, and add GC guards in callers.
[ruby-core:75664] [Bug #12411]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55934 b2dd03c8... -
- * common.mk (UNICODE_HDR_DIR): directory for unicode headers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55933 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:43 AM Bug #12680 (Closed): Please backport memory leak fixes in ext/openssl
- The following methods have an issue of memory leak:
- OpenSSL::X509::ExtensionFactory#create_ext
- OpenSSL::X509::ExtensionFactory#config=
- OpenSSL::X509::Extension#oid=
- OpenSSL::X509::Extension#value=
- OpenSSL::X509::Attribut... -
- * common.mk (MAKE_ENC): arguments for enc.mk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:11 AM Bug #12679 (Closed): Failed to build ruby on aarch64 with musl libc and gcc 6
- ~~~
verconf.h updated
compiling loadpath.c
encdb.h updated
linking static-library libruby-static.a
making srcs under enc
make[1]: Entering directory '/home/clandmeter/aports-aarch64/main/ruby/src/ruby-2.3.1'
make[1]: Nothing to be... -
- ruby_2_2 r55931 merged revision(s) 55434.
- 06:03 AM Revision fc5238a4 (git): merge revision(s) 55434: [Backport #12401]
- * common.mk (build-ext), ext/extmk.rb: use variable EXTENCS
different than ENCOBJS, to get rid of circular dependency.
build libencs when linking encodings statically.
[ruby-core:75618] [Bug #12401]
git-sv... -
- ruby_2_2 r55930 merged revision(s) 55705.
- 05:56 AM Revision caec808f (git): merge revision(s) 55705: [Backport #12345]
- * variable.c (rb_local_constants_i): exclude private constants
when excluding inherited constants too. [Bug #12345]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_2 r55929 merged revision(s) 55008.
- 05:53 AM Revision 0d09e1af (git): merge revision(s) 55008: [Backport #12342]
- * lib/drb/timeridconv.rb: don't use keeper thread. [Bug #12342]
* test/drb/ut_timerholder.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Testing with r55915, it appears to work now. Thx for the quick fix.
-
- Applied in changeset r55913.
----------
make-snapshot: save unicode headers
* tool/make-snapshot (package): save generated header files from
unicode data. [ruby-core:76879] [Bug #12677] -
- ruby_2_2 r55928 merged revision(s) 55380.
- 05:07 AM Revision 643ef237 (git): merge revision(s) 55380: [Backport #12255]
- * ext/json/lib/*.rb: Removed some comments. Because these are unnecessary
class description. [ci skip][Bug #12255][ruby-core:74835]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55928 b2dd03c8-39d4-4d8f-98ff-8... -
- ruby_2_2 r55927 merged revision(s) 55573.
- 05:06 AM Revision f4ace9b4 (git): merge revision(s) 55573: [Backport #12209]
- * pack.c (pack_pack): use union instead of bare variable to ease
optimizations and avoid assigning x87 floating point number.
[ruby-core:74496] [Bug #12209]
* pack.c (pack_unpack): ditto.
git-svn-id: svn+ss... -
- ruby_2_2 r55926 merged revision(s) 55797.
- 05:03 AM Revision b2248a00 (git): merge revision(s) 55797: [Backport #12645]
- * ext/socket/option.c, ext/socket/rubysocket.h (inet_ntop): share
the fallback definition. [ruby-core:76646] [Bug #12645]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55926 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_2 r55925 merged revision(s) 55729.
- 04:56 AM Revision eee441fd (git): merge revision(s) 55729: [Backport #12611]
- * vm.c (vm_set_main_stack): remove unnecessary check. toplevel
binding must be initialized. [Bug #12611] (N1)
* win32/win32.c (w32_symlink): fix return type. [Bug #12611] (N3)
* string.c (rb_str_split_m): s... -
- ruby_2_2 r55924 merged revision(s) 55613.
- 04:43 AM Revision be4b713d (git): merge revision(s) 55613: [Backport #12575]
- * thread.c (rb_wait_for_single_fd): Clean up fds.revents every time
before calling ppoll(2). [Bug #12575] [ruby-dev:49725]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_2 r55923 merged revision(s) 55731.
- 04:41 AM Revision 89594c03 (git): merge revision(s) 55731: [Backport #12610]
- * lib/webrick/httpservlet/cgihandler.rb (do_GET): delete HTTP_PROXY
* test/webrick/test_cgi.rb (test_cgi_env): new test
* test/webrick/webrick.cgi (do_GET): new endpoint to dump env
[ruby-core:76511] [Bug #126... -
- ruby_2_2 r55922 merged revision(s) 55726,55727.
- 04:39 AM Revision e4d36060 (git): merge revision(s) 55726,55727: [Backport #12609]
- * lib/rexml/attribute.rb (REXML::Attribute#to_string): Fix wrong
entry reference name of double quote.
[Bug#12609][ruby-core:76509]
Patch by Joseph Marrero. Thanks!!!
[Bug #12609][ruby-core:76509]
... -
- ruby_2_2 r55921 merged revision(s) 55663.
-
- ruby_2_3 r55919 merged revision(s) 55663.
- 04:36 AM Revision 8b440f54 (git): merge revision(s) 55663: [Backport #12583]
- * gc.c (gc_mark_roots): should mark the VM object itself to mark
singleton class of the VM object.
Before this patch, we only set mark bit for the VM object and
invoke mark function separately.
[Bu... - 04:31 AM Revision 36ecd731 (git): * lib/rubygems/package.rb: Fixed potential perms issue unpacking of
- gems on NFS. [Backport #12579]
* lib/rubygems.rb: bump version.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gc.c (gc_mark_roots): should mark the VM object itself to mark
singleton class of the VM object.
Before this patch, we only set mark bit for the VM object and
invoke mark function separately.
[Bu... -
- rubygems-2.4.x still failed tests on the upstream repository. I have no time for investigating it.
Please backport #12579 before this patch. -
- Current status?
-
- ruby_2_3 r55918 merged revision(s) 55523.
-
- * ext/digest/md5/md5ossl.h: Remove excess semicolons.
Suppress warning on Solaris with Oracle Solaris Studio 12.
[ruby-dev:49692] [Bug #12524]
* ext/digest/md5/md5cc.h: ditto.
* ext/digest/sha1/sha1c... -
- r55844 で対応済みなのでこちらは close します。
-
- tk was extracted to https://github.com/ruby/tk/pulls . Please submit your patch as pull request.
-
- tk was extracted to https://github.com/ruby/tk/pulls . Please submit your patch as pull request.
-
- tk was extracted to https://github.com/ruby/tk/pulls . Please submit your patch as pull request.
-
- tk was extracted to https://github.com/ruby/tk/pulls . Please submit your patch as pull request.
-
- tk was extracted to https://github.com/ruby/tk/pulls . Please submit your patch as pull request.
-
- tk was extracted to https://github.com/ruby/tk/pulls . Please submit your patch as pull request.
-
- tk was extracted to https://github.com/ruby/tk/pulls . Please submit your patch as pull request.
-
- tk was extracted to https://github.com/ruby/tk/pulls . Please submit your patch as pull request.
-
- tk was extracted to https://github.com/ruby/tk/pulls . Please submit your patch as pull request.
-
- * test/coverage/test_coverage.rb: ignored test when enabled to coverage.
It lead to crash with `make test-all`.
* compile.c (ADD_TRACE): ignore trace instruction on non-positive
line.
* parse.y (cove... -
- * lib/uri/mailto.rb (initialize): RFC3986_Parser#split sets opaque
only if the URI has path-rootless, not path-empty.
[ruby-core:76055] [Bug #12498]
patched by Chris Heisterkamp <cheister@squareup.com>
git... -
- * transcode.c: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55915 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:02 AM Revision dd04487e (git): * 2016-08-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * tool/make-snapshot (package): save generated header files from
unicode data. [ruby-core:76879] [Bug #12677]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:02 AM Bug #12670: Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- Line 5426 of gc.c at v2_3_1 https://github.com/ruby/ruby/blob/v2_3_1/gc.c#L5426 that is pointed by out.log, is about GC but r48239 is not include a change of GC, as I see.
r48239 may not be related... -
- It may be related to #10440 r48239, as `git bisect` shown.
08/15/2016
-
10:21 PM Bug #12678 (Closed): No way to set a timeout for TLS handshake when using Net::SMTP
- When establishing a connection to an SMTP server, Net::SMTP doesn't offer a way to specify a timeout for how long the TLS handshake should take.
In our production environment, this means we routinely see hangs under this callstack:
... -
09:11 PM Feature #12659: Readline: expose rl_char_is_quoted_p setting
- If I understand it correctly then you provide a wrapper that is currently not part of ruby readline module yes?
If so then I am in full support of this. -
- ruby_2_3 r55912 merged revision(s) 55581,55582,55880.
-
- * lib/net/http/generic_request.rb (write_header): A Request-Line must
not contain CR or LF.
* lib/net/http/generic_request.rb (write_header): A Request-Line must
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/r... -
- ruby_2_3 r55911 merged revision(s) 55579.
-
- * lib/net/ftp.rb (putline): raise an ArgumentError when
CR or LF is included in a line.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@55911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r55910 merged revision(s) 55410.
-
- * ext/date/date_strftime.c (date_strftime_with_tmx): reject too
large precision to get rid of buffer overflow.
reported by Guido Vranken <guido AT guidovranken.nl>.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branch... -
- ruby_2_3 r55909 merged revision(s) 55385,55390.
-
- * file.c (append_fspath): normalize directory name to be appended
on OS X. [ruby-core:75957] [Ruby trunk Bug#12483]
https://github.com/rails/rails/issues/25303#issuecomment-224834804
git-svn-id: svn+ssh://ci.ruby-l... -
- ruby_2_3 r55908 merged revision(s) 55562.
-
- * regcomp.c (noname_disable_map): don't optimize out group 0
Ruby's Regexp doesn't allow normal numbered groups if the regexp
has named groups. On such case it optimizes out related NT_ENCLOSE.
But even on t... -
- ruby_2_3 r55907 merged revision(s) 55233.
-
- * missing/crypt.c: fix size macros to use configured values
for platforms long is larger than 32bit.
[ruby-core:75792] [Bug #12446]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@55907 b2dd03c8-39d4-4... -
- ruby_2_3 r55906 merged revision(s) 55047.
-
- * ext/openssl/ossl_bn.c (try_convert_to_bnptr): Extracted from
GetBNPtr(). This doesn't raise exception but returns NULL on error.
(GetBNPtr): Raise TypeError if conversion fails.
(ossl_bn_eq): Implement BN#... -
- ruby_2_3 r55905 merged revision(s) 55181.
-
- * transcode.c (str_transcode0): scrub in the given encoding when
the source encoding is given, not in the encoding of the
receiver. [ruby-core:75732] [Bug #12431]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branche... -
- ruby_2_3 r55904 merged revision(s) 55175.
-
- * ext/openssl/ossl_pkey_dh.c (ossl_dh_compute_key): Check that the DH
has 'p' (the prime) before calling DH_size(). We can create a DH with
no parameter but DH_size() does not check and dereferences NULL.
[r... -
- ruby_2_3 r55903 merged revision(s) 55115.
-
- * transcode.c (enc_arg, str_transcode_enc_args, econv_args):
remove volatile, and add GC guards in callers.
[ruby-core:75664] [Bug #12411]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@55903 b2dd03c8... -
- ruby_2_3 r55902 merged revision(s) 55497,55498,55504.
-
- * ext/psych/*, test/psych/*: Upate psych 2.1.0
This version fixed [Bug #11988][ruby-core:72850]
* ext/psych/*, test/psych/*: Update psych 2.1.0
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@55902 b2dd... -
04:29 PM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- `map_values`, `map_keys` and `map_pairs` seems consistent.
In addition, we are considering adding a method to create a hash from an enumerable in a similar way to `map_pairs` or `map_kv`. From my point of view, adding `map_kv` to Enu... -
- Yukihiro Matsumoto wrote:
> From our discussion, we concerned `map_values` is too close to `map.values`, which has totally different semantics.
But isn't `map.values` non sensical?
{}.map.values # => NoMethodError: undefined ... -
09:59 AM Feature #12512: Import Hash#transform_values and its destructive version from ActiveSupport
- Incidentally, as discussed back in #7793, the [hashmap](https://rubygems.org/gems/hashmap) gem defines #map_keys, #map_values, and #map_pairs, and their bang variants.
-
- From our discussion, we concerned `map_values` is too close to `map.values`, which has totally different semantics. Besides that, we are thinking about adding other methods like `map_k` and `map_kv`.
Matz.
-
- reopened ticket because of naming issue.
Matz, could you close it if you finish the discussion? -
- I prepared snapshot from r55901 using tool/make-snapshot, but this snapshot fails to build without Ruby installed:
```
$ make -j4 'COPY=cp -p' Q=
CC = gcc
LD = ld
LDSHARED = gcc -shared
CFLAGS = -O2 -g -pipe -Wall -Werror=for... -
- * node.c (dump_array): show nd_alen field in NODE_ARRAY only in
the first node. it is nd_end in the rest nodes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:05 AM Bug #12674: io/wait: not handling the case when the socket is closed before doing wait_readable/writable with timeout
- Just tested on linux (x86_64-linux), same output.
-
- this was executed on a MAC (darwin, I guess).
-
- What's your platform?
~~IIRC, it depends on platforms.~~ -
- What is shown if you run under valgrind? I suspect this is also #12292.
-
08:37 AM Bug #12327: Seg Fault - ruby 2.3.0 mongo & OpenSSL issue??
- Hiroshi SHIBATA wrote:
> Can you try with Ruby 2.3.1?
I tried with 2.3.1 - it happens again. This is the trace:
```
: /opt/rbenv/versions/2.3.1/lib/ruby/2.3.0/openssl/buffering.rb:57: [BUG] Segmentation fault at 0x007f7f895f9b60
... -
07:42 AM Revision 15c9e5c0 (git): * appveyor.yml: Update libressl version to 2.3.7.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/extmk.rb (extmake): extension libraries in gems cannot link
statically.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:59 AM Revision 93bc5024 (git): * 2016-08-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55898 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * numeric.c (round_to_nearest): extract and reduce for platforms
where round is not available.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I earlier posted code to simplify the prime_division method in prime.rb.
This made the code much more concise and readable/understandable, while
also providing a small speed increase.
The code presented here for prime_division2 main...
08/14/2016
-
- I believe the following code simplification for the prime_division
method in prime.rb makes it more readable as English, thus more
understandable, while also significantly more concise in terms of
lines-of-code (25 vs 16), and may I d... -
- I wrote the following script to show the problem:
```ruby
require 'socket'
require 'io/wait'
Thread.new do
server = TCPServer.new 2000 # Server bind to port 2000
loop do
client = server.accept # Wait for a client to... -
- Applied in changeset r55896.
----------
id_table.c: extend, don't shrink
* id_table.c (hash_table_extend): should not shrink the table than
the previous capacity. [ruby-core:76534] [Bug #12614] -
- Reproduced with trunk `ruby 2.4.0dev (2016-08-14 trunk 55893) [x86_64-linux]`.
I guess it is related to method table and its extending logic.
`hash_table_extend(tbl)` can make `LIST_P(tbl->capa) == TRUE` when there are many collisi... -
- * id_table.c (hash_table_extend): should not shrink the table than
the previous capacity. [ruby-core:76534] [Bug #12614]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * gems/bundled_gems: add gemified tk 0.1.0.
this needs `extract-gems` to build.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:55 AM Revision b9a82eaa (git): * object.c (InitVM_Object): Update referenced document path.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:34 AM Revision 5858f6c1 (git): * 2016-08-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/13/2016
-
- After doing more testing of alternative techniques, for CRuby and JRuby,
here are some timing results on CRuby 2.3.1 on 64-bit Linux OS on
System76 I7 3.5GHz laptop with 16GB ram.
Version 1) the current code for prime? in class Prim... -
- The following code change provides a significant speed increase for Prime.prime? in prime.rb.
```
class Prime
...
...
def prime?(value, generator = Prime::Generator23.new)
raise ArgumentError, "Expected a prime genera... -
06:36 PM Feature #12648: `Enumerable#sort_by` with descending option
- Yukihiro Matsumoto wrote:
> I think we are talking about two things at once.
> ...
I would concur.
> Second, adding secondary key sort order to `sort_by`.
Just to clarify, I'm not sure what you mean by 'adding secondary key sor... -
- * numeric.c (num_funcall0, num_funcall1): get rid of infinite
recursion in fallback methods of Numeric.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_comparable.rb (TestComparable#test_clamp): fix
test. the result which is not clamped should be the receiver.
[Feature #10594]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55890 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- * ext/win32ole/win32ole.c (ole_val2variant): reuse the converted
result for V_I8.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Sorry, it's preview for 2.4, not 2.3.
I suspect it may be fixed already, though.
Could you try recent snapshots? -
- Why still using preview?
-
04:00 AM Bug #12672 (Closed): rails server
- execute app with rails5.0.1
rails server
/usr/local/lib/ruby/gems/2.4.0/gems/railties-5.0.0.1/lib/rails/app_loader.rb:40: warning: Insecure world writable dir /usr/local/bin in PATH, mode 040777
=> Booting Puma
=> Rails 5.0.0.1 ap... -
- Sorry if I wasn't clear. It has been committed.
-
- Applied in changeset r55888.
----------
parse.y: chained assignments
* parse.y (command_asgn, arg): fix syntax errors with chained
assignment with op assign. [Bug #12669] -
- * parse.y (command_asgn, arg): fix syntax errors with chained
assignment with op assign. [Bug #12669]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (stmt, arg): rescue modifier in command op assignment
should be limited to rhs only. [ruby-core:75621] [Bug #12402]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/win32ole/win32ole.c (ole_val2variant): get rid of repeated
conversions and fix a compile error due to V_I8 in old VC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/socket/getnameinfo.c: needs rubysocket.h for fallback
definition of inet_ntop.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_insnhelper.c (vm_getivar): ALWAYS_INLINE macro needs an
argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
08/12/2016
- 10:54 PM Revision ab67459a (git): * 2016-08-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:54 PM Revision d5c2261b (git): * ext/win32ole/win32ole.c (ole_val2variant): fix integer conversion in
- cygwin64.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Could you please provide me a technical rationale for not giving this
method consideration. I do not know what your terse comment meant.
The method I provided is substantially faster than the current method
while having the same nu... -
03:11 PM Bug #12630: add gem sources errors on Ruby 2.4.0-preview1
- you're right.
~~~ ruby
$ ruby -ropenssl -e'puts OpenSSL::OPENSSL_VERSION, OpenSSL::OPENSSL_LIBRARY_VERSION'
OpenSSL 1.0.2g 1 Mar 2016
OpenSSL 1.0.1f 6 Jan 2014
~~~
-
12:08 PM Feature #6559 (Closed): Set DoNotReverseLookup to true in Webrick
- Applied in changeset r55881.
----------
* lib/webrick/config.rb (WEBrick::Config::General):
disable reverse lookup by default. [ruby-core:45514] [Feature #6559]
Socket.do_not_reverse_lookup is true by default but WEBrick
overwrote... -
- disable reverse lookup by default. [ruby-core:45514] [Feature #6559]
Socket.do_not_reverse_lookup is true by default but WEBrick
overwrote it.
patch by Eric Hodel [ruby-core:45527]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk... -
- Actually, in the RHBZ, there are two comments from two glibc maintainers and both suggest to load glibc without specifying path, e.g.:
```
when /linux/
libc_so = "libc.so.6"
libm_so = "libm.so.6"
```
But this should apply p... -
- Shyouhei Urabe wrote:
> For Fedora the patch seems OK. But I doubt if it could break on other systems like mswin. The fix proposed by the glibc maintainers seems much moderate to me.
Use ldd instead of hard coded list sounds reason... -
- For Fedora the patch seems OK. But I doubt if it could break on other systems like mswin. The fix proposed by the glibc maintainers seems much moderate to me.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
06:46 AM Bug #12671: Hash#to_proc result is not a lambda, but enforces arity
- JRuby implements Hash#to_proc as:
```ruby
class Hash
def to_proc
method(:[]).to_proc
end
end
```
This allows us to present the proc as a lambda with correct arity:
```
$ jruby -e "pr = {}.to_proc; puts pr.arity; p... -
- None-lambda doesn't mean that it never checks its arguments.
And if it's a lambda, it doesn't match the `arity` value.
As for the implementation detail, there is no room for arity in `ifunc`s.
-
- ```
$ ruby23 -e 'pr = {foo:1}.to_proc; puts pr.lambda?; pr.call rescue puts $!; pr.call(1, 2) rescue puts $!'
false
wrong number of arguments (given 0, expected 1)
wrong number of arguments (given 2, expected 1)
```
I believe it... -
- * ChangeLog: fix the original patch author's name to the name
written in the patch, not "author name" in git.
[Feature #10594]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * error.c (rb_syntax_error_append): fix newline in syntax error
message to the beginning, not after file name and line number.
[Feature #11951]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55878 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- * parse.y (const_decl_gen): extract as a function as well as
ripper.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (assign_error_gen): [ripper] rename without backref.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_2 r55875 merged revision(s) 55609.
- 02:50 AM Revision af4907c5 (git): merge revision(s) 55609: [Backport #12568]
- * vm_args.c (setup_parameters_complex): don't raise ArgumentError
if an array is given for instance_exec with optional argument.
[ruby-core:76300] [Bug #12568]
https://github.com/rails/rails/pull/25699
git... -
- ruby_2_2 r55874 merged revision(s) 55581,55582.
- 02:46 AM Revision 26df8ea5 (git): merge revision(s) 55581,55582: [Backport #12557]
- * lib/net/http/generic_rquest.rb (write_header): A Request-Line must
not contain CR or LF.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55874 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_2 r55873 merged revision(s) 55579.
- 02:43 AM Revision 9bfab3c1 (git): merge revision(s) 55579: [Backport #12556]
- * lib/net/ftp.rb (putline): raise an ArgumentError when
CR or LF is included in a line.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_2 r55872 merged revision(s) 55427.
- 02:35 AM Revision 9fbd5955 (git): merge revision(s) 55427: [Backport #12503]
- * string.c (tr_trans): consider terminator length and fix heap
overflow. reported by Guido Vranken <guido AT guidovranken.nl>.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@55872 b2dd03c8-39d4-4d8f-98ff-823fe...
08/11/2016
-
- ruby_2_3 r55871 merged revision(s) 55434.
-
- * common.mk (build-ext), ext/extmk.rb: use variable EXTENCS
different than ENCOBJS, to get rid of circular dependency.
build libencs when linking encodings statically.
[ruby-core:75618] [Bug #12401]
git-sv... -
- ruby_2_3 r55870 merged revision(s) 55090,55091.
-
- io.c: conditionally used functions
* io.c (pipe_atexit): only used on Windows
* io.c (rb_execarg_fixup_v): wrapper only used fork or spawnv is
available.
* process.c (rb_execarg_commandline): build command lin... -
- ruby_2_3 r55869 merged revision(s) 54142,55500.
-
- assertions.rb: fix result of assert_nothing_raised
* test/lib/test/unit/assertions.rb (assert_nothing_raised): do not
discard the result of the given block.
* vm_method.c (vm_respond_to): try method_missing if respond_... -
- ruby_2_3 r55868 merged revision(s) 55705.
-
- * variable.c (rb_local_constants_i): exclude private constants
when excluding inherited constants too. [Bug #12345]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@55868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r55867 merged revision(s) 55008.
-
- * lib/drb/timeridconv.rb: don't use keeper thread. [Bug #12342]
* test/drb/ut_timerholder.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_3@55867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- ruby_2_3 r55866 merged revision(s) 55100.
-
- * ext/openssl/ossl_ssl.c (ossl_ssl_stop): Don't free the SSL struct
here. Since some methods such as SSLSocket#connect releases GVL,
there is a chance of use after free if we free the SSL from another
thread... - 03:00 PM Revision 6a7e766f (git): * 2016-08-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I guess this is a same problem with #11750 suggested by `git bisect`.
If so, it is since r51243 and fixed at r53144.
According to git informatin of Github,
r51243 == https://github.com/ruby/ruby/commit/a82ce7c55626086ad264a0d26de63b... -
12:30 PM Bug #12670 (Closed): Segmentation fault on `Magick::Image#get_pixels` on ruby since ruby-2.2
- 1. Create test.rb this code
~~~ ruby
require 'rmagick'
include Magick
(0..10).each do |_|
ImageList.new('1.bmp').get_pixels(0, 0, 1600, 800).each_slice(1600).to_a
end
~~~
2. Create any 1.bmp file with dimension at least 160... -
- Related to #12402, I found other kind inconsistencies.
simple assignment and op assign of `command` cause syntax error,
while simple assignments don't.
```
$ ruby -ce 'a = b = raise "x"'
Syntax OK
```
```
$ ruby -ce 'a = b +=... -
- Applied in changeset r55863.
----------
Comparable#clamp
* compar.c (cmp_clamp): Introduce Comparable#clamp. [Feature #10594] -
- * compar.c (cmp_clamp): Introduce Comparable#clamp. [Feature #10594]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I am not going to make multiple assignments even more complex.
The behavior of OP_ASGN for multiple assignments is not obvious.
Matz.
-
- * compar.c (rb_cmp): call comparison method by predefiend ID.
* compar.c (cmpint): returns compared result.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- https://github.com/ruby/ruby/compare/trunk...nobu:feature/12655
-
- I quite often encounter error:
```
1) Failure:
TC_OpenStruct#test_accessor_defines_method [/builddir/build/BUILD/ruby-2.3.1/test/ostruct/test_ostruct.rb:173]:
<[:foo, :foo=]> expected but was
<[:foo=, :foo]>.
```
which was i... -
- * parse.y (stmt, command_asgn): unifiy parser and ripper code by
node_assign macro.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (backref_assign_error): unify parser and ripper code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55860 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (const_decl): unify parser and ripper code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:39 AM Feature #4897: Define Math::TAU and BigMath.TAU. The "true" circle constant, Tau=2*Pi. See http://tauday.com/
- This may be of interest: Guido van Rossum recently reopened the Python version of this request and is going to add tau to Python. See https://bugs.python.org/issue12345 .
-
- * parse.y (const_path_field, top_const_field): unify parser and
ripper code.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e