Activity
From 10/10/2014 to 10/16/2014
10/16/2014
- 06:12 PM Revision d9f3b27c (git): * 2014-10-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:11 PM Revision 585e1594 (git): Revert r47971, r47972 [ruby-core:65764]
- The current implementation currently delivers signals to self
immediately and synchronously, so we do not need explicit,
potentially-confusing sleeps to wait for signal delivery.
* test/-ext-/bug_reporter/test_bug_reporter.rb
(test_bu... -
05:05 PM Feature #10394: An instance method on Enumerator that evaluates the block under with self being the block variable.
- Sounds good for me.
(Actually I face the difficulties to implement [#10318](https://bugs.ruby-lang.org/issues/10318 "#10318") ... and it's painful)
I just come up with...
`#as`
`#as_arg(s)`
`#through`
`#member`
.... ; (
An... -
02:55 PM Feature #10394 (Feedback): An instance method on Enumerator that evaluates the block under with self being the block variable.
- I like the idea itself. But I don't think `as_self` is a good name.
Any other name proposal? Anyone?
Matz.
-
02:23 PM Feature #10394 (Feedback): An instance method on Enumerator that evaluates the block under with self being the block variable.
- **Background**
There has been desire to omit the `| |` and the explicit receiver in a block used with an enumerator or an enumerable. Currently, when the content of the block is a single method that takes no argument, symbol-to-proc i... -
02:17 PM Revision b7a00385 (git): signal.c: get rid of heap corruption
- * signal.c (rb_sigaltstack_size): double default size to get rid
of heap corruption by alternate stack overflow in SEGV handler.
typically happened at fprintf() in control_frame_dump().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
01:46 PM Bug #10389 (Closed): SEGV after SEGV
- Applied in changeset r47983.
----------
* vm_backtrace.c (id2str): Fix a variable name.
[ruby-dev:48642] [Bug #10389] -
- Nobuyoshi Nakada wrote:
> 引数のIDが見つからないときに`rb_id2str()`が`Qnil`ではなく0を返すのは昔からです。
> ...
もしかして、r47951 の
```
VALUE str = rb_id2str(id);
if (!id) return Qnil;
```
は
```
VALUE str = rb_id2str(id);
if (!str) return... -
- r47971 でも以下のように発生します。
```
% ./miniruby -e 'Process.kill(:SEGV, $$)'
-e:1: [BUG] Segmentation fault at 0x0003e80000389f
ruby 2.2.0dev (2014-10-16 trunk 47971) [x86_64-linux]
-- Control frame information --------------------------... -
- 引数のIDが見つからないときに`rb_id2str()`が`Qnil`ではなく0を返すのは昔からです。
そこはr47951で直したつもりなのですが、まだ起きるでしょうか。
存在するはずのIDが見つからないというのは別として。 -
- [ruby-dev:48642] [Bug #10389]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:19 PM Bug #10285: StringIO with encodings broken due to #9769
- Backported into `ruby_2_1` at r47982.
-
- * ext/stringio/stringio.c (strio_write): ASCII-8BIT StringIO
should be writable any encoding strings, without conversion.
[ruby-core:65240] [Bug #10285]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47981 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Backported into `ruby_2_1` at r47980.
-
- * vm_eval.c (eval_string_with_cref): fix super from eval with
scope. set klass in the current control frame to the class of
the receiver in the context to be evaluated, this class/module
must match the actu... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47979 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- patterns and characters.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:12 AM Bug #10393 (Rejected): String#start_with?の1.9.x非互換バグ
- ~~~
$ ruby -v
ruby 1.9.3p547 (2014-05-14 revision 45962) [x86_64-darwin13.4.0]
$ irb
> 'foo'.start_with? nil
=> false
~~~
~~~
$ ruby -v
ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin13.0]
$ irb
> ...
TypeError: no... -
- * signal.c (check_reserved_signal): abort if reserved signal
received in reserved signal handlers.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47977 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:01 AM Feature #8976: file-scope freeze_string directive
- akr@fsij.org wrote:
> Recent Eric Wong's effort reminds me this issue.
>
> I still think this issue is worth to consider.
>
> Ruby 2.1 changed the semantics of "...".freeze to avoid string allocation.
> It is not used extensivel... -
- Recent Eric Wong's effort reminds me this issue.
I still think this issue is worth to consider.
Ruby 2.1 changed the semantics of "...".freeze to avoid string allocation.
It is not used extensively, I feel.
File scope directive... -
07:48 AM Feature #10333: [PATCH 3/1] optimize: "yoda literal" == string
- Thank you for your explanation. Completely agree with you.
I will try to read your patch.
Thanks again,
Koichi -
- ko1@atdot.net wrote:
> I can't find out which methods are target.
> How to see the list?
>
> I'm afraid that many optimized methods becomes overhead for non-target methods.
Most comments + optimization are in compile.c (still aw... -
- I can't find out which methods are target.
How to see the list?
I'm afraid that many optimized methods becomes overhead for non-target methods.
-
07:36 AM Bug #9728: Regexp bug
- Backported into `ruby_2_0_0` at r47976.
- 07:35 AM Revision 7e344b0b (git): * regcomp.c, regexec.c: Optimization should be disabled not only for
- /(?<=x).*/ but also for /(?!x).*/.
(merge r47598 partially. [Bug #9728])
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@47976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:27 AM Revision 5c3c2ddd (git): cont.c (fiber_store): fix WIN32 fibers
- [ruby-core:65745] [ruby-core:65758]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47975 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_0_0` at r47974.
- 07:23 AM Revision 4110e5fa (git): merge revision(s) 46783: [Backport #6716]
- * lib/fileutils.rb: handle ENOENT error with symlink targeted to
non-exists file. [ruby-dev:45933] [Bug #6716]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@47974 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- It works fine!
Thank you.
-
- Eric Wong wrote:
> Maybe this is a simple fix for win32, but I cannot test:
Thank you. Now, it is working. I'm running test-all now. -
- Maybe this is a simple fix for win32, but I cannot test:
diff --git a/cont.c b/cont.c
index 739ec80..08acf40 100644
--- a/cont.c
+++ b/cont.c
@@ -1366,10 +1366,10 @@ fiber_store(rb_fiber_t *next_fib, rb_thread_t *th)
terminate... -
- disable FIBER_USE_NATIVE works fine on mswin32.
-
- on mswin32, the following simple script doesn't work.
```ruby
p Fiber.new{
100
}.resume
```
```
#=>
C:/ko1/src/ruby/trunk/test.rb:1:in `p': method `inspect' called on
hidden T_OBJECT object (0x1ea6730 flags=0x1) (NotImplem... -
- Applied in changeset r47969.
----------
cont.c: fix compile error
* cont.c (rb_fiber_t): fix compile error caused by move to
vm_core.h at r47964. [Feature #10341] -
- I've missed this ticket, and r47964 caused compile error.
-
- Applied in changeset r47973.
----------
parse.y: do not use disposed string
* parse.y (parser_here_document): do not append already appended
and disposed code fragment. [ruby-dev:48647] [Bug #10392] -
- 以下のようにすると SEGV になります。
```
% cat z.rb
require 'ripper'
Ripper.sexp("<<'E'\n E\n\n")
% ./ruby z.rb
/home/ruby/tst1/lib/ruby/2.2.0/ripper/sexp.rb:31: [BUG] Segmentation fault at 0x00000000000008
ruby 2.2.0dev (2014-10-16 trunk 4797... -
- * parse.y (parser_here_document): do not append already appended
and disposed code fragment. [ruby-dev:48647] [Bug #10392]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47973 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I could reproduce it with gcc-4.9 on either Linux and OS X.
On Linux, SIGSEGV seems masked after the first stack overflow occurred, and it seems working by enabling interrupts.
~~~diff
diff --git c/eval.c i/eval.c
index 3e4ea16..6b... -
01:41 AM Bug #10290: segfault when calling a lambda recursively after rescuing SystemStackError - I can reproduce it with gcc 4.9.1 at `-Os`:
```
$ gcc-4.9 --version
gcc-4.9 (Homebrew gcc 4.9.1) 4.9.1
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
... -
- On 2014/10/12 1:28, Knut.Franke@gmx.de wrote:
> For some more sophisticated examples, see https://github.com/nome/coroutines. The library does work with vanilla Ruby, but the patch improves performance.
>
> Also, similar code can be... -
04:12 AM Bug #10382: s = '\x80'; /#{s}/ raises an exception in US-ASCII script
- US-ASCII で色々例外があることは分かっています。しかし、例外を増やすのではなく、減らす方向で考えた方がいいかと思います。US-ASCII のではなく、 UTF-8 がデフォールトソースエンコーディングとなった今では /#{'\x80'}/ などはソースのエンコーディングを考えなかったら通らなくなりました。そこで実際に US-ASCII のではなく、ASCII－8BIT を使いたかったら、その通りに -*- encoding: ASCII-8BIT と書けばいいか...
-
- There is occasionally a need to use a string literal with an Encoding different from the source encoding.
This proposes to use %e (e for encoding) to introduce such string literals.
The syntax used in the subject relies on the fact t... - 02:01 AM Revision eec651a0 (git): test/-ext-/bug_reporter/test_bug_reporter.rb: fix race
- Signal delivery is not immediate, so wait for signal delivery.
* test/-ext-/bug_reporter/test_bug_reporter.rb
(test_bug_reporter_add): fix race
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:59 AM Bug #10390: BUG] Segmentation fault at 0xbf3eeedc
- Get this when I try to merge.
```ruby
FactoryGirl.define do
factory :calculator_params, class: Hash do
initialize_with do
{ from: { city_id: '0987654321' },
to: { city_id: '12345678' },
weight: 3,
... -
- I've got segmentation fault on ruby 1.9.3 and 2.1.2
when starting rspec task
@myronmatson said that is ruby core issue, thus i post it here
https://github.com/rspec/rspec-dev/issues/52
Full listing of output in attachment
Thanks fo... - 01:10 AM Revision 720ef254 (git): test/ruby/test_rubyoptions.rb: fix race
- Signal delivery is not guaranteed to be immediate, a process may
exit before receiving signal it sent itself.
* test/ruby/test_rubyoptions.rb (test_segv_test): fix race
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47971 b2dd03c8-3... -
- * cont.c (rb_fiber_struct): remove useless typedef.
[Feature #10341]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47970 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * cont.c (rb_fiber_t): fix compile error caused by move to
vm_core.h at r47964. [Feature #10341]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:06 AM Revision e03546fd (git): test/ruby/test_process.rb: avoid killing wrong parent
- We must capture intended target PID before forking, since
Process.ppid may change if parent dies (e.g. due to timeout)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/15/2014
- 11:40 PM Revision d910af94 (git): cont.c: fix when FIBER_USE_NATIVE is 0
- * cont.c (fiber_store): restore references to next_fib (fix typo)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 11:27 PM Revision 397271ca (git): cont.c: fix build when FIBER_USE_NATIVE is 0
- * cont.c (fiber_store): remove references to nextfib
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:35 PM Revision 5c8c88a3 (git): cont.c: Optimize fiber_switch callees
- Remove some unnecessary VALUE/struct conversions and aggressively inline
functions used during fiber_switch. Either of these changes alone does
not yield significant performance increase, but in combination they
improve performance by ~6... - 10:35 PM Revision 71fcbf22 (git): cont.c (cont_save_thread): Sparse copying of thread data
- Instead of copying the complete rb_thread_t struct (almost a kB),
selectively copy only those fields that will be needed later on.
* cont.c (rb_context_t): comment on saved_thread
(cont_save_thread): sparse copy
(cont_init): copy ex... - 10:34 PM Feature #10341 (Closed): Fiber switch performance improvements
- Applied in changeset r47959.
----------
cont.c: Remove unused prev_fiber/next_fiber fields
They were added in r19890 (8a0d53a), with the explanation that it's a
double linked list of fibers in the same thread, but without any code
usin... - 10:34 PM Revision baeb94fa (git): cont.c: Small code cleanup
- Remove variable that is used only once, several lines after
initialization.
* cont.c (cont_capture): remove unnecessary variable
[ruby-core:65518] [Feature #10341]
Author: Knut Franke <Knut.Franke@gmx.de>
git-svn-id: svn+ssh://ci.ru... - 10:34 PM Revision 0bd492c6 (git): cont.c: Code cleanup in fiber_switch/fiber_store
- Defragment code blocks depending on FIBER_USE_NATIVE in order to make
the control flow (which is already non-trivial due to nonlocal jumps) in
each case more comprehensible.
Remove some unreachable code from fiber_switch (we've already ... - 10:34 PM Revision 9766fc4d (git): * 2014-10-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 10:34 PM Revision 6f6238a7 (git): cont.c: Remove unused prev_fiber/next_fiber fields
- They were added in r19890 (8a0d53a), with the explanation that it's a
double linked list of fibers in the same thread, but without any code
using them.
* cont.c (rb_fiber_t): remove prev_fiber/next_fiber
(fiber_link_join, fiber_link_r... -
- Backported into `ruby_2_1` at r47958.
-
- * lib/find.rb (Find.find): Call to_path for arguments to obtain
strings.
[ruby-core:63713] [Bug #10035] Reported by Herwin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47958 b2dd03c8-39d4-4d8f-98ff... -
- Backported into `ruby_2_1` at r47957.
-
- * object.c (rb_class_real): do not dereference 0 VALUE
* test/ruby/test_module.rb (test_inspect_segfault):
Test case and bug report by Thomas Stratmann.
[ruby-core:65214] [Bug #10282]
git-svn-id: svn+ssh://... -
- r47818 and r47832 were backported into `ruby_2_1` branch at r47956.
-
- * signal.c (rb_f_kill): should not ignore signal unless the
default handler is registered. [ruby-dev:48592] [Bug #9820]
* signal.c (rb_f_kill): get rid of deadlock as unhandled and
discarded signals do not m... -
- 最近、SEGV したときに、さらに SEGV することがあります。
```
% ./miniruby -e 'Process.kill(:SEGV, $$)'
-e:1: [BUG] Segmentation fault at 0x0003e800003c63
ruby 2.2.0dev (2014-10-15 trunk 47951) [x86_64-linux]
-- Control frame information --------------... -
- partially backport r47598 into `ruby_2_1` branch at r47954.
- 03:05 PM Revision 9b9479b1 (git): * 2014-10-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- https://github.com/k-takata/Onigmo/commit/15ddec6d18e27fdc1988236764e766fd5892ecf5
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_1` at r47953.
-
- * lib/fileutils.rb: handle ENOENT error with symlink targeted to
non-exists file. [ruby-dev:45933] [Bug #6716]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in: NetBSD's ksh, used by configure, needs escapes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:42 PM Feature #10327: Bool/False/True module for '==='
- もっともなので Falsy/Truthy に変えてみました。
patch を作り直したので添付します。
前回の patch は壊れていました。確認が不十分でごめんなさい。
~~~
$ ./miniruby -e '[nil, false, true, 0].each {|obj|
case obj
when Falsy; p [obj, false]
when Truthy; p [obj, true]
else p... -
- * vm_backtrace.c (id2str): adapt rb_id2str which returns 0 on
unknown ID to return Qnil, since oldbt_arg functions expect Qnil
on unknown method names.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47951 b2dd03c8-39d4-4d8f-98ff-... -
- * vm_backtrace.c (location_format): adjust unknown name method
results to other functions.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_1` at r47949.
-
- Backported into `ruby_2_0_0` at r47936.
-
- * array.c (ary_recycle_hash): add RB_GC_GUARD
(rb_ary_diff): remove volatile
[Bug #10369]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47949 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:12 PM Revision 1c90afbc (git): fix typos [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Backported into `ruby_2_1` at r47947.
-
- Backported into `ruby_2_0_0` at r47935.
-
- proc.c: method body GC guard
* proc.c (rb_mod_define_method): guard method body to prevent its
method entry from GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_1` at r47946.
-
- Backported into `ruby_2_0_0` at r47934.
-
- * dir.c (dir_s_aref): fix rdoc. `Dir.glob` allows an array but
`Dir[]` not. the former accepts an optional parameter `flags`,
while the latter accepts arbitrary number of arguments but no
`flags`. [ruby-c... -
- Backported r47819 into `ruby_2_1` at r47945.
-
- Backported into `ruby_2_0_0` at r47933.
-
- * configure.in: Fix typo. [Bug #9914]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47945 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_1` at r47944.
-
- Backported into `ruby_2_0_0` at r47932.
-
- * error.c: update exception tree. [DOC]
reported by @hemge via twitter.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@47944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- CentOS 5 don't have CPU_ALLOC().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:20 AM Feature #10298: Array#float_sum (like math.fsum of Python)
- Thank you for the quick patch for enum.c.
Timing and test.
I see. performance is not improved.
```
$ uname -sprsv
Darwin 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun 3 21:27:35 PDT 2014; root:xnu-2422.110.17~1/RELEASE_X86_64 i3... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It seems kosaki-san is busy.
I committed etc-nprocessors-kosaki2.patch at r47939. -
- for getting precious number of available cpus.
* ext/etc/etc.c (etc_nprocessors): use etc_nprocessors_affinity if
possible.
[Feature #10267] etc-nprocessors-kosaki2.patch
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47939 b... -
- 筋が通るというのは原則どおりなのでそれはそうですが、
US-ASCII の場合は例外扱いでそうはしないことにしたという経緯があるので
筋が通るということのみではそうする理由にはならないと思います。 -
- UTF-8 や Windows-31J で試してみたところ、両方とも (/#{s}/ も /#{'\x80'}/ も) invalid multibyte eｓcape となっています。なぜ US-ASCII の場合片方しかなってないのか分かりませんが、両方ともエラーになった方が筋が通るのではないかと思います。
-
- assert_regexp_list.
Show multiline string in multi lines.
* test/-ext-/bug_reporter/test_bug_reporter.rb: Use
assert_pattern_list.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47938 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hiroshi SHIBATA wrote:
> It will automatically install at ```make install``` therefore, Ruby 2.2 users can use it and run their test code with default installation.
Maybe this wasn't the case earlier because of bug #10372.
Also,... -
- Backported into `ruby_2_0_0` at r47937.
- 07:24 AM Revision 9c1588a8 (git): merge revision(s) 47111,47212,47451,47452,47680: [Backport #10245]
- * test/minitest/test_minitest_unit.rb: removed obsoleted condition
for Ruby 1.8.
* test/ruby/test_time_tz.rb: ditto.
* test/ruby/test_time_tz.rb: Fix test error with tzdata-2014g.
[ruby-core:65058] [... - 07:19 AM Revision 6e103e84 (git): merge revision(s) 47896: [Backport #10369]
- * array.c (ary_recycle_hash): add RB_GC_GUARD
(rb_ary_diff): remove volatile
[Bug #10369]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@47936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:16 AM Revision 46885440 (git): merge revision(s) 47891: [Backport #10373]
- proc.c: method body GC guard
* proc.c (rb_mod_define_method): guard method body to prevent its
method entry from GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@47935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:13 AM Revision f173b876 (git): merge revision(s) 47850: [Backport #10294]
- * dir.c (dir_s_aref): fix rdoc. `Dir.glob` allows an array but
`Dir[]` not. the former accepts an optional parameter `flags`,
while the latter accepts arbitrary number of arguments but no
`flags`. [ruby-c... - 07:12 AM Revision 94715a86 (git): merge revision(s) 47819: [Backport #9914]
- * configure.in: Fix typo. [Bug #9914]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@47933 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:09 AM Revision c436b465 (git): merge revision(s) 47820: [Backport #10330]
- * error.c: update exception tree. [DOC]
reported by @hemge via twitter.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@47932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_0_0` at r47931.
- 06:58 AM Revision a7679182 (git): merge revision(s) 47641,47642,47644: [Backport #10262]
- * win32/win32.c (VCSUP): nothing to do if this worktree is not under
any VCS (it means that the worktree may be from the release package).
* win32/Makefile.sub (VCSUP): nothing to do if this worktree is not
u... -
- Backported into `ruby_2_0_0` at r47930.
- 06:55 AM Revision 172cc121 (git): merge revision(s) 47683: [Backport #10281]
- array.c: GC guard
* array.c (rb_ary_splice): prevent replacing array from GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@47930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:39 AM Revision 9c7e5a85 (git): merge revision(s) 42060: [Backport #9915]
- * ext/pathname/pathname.c (path_inspect): use PRIsVALUE to preserve
the result encoding.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@47929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * enum.c (enum_inject): return nil if no iteration, instead of
Qundef.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47928 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:18 AM Bug #9424: ruby 1.9 & 2.x has insecure SSL/TLS client defaults
- This patch is even more important now that SSLv3 has basically been completely deprecated by the POODLE attack.
-
- * test/ruby/test_rubyoptions.rb (SEGVTest::ExpectedStderrList):
split backtrace information regexps.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47927 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * enum.c (enum_inject): use Qundef for no initial values.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47926 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:27 AM Feature #10381: Pathname#mkdir_p, Pathname#makedirs が欲しい
- > mkdir_p はコマンド名っぽくておすすめしたくないな、と思っています。
FIleUtils では mkdir_p のほうがコマンドの挙動がすぐ連想できるの使っています。
FileUtils からの連想で Pathname に無いというのを気づいたため、Pathname#mkdir_p があると嬉しいと感じています。
FileUtils#mkpath と FileUtils#mkdir_p どちらがよく使われているか気になって、GitHub でコード... -
03:35 AM Bug #10388 (Rejected): Operator precedence problem in multiple assignment (massign)
- I understand it wouldn't be easy to fix this, but since I happened to find it here it goes.
- `a, b = c = 1, 2` is currently taken as `a, b = (c = 1), 2`; I'd expect it to be taken as `a, b = (c = 1, 2)`.
- `a, b = *c = 1, 2` is cu... -
- * test/ruby/test_rubyoptions.rb: Use assert_regexp_list.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Seems it doesn't happen on the trunk.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/14/2014
-
10:46 PM Bug #10387 (Closed): Overwriting an array variable doesn't release referenced objects
- I narrowed down the following, but I'm not sure if the problem is mine or a bug:
~~~ruby
require 'objspace'
GC.start
begin
threads = []
1000.times do
threads << Thread.new { Random.new(10) }
end
threads.each &:jo... -
- (struct nmin_data): New field to record the n-th maximumelement, limit
(nmin_filter): Update limit field.
(nmin_i): Drop too big eleents.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 10:01 PM Revision d63a88c0 (git): test/ruby/test_optimization.rb (test_string_size): new test
- String#size may be overridden, so test for it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:52 PM Revision a1ad7b51 (git): test/ruby/test_optimization.rb: redefinition tests for String
- * test/ruby/test_optimization.rb (test_string_eq_neq): new test
(test_string_ltlt): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:52 PM Revision 5733a574 (git): test/ruby/test_optimization.rb (test_hash_aset_with): assert assignment
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
09:13 PM Bug #9424: ruby 1.9 & 2.x has insecure SSL/TLS client defaults
- This patch looks broken.
:options => -> {
opts = …
opts |= OpenSSL::SSL::OP_NO_SSLv3 if defined?(OpenSSL::SSL::OP_NO_SSLv3)
}.call
If that last constant isn't defined, the lambda will return nil and no options will be ov... -
07:57 PM Revision f9deff97 (git): * gc.c (rb_obj_id): [DOC] Fix typo, clean up sentence, and wrap cols
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:54 PM Revision 329b2f47 (git): * 2014-10-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- [Fixes GH-740] https://github.com/ruby/ruby/pull/740
* object.c: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- p.s. From my point, `nucomp_expt` does work enough.
-
- As far as I research, I couldn't find the reason we should keep m_sqrt function at complex.c.
So I've removed this and related code.
If you could know why we've keep it and toll me, I would appreciate it! -
- I can find more useful function `f_zero_p `.
```c
static VALUE
nucomp_real_p(VALUE self)
{
get_dat1(self);
return f_zero_p(dat->imag);
}
``` -
04:30 PM Bug #10159: Ruby 2.x Syslog::Logger is newer than the one in Rubygems but version is the same
- Ruby 2.1.3 has the same issue. The patch is already supplied, why hasn't this been addressed?
-
- えぇと、ここでの string 自体は US-ASCII で valid なのです。
'\x80' というのは US-ASCII な 4文字の文字列なので。
CODERANGE_BROKEN な文字列ではありません。
それを regexp として解釈した時に US-ASCII としては invalid なことに気がついて現在は例外になりますが、
US-ASCII な文字列の中にエスケープされた 8bit なバイトを示す記述があったら、
ASCII-8BIT... -
- RegexpはASCII-8BITになってもStringはスクリプトエンコーディングのままなので、意図的なCODERANGE_BROKENなのか、意図しないバグによるものなのか、区別する方法がないというのが問題ですね。
-
- 以下のふたつのスクリプトの動作は一致するべきだと思うのですが、
前者と異なり後者は例外となります。
```
% cat z1.rb
# -*- encoding: US-ASCII -*-
r = /#{'\x80'}/
p [r, r.encoding]
% ./miniruby -v z1.rb
ruby 2.2.0dev (2014-10-14 trunk 47915) [x86_64-linux]
[/\x80/, #<... -
01:14 PM Bug #10384 (Closed): Fiddle::DLError: unknown symbol "Init_objspace" during Fiddle::TestHandle#test_NEXT and Fiddle::TestHandle#test_static_sym on Solaris
- Solarisにて、make test-all中に以下のエラーが発生することが多くなっています。
（出ないこともたまにあります。）
~~~
2) Error:
DL::TestHandle#test_static_sym:
DL::DLError: unknown symbol "Init_objspace"
/XXXXX/test/dl/test_handle.rb:34:in `sym'
/XXXXX/test/dl/test_... -
- Applied in changeset r47916.
----------
rbinstall.rb: fix .gemspec permissions
* tool/rbinstall.rb (gem): Fix permissions of bundled gems
specification files. [ruby-core:65700] [Bug #10383] -
11:54 AM Bug #10383 (Closed): .gemspec files should not be world writable
-
- * tool/rbinstall.rb (gem): Fix permissions of bundled gems
specification files. [ruby-core:65700] [Bug #10383]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47916 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- mkdir_p はコマンド名っぽくておすすめしたくないな、と思っています。
makedirs については mkdir と単語の略しかたが違っていて気に入らなかったような気がします。
あと Pathname では基本的には alias でいろいろな名前をつけることはしていないという話もあります。
-
- Pathname#mkpath にも FileUtils#mkpath と他の同じ挙動をするメソッド名が欲しいです。
~~~
diff --git a/ext/pathname/lib/pathname.rb b/ext/pathname/lib/pathname.rb
index 82541e9..40c3ae1 100644
--- a/ext/pathname/lib/pathname.rb
+++ b/ext/pathname/lib/pathna... -
- I'm not sure that ignoring getaddrinfo()'s non-first entries is a good behavior.
-
12:02 PM Bug #10290: segfault when calling a lambda recursively after rescuing SystemStackError
- I can reproduce clang on linux.
```
[hsbt@chkbuild001 ~]$ clang -v
clang version 3.5.0 (tags/RELEASE_350/final)
Target: x86_64-amazon-linux-gnu
Thread model: posix
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-amaz... -
- I can't reproduce with gcc-4.9(not clang).
-
- > It can be installed with
> ...
It will automatically install at ```make install``` therefore, Ruby 2.2 users can use it and run their test code with default installation.
>
> ...
-
- As described among else in bug #9869, minitest was removed as a default gem.
It can be installed with
> make update-gems
but I had to do that by hand. It should be done automatically (e.g. at least for make test and so on), or the... -
10:16 AM Revision fb06f080 (git): ext/win32ole/win32ole_record.c: use typed data.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47915 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- This is still/again issue for Ruby 2.2. There are changes in io-console but its version does not reflect them. Could you please make the io-console versioning reliable and useful? Thanks
BTW this is concern for BigDecimal as well ... -
- Ups, sorry. That was my fault. I forgot to remove one piece of workaround I applied before. Sorry for the noise.
-
- Sorry but it does not work for me. However, the error is now different:
~~~
1) Failure:
TestTimeTZ#test_gen_lisbon_111 [/builddir/build/BUILD/ruby-2.2.0-r47902/test/ruby/test_time_tz.rb:396]:
Expected [] to include [true, true, t... -
- * symbol.c (global_symbols): make ids two-dimensional array of
strings and symbols, for write-barrier.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * symbol.c (global_symbols): make IDs immortal always, instead
of treating dynamic symbols as IDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * iseq.c, marshal.c, string.c: use rb_str_intern instead of
rb_str_dynamic_intern.
* symbol.c (rb_str_intern): rename rb_str_dynamic_intern.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47912 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > Hello, are there any plans to fix this issue in Ruby 2.1.4?
No, because no one can identify the cause of the problem, and no one have provided patches.
Could you please try the following three configure options?
% ./configur... -
- I've changed the way BOP_* flags are defined (they are now OM_* flags).
Everything is in "opt_str_lit-v2" branch of git://bogomips.org/ruby.git
Full diff of my work-in-progress here against trunk:
http://80x24.org/spew/m/opt-str-l... -
- https://github.com/nobu/ruby/compare/Feature%2310298-float_sum
It doesn't improve the performance as `Array.float_sum`, though. -
02:02 AM Bug #10379 (Closed): Crash in Ruby 2.1.3 (and 2.1-head), works in 2.1.2
- This crash does not happen 100% consistently, but does happen very often.
This crash happens most commonly when I am generating a large SELECT, containing about 600 options (_navigation.html.erb:35). I load Player objects from the dat... - 01:21 AM Revision 18828191 (git): test new optimizations for redefines
- * test/ruby/test_optimization.rb (test_string_freeze): new test
(test_hash_aref_with): ditto
(test_hash_aset_with): ditto
Our new (in 2.2) optimizations must not trigger when redefined.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t...
10/13/2014
-
- all StreamParser have no tests.
-
- Needs tests
-
- Applied in changeset r47902.
----------
* lib/xmlrpc/parser.rb: added new parser class using libxml-ruby gem.
[Feature #9379][ruby-core:59633]
* lib/xmlrpc/config.rb: ditto. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Yeah, sorry, this is a duplicate of #5531 with just a different method name
-
-
- No feedback after 1 month, maybe we should close it
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- @Eric Wong
Thank you for letting me know! I'm gonna subscribe right away.
But sometimes I wanna read past discussion or replay for mention.
Anyway your advice is really useful : )
I found https://github.com/ruby/bugs.ruby-la... -
- I follow by subscribing to the ruby-core mailing list:
mailto:ruby-core-request@ruby-lang.org?subject=subscribe
Then read on any mail client :)
That said, getting diffs/attachments isn't always optimal;
especially for offline read... -
- Ops, I didn't make it clear enough.
I mean, I wanna read and catch up https://bugs.ruby-lang.org, even though using mobile device, tablet and so on.
Right now, viewing isn't optimized.
-
- Priority might not be high, I'd be glad if I could read and catch up great discussion here.
If there's anything I can do, please feel free to tell me :)
-
- Right now, `Complex#real?` return `false` anytime.
I suppose `#is_a?(Complex)` is enough to check whether a object is `Complex`'s object or not.
(I have to admire `#real?` is more useful than `#is_a?(Complex)`)
But what we really... -
05:35 PM Bug #10203: TCPServer.new has strange behaviour when EADDRINUSE without specifying hostname
- I was not interested in adding IPv6 support to my application, only in binding a port with a fallback mechanism. I worked around the problem with bind('0.0.0.0', 10001).
But I still think that it is wrong that TCPServer.new implements... -
- Ruby uses getaddrinfo() to obtain addresses to bind.
```
% ./ruby -rsocket -e 'p Addrinfo.getaddrinfo(nil, 10001, nil, :STREAM, nil, Socket::AI_PASSIVE)'
[#<Addrinfo: 0.0.0.0:10001 TCP>, #<Addrinfo: [::]:10001 TCP>]
```
TCPServe... -
- Indeed, bindv6only=1 seems to change this. However, bindv6only=1 is kind-of the default on all systems (except some Linux distros).
My goal was to implement the following:
try to bind port 10001 ; if already taken, bind port 10002
T... -
- It seems net.ipv6.bindv6only affect the behavior.
```
% sudo sysctl net.ipv6.bindv6only=0
net.ipv6.bindv6only = 0
% ./ruby -vrsocket -e 'p TCPServer::new(10001); system("netstat -ln|grep 10001"); p TCPServer::new(10001); system("ne... -
- correct copy/paste:
$ ./ruby -vrsocket -e 'p TCPServer::new(10001); system("netstat -ln|grep 10001"); p TCPServer::new(10001); system("netstat -ln|grep 10001"); p TCPServer::new(10001)'
ruby 2.2.0dev (2014-10-13 trunk 47902)... -
- I built Ruby 2.2 from source, and still encountered the same problem as the original report, with the exception that the bogus error message seems fixed:
$ ./ruby -vrsocket -e 'p TCPServer::new(10001); system("netstat -ln|grep 10001");... -
- Hm.
Ruby 2.1.3 causes the wrong error message:
```
% ./ruby -vrsocket -e 'p TCPServer::new(10001); p TCPServer::new(10001)'
ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-linux]
#<TCPServer:fd 7>
-e:1:in `initialize': no im... -
- lucas@lucas-nussbaum.net wrote:
> It might be fixed in Ruby 2.2... I don't have an easy way to test. Akira, do you have an easy way to test with Ruby 2.1?
>
> If it is indeed fixed, it might be worth backporting to 2.1.
It may be... -
- It might be fixed in Ruby 2.2... I don't have an easy way to test. Akira, do you have an easy way to test with Ruby 2.1?
If it is indeed fixed, it might be worth backporting to 2.1. -
- It doesn't reproduce on my environment.
```
% lsb_release -idrc
Distributor ID: Debian
Description: Debian GNU/Linux testing (jessie)
Release: testing
Codename: jessie
% bin/irb
irb(main):001:0> RUBY_VERSION
=> "2.2.... -
05:32 PM Revision 7ce520e9 (git): * ext/tk/tcltklib.c: (experimental) support Tcl/Tk8.6.2.
- * ext/tk/extconf.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:16 PM Bug #10290: segfault when calling a lambda recursively after rescuing SystemStackError
- I can reproduce it on 2.0.0-p576 when compiled with `-Os`, but not `-O2`:
```
$ make clean && ./configure --disable-install-doc CC=clang CFLAGS=-O2 && make -j12
$ ./miniruby -v
ruby 2.0.0p576 (2014-09-19 revision 47627) [x86_64-dar... -
- I can't reproduce following versions:
```
ruby 1.9.3p548 (2014-09-06) [x86_64-darwin13.4.0]
ruby 2.0.0p576 (2014-09-19 revision 47628) [x86_64-darwin13.4.0]
ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin13.0]
ruby 2.2.0... -
- descending order.
[ruby-core:65452] Suggested by David Grayson.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `ruby_2_1` branch has same problem.
-
- Applied in changeset r47900.
----------
* lib/find.rb (Find.find): Call to_path for arguments to obtain
strings.
[ruby-core:63713] [Bug #10035] Reported by Herwin. - 03:49 PM Revision 63fa57e9 (git): * 2014-10-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Shyouhei Urabe wrote:
> Akira, isn't it obvious this patch introduce a backward incompatibility?
> ...
The problem is how easy/difficult to modify software to follow this change.
Trying to modify test-all is a way to estimate the di... -
- David Grayson wrote:
> Hello. I think the Ruby team should reconsider the ordering of the array returned by `max` and `max_by` when the `n` argument is provided. It makes much more sense to me that it would be sorted in descending ord... -
- I got same error with ruby trunk.
-
- Applied in changeset r47904.
----------
common.mk: update-gems for older BASERUBY
* common.mk (update-gems): chdir to the target directory and then
add the tool directory to load paths, for older BASERUBY.
[Bug #10372][ruby-core:65... -
- Which version of ruby are you using to download the files?
Since 1.9, `-I` directories are expanded to absolute paths. -
- Applied in changeset r47899.
----------
* common.mk: use relative load path for bundled_gems directory.
[Bug #10372][ruby-core:65630] -
- I update this patch on Ruby 2.2.
-
- * common.mk (update-gems): chdir to the target directory and then
add the tool directory to load paths, for older BASERUBY.
[Bug #10372][ruby-core:65630]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47904 b2dd03c8-39d4-4d8f-98f... -
- * common.mk: $(srcdir)/../tool is an invalid path.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hi, tenderlove.
Please remove DL from trunk. -
10:10 AM Feature #10017: Add `Hash#fetch_values`
- Should we get some more votes here, or should I just change my patch to use fetch_values?
-
- nil も含むなら False/True よりも Falsy/Truthy の方が良いのではないでしょうか。
case で使うだけなら `:!.to_proc` と `:itself.to_proc` を使うという方法もありそうです。
(`itself` は 2.2 以降ですが。)
~~~
ruby -e '[nil, false, true, 0].each do |obj|
case obj
when :!.to_proc; p [obj... -
- I can't reproduce with trunk and ruby_2_1 branch.
-
- Ruby 2.0.0 was fixed at r41812. Ruby 1.9.3 was fixed at r42016.
Please use latest version of Ruby. -
- [Feature #9379][ruby-core:59633]
* lib/xmlrpc/config.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Ruby 1.9 is EOL status now.
Please try with Ruby 2.0 or 2.1 -
- Thank you for your report. This issue was fixed at r47693.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- Could you try with latest version of Ruby 2.1?
-
- I can't reproduce this issue on linux and osx.
If you still have this issue, please reopen this. -
-
- strings.
[ruby-core:63713] [Bug #10035] Reported by Herwin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Could you try with latest version of Ruby 2.1?
-
-
- It is not fit to Array class because Array is not only for Float.
I think it is better to implement it as an optimization of reduce(:+). -
- 開発者会議のときに、奇妙だがそういうものとしようということになった覚えがあります。
-
- [Bug #10372][ruby-core:65630]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- As long as I know about Nuby,
(I can suppose first rational and complex implementation from http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/33574
)
I guess we don't need such a comment-out anymore. -
03:48 AM Feature #10225: [PATCH] *math.c: New method Math.normcdf
- On Oct 11, 2014, at 11:18 PM, mail@tanakakazuki.com wrote:
> Sorry for my late. It's hard to say but.. ruby-gsl doesn't look good enough.
I agree that ruby-gsl has its shortcomings. GSL is a fairly large library that provides lot... -
- Not getting any feedback on implementation details, I'm assuming that nobody cares too much, and will therefore proceed. I have tried a refinement (proposal 5); I didn't see any effects on performance. But using a refinement would make i...
-
- * parse.y (remove_duplicate_keys): should keep nodes linking not
to be collected. [Bug #10315]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47898 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/12/2014
-
- @steveklabnik [Fixes GH-739] https://github.com/ruby/ruby/pull/739
* README.EXT.jp: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:44 PM Bug #10374 (Closed): FileUtils.mv can't move broken symlinks
- FileUtils.mv raises Errno::ENOENT when invoked on a broken symlink, even though the symlink does exist.
- 09:53 PM Bug #10369 (Closed): [PATCH] array.c: missing RB_GC_GUARDs
- Applied in changeset r47896.
----------
array.c: swap volatile for RB_GC_GUARD
* array.c (ary_recycle_hash): add RB_GC_GUARD
(rb_ary_diff): remove volatile
[Bug #10369]
The RB_GC_GUARD seems needed for most of the ary_recycle_hash... - 09:53 PM Revision eb514777 (git): array.c: swap volatile for RB_GC_GUARD
- * array.c (ary_recycle_hash): add RB_GC_GUARD
(rb_ary_diff): remove volatile
[Bug #10369]
The RB_GC_GUARD seems needed for most of the ary_recycle_hash
functions anyways.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47896 b2dd... - 08:44 PM Feature #10354: Optimize Integer#prime?
- I rewrote #prime? again using a better algorithm. It's about 2x faster. This version is for `Integer`, but could be reworked for `BigNum`.
~~~
class Integer
def prime?
return self >= 2 if self <= 3
return false if self ... -
- in date_core based on a patch by @vipulnsward [Fixes GH-724]
https://github.com/ruby/ruby/pull/724
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47895 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y (remove_duplicate_keys): should not simply eliminate all
value nodes, which may have side effects.
[ruby-core:65625] [Bug #10315]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:35 PM Revision 7fa39b27 (git): * 2014-10-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47893 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * .gdbinit (nd_tree): dump node tree by dump_node().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This ticket is for backport management.
r47891 added RB_GC_GUARD() in rb_mod_define_method() to protect method entry (VALUE body which can be derived from rb_block_lambda()) from unexpected GC.
It seemsd `ruby_2_1` and `ruby_2_0_0` h... -
- * proc.c (rb_mod_define_method): guard method body to prevent its
method entry from GC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:41 PM Bug #9890 (Closed): Empty Date class
- Fixed upstream by my commit https://github.com/rubygems/rubygems/pull/948.
And now merged on trunk. -
- When I do
> make update-gems
I get the following error:
~~~
-e:1:in `require': cannot load such file -- downloader (LoadError)
uncommon.mk:1084: recipe for target 'update-gems' failed
make: *** [update-gems] Error 1
~~~
The r... -
- @Tomoyuki Chikanaga san
Sorry for my delay. I was little bit puzzled about how to test well.
I suppose it's better to add not only `#adjugate` but also all of such a testcase about properties by instance variable.
I'm gonna make... -
06:44 AM Feature #10371: Use Thread#handle_interrupt in MonitorMixin
- There was an old bug that might have been related: https://bugs.ruby-lang.org/issues/4266
-
- Now that ruby has Thread#handle_interrupt, MonitorMixin can always unlock the mutex even when a timeout exception is raised.
Currently, if a timeout exception is raised in MonitorMixin#mon_exit at just the wrong time, the @mon_owner i... -
- @David MacMahon
Sorry for my late. It's hard to say but.. ruby-gsl doesn't look good enough.
And I suppose we'd better to make such a library from scratch.
(Actually I start to make other library(called Numrb)
Aside from tha... -
- As far as I know, `rb_iterate` replaced by `rb_block_call` API between Ruby 1.8 and 1.9.
And maintenance of Ruby versions 1.8 ended.
So I think we don't need to check whether rb_block_call exists. -
- https://github.com/ruby/ruby/pull/738
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:18 AM Bug #10315: Override policy for duplicated keywords
- Nobuyoshi Nakada wrote:
> Applied in changeset r47877.
> ...
There is a problem with this solution. Namely, duplicate key-value pairs are removed at parsing stage, and if they had side effects (like printing), the semantics changes.
... -
- Thanks. I'll wait a few days for others to look and try it out
before committing. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/11/2014
-
- ~~~
[PATCH] array.c: swap volatile for RB_GC_GUARD
* array.c (ary_recycle_hash): add RB_GC_GUARD
(rb_ary_diff): remove volatile
The RB_GC_GUARD seems needed for most of the ary_recycle_hash
functions anyways.
~~~
-
08:58 PM Feature #10341: Fiber switch performance improvements
- Attached a revised version of patch 5 with fiber_mark_self replaced by rb_fiber_mark_self. Thanks for the hint.
-
06:09 PM Bug #10367 (Rejected): Net::HTTP read_timeout value behaves unexpectedly.
- John Thomas wrote:
> I would think that the expected behavior of the Net::HTTP.new().read_timeout property be that if that timeout was hit during a request, a Net::ReadTimeout exception would be thrown, and the request would be killed. ... -
07:49 AM Bug #10367: Net::HTTP read_timeout value behaves unexpectedly.
- This should be assigned to NARUSE, Yui (naruse) it looks like.
-
- I would think that the expected behavior of the Net::HTTP.new().read_timeout property be that if that timeout was hit during a request, a Net::ReadTimeout exception would be thrown, and the request would be killed. Currently, however, wh...
-
- Nobuyoshi Nakada wrote:
> Just a memo:
> ...
Thanks for the information. -
- Just a memo:
~~~ruby
[1, 2].inject(:quo) #=> (1/2)
~~~ -
- And without having Rational#to_a, Array#to_r does not mean much.
So I reject this.
Matz.
-
- I think Nobuyoshi Nakada and Jeremy Evans are right. I will withdraw `to_a` from the proposal.
-
04:39 AM Feature #10365: `Rational#to_a` and `Array#to_r`
- Wouldn't the proposed Rational#to_a break backwards compatibility, as well as consistency with other numeric classes:
Currently:
Array(1) # => [1]
Array(1.0) # => [1.0]
Array(BigDecimal.new('1.0')) # => [#<BigDecimal:12c032467878... -
- IMHO, splatting a rational doesn't feel to make sense, so `to_a` doesn't feel appropriate.
-
- Sorry, I meant
2/51r.to_a # => [2, 51] -
- I guess people would want to extract the numerator and the denominator of an array. `to_a` would perhaps be a good name:
(2/51).to_a # => [2, 51]
It also might be useful if `Array#to_r` were provided as an alternative way to cr... -
04:39 PM Revision 8980a9b4 (git): * file.c: include sys/time.h only if HAVE_SYS_TIME_H
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- For some more sophisticated examples, see https://github.com/nome/coroutines. The library does work with vanilla Ruby, but the patch improves performance.
Also, similar code can be simplified by using Fiber#raise. Compare e.g. the two... - 03:13 PM Revision 23abeeb7 (git): * 2014-10-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47887 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * file.c (sys/time.h): include after unistd.h to get rid of
mismatch on struct stat and some system call functions on Linux.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:33 PM Revision 0d1b2755 (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47885 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fixes build error.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- extinit.$(OBJEXT) used to be generated by the builtin rule, thus
didn't accept custom $(CC) and caused linkage error for cross
compiling.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Note: Some of the fixes are for newlib in general but not NaCl-specific.
* include/ruby/intern.h (rb_fd_select): declare struct timeval, or the
struct gets local to the function in C99.
* file.c (#include): add nacl/stat.h for PNaCl.... -
10:58 AM Bug #10368 (Closed): GC mark miss on bindings
- 以下のコードでSEGVすることがあります。
mに渡したブロックがGCされてしまうのが原因です。
~~~ruby
def m
binding
end
GC.stress = true
b = nil
tap do
b = m {}
end
GC.start
0.times.to_a
b.eval('yield')
~~~
ブロックに対応するProcオブジェクトをrb_binding_tに持たせるようにするパッチを添付します。 - 06:33 AM Revision 3fedb512 (git): compile.c: fix RB_GC_GUARD usage
- * compile.c (iseq_build_from_ary_exception): move RB_GC_GUARD
(iseq_build_from_ary_body): use PRIsVALUE instead of RB_GC_GUARD
Currently unused functions, but we should set good examples for
using RB_GC_GUARD (and favoring PRIsVALUE i... - 06:02 AM Revision 58a73d96 (git): string.c (rb_str_intern): remove unnecessary RB_GC_GUARD
- Incorrectly placed, and no longer needed since r25351
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On the other hand, maybe we should allow Ruby-level options to `system'
to raise, but continue hiding errors when running the command itself.
In other words:
# continue old 1.8 behavior if redirect is done via shell
# (n.b. th... -
- Yes, it's intentional spec, but to raise errors `Process.spawn` and `Process.wait` are needed.
It may be good to add an option for errors to `system`. -
- * parse.y (remove_duplicate_keys): remove duplicate literal keys,
i.e., symbols and strings. [ruby-core:65368] [Bug #10315]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm.c (kwmerge_i): override existing keys by new keys.
[ruby-core:65368] [Bug #10315]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r47877.
----------
parse.y: precedence of duplicated keys
* parse.y (assocs): concatenate splatted literal hashes. the
former key has precedence even if duplicated literal keys
follow. [ruby-core:65368] [Bug ... -
- * parse.y (assocs): concatenate splatted literal hashes. the
former key has precedence even if duplicated literal keys
follow. [ruby-core:65368] [Bug #10315]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47877 b2dd03c8-39d4-4d... -
- * configure.in: remove extra right-bracket.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in (RUBY_NACL): automatically locate pnacl-clang.
(RUBY_PLATFORM): pnacl instead of le32-nacl.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- platforms other than NativeClient.
* ChangeLog: ditto. add entries for the last two commits.
Sat Oct 11 11:12:00 2014 Yuki Yugui Sonoda <yugui@yugui.jp>
* signal.c (install_signalhandler, init_sigchld): allow failure because i... -
- * signal.c (install_signalhandler, init_sigchld): allow failure because it
always fails with ENOSYS on NaCl.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in (RUBY_NACL and others): Supports PNaCl.
* dln.c: replace the old hacky dynamic loading over HTTP with nacl_io.
* file.c: tenatively use access(2) instead of eaccess.
(rb_file_load_ok): weaken with attribute but not by po... -
- Currently, rational inspection is expressed with parentheses:
(2/51)
If this were taken as a Ruby expression, it would mean integer division, whose value is `0` in this case. It does not make much sense to express that it is in... -
- properly, with a patch by @eval [Fixes GH-733]
https://github.com/ruby/ruby/pull/733
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
10/10/2014
-
- Yes, `autoload` can do the trick, but it needs a separated file and warns only once.
-
- Eric Wong <normalperson@yhbt.net> wrote:
> http://80x24.org/spew/m/opt-str-lit-v1%40m.txt
Benchmark suite so far:
http://80x24.org/spew/m/opt_str_lit-v1-bench%40whir.txt
Note: this increases iseq size and can slow some perfo... -
- Current patch (named "opt_str_lit" insn):
http://80x24.org/spew/m/opt-str-lit-v1%40m.txt
One VM instruction now optimizes away object allocation for string
literals in the following cases:
* "lit" % obj
* str << "lit"
* "li... -
09:59 PM Bug #9681: miniruby Bus Error at 0x3d44c4
- Hello, are there any plans to fix this issue in Ruby 2.1.4?
- 07:16 PM Feature #10361 (Closed): Support open_timeout option in open-uri
- Applied in changeset r47869.
----------
open-uri: accept :open_timeout option
* lib/open-uri.rb (OpenURI::Options): add :open_timeout default
* (def OpenURI.open_http): check :open_timeout option
* (module OpenURI): rdoc for :open_time... -
09:46 AM Feature #10361 (Closed): Support open_timeout option in open-uri
- I found it weird that open-uri accepts read_timeout option, but not open_timeout.
I believe this option should be added. - 07:16 PM Revision b394484a (git): * 2014-10-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:15 PM Revision 9559b04e (git): open-uri: accept :open_timeout option
- * lib/open-uri.rb (OpenURI::Options): add :open_timeout default
* (def OpenURI.open_http): check :open_timeout option
* (module OpenURI): rdoc for :open_timeout
* test/open-uri/test_open-uri.rb (test_open_timeout): new test
[Feature #1... -
- bdimych@narod.ru wrote:
> irb(main):013:0* system 'cmd', '/c', 'echo', 'aaa', :out => File.open('bad/file.txt', 'w')
> Errno::ENOENT: No such file or directory - bad/file.txt
> from (irb):13:in `initialize'
> from (i... -
10:04 AM Bug #10362 (Closed): spawn doesn't raise exception on redirection error
- ~~~
irb(main):002:0*
irb(main):003:0*
irb(main):004:0* system 'cmd', '/c', 'echo', 'aaa'
aaa
=> true
irb(main):005:0>
irb(main):006:0*
irb(main):007:0*
irb(main):008:0* system 'cmd', '/c', 'echo', 'aaa', :out => ['bad/file.txt',... -
03:53 PM Bug #10364 (Rejected): Malformed CSV Header Causes NoMethodError
- The method CSV#readline raises a "NoMethodError: undefined method 'encode' for nil:NilClass" exception when the CSV file's header row contains a trailing delimiter (a comma in my case). The following CSV data can be used to recreate thi...
-
- * thread.c (only_if_constant): get rid of __builtin_choose_expr()
on older gcc.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * configure.in (__builtin_choose_expr_constant_p): in gcc 4.8 or
earlier, __builtin_choose_expr() does not consider
__builtin_constant_p(variable) a constant expression.
* include/ruby/ruby.h (RUBY_SAFE_LEVEL_CHECK): fix for older g... -
- * include/ruby/ruby.h (RUBY_SAFE_LEVEL_CHECK): eliminate function
call for warning/error if not match to get rid of unconditional
warning/error by a certain compiler option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47866 b2... -
- * io.c (rb_io_make_open_file): remove useless backslash.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47864 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:16 AM Feature #10355: Feature request: Module#prepended?(mod)
- 提案する名前について `prepended?` は正しくありませんでした。`prepend?` が正しいです。訂正します。
-
- メソッド定義が上書きされているかどうかを調べたいというより、誰がownerでもいいけど確実にprependされていてほしい、という方が要求として正確なように思います。
-
- このメソッドに反対なわけではないですが、メソッド定義が上書きされているかどうかを調べたいのであれば、`UnboundMethod#owner`などを使うほうがいいのではないでしょうか。
-
- 特定メソッドの出力のフィルタをprependによって実現したい場合、親クラスで既にprependされていても子クラスでメソッド定義が上書きされればprependが実際には効かないことになります。
このような状態が起きてないかどうかを調べる必要がある(起きていればprependしなおす)、というケースで Module#prepended? 相当の機能が必要となります。
フレームワークなどの記述において、DI等で挿入されたオブジェクトの機能を調べてコントロールする用... -
- ある機能が prepend によって追加されているかどうかを調べたいときに Module#include? では不十分です。
継承関係の親クラスにおいて prepend されたモジュールのメソッドは、子クラスでも定義が存在する場合、実際には呼び出されません。
~~~ruby
module P
def myname
str = super
"p" + str
end
end
class X
def myname
... -
- あるモジュール X に対してモジュール P1 がprependされているかどうかを調べる方法があると嬉しく思います。
`Module#include?` を使うと継承関係に含まれているかどうかはわかりますが、それが対象モジュールに対してprependされたものかは分かりません。
~~~ruby
module P1; end
module P2; end
class X
prepend P1
end
class Y< X
prepend ... -
- @Nobuyoshi Nakada san
I'm so sorry... I just did grep by `rb_math_cos`, `rb_math_sin`, and so on... forgot C-lang has macro.
Thank you for your time. I should learn more. -
- Aren't they used in complex.c?
-
- I wondering which is preferred, remove or comment-out.
I came to the conclusion that we can invoke such a function when the time we need come. -
03:40 AM Feature #10354: Optimize Integer#prime?
- Oups, it would help if I gave the right implementation for Bignum#prime? See below
Here are some benchmarks:
Benchmark over 1..1_000_000
Current prime lib: 15.54
Fixed prime lib: 7.13
Nick's: 2.49
Benchmark for... -
- Nick Slocum shows in https://github.com/ruby/ruby/pull/736 that Integer#prime? can be optimized quite a bit.
First, that's because there are some basic things to avoid in the current lib, like needlessly capturing blocks and there's a... -
03:31 AM Feature #10351: [PATCH] prevent CVE-2014-6277
- On 10/10/2014 02:16 AM, Eric Wong wrote:
> shyouhei@ruby-lang.org wrote:
>> This patch does not add a new feature, nor delete anything. It just
>> changes the default behaviour when ruby spawns subprocesses.
>>
>> Process.spaw... -
- Akira, isn't it obvious this patch introduce a backward incompatibility?
I'd be surprised if it could passed the tests, because that means our tests are insufficient. Is it that important to pass make check at this point?
I don't... -
-
02:58 AM Bug #10353 (Closed): weird behavior when dynamically adding method using instance_eval
- Earlier this week I cross by a weird bug using a gem and after digging into the problem I found this issue with MRI.
I could not reproduce it on 1.9.3-p545 nor on the 2.2.0-preview1, the issue occurs on the 2.1.2
~~~
2.1.2 :001 > cl... -
- * io.c (rb_io_make_open_file): move from include/ruby/io.h, and
hide too detailed implementations.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:27 AM Revision 0d3d17b9 (git): * 2014-10-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * include/ruby/io.h (rb_io_mode_flags, rb_io_modenum_flags):
deprecate old macros for compatibility for ruby 1.8 and older.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e