Activity
From 11/26/2013 to 12/02/2013
12/02/2013
-
11:59 PM Bug #9198 (Closed): Segfault in TestException#test_machine_stackoverflow
- I observe segfault in TestException#test_machine_stackoverflow test case for -preview2. Please see attached log.
-
11:50 PM Bug #9178: Segfault when misusing Enumerable#chunk with #to_enum and #with_index
- r43929 was backported to ruby_2_0_0 branch at r43961.
r39594 and r39596 were also required to backport. see #8010. -
- r39594 and r39596 were backported to ruby_2_0_0 branch at 43960.
-
11:19 PM Bug #9173: rb_sprintf %li format specifier does not work correctly with long values and can cause Ruby to crash
- I was trying to find confirmation of the change before posting this issue but I was unable to find a reference. Thank-you for clarifying, this can be closed.
-
- r43853 was backported to ruby_2_0_0 branch at r43959.
-
10:52 PM Bug #9192: Inconsistent comparison between Float and BigDecimal
- Sorry, I've not read your code carefully. # from my iPhone
I'll look it again tommorrow. -
06:54 PM Bug #9192: Inconsistent comparison between Float and BigDecimal
- nobu (Nobuyoshi Nakada) wrote:
> Sounds like the old usual floating point number error.
I don't think so. BigDecimal('706.06') is exact. 706.06 is a float, and therefore can't be represented exactly. That means that it's either repre... -
04:28 PM Bug #9192: Inconsistent comparison between Float and BigDecimal
- Regardless the floating point computational representation, shouldn't we expect the same result for following statements?
BigDecimal('706.06') <= 706.06
and
706.06 >= BigDecimal('706.06')
-
- Sounds like the old usual floating point number error.
-
- I was checking a possible inconsistency on ActiveModel and I found situations where comparing BigDecimal to Float differs to comparing Float to BigDecimal.
I have create a simple ruby script to exemplify the problem. The script is att... -
- Yes, I saw #9133 after I've written the previous comment.
Anyway, this ticket should be opened for trunk. We have to handle these issues separately. -
09:40 PM Bug #9130: logger continues to write in old log file after rotation
- nagachika (Tomoyuki Chikanaga) wrote:
> This issue seems introduced by r43511. So I assign this to naruse san.
No. This bug is what logger.rb has been having for a long time.
The above patch fixes the newly implemented method for si... -
- This issue seems introduced by r43511. So I assign this to naruse san.
-
10:34 PM Bug #9189 (Assigned): Build failure on Windows in case of nonascii TEMP environment.
- r43950 (and r43958) is only a workaround.
We have to change the entire implementation of ENV to treat encoding. -
- This issue was solved with changeset r43950.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* hash.c (getenv): use ANSI codepage version of getenv() for mi... -
- Ah, I see.
There is a bug of handling the environment variables in miniruby.
I'm debugging it now... -
10:32 PM Misc #9197 (Closed): Remove RAA from lib/erb.rb documentation
-
- This issue was solved with changeset r43958.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* hash.c (getenv): fixed test failures introduced by r43950.
... -
02:44 PM Bug #9195: r43951 raised many test failures of TestProcess and TestEnv on vc10-x64-trunk
- Sorry, The revision is r43950, not r43951.
-
02:21 PM Bug #9195: r43951 raised many test failures of TestProcess and TestEnv on vc10-x64-trunk
- >phasis68
r43951 is only bump version. Can you investigate broken commit? -
- It seems that r43951 caused side effect of ENV handling.
After r43951, I can see 13 failures and 1 error which are related with ENV.
Here is somes test failures from http://ruby-mswin.cloudapp.net/vc10-x64/ruby-trunk/log/20131202T011... -
05:26 PM Feature #9196 (Closed): Module#constants(false) should not use a hashtable internally - This issue was solved with changeset r43956.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* variable.c (rb_mod_constants): when calling Module#constants... - 05:13 PM Feature #9196 (Closed): Module#constants(false) should not use a hashtable internally
- Module#constants always uses a hashtable to ensure that only unique constant names are returned - even when called with the `inherit` argument set to false.
Rails calls constants(false) heavily during boot and the use of a hashtable c... -
04:59 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
- > i think that the most useful part of this proposal is deprecating `Numeric#nonzero?` with its current behavior in favour of `Numeric#nonzero`.
Personally I would agree with this too. I guess I'm not a fan of quirks if they're inconsis... -
- >luislavena
If you still happened this issue, please reopen this. -
- * enumerator.c (enumerator_with_index): should not store local variable
address to memoise the arguments. it is invalidated after the return.
[ruby-core:58692] [Bug #9178]
git-svn-id: svn+ssh://ci.ruby-lang.org/rub... -
- * enumerator.c (enumerator_with_index_i): allow Bignum as offset, to
get rid of conversion exception and integer overflow.
[ruby-dev:47131] [Bug #8010]
* enumerator.c (enumerator_with_index): Restore handlin... -
02:21 PM Bug #9125: Net::SMTP - invalid method raised when attempting to connect using STARTTLS
- All other callers of #critical expect a Net::SMTP::Response so it seems Pawel's patch is correct.
-
- This issue was solved with changeset r43954.
Pawel, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/net/smtp.rb (Net::SMTP#critical): Always return a
Net::... -
- * file.c (rb_readlink): fix buffer overflow on a long symlink. since
rb_str_modify_expand() expands from its length but not its capacity,
need to set the length properly for each expansion.
[ruby-core:58592]... -
01:59 PM Feature #9190: Expose serial helper macros
- I would like to see these exposed as well. They provide visibility into VM behavior, and are very useful for measuring how many constant or method table invalidations are happening in large applications.
- 01:45 PM Feature #9190: Expose serial helper macros
- > Why do you need those internal values?
We have something similar in our custom build of Ruby. It's very useful for performance metrics. -
-
- Why do you need those internal values?
-
07:50 AM Feature #9190: Expose serial helper macros
- After addressing a Pull Request comment, the methods are defined on RubyVM:
RubyVM.method_serial
RubyVM.constant_serial -
- I've defined RubyVM::InstructionHelper with singleton methods #method_serial and #constant_serial. They delegate to helper macros GET_METHOD_SERIAL() and GET_CONSTANT_SERIAL().
With these methods, users have visibility into the metho... -
- Please retry with 2.0.0p353.
-
- No time was wasted, I wanted to be sure your use-case was understood.
As you requested, this issue is now closed. - 01:31 PM Revision ff9f9c6d (git): * hash.c (getenv): fixed test failures introduced by r43950.
- [ruby-core:58774] [Bug #9195] reported by phasis68 (Heesob Park).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:59 PM Revision ead0c5d3 (git): * hash.c (rb_hash_rehash): make temporary st_table under the control
- of GC. [Bug #9187]
* test/ruby/test_hash.rb: add a test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- duplicated. please move to #8872
-
12:08 PM Misc #9146: Update documentation for lib/abbrev.rb
- Thanks for the patch, I'll review and give you some feedback soon!
-
- 11:51 AM Bug #9186: json/pure.rb missing on trunk
- > Can you please elaborate more? Do you mean JSON is now cross-compile unsafe? It seems horrible.
This was a long time ago, and I can't recall specific details. I was just using this as an example of when C extensions may not work pro... -
10:53 AM Bug #9186: json/pure.rb missing on trunk
- 2013/12/1 charliesome (Charlie Somerville) <charliesome@ruby-lang.org>:
>
> Issue #9186 has been updated by charliesome (Charlie Somerville).
>
>
>> Hmm.. When? It shouldn't happen on CRuby.
>
> It isn't a common use case,... - 09:14 AM Bug #9186: json/pure.rb missing on trunk
- > Hmm.. When? It shouldn't happen on CRuby.
It isn't a common use case, but I have experienced some issues with C extensions when cross-compiling CRuby. -
- > there's also probably some situations where C extensions can't be loaded in CRuby.
Hmm.. When? It shouldn't happen on CRuby. - 06:55 AM Bug #9186: json/pure.rb missing on trunk
- @vo.x: I noticed this because it was breaking on Rubinius - there's also probably some situations where C extensions can't be loaded in CRuby.
-
- I'm just wondering, what should be the circumstances that C extension is missing?
-
- This is a very long standing test failure since 2013-03-23.
If you think this is a intended behavior and don't want to apply any patch, please remove this test case.
-
- Is there any concerns about this issue?
I made another patch.
http://paste.ubuntu.com/6487604/
It solves the test failure and also enforce 64-bit time_t type on MinGW64 32-bit build. -
- I cannot reproduce on Mac OS X 10.9 (Mavericks).
What's your environment. Please check if it is reproducible with 2.0.0-p353 and trunk?
-
-
- Please try ruby-2.0.0p353 with your code.
-
- Fixed at r43370.
-
- duplicated #9192
-
- I was checking a possible inconsistency on ActiveModel and I found situations where comparing BigDecimal to Float differs to comparing Float to BigDecimal.
I have create a simple ruby script to exemplify the problem. The script is att... - 08:26 AM Revision 39a8519a (git): * variable.c (rb_mod_constants): when calling Module#constants with
- inherit=false, there is no need to use a hashtable to deduplicate
constant names. [Feature #9196] [ruby-core:58786]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:12 AM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
- Matz, whether you reject this or not, I still would like to understand the reason for current behavior, it's not an accident, someone deliberately coded this.
-
- This issue was solved with changeset r43953.
Satoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/rubygems: Update to RubyGems master baa965b. Notable c... -
05:36 AM Revision 01b1f004 (git): * lib/csv.rb: [DOC] Fix typos
- s/occurrs/occurs/, s/interation/iteration/, s/intetionally/intentionally/,
s/modfied/modified/, s/axception/exception/, s/curcuit/circuit/
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43955 b2dd03c8-39d4-4d8f-98ff-823fe69... -
- Net::SMTP::Response. Patch by Pawel Veselov.
[ruby-trunk - Bug #9125]
* test/net/smtp/test_smtp.rb: Test for the above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
04:13 AM Bug #9005: object.send(:define_method, ...){...} creates private method
- Ran against trunk:
```
-e:1:in `<main>': private method `foo' called for :foo:Symbol (NoMethodError)
``` -
- (already finished)
-
- Thank you for your long description.
I would like to also know how we educate all the people to take care of Windows.
12/01/2013
-
- Yes, it shows the correct path.
C:\work\ruby-2.1.0-r43936>miniruby.exe -e "system('set TEMP')"
TEMP=C:\Users\희섭\AppData\Local\Temp
BTW, In Visual C++ compiler, I can see same build failure with non-ascii USERNAME environment varia... -
- Is TEMP changed by miniruby?
miniruby -e "system('set TEMP')"
shows the correct path? -
- Yes, the error message is not from ruby, but from mingw compilers.
And I found TMP environtment variable is the actual cause of this error.
Nevertheless, I think Ruby is not entirely free from this error.
If I run "ruby extconf.rb" ... -
- "This application" is not ruby.
It's your compiler.
Please contact the compiler's support team for more information :) -
- I experienced a build failure during build extension library with trunk on Windows.
make[2]: Entering directory `/c/work/ruby-2.1.0-r43936/ext/bigdecimal'
generating bigdecimal-i386-mingw32.def
compiling bigdecimal.c
In file in... -
09:41 PM Bug #8584: Remove curses
- (Sidenote, not related to this, but all of ruby's stdlib should become as modular as possible, so users could toggle on/off what components of ruby they want to have included, perhaps with rubygems able to allow for this. "gem uninstall ...
-
- \o/
-
- I agreed to remove curses from Ruby 2.1 and create github.com/ruby/curses
>naruse
How do you think about this? -
- Copy directories to lib/ when installing extensions. This completes
the fix for [ruby-trunk - Bug #9106]
* test/rubygems: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- duplicated to #8932
-
07:23 PM Misc #9188: r43870 make benchmark/bm_so_k_nucleotide.rb slow
- Unfortunately, r43870 is a trade-off and optimized for frequently-reused
keys.
How about only using rb_fstring for string literal hash keys? -
- =(
Maybe we should revert it? -
05:44 PM Misc #9188 (Closed): r43870 make benchmark/bm_so_k_nucleotide.rb slow
- Hi.
I think r43870 make benchmark/bm_so_k_nucleotide.rb slow.
r43870
% time ./miniruby ./benchmark/bm_so_k_nucleotide.rb
./miniruby ./benchmark/bm_so_k_nucleotide.rb 1.70s user 0.01s system 99% cpu 1.718 total
r43869
% time ... -
05:06 PM Revision 46e44fb6 (git): * test/ruby/test_case.rb (test_nomethoderror):
- Add test related to r43913, r43914
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:56 PM Revision 54f6020d (git): * 2013-12-02
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:55 PM Revision 6b1a58b9 (git): * hash.c (getenv): use ANSI codepage version of getenv() for miniruby
- on Windows.
[ruby-core:58732] [Bug #9189] reported by phasis68 (Heesob Park).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `class_alias' sounds like an alias of a class, to me, so the latter name feels better.
Anyway, it can implement in pure ruby, and you'd be able to make it as a gem. -
- Hi core team,
First drink a Calpis (カルピス Karupisu) before reading on :-)
Now, my proposal is to add a slight new feature that is mostly one of convenience.
We have two ways to use aliases:
(1) alias
(2) alias_method
But a... - 02:28 PM Bug #9187 (Closed): st_table leaks when exception is raised in Hash#rehash
- This issue was solved with changeset r43942.
Masaki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* hash.c (`rb_hash_rehash`): fix to free new `st_table` ... -
- Following code causes leakage of st_table:
~~~ruby
class Foo
def initialize
@raise = false
end
def hash
raise if @raise
@raise = true
return 0
end
end
h = {Foo.new => true}
10_0000.times do
h... -
- Many wiki pages have become outdated and spam-ridden, we will import
these to trunk and begin maintaining them in ruby-trunk. This will
also allow new contributors to easily contribute patches to update
these pages, where previousl... -
- Thank you tmm1!
There is also rbtree2 (https://github.com/kitak/rbtree2), that is also seemingly unmaintained, but perhaps they will be more willing to do a release. Ofcourse, it would be best if we could get OZAWA-san to respond to t... -
- The following patch fixes rbtree on ruby 2.1: https://gist.github.com/tmm1/7609371
I emailed it to burningdowntheopera@yahoo.co.jp 8 days ago, but no response. -
10:41 AM Bug #9155: DelegateClass - ArgumentError: not delegated
- Submitted a pull request for this:
https://github.com/ruby/ruby/pull/459 -
07:04 AM Bug #9155: DelegateClass - ArgumentError: not delegated
- See - https://github.com/ruby/ruby/pull/459 for a fix
-
- I'd like to add a before_fork{} hook that fires in the parent before the fork. An after_fork hook in the parent seems unnecessary.
-
- "tmm1 (Aman Gupta)" <ruby@tmm1.net> wrote:
> Simple implementation of an after_fork{} hook: https://github.com/tmm1/ruby/commit/711a68b6599d176c5bcb4ef0c90aa195a290d1c0
>
> Any objection?
I think there needs to be separate h... -
07:12 AM Feature #5446: at_fork callback API
- tmm1 (Aman Gupta) wrote:
> Simple implementation of an after_fork{} hook: https://github.com/tmm1/ruby/commit/711a68b6599d176c5bcb4ef0c90aa195a290d1c0
> ...
Sounds good and useful to me! -
- Simple implementation of an after_fork{} hook: https://github.com/tmm1/ruby/commit/711a68b6599d176c5bcb4ef0c90aa195a290d1c0
Any objection? -
- Here is another example of a gem which implement its own fork hooks: https://github.com/zk-ruby/zk/blob/master/lib/zk/fork_hook.rb
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:42 AM Bug #9186 (Rejected): json/pure.rb missing on trunk
- Line 60 of ext/json/lib/json.rb requires json/pure if json/ext cannot be required.
This file is missing on trunk, meaning the JSON library is broken unless the C extension is present. -
- I found my bug!
I didn't recursively copy the files.
Fix soon! -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43945 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- This should be fixed with r43937
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- is raised in do_hash(). [Bug #9187]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:53 AM Misc #8962: [DOC] add step to enable Generational GC merits in README.EXT*
- ping?
2013/10/16 zzak (Zachary Scott) <e@zzak.io>
>
> Issue #8962 has been updated by zzak (Zachary Scott).
>
> Status changed from Open to Assigned
>
> Koichi, could you add some notes on this, maybe link to help...
11/30/2013
-
- Implement gem.deps.rb (Gemfile) .lock support
Fixed `gem uninstall` for a relative directory in GEM_HOME.
* test/rubygems: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43939 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This issue was solved with changeset r43935.
tadayoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
dir.c: check unknown keywords
* dir.c (dir_initialize): che... - 09:02 PM Revision 6727297d (git): * 2013-12-01
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43938 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- free slots to fix test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43937 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This issue was solved with changeset r43932.
Heesob, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
win32ole.c: correct declaration
* ext/win32ole/win32ole.c (has... -
- r43910 introduced a build failure in RubyInstaller CI:
http://ci.rubyinstaller.org/job/ruby-trunk-x86-build/2730/console
compiling ../../../ext/win32ole/win32ole.c
../../../ext/win32ole/win32ole.c:3305:1: error: conflicting types ... -
- This issue was solved with changeset r43930.
Bertram, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
eval.c: determine exit status and signal before finalization
... -
- Fundamentally, subclasses of Exception are not expected other than T_OBJECT.
And I couldn't reproduce it with the trunk, can't you show your backtrace? -
- This issue was solved with changeset r43929.
Hans, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
enumerator.c: should not store local variable address
* enumerat... -
- [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- This issue was solved with changeset r43928.
Alban, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
siphash.c: fix missing condition
* siphash.c (sip_hash24): fix ... -
- * dir.c (dir_initialize): check unknown keywords. [ruby-dev:47152]
[Bug #8060]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_insnhelper.c (rb_extract_keywords, rb_check_keyword_opthash):
extract from vm_callee_setup_keyword_arg.
* class.c (rb_scan_args): check if keys of keyword hash are symbols.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43934... -
- * lib/irb/workspace.rb: [DOC] Fix typo (s/binging/binding/)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43933 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/win32ole/win32ole.c (hash2named_arg): correct declaration to fix
build failure. a patch by phasis68 (Heesob Park) at
[ruby-core:58710]. [Bug #9184]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43932 b2dd03c8-39d4-4d8f-9... -
- * vm_dump.c (rb_vmdebug_debug_print_pre): suppress warning on a
platform ptrdiff_t is shorter than long int.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43931 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- No, just a usual bug which aborts by local filesystem access.
-
- * eval.c (ruby_cleanup): determine exit status and signal to terminate
before finalization, to get rid of access destroyed T_DATA execption
object. [ruby-core:58643] [Bug #9167]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@439... -
- * enumerator.c (enumerator_with_index): should not store local variable
address to memoise the arguments. it is invalidated after the return.
[ruby-core:58692] [Bug #9178]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43929 b2d... -
- * siphash.c (sip_hash24): fix for aligned word access little endian
platforms. [ruby-core:58658] [Bug #9172]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43928 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_eval.c (rb_yield_block): implement non-nil block argument.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43927 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * range.c (range_each): revert the old behavior, no block is given to
the yielded block.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43926 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- IRB::Localeクラス内に、@modifier というインスタンス変数があるのですが、attr_reader が :modifieer とtypoしています。
この必ずnilを返す属性を使っていた人が居るとも思えないので、添付のパッチのように単に :modifier に直すだけで良いように思いますが、念のためパブリックAPIを保持したければ以下のメソッドも追加しておくぐらいでしょうか…。
def modifieer
@modifier... -
02:46 AM Revision 07c15e8b (git): * ext/tk/extconf.rb: show the reason of why ignore tclConfig.sh/tkConfig.sh.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43925 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:20 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
- alexeymuranov (Alexey Muranov) wrote:
> Please correct me if i am wrong, but i think that the most useful
> ...
There _is_ _no_ useful part in this proposal. Its only effect is an
endless discussion between people, who embrace Ruby an... -
01:29 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
- Please correct me if i am wrong, but i think that the most useful part of this proposal is deprecating `Numeric#nonzero?` with its current behavior in favour of `Numeric#nonzero`.
-
- I found a method name typo in FileUtils.
Since this Entry_ class is only for internal use, maybe it's OK to just rename the method with the attached patch?
11/29/2013
-
11:23 PM Feature #9179 (Closed): MatchData#values_at should support named capture
- =begin
Using (({MatchData#[]})), we can access a named capture by its name.
/(?<a>...)/.match("foo")[:a] #=> "foo"
/(?<a>...)/.match("foo")["a"] #=> "foo"
But (({MatchData#values_at})) accepts only Integer and refuses Symbol... -
- eweb (Eamonn Webster) wrote:
> Ever asked someone 'Do you know the time?' and they answer 'Yes'. So you ask 'What time is it?' and mutter 'Jerk!' under your breath.
> ...
Between `#know_time?` and `#time_now!`, i would prefer the secon... -
10:22 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
- Humans don't have to ask if a number is not a zero :)
-
10:00 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
- Ever asked someone 'Do you know the time?' and they answer 'Yes'. So you ask 'What time is it?' and mutter 'Jerk!' under your breath.
Ruby is a friendly language, let's not turn it into a jerk. -
- Just for the record, I only said I can see how this behavior can be useful in cases you want to consider 0 (zero) as falsey. But I do actually prefer that boolean methods (those ending with a question mark) do always returned strict bool...
-
03:07 AM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
- There is no use-case for this request and it would cause many incompatibilities (e.g. in rake, thor, ruby itself, ...):
https://github.com/jimweirich/rake/blob/bfafc3a0/lib/rake/application.rb#L300
https://github.com/ruby/ruby/blob/8... -
- You can use Process.exit! in such a situation.
Try appending "Process.exit!(0)" at the end of your code.
-
09:36 PM Bug #9177 (Third Party's Issue): Can't exit curses program and retain screen contents
- Hi!
Please try the attached program.
Expected result:
* After you hit some key, the program should quit and the "Hit any key" message should still be visible on screen
Current result:
* When the program exits, the screen conte... -
09:59 PM Bug #9178: Segfault when misusing Enumerable#chunk with #to_enum and #with_index
- does also crash on
ruby 2.0.0p299 (2013-08-29) [x86_64-linux-gnu]
ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-linux]
-
- [1].to_enum(:chunk).with_index {|c,i| i == 5}.to_a
does not crash on "ruby 2.0.0p0 (2013-02-24 revision 39474) [i686-linux]"
-- Control frame information -----------------------------------------------
c:0026 p:---- s:0089 e:00008... -
09:14 PM Bug #9176 (Closed): test_gc_reason failed.
- =begin
test_gc_reason failed always at 'make test-all' In my environment.
1) Failure:
TestGc#test_gc_reason [.../test/ruby/test_gc.rb:84]:
<{:gc_by=>:newobj}> expected but was
<{:major_by=>:nofree, :gc_by=>:method, :immediate_... -
- ちょっと正確なrevisionは出ませんが、最近の笹田さんと樽家さんの変更で
問題が出なくなったんじゃないかと。
一応閉じておきます。 -
- こちらどうでしょう。時間経っていますが引き続き調査します?
-
- Please try 1.9.3-p484
-
-
-
- >Linda_pp
shyouhei さんと kosaki さんのコメントに関して何か意見ありましたらお願いします。 -
-
-
- Could you review this?
-
- ko1: Could you review this?
-
- s/currenly/currently/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/tk/sample/scrollframe.rb: forgot a Module definition.
* ext/tk/extconf.rb: check unsupported version of tclConfig.sh/tkConfig.sh. It is because current Ruby/Tk doesn't support Tcl/Tk8.6.
* ext/tk/extconf.rb: change search step of... -
- There is still NoMemoryError on Windows with trunk.
C:\Users\phasis>ruby -v -rbigdecimal -e "p BigDecimal('1e-10').power(1e8)"
ruby 2.1.0dev (2013-11-28 trunk 43886) [i386-mingw32]
-e:1:in `power': failed to allocate memory (NoMemor... -
03:22 PM Bug #6986 (Closed): Inconsistent result of BigDecimal#power
- I think it is fixed in bigdecimal version 1.2.3.
-
03:29 PM Revision 2fd4dec9 (git): fix typos
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43922 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43921 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 03:21 PM Revision e65cb023 (git): * 2013-11-30
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- It is corrected in 1.2.3.
$ ruby -ve 'gem "bigdecimal", "1.2.3"; require "bigdecimal"; puts BigDecimal(2).power(1e20)'
ruby 1.9.3p484 (2013-11-22) [x86_64-darwin12.5.0]
Infinity
$ ruby -ve 'gem "bigdecimal", "1.2.3"; require "big... -
- s/arguement/argument/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_parse.rb: Fix typo in a test name.
s/allowd/allowed/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:01 PM Revision 44cb6eae (git): * vm_dump.c (rb_vmdebug_debug_print_pre): Bugfix. Get PC directly.
- PC is cached into local stack and cfp->pc is incorrent at next of
branch or jump.
* vm_exec.h (DEBUG_ENTER_INSN): catch up this change.
* vm_core.h: update signature of rb_vmdebug_debug_print_pre.
git-svn-id: ... - 11:45 AM Revision 511cc1db (git): * compile.c : Bugsfix for dump_disasm_list.
- rb_inspect denies a hidden object. So, insert rapper that creates
the unhidden one.
adjust->label is null sometimes.
insn_data_line_no makes no sense at all.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tru... -
11:34 AM Bug #8326: Running Redmine unter Ruby 2.0.0 produces an "Illegal instruction(coredump)" under AIX 7.1
- This turns out to be issue related to optimization, we were able to workaround this using ruby compiled with xlc flags "-O -qhot". Hope it helps someone. Thanks!!
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- and class of `pattern` has `method_missing`
[Bug #8882] [ruby-core:58606]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_eval.c (rb_yield_block): yield block with rb_block_call_func
arguments.
* range.c (range_each): use rb_yield_block.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43912 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * include/ruby/ruby.h (RB_BLOCK_CALL_FUNC_ARGLIST): constify argv.
* enum.c (rb_enum_values_pack): ditto.
* vm_eval.c (rb_block_call, rb_check_block_call): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43911 b2dd03c8-39d4-4d8... -
- * include/ruby/ruby.h (RB_BLOCK_CALL_FUNC_ARGLIST): for declaration
argument list of rb_block_call_func.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * include/ruby/ruby.h (rb_block_call_func_t): strict check for
rb_block_call_func* if RB_BLOCK_CALL_FUNC_STRICT is set.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43909 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * array.c (take_i), range.c (first_i): make rb_block_call_func
compatible.
* enum.c (collect_all, DEFINE_ENUMFUNCS): add blockarg.
* enum.c ({min,max,minmax,chunk,slicebefore}_ii): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/... -
- Oops, @ko1 is right.
The issue at hand is that fstrings were allowed to be shared strings. With rb_gc_mark(), the shared string was more likely to get marked (due to the mark_stack addition). But there were still cases where the share... -
- Seems useful to be able to check for presence (as opposed to falsyness) and receive the value
class Hash
def has_key?(key, &block)
val = fetch(key){return false}
block.(val) if block
true
end
end
if h.has_k... -
05:00 AM Bug #9173: rb_sprintf %li format specifier does not work correctly with long values and can cause Ruby to crash
- This is now expected behavior. %i starting in 2.0 means you need to provide a ruby object (VALUE) argument, not an integer. You need to switch from %li to %ld.
-
- There is additional handling of %i versus %d in BSD_vfprintf (>= 2.0). When l (long) is specified as the length, %li, the additional handling is triggered.
Note: %ld works fine, %li and %ld work in Ruby 1.9.3
Sample Code:
## spri... -
04:55 AM Bug #9124: TestSocket errors in test-all on Arch 64-bit
- normalperson (Eric Wong) wrote:
> Linux patch to fix this:
> ...
Ah, I see. I'll check again when Arch pushes an update to 3.12.1-3-ARCH. Thank you for the info. -
- * include/ruby/ruby.h (rb_block_call_func): add blockarg. block
function can take block argument, e.g., proc {|&blockarg| ...}.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:57 AM Revision 93bfdb9d (git): * 2013-11-29
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- s/Extentions/Extensions/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/28/2013
-
10:53 PM Bug #9172: siphash faulty on arm little endian with word align - missing code
- I confirmed the issue on my BeagleBone Black.
$ ./miniruby -ve 'p ["discoverer".hash, "sub-setter".hash]'
ruby 2.1.0dev (2013-11-28 trunk 43540) [armv7l-linux-eabihf]
[-51053038, -51053038]
I think this is a bug of th... -
- nobu what do you think?
what is "collision.rb"? -
09:01 PM Bug #9172 (Closed): siphash faulty on arm little endian with word align - missing code
- siphash.c check for "little endian+unaligned word access" and
"bigendian". But my arch : armv7-a cortex a9 is little endian word
aligned. This discard the loop that reduce the input below 8 bytes and a
case when the leftover is four b... -
- Now I finally understand the purpose of nonzero? :) In several languages, including Perl and JavaScript, 0 is a falsy value, but this is not the case for Ruby. So it's kind of a hack to make 0 be treated as a falsy value :) Indeed, now t...
-
03:11 PM Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
- nonzero? returning the number is useful; I used this recently:
t '.items_count', count: items_count.nonzero? || t(.'no')
It returns the number or, if it's zero, the proper translation for no (generating a "no items" message).
I ... -
07:44 PM Feature #8998: string keys for hash literals should use fstrings
- > The regression was indeed caused by r43718, and has been resolved with r43887.
No. Before r43718, it works accidentally.
-
- The regression was indeed caused by r43718, and has been resolved with r43887.
-
- Here is a simple patch to use fstrings for the table backing symbols.
Unfortunately it causes a segfault in test/rdoc/test_rdoc_parser_ruby.rb. Maybe someone wants to investigate.
~~~diff
diff --git a/parse.y b/parse.y
index 8207... -
- * common.mk (Doxyfile): tool/file2lastrev.rb needs running with
BASERUBY since r43617. [ruby-dev:47823] [Bug #9169]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- s/FixNum/Fixnum/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- setup entry for commits, its not required. Actually easier if
contributors don't include a ChangeLog entry.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- rules
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43900 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43899 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
11:55 AM Bug #9170 (Closed): Math.sqrt returns different types when mathn is included; breaks various gems - this bug can be reproduced in Ruby 1.8 as well
- Math.sqrt() usually returns a Float or throws an exception. Some gems rely on this behaviour (e.g. by calling nan? on the results of a calculation that includes a sqrt).
After requiring mathn, Math.sqrt() returns an Integer in some ca... -
- Please report to rvm issue before ruby-core issue.
-
- than 2.0.0p353.
* benchmark/bm_hash_keys.rb: added. r43896 is about 5 times faster
than 2.0.0p353.
* benchmark/bm_hash_values.rb: added. r43896 is about 5 times faster
than 2.0.0p353.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/tr... -
- from wiki page: HowToRequestFeatures
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43897 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43896 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- * include/ruby/st.h: add prototypes for above.
* hash.c (rb_hash_values): use st_values_check() for performance
improvement if VALUE and st_data_t are compatible.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43895 b2dd03c8-39d4-4... -
- * include/ruby/st.h: define modified prototype.
* hash.c (rb_hash_keys): use modified st_keys().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43894 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
07:43 AM Bug #9114: InstructionSequence.compile w/tailcall_optimization: true, trace_instruction: false not working as expected
- Eric,
My apologizes as I probably wasted your time with that. The problem with the code you posted is that for TCO you still have to specify trace_instruction: false. If you execute the following, it is fine in Ruby 2.0.0p247 at least, ... -
- * gc.c (gc_stat): Add :last_collection_flags for reason/trigger/type of
last GC run.
* gc.c (gc_prof_sweep_timer_stop): Record HAVE_FINALIZE GPR even
without GC_PROFILE_MORE_DETAIL.
* gc.c (gc_profile_flags): Add GC::Profiler.decode_... -
- * version.c (ruby_show_copyright): use EXIT_SUCCESS instead of magic
number 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43892 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * lib/optparse.rb (OptionParser::Switch#compsys): regexp literal
should be lhs of =~.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43891 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * win32/win32.c (rb_w32_dup2): extract from rb_cloexec_dup2() and
redirect_dup2().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43890 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- s/Confg/Config/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43889 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (Doxyfile): tool/file2lastrev.rb needs running with
BASERUBY since r43617. [ruby-dev:47823] [Bug #9169]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43888 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Linux patch to fix this:
http://mid.gmane.org/20131127124021.GA2025@elgon.mountain
I think Ruby can remain unchanged. -
02:09 AM Bug #9157: rb_readlink() calls rb_str_modify_expand() too early
- does it deserves a CVE?
-
- If we resurrect dying objects (non-marked, but not swept yet),
pointing shared string can be collected.
To avoid such issue, fstrings (recorded to fstring_table)
should not be ELTS_SHARED (should not have a shared string).
git-s...
11/27/2013
-
- I don't know whether it is the interpreters fault or mine.
This is what I do:
- Subclassing StandardError in C
- Encapsulating some data into it using Data_Make_Struct
- Raising this exception
- Not catching it by "rescue"... -
09:48 PM Bug #9101 (Assigned): Reference to unset variable
-
- Reminder: Not one single reaction in more than two weeks.
-
09:16 PM Bug #9166 (Third Party's Issue): Installation halted by: Error running '__rvm_make -j 1', please read /usr/local/rvm/log/1385553502_ruby-2.0.0-p353/make.log There has been an error while running make.
- Installation halted by:
Error running '__rvm_make -j 1', please read /usr/local/rvm/log/1385553502_ruby-2.0.0-p353/make.log There has been an error while running make.
[2013-11-27 19:58:45] __rvm_make
__rvm_make ()
{
\m... -
- This looks to be a problem of Linux 3.12 and later
commit 1661bf364ae9c506bc8795fef70d1532931be1e8
Author: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu Oct 3 00:27:20 2013 +0300
net: heap overflow in __audi... -
- "tmm1 (Aman Gupta)" <ruby@tmm1.net> wrote:
> Seeing some occasional segfaults in CI after this change. Not quite
> sure what's up yet.
>
> http://c5632.rubyci.org/~chkbuild/ruby-trunk/log/20131127T070302Z.log.html.gz
>
> #3... -
- Seeing some occasional segfaults in CI after this change. Not quite sure what's up yet.
http://c5632.rubyci.org/~chkbuild/ruby-trunk/log/20131127T070302Z.log.html.gz
#3 0x0063fb97 in rb_bug (fmt=0x67363d "Segmentation fault") at e... -
- "tmm1 (Aman Gupta)" <ruby@tmm1.net> wrote:
> Issue #8998 has been updated by tmm1 (Aman Gupta).
Cool, I didn't check object lifetimes.
Any measurable impact on speed?
> >+ if (!OBJ_FROZEN(str))
> >+ *key = rb_fstring... -
- This issue was solved with changeset r43870.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* hash.c (hash_aset_str): Use rb_fstring() to de-duplicate hash s... -
- >+ if (!OBJ_FROZEN(str))
> ...
Do you know why the OBJ_FROZEN check is required here?
I tried to investigate and it appears this function is sometimes invoked with symbols. -
- I didn't realize MRI already froze string keys in hashes.
Your patch reduces long-lived strings in our rails app by ~11%:
$ ruby -rconfig/environment -e' GC.start; p ObjectSpace.count_objects[:T_STRING] '
173956
$ ruby ... -
07:29 PM Bug #9164: IO::foreach incorrect work for binary file on windows platform
- phasis68 (Heesob Park) wrote:
> On Windows, "\x1A"(Control+Z) means end of file.
> ...
Thank you.
Sorry, my problem, it isn't a bug. -
- On Windows, "\x1A"(Control+Z) means end of file.
You must use binary read mode.
p File.foreach('1.txt',mode:'rb').to_a => ["123\n", "\x1A\xE8\xBA\b\n", "789\n"] -
- d2 = "123\n".b + "\x1a\xe8\xba\b".b + "\n789\n".b
File.binwrite('1.txt', d2)
p File.binread('1.txt').each_line.to_a # => ["123\n", "\x1A\xE8\xBA\b\n", "789\n"]
p File.foreach('1.txt').to_a... -
06:30 PM Bug #9150: Segfault in case statement execution, possibly related to refinements
- I've not investigated this problem yet, but Matz said implicit method calls should not honor refinements, so r42869 might be an undesirable change.
-
- @nagachika What do you think?
-
- Fixed via r43880
-
05:53 PM Bug #9165: IRBのコード中にtypo
- けいじゅ＠いしつかです.
matsuda (Akira Matsuda) <ronnie@dio.jp> wrote:
> Issue #9165 has been reported by matsuda (Akira Matsuda).
>
> IRBのコード内にtypoを見つけました。
> 明らかにケアレスミスっぽいので添付のパッチをコミットしちゃって良いでしょうか？
あらま.
よろしくお願いします(__;
... -
- IRBのコード内にtypoを見つけました。
明らかにケアレスミスっぽいので添付のパッチをコミットしちゃって良いでしょうか？ -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43886 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * hash.c (rb_hash_keys): use st_keys() for performance improvement
if st_data_t and VALUE are compatible.
* st.h: define macro ST_DATA_COMPATIBLE_P() to predicate whether
st_data_t and passed type are compatible.
* configure.in: ch... - 03:13 PM Revision 88468275 (git): * 2013-11-28
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43884 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- and ATOMIC_SIZE_XXX.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43883 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- __atomic_compare_exchange_n() and refactoring.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43882 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Committed per http://twitter.com/m_seki/status/405573265139044352
-
- This issue was solved with changeset r43872.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/rinda/ring.rb: Announce RingServer for the same process.
... -
- Rinda::RingServer#do_reply takes tuples of the form [:lookup_ring, DRbObject]. For remote processes looking for a ring server this works fine as the callback proc in the second slot of the tuple will be a DRbObject.
When a process is... -
- ping?
-
- * ext/json/lib/json/common.rb: Ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43881 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hrm, I will check it.
-
- It's #9142.
I couldn't reproduce it.
Maybe related to rvm? -
- Please feedback to run your code with ruby-trunk.
-
- > No needs to compare with @filename?
645 File.open(@filename, File::WRONLY | File::APPEND) do |lock|
646 lock.flock(File::LOCK_EX) # inter-process locking. will be unlocked at closing file
647 ... -
- > Is there a way to access when variables are read/assigned in Tracepoint?
No. I reject this approach because of performance (without enabling these trace).
But there is no proof of my assumption. Please try and measure.
> ...
I... -
-
05:22 AM Feature #9162 (Rejected): Read/Write operations in Tracepoint
- Is there a way to access when variables are read/assigned in Tracepoint? Specifically, I'm interested in creating a tool which does dynamic, threading analysis of Ruby code to find atomicity violations, dead-locks and race conditions. ...
-
-
- You can use byebug to debug your code with this command line: `bundle exec rspec -rbyebug`.
FYI, `--debug` option of rspec has been removed in 3.0.0.beta1 of rspec-core.
Please see rspec-core's Changelog.md: https://github.com/rspec/... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43880 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43879 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Can somebody following this thread check out my patch for
https://bugs.ruby-lang.org/issues/8998
Theoretically it should be better than nothing (but not ideal), but I
don't think any of my code uses string hash keys enough to m... -
- This issue was solved with changeset r43866.
Aman, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* compile.c: Use rb_fstring() to de-duplicate string literals in ... -
08:26 AM Bug #9159: [patch] use rb_fstring for internal strings
- Seeing similar results for Discourse:
https://gist.github.com/SamSaffron/7668043 -
07:33 AM Bug #7239: Can't read from subprocess when run with rubyw on windows
- Please backport this to Ruby 1.9.3.
-
- test_expand_heap.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43878 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- GC heap/page/slot sizing.
* test/ruby/test_gc.rb (class TestGc): test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43877 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * hash.c (hash_aset_str): Re-use existing variable to avoid
unnecessary pointer dereferencing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43876 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43875 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- heap_tomb_page_length.
* test/ruby/test_gc.rb: fix to use GC.stat[:heap_eden_page_length]
instead of GC.stat[:heap_length].
This test expects `heap_eden_page_length' (used pages size).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t... -
06:03 AM Bug #9157: rb_readlink() calls rb_str_modify_expand() too early
- nobu (Nobuyoshi Nakada) wrote:
> This issue was solved with changeset r43853.
Ah, I didn't realize that rb_str_modify_expand() takes a difference as its argument, not the total buffer length. This works because the function doubles t... -
- assert_equal.
* test/ruby/test_hash.rb (class TestHash): ditto.
* test/ruby/test_iseq.rb (class TestISeq): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43873 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
05:57 AM Feature #8257: Exception#cause to carry originating exception along with new one
- I think we still need to add Exception.new(:cause => ex) to allow constructing an exception with a *specific* cause. The $! capturing is great but often there may be more than one exception in play.
This needs to happen before 2.1 final. -
- [ruby-trunk - Bug #9163]
* test/rinda/test_rinda.rb: Tests for the above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43872 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- filenames via rb_fstring().
* test/ruby/test_iseq.rb (class TestISeq): Add test for shared
iseq labels via rb_fstring(). [Bug #9159]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43871 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- keys. Patch by Eric Wong. [Bug #8998] [ruby-core:57727]
* test/ruby/test_hash.rb (class TestHash): test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43870 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Symbol into a String.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43869 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- used -> page_length
limit -> total_slots
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43868 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:20 AM Bug #9160 (Closed): configureに--with-rubylibprefixを指定するとrbconfigのprefixが空文字になる
- =begin
== 現象
configureに--with-rubylibprefixを指定したとき、
RbConfig::CONFIG['prefix']および関連するbindirなどのprefixが空文字になってしまいます。
% ruby -rrbconfig -e 'p RbConfig::CONFIG["prefix"]'
""
% ruby -rrbconfig -e 'p RbConfig::CONFIG["bin... -
- * test/-ext-/bug_reporter/test_bug_reporter.rb (test_bug_reporter_add):
remove expected core file to get rid of false error in chkbuild.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43867 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/26/2013
-
- * iseq.c (prepare_iseq_build): De-duplicate iseq labels and source locations.
* re.c (rb_reg_initialize): Use rb_fstring() for regex string.
* string.c (rb_fstring): Handle non-string and already-fstr arguments.
* vm_eval.c (eval_string_... -
- This issue was solved with changeset r43859.
Sam, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
hash.c: cut off if recursion
* hash.c (rb_hash): cut off if recur... -
- @nobu running in ubuntu latest x64
-
- its a similar error to #9003
p a.hash # raises Stack Error
p b.hash # Segmentation fault: 11
happens for:
ruby 2.1.0dev (2013-11-26 trunk 43854) [x86_64-darwin12.0]
does not happen for:
ruby 2.1.0dev (2013-09-22 trunk 43011... -
- It's a simple machine stack overflow.
What's your platform? -
- (13/11/26 19:23), no6v (Nobuhiro IMAI) wrote:
> File.open(@filename, File::WRONLY | File::APPEND) do |lock|
> lock.flock(File::LOCK_EX) # inter-process locking. will be unlocked at closing file
> - ... -
- Thanks for your suggestion. I feel this simple condition seems looking good.
I updated a patch using `File.identical?`.
diff --git a/lib/logger.rb b/lib/logger.rb
index c70b091..f1c6cbe 100644
--- a/lib/logger.rb
+++ b/lib/logger.... -
- Probably, you can use `File.identical?` instead of comparison of ino.
-
10:14 PM Revision 599c3a92 (git): * ext/psych/lib/psych.rb: psych version 2.0.2
- * ext/psych/psych.gemspec: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43865 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- years.
* ext/psych/lib/psych/visitors/yaml_tree.rb: ditto
* test/psych/test_date_time.rb: test for change.
Fixes: https://github.com/tenderlove/psych/issues/168
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43864 b2dd03c8-39d4-4d8... -
- This issue was solved with changeset r43858.
Brandur, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* test/ruby/test_settracefunc.rb: add tests for a_call/a_retur... -
- strings.
* test/psych/test_date_time.rb: test for change.
Fixes: https://github.com/tenderlove/psych/issues/171
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43863 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- > if (nd_type(node) == NODE_STR) {
> ...
Some internal strings are no longer hidden with this patch, since the underlying T_STRING object can be shared via the fstr table.
Since the object is already marked immutable (via the frozen ... -
- One example of strings de-duplicated by this patch are iseq labels. Before:
irb(main):001:0> mm = "method_missing"
irb(main):002:0> GC.start; ObjectSpace.each_object(String).select{ |o| o == mm }.size
=> 77
After:
irb(... -
- I added rb_fstring wrappers around internal strings generated by iseqs, regexps and eval:
https://github.com/tmm1/ruby/commit/9587fae171835ccf013661ba837f097754f170ef
In our rails app, this reduces the number of long-lived string... -
- * string.c (str_new4): copy the original capacity so that memsize of
frozen shared string returns correct size.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43862 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:20 PM Revision faaec02a (git): * 2013-11-27
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43861 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * array.c (rb_ary_hash): should not ignore the rest of recursive
constructs.
* hash.c (rb_hash_hash): ditto.
* range.c (range_hash): ditto.
* struct.c (rb_struct_hash): ditto.
* test/-ext-/test_recursion.rb (TestRecursion): separate fr... -
- This issue was solved with changeset r43853.
Maciek, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
file.c: fix buffer overflow
* file.c (rb_readlink): fix buffer... -
- If rb_readlink() (file.c) is called on a long symlink, Ruby tends to crash. This is present in -trunk. The problem is that the rb_str_modify_expand() statement is incorrectly placed before the statement 'size*=2'. Here is a patch:
---... -
- nagachika (Tomoyuki Chikanaga) wrote:
> I've overlooked this ticket.
> ...
That would be sweet if you can backport. One less patch I need to maintain for Fedora. -
- I've overlooked this ticket.
Hello vit, r43587 should be backported to ruby_2_0_0, doesn't it?
- 03:53 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
- unsubscribe
-
- matz (Yukihiro Matsumoto) wrote:
> OK, I misunderstood something.
> ...
I discovered the current behavior while playing around, learning about method binding in ruby, not via a bug in my code. I noticed in irb (to_s) that an unbound m... -
02:47 PM Feature #7274: UnboundMethods should be bindable to any object that is_a?(owner of the UnboundMethod)
- OK, I misunderstood something.
In case foo is implemented in Base as in the original example, I admit that it will not cause any serious problem.
But I still have small concern.
If you are sure foo is implemented in Base, you can ... -
- to continue, the above:
we are binding a method from Base to an instance of Base, and it's failing. Why? How can that possibly be unsafe? What difference does it make that the method was requested from a subclass of Base? It certai... -
- matz (Yukihiro Matsumoto) wrote:
> @rits You haven't read my message above, have you?
> ...
Neither I nor marcandre understood what you were alluding to and asked for a clarification, but you just repeated without clarifying.
You appear... -
- @rits You haven't read my message above, have you?
>It is due to implementation limitation of CRuby.
> ...
Matz.
-
- matz (Yukihiro Matsumoto) wrote:
> @rits Yes, basically. Method transplanting from modules is already allowed though.
> ...
ok, but you never really explained what purpose this restriction serves, it seems pretty arbitrary and illogical -
- @rits Yes, basically. Method transplanting from modules is already allowed though.
Matz.
-
- Hello,
Here is a cute bug that has existed for a little while in file.c . Ruby will tend to crash when File.readlink() is called on a symlink with a long target. Fix:
--- - 2013-11-25 22:10:59.694183795 -0700
+++ file.c 2013... -
-
03:05 PM Bug #9106: 'gem install' doesn't copy .so files of ext libs
- This problem is reproduced on ruby 2.1.0-preview2 on Linux/OSX.
'msgpack' gem cannot be loaded (LoadError) and 'ext/msgpack/msgpack.so' (or .bundle) is not copied to 'lib/msgpack/msgpack.so'.
About other library (ex: cool.io), binary f... -
- It's by a security reason.
What's your platform? -
10:01 AM Bug #9156 (Closed): Not able to get tmp dir to work with Ruby 2.0.0
- I just migrated to Ruby 2.0.0 from 1.9.2 and I'm getting errors when trying to handle files because I can't get tmp directories to work.
If you check this file and look at line 29 you'll see that a check on world_writable? has been ad... -
- I think I've seen very similar report in these days, but I can't find it now...
7 libruby.2.0.0.dylib 0x00000001027af9ca st_init_strcasetable + 16
8 libruby.2.0.0.dylib 0x00000001026eb9a5 rb_enc_init + 29
9... -
- * hash.c (rb_hash): cut off if recursion detected to get rid of stack
overflow. [ruby-core:58567] [Bug #9151]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43859 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I noticed the attached patch has problems with mingw.org 32bit toolchain.
The updated patch is only affects for MINGW64 toolchain.
Refer to https://groups.google.com/forum/#!topic/rubyinstaller/zNNccqwWMsA for more information. -
- by Brandur <brandur@mutelight.org> [Feature #9120]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43858 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- for run.gdb.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43857 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- is frozen.
rb_class_path() can modify frozen classes (and causes errors).
This patch is temporary. We need no-modification/no-allocation
class path function.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43856 b2dd03c8-39d4-... -
- events) for internal events.
Reentrant check for internal events are remaining.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43855 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- simultaneously.
I will introduce special care for internal events later.
* ext/-test-/tracepoint/tracepoint.c: test this behavior.
* test/-ext-/tracepoint/test_tracepoint.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@... -
- @hsbt yep that's where I found the issue - I thought I'd make it easier to replicate with the above code :)
-
- It happened will_paginate too. follow code.
https://github.com/mislav/will_paginate/blob/master/lib/will_paginate/page_number.rb
-
- Running the attached code gives ArgumentError: not delegated. It's unexpected as it worked on preview 1 and in 2.0.0. Error pasted below. https://gist.github.com/ukd1/9293c419a080d034f4bb - has sample code plus runs on 2.0.0p247 + 2.1.0-...
-
- * file.c (rb_readlink): fix buffer overflow on a long symlink. since
rb_str_modify_expand() expands from its length but not its capacity,
need to set the length properly for each expansion.
[ruby-core:58592] [Bug #9157]
git-svn-id... -
- control characters for strict json parsers.
* ext/objspace/objspace_dump.c (objspace_dump): Document File/IO
output option.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43852 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- __sync family are legacy functions now and it is recommended
that new code use the __atomic functions.
http://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.html
* configure.in: check existence of __atomic functions.
git-svn-... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43850 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43849 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/bigdecimal/bigdecimal.gemspec: revert Gem::Specification#date
for snapshot/release tarballs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43848 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- =begin
In Fedora Rawhide, there was disable support for verification of certificate, CRL, and OCSP signatures using MD5 in OpenSSL [1, 2], therefore I observe following test errors:
7) Error:
test_sign_and_verify(OpenSSL::TestX5...