Activity
From 11/12/2013 to 11/18/2013
11/18/2013
-
11:42 PM Bug #9119: TestTime#test_marshal_broken_offset broken under MinGW
- I found a difference between the rubyinstaller version and mine.
The line "`#define LOCALTIME_OVERFLOW_PROBLEM 1`" is only found in my config.h.
It seems that the localtime(3) overflow check code returns incorrect value for some i... -
- I can reproduce this bug with rubyinstaller 2.0.0-p247 version.
```
C:\Users\phasis>ruby -ve "ENV['TZ']='UTC';p Time.now.utc_offset"
ruby 2.0.0p247 (2013-06-27) [i386-mingw32]
32400
```
But, I cannot reproduce with my own compi... -
07:46 PM Bug #9119: TestTime#test_marshal_broken_offset broken under MinGW
- The test is added at r42596 by nobu.
-
10:53 PM Bug #9109: extend したモジュールメソッドと RSpec の let で 2 つ同名を使ったときに segmentation fault になる
- とりあえずstack overflowでSEGVするのは直ったと思います。
代わりに [BUG] vm_call_cfunc - cfp consistency error が出るようになりましたが、それはまた別件なので。 -
- This issue was solved with changeset r43707.
sunao, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
eval_intern.h: refine stack overflow detection
* eval_intern.h ... -
- compiling.
[ruby-core:58391] [Bug #9119] Reported by Luis Lavena.
Analyzed by Heesob Park.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43713 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:55 PM Revision 2a051d7a (git): * lib/rdoc/rubygems_hook.rb: Remove debugging puts committed by
- accident.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43712 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:02 PM Revision 230ddd70 (git): * 2013-11-19
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43711 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
07:02 PM Revision 64e693dd (git): * test/bigdecimal/test_bigdecimal.rb: incorporate BigMath.log
- tests from JRuby by Peter Vandenabeele.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43709 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * common.mk, ext/rbconfig/sizeof: move RbConfig::SIZEOF to an
extension library to get rid of annoying nmake VPATH rule.
* inits.c (rb_call_inits), miniinit.c (Init_sizes): RbConfig::SIZEOF
is no loger built-in.
* template/sizes.c.... -
- * eval_intern.h (TH_PUSH_TAG, TH_EXEC_TAG): refine stack overflow
detection. chain local tag after setjmp() successed on it, because
calling setjmp() also can overflow the stack.
[ruby-dev:47804] [Bug #9109]
* vm_eval.c (rb_catch_... -
- * thread_pthread.c (ruby_init_stack): set stack_start properly by
get_main_stack() if possible.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43706 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * eval_jump.c (rb_exec_end_proc): unlink and free procs data before
calling for each procs. [Bug #9110]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43705 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hanmac (Hans Mackowiak) wrote:
> would it with the change also possible to add Module multible times into the Ancestor chain?
I'd tried it once, but found that some modules implicitly expect they are included only one time.
So, we'l... -
11:04 AM Bug #9122 (Closed): requiring readline in a spawned ruby process with new process group can hang it
- Lets say I have a program:
~> cat a.rb
require "pty"
require "io/console"
puts "Starting"
m, s = PTY.open
s.raw! # disable newline conversion.
pid = spawn("ruby using_pry.rb", chdir: '.', pgroup: true, out: m, err: m)
at_... -
09:43 AM Feature #9121 (Assigned): [PATCH] Remove rbtree implementation of SortedSet due to performance regression
-
09:24 AM Feature #9121 (Closed): [PATCH] Remove rbtree implementation of SortedSet due to performance regression
- rbtree is slower than the pure ruby version.
I have provided benchmarks and a patch here:
https://github.com/ruby/ruby/pull/451
> ruby sorted_set_benchmark.rb
using rbtree
user system total real
#add 0.0... -
05:02 AM Feature #9120 (Closed): [PATCH] Tests for a_call + a_return
- Tests for `a_call` and `a_return` in `TracePoint` added in this commit: https://github.com/ruby/ruby/commit/ac778eb2cf8f66a7c15573a73c620f237f9f17dd
The MRI implementation is pretty straightforward and I suppose arguably doesn't need ... -
- * configure.in (warnflags): make division-by-zero error for
RUBY_CONST_ASSERT macro.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43704 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:30 AM Revision 5f2cc0da (git): * 2013-11-18
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43703 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_core.h (VM_STACK_OVERFLOWED_P, WHEN_VM_STACK_OVERFLOWED): extract
condition from CHECK_VM_STACK_OVERFLOW.
* vm_exec.c (vm_stack_overflow_for_insn): move rb_bug call.
* vm_exec.h (CHECK_VM_STACK_OVERFLOW_FOR_INSN): share the cond... -
02:07 AM Misc #8741: email notification on bugs.ruby-lang.org is broken
- I registered few weeks ago and didn't receive any notification neither from bugs i filed (#8937, #8990, #8999, #9000) nor from ones I was watching (#8741).
Please reopen it.
(same issue at https://github.com/asakusarb/redmine4ruby-la...
11/17/2013
-
11:39 PM Feature #9112: Make module lookup more dynamic (Including modules into a module after it has already been included)
- would it with the change also possible to add Module multible times into the Ancestor chain?
like
C1 < M1 < C2 < M1 < M2 < C3
? -
10:39 PM Feature #9112: Make module lookup more dynamic (Including modules into a module after it has already been included)
- Thank you for the quick reply Eric and Nobu! Looking forward to how this turns out :-)
-
09:50 PM Bug #9119 (Closed): TestTime#test_marshal_broken_offset broken under MinGW
- =begin
Hello,
The test (({TestTime#test_marshal_broken_offset})) has been broken under x86-mingw32 for really long time, in both 2.0 and trunk:
http://ci.rubyinstaller.org/job/ruby-2_0_0-x86-test-all/170/console
http://ci.rubyi... -
- Enumerable#count may not a good idea, better would be Enumerator#size
-
03:48 AM Feature #9118: In Enumerable#to_a, use size to set array capa when possible
- It definitely breaks that usage, but that's bad usage--we're supposed to use Enumerable#count for that, not size.
In cases where size doesn't correctly predict the array, this doesn't really break anything, it just switches out one ba... -
03:28 AM Feature #9118: In Enumerable#to_a, use size to set array capa when possible
- I think the proposal will break the compatibility of the following code:
class C
include Enumerable
def size
to_a.size
end
def each
end
end
C.new.size #=> expected: 0, with the proposal: stack l... -
- Ah, right! This seems like an opportunity to improve on existing behavior: right now that just silently hangs forever. Do you think we should warn, then hang, or just raise? I'd lean towards the warn because it's possible size is returni...
-
- enum.size can return Float::Infinity maybe for [1,2,3].cycle.size you need to check that too
-
06:05 PM Feature #9116: String#rsplit missing
- Out of curiosity, i have looked it up: http://docs.python.org/3/library/stdtypes.html#str.rsplit
-
02:39 PM Feature #9108: Hash sub-selections
- `select(*args)` just seemed like a more natural interface, though I suppose `select(enum)` provides more flexibility and solves any compatibility problems with the current behaviour of select. If an empty enumerable is given, an empty ha...
-
- * compile.c (iseq_peephole_optimize): enable tail call optimization on
super too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43701 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * hash.c (NOINSERT_UPDATE_CALLBACK): make both of noinsert and insert
internal functions static. and put semicolons for etags to find the
following functions properly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43700 b2dd03c... -
- * string.c (tr_find): constify argument table.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43699 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:59 PM Feature #6842: Add Optional Arguments to String#strip
- I need this a couple of weeks ago. Looks like a preety commo use case.
-
- I still look forward to this feature. So much more convenient and readable than the current work-around of using regex and sub/gsub. Is there anything more that needs to be done to make this happened for Ruby 2.1 or 2.2?
-
08:57 AM Bug #9115: Logger traps all exceptions; breaks Timeout
- ...I guess my search was broken. I did another and found a whole lot of "rescue exception" that don't seem to always re-raise. But the logger is a big one because it's supposed to be usable everywhere, and someone who logs a lot _will_ r...
-
- Hello,
Here is a 2009 discussion about gems and multiple binaries (targeting different versions of Ruby):
http://rubyforge.org/pipermail/rubygems-developers/2009-April/004522.html
My alternative to that issue is what you can see...
11/16/2013
-
- Cross-post from https://github.com/ruby/ruby/pull/444.
Enumerable#to_a works by creating an empty array with small capacity, then populating it and expanding the capacity as it goes. For large enumerables, this causes several resizes,... -
09:45 PM Revision fd6b01c4 (git): Explain fix in r43697
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43697 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:00 PM Bug #9117 (Closed): 43656 breakes openssl in stalic-ext ruby
- =begin
while fixing #8879 a new bug was introduced in ((<r43656|URL:https://bugs.ruby-lang.org/projects/ruby-200/repository/revisions/43656>)).
without the patch ruby-2.0.0-p247 - (({ruby -ropenssl -e 'puts Digest::SHA512.new'})):
... -
07:23 PM Feature #9116: String#rsplit missing
- On Nov 16, 2013 6:35 PM, "artagnon (Ramkumar Ramachandra)" <
artagnon@gmail.com> wrote:
>
> There's nothing corresponding to Python's rsplit(). A quick glance at
rb_str_split_m() tells me that it should be pretty trivial to impl... -
05:35 PM Feature #9116 (Open): String#rsplit missing - There's nothing corresponding to Python's rsplit(). A quick glance at rb_str_split_m() tells me that it should be pretty trivial to implement. Is there any specific reason it hasn't already been done?
-
07:05 PM Bug #9061: REXML::Parsers::UltraLightParser で doctype を含む XML のパースがうまくいかない
- 遅くなりましたがテストを追加してパッチをそのまま取り込みました！
報告ありがとうございました！ -
- This issue was solved with changeset r43693.
Ippei, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/rexml/parsers/ultralightparser.rb
(REXML::Parsers::Ultra... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43696 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 04:49 PM Revision bfce3d10 (git): * 2013-11-17
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43695 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- message instead of error number.
* cont.c (fiber_machine_stack_alloc): Ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43694 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Line 577-579 of logger.rb
rescue Exception => ignored
warn("log writing failed. #{ignored}")
end
Thus, when the system times out in the middle of writing a log message, it warns "log writing failed. execution ... -
12:08 PM Bug #9106: 'gem install' doesn't copy .so files of ext libs
- It sounds good improvement of RubyGems to manage binaries for each ruby API versions.
Your comment totally makes sense. I'll fix msgpack next version. Thank you! -
- =begin
@frsyuki: you should trust rubygems to make msgpack/msgpack.so accessible somewhere in the $LOAD_PATH so:
require 'msgpack/msgpack'
so option c is the best fix.
With RubyGems 2.2 the directory you `gem install` to can ... -
- Here's an update where a call is in tail position, but from the output you'll see only the initial call uses the tail call optimization.
source = <<-SOURCE
def fact n, acc = 1
if n.zero?
acc
else
... -
- Which call is in tail position for this method? I'm not seeing it.
-
02:55 AM Bug #9114: InstructionSequence.compile w/tailcall_optimization: true, trace_instruction: false not working as expected
- btw- that method is incorrect, and when I wrote a better/working method, now it doesn't have that error in 2.0.0p247 but still fails with 1.9.3-p448. Not sure why:
method_string = <<RUBY
def recursively_sort(obj)
case obj
when Array... -
- Code to reproduce is a recursive sort I wrote; I was trying to compile RubyVM::InstructionSequence with tailcall_optimization: true, trace_instruction: false, which has worked before, but not for this case.
method_string = <<RUBY
de... - 09:31 AM Revision a66a9fbb (git): * lib/rexml/parsers/ultralightparser.rb
- (REXML::Parsers::UltraLightParser#parse): Fix wrong :start_doctype
position.
[Bug #9061] [ruby-dev:47778]
Patch by Ippei Obayashi. Thanks!!!
* test/rexml/parser/test_ultra_light.rb: Add a test for this case.
git-svn-id: svn+ssh:... - 12:29 AM Bug #9110 (Closed): double free or corruption error at_exit with callcc
- This issue was solved with changeset r43685.
Masaki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* eval_jump.c (rb_exec_end_proc): fix double free or corruption... - 12:24 AM Revision bc3db2a5 (git): * test/ruby/test_hash.rb (class TestHash): add tests for [ruby-dev:47803] [Bug #9105]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43692 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
11/15/2013
-
- This issue was solved with changeset r43683.
Masaya, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
hash.c: iteration level with reentering
* hash.c (`ha... -
- * test/ruby/envutil.rb (EnvUtil.diagnostic_reports): find crash report
on Mac OS X.
* test/ruby/envutil.rb (Test::Unit::Assertions::FailDesc): include
crash report on Mac OS X.
* test/ruby/envutil.rb (Test::Unit::Assertions#assert_... -
- Then it is a task of package maintainers.
-
04:16 PM Feature #9113: Ship Ruby for Linux with jemalloc out-of-the-box
- @martin this is a great "oldish" article by facebook about this http://www.facebook.com/notes/facebook-engineering/scalable-memory-allocation-using-jemalloc/480222803919
@nobu I guess my suggestion here is to include jemalloc source in ... -
03:23 PM Feature #9113: Ship Ruby for Linux with jemalloc out-of-the-box
- On one level, this feels like a non-brainer. But then the question is
why the standard memory allocator in libc hasn't been improved.
I can imagine all kinds of reasons, from "alternatives use too much
memory" to "not invente... -
- If system malloc is replaced with those newer libraries, ruby will use it.
Otherwise, configure with LIBS=-ljemalloc. -
02:45 PM Feature #9113 (Assigned): Ship Ruby for Linux with jemalloc out-of-the-box
- Could you comment this?
-
- libc's malloc is a problem, it fragments badly meaning forks share less memory and is slow compared to tcmalloc or jemalloc.
both jemalloc and tcmalloc are heavily battle tested and stable.
2 years ago redis picked up the jemallo... -
- * test/ruby/test_beginendblock.rb (test_callcc_at_exit): use
assert_normal_exit for better message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43690 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Hi I'm @frsyuki.
1) I don't understand which behavior of RubyGems should the code trust. It assumes that msgpack.so is placed into lib/msgpack/msgpack.so because ext/msgpack/extconf.rb includes this line:
create_makefile('msgpack/m... -
05:26 PM Bug #9106: 'gem install' doesn't copy .so files of ext libs
- hsbt (Hiroshi SHIBATA) wrote:
> tagomoris: Thank you for your report. Can you investigate to msgpack gem?
I don't understand why msgpack requires with such code. So I'll tell it to @frsyuki, original developer of msgpack.
-
- For backwards compatibility I will need to alter RubyGems before Ruby 2.1 (I haven't had time yet).
Future versions of RubyGems will not support this lack of trust, though. -
10:12 AM Bug #9106 (Feedback): 'gem install' doesn't copy .so files of ext libs
- tagomoris: Thank you for your report. Can you investigate to msgpack gem?
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43689 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- i found the wikipedia source: http://en.wikipedia.org/wiki/Combining_character
its not about treating "^a" or "a^" the same as "â" but there is a way to clue the chars together
i think thats also a reason for http://api.rubyonrails.org/... -
02:41 PM Feature #9111: Encoding-free String comparison
- > Hanmac: "â" can be maked from "a" + "^"
Treating them the same is too much, I think. There are various marking methods. For example, `â` would have a different marking in TeX. Assuming them equal is going too much. They should be tr... -
- what about strings with the same encoding, but different content, but that is turned the same?
like "â" can be maked from "a" + "^" somehow, should they also treated as equal? -
- Following nobu's suggestion, I came up with the following several possibilities:
When two strings with different encodings are to be compared by `String#<=>`, then one of the following options should be taken:
* Raise a Warning mes... - 05:15 PM Revision 28a1c4f3 (git): * cont.c : Introdule ensure rollback mechanism. Please see below.
- * internal.h (ruby_register_rollback_func_for_ensure): catch up above change.
Add rollback mechanism API.
* vm_core.h (typedef struct rb_vm_struct): catch up above change.
Introdule ensure-rollback relation t... - 05:08 PM Revision 9e96b1ed (git): revert r43675 and r43683 without tests for applying rollback patch.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43687 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:38 PM Bug #9110 (Assigned): double free or corruption error at_exit with callcc
-
- However, i do not see why it has to be used as `select(*args)` and not select `select(ary)` or `select(enum)`.
-
- wardrop (Tom Wardrop) wrote:
> I think an appropriate solution would be to amend `Hash#select`. It currently doesn't take any arguments, so could easily take a list of `*args`. You could use the optional block to further refine this s... -
- `Enumerator` includes `Enumerable`, as does `Hash`. `Enumerator` introduces a few new methods that revolve around the concept of a cursor, but otherwise everything else comes from `Enumerable`.
My whole point is that for anyone using ... -
- phluid61 (Matthew Kerwin) wrote:
> wardrop (Tom Wardrop) wrote:
> ...
Sorry, I realise you do mean the right thing. I was put off by the fact that you say they're most often interchangeable; all they have in common is `#each` -
- wardrop (Tom Wardrop) wrote:
> They do differ, yes, but in most cases an enumerator is interchangeable with a `Hash`. I can't imagine anyone would be using `Hash#select` to get an enumerator anyway. If anyone is, then their code deserve... -
- They do differ, yes, but in most cases an enumerator is interchangeable with a `Hash`. I can't imagine anyone would be using `Hash#select` to get an enumerator anyway. If anyone is, then their code deserves to break to some extent. You s...
-
- Enumerator differs from Hash.
-
- I suppose square-bracket syntax is too ambiguous as it collides with many other existing and potential behaviours I didn't consider. A normal method is fine.
I think an appropriate solution would be to amend `Hash#select`. It currentl... -
03:30 AM Feature #9108: Hash sub-selections
- I prefer such syntax for nested hash (as in http://bugs.ruby-lang.org/issues/5531)
Why not to use usual method like `#key_values_at` or `#subhash` or smth like that? - 03:29 PM Revision 7664609f (git): * 2013-11-16
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43686 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- when reentering by callcc. [ruby-core:58329] [Bug #9110]
* test/ruby/test_beginendblock.rb: test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43685 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * eval.c (setup_exception): set up cause after exception to be raised
is fixed. [Feature #8257]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43684 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * hash.c (hash_foreach_iter, hash_foreach_ensure, rb_hash_foreach):
deal with iteration level when reentering by callcc. temporary
measure until rollback of ensure is introduced. [ruby-dev:47807]
[Bug #9105]
git-svn-id: svn+ssh:... -
- It has been rejected because it is hard to implement without significant performance penalty.
Now we have subclass trees, so it might be possible. -
- This would be a new feature.
I believe this was requested and rejected back in the 1.8 days, but looking for the discussion is too difficult for me.
If it was, maybe matz has changed his mind -
- If a module (M) is included into a class (C) and afterwards another module (M2) is included into the first module (M) then C does not include M2 and instances do not respond to methods defined in M2. I think instances of C should respond...
-
- * lib/delegate.rb (Delegator#send): override to get rid of global function interference.
[Fixes GH-449]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43682 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * iseq.c (make_compile_option): fill with 1 of int, not char if opt is true.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43681 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
01:07 AM Feature #9098: Indent heredoc against the left margin by default when "indented closing identifier" is turned on.
- Sweet. I'll go ahead and start cooking up the patch. Thanks all for the preliminary feedback.
-
- This issue was solved with changeset r43679.
Akira, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
objspace_dump.c: refine output
* ext/objspace/objspace_dump.c (...
11/14/2013
-
- sawa (Tsuyoshi Sawada) wrote:
> I suggest that the comparison `String#<=>` should not be based on the respective encoding of the strings, but all the strings should be internally converted to UTF-8 for the purpose of comparison.
It's... -
- =begin
Currently, strings with the same content but with different encodings count as different strings. This causes strange behaviour as below (noted in StackOverflow question http://stackoverflow.com/questions/19977788/strange-behavio... -
10:42 PM Bug #9105 (Open): callcc による不整合(例:Hash)
- r43675 はマルチスレッドで同一の Hash を使っている場合に `RHASH_ITER_LEV(hash)` の値が不正になることがあると思います。
以下のようなスクリプトを実行すると `RHASH_ITER_LEV()` が 0 に戻らなくなるので要素追加に失敗します。
~~~ruby
h = {1=>2}
th1 = Thread.start{ h.each{ sleep 1 } }
sleep 0.1
th2 = Thread.start{ ... -
- This issue was solved with changeset r43675.
Masaya, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
hash.c: restore iter_lev
* hash.c (`hash_foreach_ensu... -
09:48 PM Feature #9108: Hash sub-selections
- ```ruby
[:dog, :cat].map { |k| sounds[ k] }
#=> ["woof", "meow"]
```
```ruby
[:dog, :cat].inject Hash.new do |r,k| r[ k] = sounds[ k] ; r end
#=> {:dog=>"woof", :cat=>"meow"}
```
If you look at it this way, one should rather ... -
07:50 PM Feature #9108: Hash sub-selections
- related to #8499 and the rejected #6847.
Personally I'd love to see `Hash#slice` implemented in Ruby core, but I think `#[]` shouldn't work as `#slice`. It should instead return the values only for the requested keys.
-
- I think, in *Rails*, the proposed method (not the assignment) is called [`Hash#slice`](http://api.rubyonrails.org/classes/Hash.html#method-i-slice).
I think it is impossible to use `#[]` for that method:
```ruby
h = {1 => 2}
h[1]... -
- wardrop (Tom Wardrop) wrote:
> I think a more concise and graceful solution to this would be to allow the Hash#[] method to take multiple arguments, returning a sub-hash, e.g.
> ...
As `sounds[:dog]` returns `'woof'`, it should return ... -
- Apologies for immediately replying again, but I've just had a potential source of confusion occur to me:
```ruby
hash = {a:1, b:2}
keys = [:a,:b]
hash[*keys] #=> {a:1, b:2}
keys = [:a]
hash[*keys] #=> 1, expected {a:1} ?
k... -
- In your proposal, what would happen with undefined keys? I see two reasonable options:
```ruby
sounds = {dog: 'woof', cat: 'meow'}
# option 1:
sounds[:dog, :fish] #=> {dog: 'woof'}
# option 2:
sounds[:dog, :fish] #=> {dog: 'woof... -
- Hi,
I seem to regularly have the requirement to work on a sub-set of key/value pairs within a hash. Ruby doesn't seem to provide a concise means of selecting a sub-set of keys from a hash. To give an example of what I mean, including ... -
- 2013/11/11 akr (Akira Tanaka) <akr@fsij.org>:
> Bug #9102: ObjectSpace.dump_all creates a FD without close-on-exec flag
> https://bugs.ruby-lang.org/issues/9102
> I think we cannot use mkstemp().
Another reason we should a... -
- This issue was solved with changeset r43676.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* test/openssl/test_cipher.rb (test_aes_gcm_wrong_tag): Don't use
... -
- I was just kidding, Eric. I liked Matz comment, that's all :)
-
- On 13 Nov 2013, at 08:16, rosenfeld (Rodrigo Rosenfeld Rosas) <rr.rosas@gmail.com> wrote:
> Issue #9107 has been updated by rosenfeld (Rodrigo Rosenfeld Rosas).
>
>
> Oh, man, Redmine should have a "like" feature just like Faceb... -
- Oh, man, Redmine should have a "like" feature just like Facebook ;)
-
01:14 AM Feature #9107 (Rejected): Introduce YES and NO as aliases of true and false
- Define them by yourself in your application.
To be honestly, yes/no seems bit childish to me, a old guy.
Matz.
-
- +1 to Avdi's idea. I mostly miss this when I'm writing my specs. Sometimes I have to compare some processed HTML with the expected result and it's not easy to write the expected string without compromising indentation. Usually I end up w...
-
- Creating a patch will help, but it can't be committed without the approval of matz.
-
- Oh, that's an awesome suggestion, @avdi. I like it. That way, it wouldn't be introducing backward incompatibility. Maybe we can target next minor (since it's a new feature) as well?
@drbrain, so I think I'll want to change this ticket... -
10:53 AM Feature #9098: Indent heredoc against the left margin by default when "indented closing identifier" is turned on.
- On Sat, Nov 9, 2013 at 4:18 PM, sikachu (Prem Sichanugrist) <s@sikac.hu>
wrote:
I've been using here document (heredoc) for a while, and I've found out
> that it's very annoying that the content is always treated as flushed lef... -
- I prefer Avdi's idea in [ruby-core:58322] as it does not introduce incompatibility.
-
- I can see that. I actually just indented the example in without looking at the line width. My bad. :)
If the second example is *not* over 80 columns, would that still be consider worse for you? -
- I can see the second is worse, not better, because it runs over 80 columns on more lines which wrap in my editor.
-
- @drbrain I could, but then the code would look ugly when the non-heredoc section is well-indented, and especially if the heredoc is pretty long. Consider this example code:
~~~ruby
module Rails
class CommandsTasks # :nodoc:
a... -
- _th.tagをセットした後、EXEC_TAG()中のsetjmp()の中でスタックオーバーフローしているようですね。
これはどうしたものかなぁ。 -
- 運が悪いとsystemstackerrorにならず SEGV が発生する既知の現象に見えます。
-
12:34 PM Bug #9109 (Closed): extend したモジュールメソッドと RSpec の let で 2 つ同名を使ったときに segmentation fault になる
- =begin
以下のコードで segmentation fault を起こします。
require 'rspec'
module ExtendModule
def foo
'foo'
end
def bar
'bar'
end
end
describe 'foo' do
extend ExtendModule
let(:foo) { foo }
l... - 04:06 PM Revision 5caf6812 (git): * 2013-11-15
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43680 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/objspace/objspace_dump.c (dump_output): allow IO object as
output, and use Tempfile.create and return open file instead of
mkstemp() and path name for :file output.
[ruby-core:58266] [Bug #9102]
* test/objspace/test_objspace.... -
- Rational#to_d without argument. [Bug #8958]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43678 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Following code causes double free or corruption error.
require "continuation"
c = nil
at_exit { c.call }
at_exit { callcc {|_c| c = _c } } -
11:40 AM Revision c3c06ff7 (git): * ruby_atomic.h (ATOMIC_SIZE_CAS): fix compile error on Solaris since r43460.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43677 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- String#succ because it can make modified (wrong) auth_tag longer
than 16 bytes. The longer auth_tag makes that
EVP_CIPHER_CTX_ctrl (and internally aes_gcm_ctrl) fail.
[ruby-core:55143] [Bug #8439] reported by Vit Ondruch.
git-s... -
- =begin
Ugh. This is a misfeature of msgpack, it should trust that RubyGems will do the right thing:
here = File.expand_path(File.dirname(__FILE__))
require File.join(here, 'msgpack', 'version')
begin
m = /(\d+.\d+)/.mat... -
- Yes, I will investigate.
-
- This issue was solved with changeset r43673.
Jack, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/thread/thread.c: [DOC] This patch accomplishes the followin... -
- * hash.c (hash_foreach_ensure): restore iter_lev to the previous
value, not just decrement. [ruby-dev:47803] [Bug #9105]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43675 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * hash.c (foreach_safe_i, hash_foreach_iter): deal with error detected
by ST_CHECK.
* st.c (st_foreach_check): call with non-error argument in normal case.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43674 b2dd03c8-39d4-4d8f-98f...
11/13/2013
-
11:36 PM Feature #9107 (Rejected): Introduce YES and NO as aliases of true and false
- I have a patch introducing the constants YES/NO as aliases of true/false. You can check it out here: https://github.com/gsamokovarov/ruby/compare/trunk...yes-no
While I don't expect this to be accepted, I think it can start a discussi... - 09:53 PM Feature #9023: Array#tail
- rest sounds definitely better. Clojure uses it and it feels very natural
and readable.
On Wed, Nov 13, 2013 at 7:59 AM, bozhidar (Bozhidar Batsov) <
bozhidar@batsov.com> wrote:
>
> Issue #9023 has been updated by bozh... -
06:59 PM Feature #9023: Array#tail
- I also dislike the name Array#tail, since it's commonly associated with linked lists, not arrays. I think a much better name would be Array#butfirst (and I've actually renamed Array#tail in powerpack to Array#butfirst). On a related note...
-
- This issue was solved with changeset r43668.
Marcus, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* ext/digest/*: [DOC] Fix several typos and broken http links.
... -
- - Teach RDoc about ConditionVariable
- Teach RDoc about Queue
- Teach RDoc about SizedQueue
- Use fully-qualified namespace for Document-method
This is necessary to separate definitions between classes
- Fix rdoc bug in call_... -
- Eric, could you handle this?
-
- 'gem install' should copy files of 'ext/**/*.so' of each installed gems, but doesn't.
$ ruby -v
ruby 2.1.0dev (2013-11-12 trunk 43653) [x86_64-linux]
$ gem install msgpack
Fetching: msgpack-0.5.7.gem (100%)
Building native e... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43672 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Why not make your content flush left?
- 03:15 PM Revision 647d4f5e (git): * 2013-11-14
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43671 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- commit 6895f38bfc3c0ad6bd212b8f9acc3c71384dfcb7
Author: Chikanaga Tomoyuki <nagachika00@gmail.com>
Date: Thu Nov 14 00:14:00 2013 +0900
* ChangeLog: fix a typo at r43666
* ext/openssl/ossl_asn1.c: ditto.
git-svn-id: svn+ssh:... -
10:50 AM Bug #9105 (Closed): callcc による不整合(例:Hash)
- =begin
以下のコードを実行すると、
equire 'continuation'
h = {1=>2,3=>4}
c = nil
f = false
h.each { callcc {|c2| c = c2 } }
unless f
f = true
c.call
end
h.each {|i| h.delete(1); p i}
以下のような結果になります。
[1, 2]
[false, ... -
- +precision+ argument for Rational#to_d [Bug #8958]
-This line, and those below, will be ignored--
M ChangeLog
M ext/bigdecimal/lib/bigdecimal/util.rb
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43669 b2dd03c8-39d4-4d8f-98f... -
- Improved examples for Digest overview and fixed a broken example in
Digest::HMAC overview. This patch also adds a description of
Digest::SHA256.bubblebabble to the Digest overview.
Patched by @stomar [Bug #9027]
git-svn-id: svn+... -
- - OpenSSL::ConfigError
- OpenSSL::Config::DEFAULT_CONFIG_FILE
Patched by @vbatts via GH-436
https://github.com/ruby/ruby/pull/436
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43667 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:29 AM Feature #8909: Expand "f" frozen suffix to literal arrays and hashes
- "charliesome (Charlie Somerville)" <charliesome@ruby-lang.org> wrote:
> My personal opinion on extending optimized #freeze to other literals
> is that it should be up to each implementation to decide on.
I agree. If an optimiz... - 07:33 AM Feature #8909: Expand "f" frozen suffix to literal arrays and hashes
- My personal opinion on extending optimized #freeze to other literals is that it should be up to each implementation to decide on.
-
- #8992 landed changes to optimize String#freeze, and #9043 deals with the possibility of adding a shortcut String#f method.
I believe this issue will now decide:
* Should the compiler optimize some form (or all forms) of literal Arr... -
- Fwiw, I am against adding aliases to the same method,
especially extremely short names which are hard to search for.
It is confusing and increases overhead for reading/following code.
Easy-to-write code is not necessary easy... -
- The change to optimize String#freeze has landed for #8992, which compiler-optimizes String#freeze. The only remaining decision is whether to also add #f with the same optimization.
matz likes the idea of String#f. I'm happy either way... -
- Ooops, didn't mean to close this only mention..
-
- This issue was solved with changeset r43657.
Ben, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* doc/regexp.rdoc: [DOC] add note about Bug #4044 as suggested by
... -
- OpenSSL::ASN1::ObjectId included a fix for the class overview, which
previously showed the documentation for Constructive due to missing
ObjectId overview. This patch also includes a note for Primative.
Based on a patch by @vbatts... -
- henry.maddocks (Henry Maddocks) wrote:
> How is this different to 'wrapping' an exception? Eg.
> ...
Not much different, but built-in and automatically available. -
08:04 AM Feature #8257: Exception#cause to carry originating exception along with new one
- How is this different to 'wrapping' an exception? Eg.
http://www.jayway.com/2011/05/25/ruby-an-exceptional-language/
-
- nobu (Nobuyoshi Nakada) wrote:
> Automagically captured exceptions doesn't feel `cause' to me, now.
> ...
That's true, but will that be the exception or the rule? It seems to me that most "hidden" or "suppressed" exceptions will be dir... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43665 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43664 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- - Integer#to_bn
- OpenSSL::Buffering module
- Document deprecated OpenSSL::Digest::Digest compatibility class
- OpenSSL::Config
These changes were based on a patch by @vbatts via GH-436
https://github.com/ruby/ruby/pull/436
... -
- * ext/io/console/io-console.gemspec: add a certification.
http://www.benjaminfleischer.com/2013/11/08/how-to-sign-your-rubygem-cert/
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43662 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- This has been completed as of revisions r43627 and r43634.
Thanks for the collaboration, everyone :-) -
- [Backport #9104]
the patch is provided by drbrain (Eric Hodel).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43661 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Reported by Alex Johnson on ruby-doc.org
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43660 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43659 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:05 AM Revision 4aaa510f (git): * 2013-11-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43658 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- duerst-san in [ruby-core:43612] [Fixes GH-443] Patched by @rosenfeld
https://github.com/ruby/ruby/pull/443
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43657 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- r43449, r43514 and r43525 are backported to ruby_2_0_0 at r43656.
11/12/2013
-
- https://github.com/ruby/ruby/pull/443
-
- On 2013/11/07 21:50, rosenfeld (Rodrigo Rosenfeld Rosas) wrote:
>
> Issue #4044 has been updated by rosenfeld (Rodrigo Rosenfeld Rosas).
>
>
> Shouldn't this bug be mentioned in the docs for \W in the Regexp documentation?
>... -
04:44 PM Bug #9103: Segmentation fault. ROR/rubypython/Sidekiq stack.
- Full error log attached.
-
- Sidekiq's worker with follow code (rubypython requirying is in application.rb):
def perform(args)
puts "Doing hard work #{args['paramss']}"
puts args["task"]
RubyPython.start(:python_exe => "python2.7")
d_link = Ruby... -
- * load.c (ruby_init_ext): share feature names between frame name and
provided features.
* load.c (rb_feature_p): deal with default loadable suffixes.
* load.c (load_lock): initialize statically linked extensio... -
- vcs.rb: split
* tool/vcs.rb: split from file2lastrev.rb.
* tool/rbinstall.rb (Gem::Specification.load): obtain spec date from
VCS for the case using git, RUBY_RELEASE_DATE is the last resort.
probably... -
- * common.mk: use RUNRUBY instead of MINIRUBY because MINIRUBY can't
require extension libraries. The patch is from nobu
(Nobuyoshi Nakada).
* configure.in (RUNRUBY): append -- only after runruby.rb, not
... -
- The encoding is set back to US-ASCII because the string is just 'foo'. If you change the string e.g. to "foo\u1234", then even after using Regexp.quote, it will keep UTF-8 as the encoding.
A US-ASCII Regexp will match against any UTF-... -
- On 2013/11/12 2:29, fuadksd (Fuad Saud) wrote:
>
> Issue #6727 has been updated by fuadksd (Fuad Saud).
>
>
> Reading back the comments, I realize Indexable may be a good idea for String/Array polymorphism.
The idea is al... -
- Reading back the comments, I realize Indexable may be a good idea for String/Array polymorphism.
-
06:58 AM Bug #8993: Request for clarification on method argument binding for keyword arguments
- No update on this? In case my previous posts were too confusing, here's the gist of it:
As far as I can tell, MRI does not implement the behavior that #8040 describes, so I think this is a bug. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43653 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 12:16 AM Revision 80c90e1b (git): * 2013-11-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@43652 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Fixed tests on Windows (I hope) by forcing platform for
platform-dependent tests.
Fixed File.exists? warnings.
Improved testing infrastructure.
* test/rubygems: ditto.
* test/rdoc/test_rdoc_rubygems_hook.rb: Switch to util_sp...