Project

General

Profile

Activity

From 04/28/2011 to 05/04/2011

05/04/2011

11:08 PM Revision 09c2f412 (git): * 2011-05-05
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31435 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:07 PM Revision d3802d71 (git): fix capture to avoid doing a sub on the useconds when parsing dates
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31434 b2dd03c8-39d4-4d8f-98ff-823fe69b080e tenderlovemaking (Aaron Patterson)
08:29 PM Feature #1291 (Closed): O_CLOEXEC flag missing for Kernel::open
r31430
kosaki (Motohiro KOSAKI)
06:46 PM Bug #3804 (Feedback): ruby crashed while running spork
could you paste log by CrashReporter on OSX(Darwin)?
It's located in ~/Library/Logs/CrashReporter/ruby-*.log
See Also: http://redmine.ruby-lang.org/projects/ruby/wiki/HowToReport
sorah (Sorah Fukumori)
06:11 PM Feature #4645 (Feedback): Pass existing buffer to getsockopt
There are cases when you need to pass a pre-initialized buffer to
getsockopt, but ruby currently doesn't support this.
For an example, see the API used by iptables to manipulate the firewall
rulesets (below). You have to set the tab...
candlerb (Brian Candler)
05:23 PM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
Hi

2011/5/4 Eric Wong <normalperson@yhbt.net>:
> KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
>> diff --git a/ext/-test-/wait_for_single_fd/wait_for_single_fd.c
>> b/ext/-test-/wait_for_single_fd/wait_for_single_fd.c
>> ind...
kosaki (Motohiro KOSAKI)
02:23 PM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> diff --git a/ext/-test-/wait_for_single_fd/wait_for_single_fd.c
> b/ext/-test-/wait_for_single_fd/wait_for_single_fd.c
> index d406724..6efd1af 100644
> --- a/ext/-test-/wait_...
normalperson (Eric Wong)
01:23 PM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
diff --git a/ext/-test-/wait_for_single_fd/wait_for_single_fd.c
b/ext/-test-/wait_for_single_fd/wait_for_single_fd.c
index d406724..6efd1af 100644
--- a/ext/-test-/wait_for_single_fd/wait_for_single_fd.c
+++ b/ext/-test-/wait_fo...
kosaki (Motohiro KOSAKI)
11:45 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
3 more safety patches + tests based on your comments in this thread:
1) rb_wait_for_single_fd: explain return value for poll() users
2) rb_wait_for_single_fd: have poll()-using impl set EBADF
3) rb_wait_for_single_fd: check for inva...
normalperson (Eric Wong)
11:23 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
Motohiro KOSAKI <kosaki.motohiro@gmail.com> wrote:
> I've commited following five patches.
>
> 0001-rb_wait_for_single_fd-initial-implementation.patch
> 0002-io-wait-switch-to-rb_wait_for_single_fd.patch
> 0003-ext-socket-ini...
normalperson (Eric Wong)
10:23 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
+int
+rb_wait_for_single_fd(int fd, int events, struct timeval *tv)
+{
+ struct pollfd fds;
+ int result, lerrno;
+ double start;
+ int timeout = tv ? tv->tv_sec * 1000 + (tv->tv_usec + 500) / 1000 : -1;

no ...
kosaki (Motohiro KOSAKI)
10:16 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
I've commited following five patches.
0001-rb_wait_for_single_fd-initial-implementation.patch
0002-io-wait-switch-to-rb_wait_for_single_fd.patch
0003-ext-socket-init.c-simplify-wait_connectable-using-rb.patch
0004-readline-use-rb_w...
kosaki (Motohiro KOSAKI)
09:29 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
-----------------------------------------------------------------------
int
rb_wait_for_single_fd(int fd, int events, struct timeval *tv)
{
(snip)
BLOCKING_REGION({
result = poll(&fds, 1, timeout);
if (result ...
kosaki (Motohiro KOSAKI)
08:30 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
Your patch improve single fd case. but slightly decrease multiple fd case.
The most important usecase of IO.select is web server application (ie multiple fd case).
It's no good trade-off.
name before ruby 1.9.3dev (2011-05-03 tr...
kosaki (Motohiro KOSAKI)
08:23 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
> My patches don't touch the rb_thread_fd_select() code.  thread.c:2393
> is in rb_fd_copy(), not rb_thread_fd_select(), and is the following:
>
>   memcpy(dst->fdset, src, size);
>
> Shouldn't that be:
>
>   memcpy(dst->fdset...
kosaki (Motohiro KOSAKI)
12:23 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
Motohiro KOSAKI <kosaki.motohiro@gmail.com> wrote:
> Issue #4531 has been updated by Motohiro KOSAKI.
>
> Please do NOT send untested patch. :-/
>
> % ./ruby-single-wait benchmark/bm_io_select3.rb
> max fd: 100000 (results...
normalperson (Eric Wong)
02:29 PM Bug #4643 (Third Party's Issue): While running rake db:migrate
It seems mysql gem's issue. naruse (Yui NARUSE)
01:24 PM Bug #4643 (Third Party's Issue): While running rake db:migrate
rake aborted!
Mysql::Error: query: not connected: SHOW TABLES
(See full trace by running task with --trace)
C:/Ruby192/bin/rake: [BUG] Segmentation fault
ruby 1.9.2p180 (2011-02-18) [i386-mingw32]
-- control frame ----------
c:...
ehshopon (Ehteshamul Haque)
02:29 PM Bug #4642 (Third Party's Issue): While running ralk db:migrate
It seems mysql gem's issue. naruse (Yui NARUSE)
01:21 PM Bug #4642 (Third Party's Issue): While running ralk db:migrate
rake aborted!
Mysql::Error: query: not connected: SHOW TABLES
(See full trace by running task with --trace)
C:/Ruby192/bin/rake: [BUG] Segmentation fault
ruby 1.9.2p180 (2011-02-18) [i386-mingw32]
-- control frame ----------
c:...
ehshopon (Ehteshamul Haque)
01:14 PM Revision f5b0f04d (git): * benchmark/bm_vm4_pipe.rb: Reduced iterations. Too slow benchmark
is bad.
* benchmark/bm_vm4_thread_pass.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31433 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
01:10 PM Revision 674a33ed (git): * test/date/test_date_base.rb: don't use no message skip().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31432 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
12:13 PM Revision 512624b6 (git): * benchmark/bm_io_select2.rb: reduce number of using file
descriptors. because gdb need some fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31431 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
11:29 AM Revision be62297f (git): * io.c (Init_IO): Added File::CLOEXEC constant. [ruby-core:22893] [Feature #1291]
* test/ruby/test_io.rb (TestIO#test_o_cloexec): test for File::CLOEXEC.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31430 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
10:02 AM Revision c06da473 (git): * thread.c (rb_wait_for_single_fd): Fix wrong return value.
* test/-ext-/wait_for_single_fd/test_wait_for_single_fd.rb
(TestWaitForSingleFD#test_wait_for_closed_pipe): test for it.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31429 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
09:50 AM Revision 2a989121 (git): * ext/-test-/wait_for_single_fd: New. for testing
rb_wait_for_single_fd() internal function.
The patch was written by Eric Wong. [ruby-core:35991]
* test/-ext-/wait_for_single_fd/test_wait_for_single_fd.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31428 b2dd03c8-39...
kosaki (Motohiro KOSAKI)
06:26 AM Revision 8a98c57f (git): fix a typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31427 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
03:47 AM Revision 951b0901 (git): * thread.c (rb_wait_for_single_fd): Added POLLNVAL check.
based on a patch from Eric Wong at [ruby-core:35991].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31426 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
02:54 AM Revision d7fa4d83 (git): * io.c (rb_f_select): remove useless ifdef.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31425 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
02:44 AM Revision 9851b0ce (git): * ext/socket/init.c (wait_connectable): fix error handling code.
RB_WAITFD_OUT is turned on even though an error occur.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31424 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
01:13 AM Revision 4da4cb04 (git): * ext/readline/readline.c (readline_event): use rb_wait_for_single_fd().
The patch was written by Eric Wong. [Ruby 1.9 - Feature #4531]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31423 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
01:12 AM Revision 82b2e801 (git): * ext/socket/init.c (wait_connectable): use rb_wait_for_single_fd().
The patch was written by Eric Wong. [Ruby 1.9 - Feature #4531]
* ext/socket/init.c (try_wait_connectable, wait_connectable_ensure):
removed.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31422 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
01:09 AM Revision cd796c60 (git): * ext/io/wait/wait.c (io_wait): use rb_wait_for_single_fd().
The patch was written by Eric Wong. [Ruby 1.9 - Feature #4531]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31421 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
01:07 AM Revision 249fe0e7 (git): * thread.c (rb_wait_for_single_fd): new. poll(2) based backend for rb_wait_for_single_fd().
Now only Linux uses it.
The patch was written by Eric Wong. [Ruby 1.9 - Feature #4531]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31420 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
12:59 AM Revision 9be37ca7 (git): * thread.c (rb_wait_for_single_fd): new.
* thread.c (select_single): select(2) based backend for rb_wait_for_single_fd().
* io.c (make_writeconv): use rb_wait_for_single_fd() instaed of
rb_thread_fd_select().
* io.c (rb_io_wait_readable): ditto.
* thread.c (rb_thread_wait_fd...
kosaki (Motohiro KOSAKI)

05/03/2011

11:06 PM Revision d47073de (git): * ext/psych/lib/psych/visitors/yaml_tree.rb: fix time dumping so that
Syck can load UTC times that Psych dumps.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31418 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
tenderlovemaking (Aaron Patterson)
10:43 PM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
Please do NOT send untested patch. :-/
% ./ruby-single-wait benchmark/bm_io_select3.rb
max fd: 100000 (results not apparent with <= 1024 max fd)
benchmark/bm_io_select3.rb:15: [BUG] Segmentation fault
ruby 1.9.3dev (2011-05-03 ...
kosaki (Motohiro KOSAKI)
07:45 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
I've updated the series with your suggestions and rebased against trunk r31412 and uploaded a new
mbox with the 6 following patches:
1. rb_wait_for_single_fd: initial implementation
2. io/wait: switch to rb_wait_for_single_fd()
3. ...
normalperson (Eric Wong)
10:37 PM Revision fb584746 (git): * 2011-05-04
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31417 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
10:37 PM Revision f081eca1 (git): * thread.c (rb_fd_copy): fix wrong argument.This issue was pointed
out by Eric Wong. [ruby-core:35982]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31416 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
09:52 PM Bug #4304 (Rejected): Win32上でfiber大量生成テストが失敗
再現できる人が現れないのでrejectしますね kosaki (Motohiro KOSAKI)
09:50 PM Bug #4387 (Rejected): test_socket_connect_nonblock(TestSocketAddrinfo) がまれに失敗する
進展する気がしないので、いったんrejectしますね。 kosaki (Motohiro KOSAKI)
08:35 PM Feature #2190: FileUtils::chmod - allow symbolic mode
I slightly change the testcase at r31415. because FreeBSD don't change sticky bit.
Thx.
kosaki (Motohiro KOSAKI)
07:32 PM Bug #3804: ruby crashed while running spork
also happened to me:
ruby -v ruby 1.9.2p180 (2011-02-18 revision 30909) [x86_64-darwin10.7.0]
/Users/eumir/.rvm/gems/ruby-1.9.2-p180@evolux/gems/spork-0.8.4/lib/spork/forker.rb:50: [BUG] pthread_mutex_lock: Invalid argument (EINV...
corroded (Eumir Gaspar)
07:00 PM Bug #4393: windows commands starting with "@" should run at all
Note: ruby 1.8 makes different result. because we changed system() spec at ruby-1.9.
>> system("@ls.exe")
=> false
kosaki (Motohiro KOSAKI)
11:31 AM Revision 50522eb3 (git): * test/fileutils/test_fileutils.rb (TestFileUtils#test_chmod_symbol_mode):
Skip sticky bit test if the platform is FreeBSD. It doesn't allow to
change sticky bit if a target is regular file.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31415 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
09:31 AM Revision 7ad29955 (git): * test/date/test_date.rb (TestDate#test_coerce):
test for [ruby-core:35127].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31414 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
yugui (Yuki Sonoda)
05:29 AM Bug #4618: Encoding::ConverterNotFoundErrors on trunk (Windows mingw)
Thank you Nobu.
All looks good on Win7 32-bit using tdm-gcc 4.5.2 and upgraded to OpenSSL 1.0.0d:
sh-3.1$ ruby --version
ruby 1.9.3dev (2011-05-03 trunk 31412) [i386-mingw32]
sh-3.1$ make test-all TESTS='openssl psych'
...
# Ru...
jonforums (Jon Forums)
05:26 AM Bug #4640: trunk thread.c build failure (Windows mingw)
Thank you Nobu.
The build completes OK on Arch and tdm-gcc 4.5.2 (Win7 32-bit) but "make test" appears to hang/stick (timeout?) somewhere in test_thread.rb.
I'll try with mingw 4.5.2 and mingw-w64 4.5.3 and report back if there's a...
jonforums (Jon Forums)
03:57 AM Bug #4640 (Closed): trunk thread.c build failure (Windows mingw)
This issue was solved with changeset r31408.
Jon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* include/ruby/intern.h (rb_w32_fdcopy): add prototype. fixes
#...
nobu (Nobuyoshi Nakada)
04:45 AM Revision 227609ea (git): fix typos and remove some whitespaces
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31413 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)

05/02/2011

11:29 PM Bug #4640 (Closed): trunk thread.c build failure (Windows mingw)
While attempting to build trunk@31407 I get the following failure using both mingw.org GCC 4.5.2 and tdm-gcc GCC 4.5.2 on Win7 Ultimate 32-bit. The build successfully completes and "make test" passes when trying to reproduce with Arch 2.... jonforums (Jon Forums)
07:27 PM Revision 55a1b1d9 (git): * thread.c (rb_thread_select): preserve errno if no error
occurred.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31412 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
07:27 PM Revision ab8e05cc (git): * win32/win32.c (rb_w32_fdcopy): suppress a warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31411 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:05 PM Revision 7694c341 (git): * win32/win32.c: remove trailing spaces and no-cuddle "else".
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31410 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
06:57 PM Revision 690072a1 (git): * 2011-05-03
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31409 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:57 PM Revision 88559ce4 (git): * include/ruby/intern.h (rb_w32_fdcopy): add prototype. fixes
#4640
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31408 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
03:43 PM Bug #4639 (Rejected): net http segmentation fault in ruby 1.9.2-head/1.9.2-p180
I got a segmentation fault while running activemerchant in ruby 1.9.2 which i just got only now. It has been working like a charm way before and my guess is that this is related to my recent upgrade to Mac OSX version 10.6.7. but i would... corroded (Eumir Gaspar)
01:16 AM Feature #2190 (Closed): FileUtils::chmod - allow symbolic mode
r31407 kosaki (Motohiro KOSAKI)
01:12 AM Bug #4634: Segmentation fault on marshal_dump
=begin
Hi,
Your marshal_dump implementation seems to fall into stack overflow because of infinite recursion. I've got SystemStackError with script like below.
4634.rb
class A
def marshal_dump
dup.tap{|i| i.instance_var...
nagachika (Tomoyuki Chikanaga)
12:39 AM Bug #4555 (Closed): [PATCH] ext/socket/init.c: rsock_connect retries on interrupt
r31405
kosaki (Motohiro KOSAKI)

05/01/2011

04:16 PM Revision 0a1e7d15 (git): * lib/fileutils.rb (FileUtils#chmod): accept symbolic mode argument.
The patch was written by takkanm. [ruby-core:26029][Feature #2190]
* lib/fileutils.rb (FileUtils#fu_mode): new helper function.
* lib/fileutils.rb (FileUtils#symbolic_modes_to_i): ditto.
* lib/fileutils.rb (FileUtils#mode_mask): ditto.
...
kosaki (Motohiro KOSAKI)
03:38 PM Revision 0468df62 (git): * 2011-05-02
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31406 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:38 PM Revision 49b4510c (git): * ext/socket/init.c (rsock_connect): add to care EINTR. based
on a patch from Eric Wong at [ruby-core:35621][Bug #4555]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
02:29 PM Bug #4555: [PATCH] ext/socket/init.c: rsock_connect retries on interrupt
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> > Your patch looks reasonable to me, but maybe some platforms break under it...
>
> Can you please clarify this? Which platform break and why?

Nevermind, see below:

>...
normalperson (Eric Wong)
01:23 PM Bug #4555: [PATCH] ext/socket/init.c: rsock_connect retries on interrupt
> Your patch looks reasonable to me, but maybe some platforms break under it...

Can you please clarify this? Which platform break and why?


> I was trying to emulate rb_io_wait_writable() logic which calls
> rb_thread_fd_w...
kosaki (Motohiro KOSAKI)
12:23 PM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
>> Also, RB_POLLIN should be avoided.
>
> Huh? What would I use for events instead?
>
> Thanks for taking your time to review this!

I meant RB_POLLIN is not backend independ name.

thanks.
kosaki (Motohiro KOSAKI)
02:23 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> I'd suggest to make generic single fd waiting abstract function, like below.
> rb_wait_for_single_fd(int fd, int events, struct timeval *tv);
>
> Also, RB_POLLIN should be ...
normalperson (Eric Wong)
09:37 AM Revision 91799a2f (git): merges r30786, r30787 and r30797 from trunk into ruby_1_9_2.
--
* test/fileutils/fileasserts.rb: add message arguments.
--
* lib/fileutils.rb (FileUtils::LowMethods): make low level methods
in NoWrite and DryRun to do nothing. [ruby-dev:43129]
--
* test/fileutils/fileasserts.rb (assert_block): ...
yugui (Yuki Sonoda)
09:37 AM Revision 13a22e38 (git): merges r30784 from trunk into ruby_1_9_2.
--
* parse.y (lex_getline, parser_set_encode): set encoding of lines
in SCRIPT_LINES__ as source encoding. [ruby-dev:43168]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_2@31403 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
yugui (Yuki Sonoda)
09:37 AM Revision 3202eea1 (git): * thread.c (thread_s_kill): workaround for [ruby-core:35086].
fixes #4367.
* test/ruby/test_thread.rb (TestThread#test_kill_wrong_argument):
test for [ruby-core:35086].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_2@31402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
yugui (Yuki Sonoda)
09:37 AM Revision 0ca24ab2 (git): merges r30779 from trunk into ruby_1_9_2.
--
* string.c (str_utf8_nth): fixed a conditon of optimized lead
byte counting. [Bug #4366][ruby-dev:43170]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_2@31401 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
yugui (Yuki Sonoda)

04/30/2011

11:20 PM Bug #4636 (Closed): thread.c#do_select() が HAVE_RB_FD_INIT のケースを正しくハンドリングしていない
r31394-r31397 のコミットで直ってるはずです kosaki (Motohiro KOSAKI)
05:33 PM Bug #4636 (Closed): thread.c#do_select() が HAVE_RB_FD_INIT のケースを正しくハンドリングしていない
=begin
えっと。気づいたので起票しておきます
do_select()に
fd_set UNINITIALIZED_VAR(orig_read);
....
if (read) orig_read = *read;
なんて行がありますが、これはあからさまに間違っていて、たとえば最近のBSDだと
http://netbsd.gw.com/cgi-bin/man-cgi?select++NetBSD-4.0
...
kosaki (Motohiro KOSAKI)
04:22 PM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
=begin
I also commited io_select_using_poll_test.rb (but modified a little) at r31390.
=end
kosaki (Motohiro KOSAKI)
08:23 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
=begin
Motohiro KOSAKI <kosaki.motohiro@gmail.com> wrote:
> Issue #4531 has been updated by Motohiro KOSAKI.
>
>
> commnet for patch 0001.
>
> begin
> require 'io/wait'
> rescue LoadError
> end
>
> shold be
...
normalperson (Eric Wong)
03:46 AM Feature #4531: [PATCH 0/7] use poll() instead of select() in certain cases
=begin
commnet for patch 0001.
begin
require 'io/wait'
rescue LoadError
end
shold be
begin
require 'io/wait'
rescue LoadError
# skip this test.
return
end
If we can't load io/wait, why do we need to run the te...
kosaki (Motohiro KOSAKI)
04:08 PM Revision 4d881692 (git): * thread.c (rb_thread_select): release GVL while waiting select().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31400 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
04:02 PM Revision 3cea846e (git): * 2011-05-01
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31399 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:02 PM Revision e140be69 (git): fix commit mistake of r31389.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31398 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
02:11 PM Revision 04202dc8 (git): * win32/win32.c (rb_w32_fdcopy): New. This can copy even though
fdset size exceed FD_SETSIZE.
* include/ruby/intern.h (rb_fd_copy): use rb_w32_fdcopy()
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
11:23 AM Revision 3c68095b (git): * thread.c (do_select): Change arugment type to rb_fdset_t.
Now do_select() is free from unexpected hangup if
HAVE_RB_FD_INIT=1 [Bug #4636]
* thread.c (rb_thread_fd_select, rb_thread_wait_fd_rw):
adapt new argument type.
* thread.c (rb_thread_select): make dummy implementation.
git-svn-i...
kosaki (Motohiro KOSAKI)
11:18 AM Revision 225fa965 (git): * thread.c (rb_fd_copy): Change function argument. Now
rb_fd_copy() has fully copy semantics.
* include/ruby/intern.h: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31395 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
11:15 AM Revision 2d2544c8 (git): * include/ruby/intern.h (rb_thread_select): mark as deprecated.
* ext/io/wait/wait.c (wait_readable): use rb_thread_fd_select
instead of rb_thread_select.
* ext/socket/init.c (wait_connectable0): ditto.
* ext/readline/readline.c (readline_event): ditto.
* io.c (rb_io_wait_readable, wait_readable, r...
kosaki (Motohiro KOSAKI)
11:08 AM Revision 4c926e9f (git): * thread.c (do_select): remove useless ifdef. time calculation
is not heavy weight.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
07:49 AM Revision 5201602c (git): * benchmark/bm_io_select3.rb: New.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31392 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
07:30 AM Revision 98c7ca9b (git): * io.c (copy_stream_body, rb_io_s_copy_stream): move rb_fd_init()
from copy_stream_body to rb_io_s_copy_stream. fds of passing
rb_fd_term() have to be guaranteed initialized.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31391 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
07:16 AM Revision 568c9343 (git): * benchmark/bm_io_select.rb, benchmark/bm_io_select2.rb: New.
based on a patch from Eric Wong at [Feature #4531]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31390 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
03:54 AM Feature #2190 (Assigned): FileUtils::chmod - allow symbolic mode
=begin
Hi
This request seems very reasonable to me. I'll review the patch later.
=end
kosaki (Motohiro KOSAKI)
03:37 AM Feature #2190: FileUtils::chmod - allow symbolic mode
=begin
+1
we have a million `chmod ...` expressions lurking because of this omission. please accept this into trunk!
=end
anthezium (ted cooper)
03:23 AM Feature #3905: rb_clear_cache_by_class() called often during GC for non-blocking I/O
=begin
Motohiro KOSAKI <kosaki.motohiro@gmail.com> wrote:
> r29673 caused a regression (see [Bug #4289]). Then, I reverted it by r31378.
> Alternative fixing way is discussed by [Bug #4289] thread.

I've pushed the ephemeral cla...
normalperson (Eric Wong)

04/29/2011

11:22 PM Feature #4632: Regexp instance method | for creating Regexp.unions
=begin
Thanks for the quick answer.
=end
rbjl (Jan Lelis)
10:33 PM Feature #4632 (Rejected): Regexp instance method | for creating Regexp.unions
=begin
We once had this feature, eregex.rb, but dropped since 1.9. No once nursed that lib.
I don't stop you to have such tiny lib as a gem. If that gem was used widely, chances are that we might invite that as our standard again so...
shyouhei (Shyouhei Urabe)
10:23 PM Feature #4632: Regexp instance method | for creating Regexp.unions
=begin
I like it for Regexp, but a string method would violate the POLS, imho.

Konstantin

On Apr 29, 2011, at 14:59 , Jan Lelis wrote:

>
> Issue #4632 has been reported by Jan Lelis.
>
> -----------------------------------...
rkh (Konstantin Haase)
09:59 PM Feature #4632 (Rejected): Regexp instance method | for creating Regexp.unions
=begin
Regexp.union is a great feature, but it is rarely used. I can imagine, the following syntax would be quite popular:
For example:
/Ruby\d/ | /test/i | "cheat" #=> Regexp.union( Regexp.union( /Ruby\d/, /test/i ), "cheat" )
...
rbjl (Jan Lelis)
10:20 PM Bug #4634 (Rejected): Segmentation fault on marshal_dump
=begin
Call
...
def marshal_dump
dup.tap{|i| i.instance_variable_set(:@callbacks,[]) }
end
...
=>>>
[BUG] Segmentation fault
ruby 1.9.2p180 (2011-02-18 revision 30909) [x86_64-linux]

-- control frame ----------...
asozontov (Anton Sozontov)
10:01 PM Feature #4633 (Rejected): iterate method / extended version of for
=begin
The Ruby world is known for using each, but it does not always look nice (although in most cases it does).
I am proposing an iterate method that is nicely readable and allows easy iteration over multiple objects. It behaves li...
rbjl (Jan Lelis)
07:09 PM Revision b48537cd (git): * test/io/wait/test_io_wait.rb: New. for testing ext/io/wait.
the patch was written by Eric Wong. [Feature #4531]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
04:18 PM Revision d4dcad87 (git): fix eol-style
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31388 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
03:50 PM Revision 1bbab743 (git): spell fix
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
03:43 PM Revision 58e414b8 (git): * include/ruby/win32.h: remove redundunt declaration of
rb_w32_time_subtract().
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31386 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
03:20 PM Revision 708034fe (git): * 2011-04-30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:20 PM Revision ada9870a (git): * thread_pthread.c (gvl_init): fix hangup if GVL_SIMPLE_LOCK=1.
We don't have to call mutex_unlock() before initialize it!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31384 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
12:23 PM Feature #4607: benchmark/bm_vm3_thread_mutex.rb の性能改善
=begin
まつもと ゆきひろです

In message "Re: [ruby-dev:43454] [Ruby 1.9 - Feature #4607][Closed] benchmark/bm_vm3_thread_mutex.rb の性能改善"
on Fri, 29 Apr 2011 10:17:26 +0900, Motohiro KOSAKI <kosaki.motohiro@gmail.com> writes:

|添付のよ...
matz (Yukihiro Matsumoto)
12:23 PM Feature #4607: benchmark/bm_vm3_thread_mutex.rb の性能改善
=begin
まつもと ゆきひろです

In message "Re: [ruby-dev:43454] [Ruby 1.9 - Feature #4607][Closed] benchmark/bm_vm3_thread_mutex.rb の性能改善"
on Fri, 29 Apr 2011 10:17:26 +0900, Motohiro KOSAKI <kosaki.motohiro@gmail.com> writes:

|添付のよ...
matz (Yukihiro Matsumoto)
10:17 AM Feature #4607 (Closed): benchmark/bm_vm3_thread_mutex.rb の性能改善
=begin
r31373
=end
kosaki (Motohiro KOSAKI)
12:12 PM Revision 5f131b64 (git): * thread_win32.c, include/ruby/win32.h: add prototypes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31383 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
11:47 AM Bug #4623: Consistent crash related to action_mailer
Possibly different:
-- control frame ----------
c:0075 p:0021 s:0350 b:0348 l:000347 d:000347 METHOD /Users/alex/.rvm/gems/ruby-1.9.2-p180/gems/activesupport-3.0.5/lib/active_support/buffered_logger.rb:129
c:0074 p:0097 s:0345 b:0345 l:...
alexneth (Alex Neth)
10:32 AM Bug #4289: Timeouts in threads cause SEGV
=begin
0001-revert-r29673-optimization-which-caused-segfaults.patch was commited as r31378.
I think other patch need to get Tanaka-san's review.
=end
kosaki (Motohiro KOSAKI)
10:32 AM Feature #3905: rb_clear_cache_by_class() called often during GC for non-blocking I/O
=begin
r29673 caused a regression (see [Bug #4289]). Then, I reverted it by r31378.
Alternative fixing way is discussed by [Bug #4289] thread.
=end
kosaki (Motohiro KOSAKI)
10:24 AM Bug #4618 (Closed): Encoding::ConverterNotFoundErrors on trunk (Windows mingw)
=begin
This issue was solved with changeset r31377.
Jon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* io.c (make_writeconv): do not add textmode newline decora...
nobu (Nobuyoshi Nakada)
02:54 AM Bug #4618 (Assigned): Encoding::ConverterNotFoundErrors on trunk (Windows mingw)
=begin
=end
usa (Usaku NAKAMURA)
10:24 AM Bug #4619 (Closed): io.c is broken on Windows
=begin
This issue was solved with changeset r31377.
Jon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* io.c (make_writeconv): do not add textmode newline decora...
nobu (Nobuyoshi Nakada)
06:50 AM Feature #4589: add Queue#each() method and include Enumerable
=begin
I don't think it is appropriate to include Enumerable. Too many methods from Enumerable seem inappropriate (or behavior would be application-specific). For example, should #find block, or only return items that match in the Queu...
drbrain (Eric Hodel)
04:52 AM Bug #4630 (Closed): PROCDEBUG to non-zero values causes segmentation faults in check_env in trunk

PROCDEBUG is meant to show debugging output from the vm.
However, when it's activated in vm.c
#define PROCDEBUG 1
The make process fails in segmentation faults.
I've narrowed it down to the following variables displayed in check_...
ehuard (Elise Huard)
04:18 AM Revision b4c5fad4 (git): * thread_win32.c (native_cond_timedwait): New. r31373 caused
win32 build failure.
* thread_win32.c (__cond_timedwait, abs_timespec_to_timeout_ms):
New helper functions.
* win32/win32.c (rb_w32_time_subtract): rename from subtract and
remove static.
git-svn-id: svn+ssh://ci.ruby-lang.org/r...
kosaki (Motohiro KOSAKI)
03:23 AM Revision 9d4ae4ab (git): fix indentation
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
02:06 AM Revision eaca3529 (git): set svn:eol-style property
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
01:44 AM Revision 3c24bc37 (git): * benchmark/bm_vm4_pipe.rb: Add two new benchmark for GVL
performance. They was written by Koichi Sasada.
* benchmark/bm_vm4_thread_pass.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
01:29 AM Revision e4ba4b79 (git): * vm_method.c (rb_clear_cache_by_class): Revert r29673. It made
a segmentation fault regression. [Bug #4289][ruby-core:34554].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
01:24 AM Revision 85c1d5d4 (git): * io.c (make_writeconv): do not add textmode newline decorator if any
newline decorator is set already. fixes #4618, fixes #4619
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
01:18 AM Revision 7ff7a2b3 (git): ChangeLog change.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
01:18 AM Revision 6998f013 (git): * thread.c (lock_func): small cleanup.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31375 b2dd03c8-39d4-4d8f-98ff-823fe69b080e kosaki (Motohiro KOSAKI)
01:11 AM Revision 32ae0ae1 (git): * 2011-04-29
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31374 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:11 AM Revision 74c5e807 (git): * thread.c (rb_mutex_lock, lock_func): Avoid busy loop and
performance degression. bm_vm3_thread_mutex.rb performance
change from 109.064sec to 16.331sec.
* thread.c (init_lock_timeout): New helper function.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31373 b2dd03c8-39d4-4d8f-98ff-82...
kosaki (Motohiro KOSAKI)

04/28/2011

04:23 PM Bug #3990: tests of rexml/rss reports many errors and failures without iconv
=begin
西山和広です。

At Thu, 3 Mar 2011 19:25:34 +0900,
SASADA Koichi wrote:
>
> (2011/03/03 19:12), U.Nakamura wrote:
> > ささださんもいたはずの、RubyKaigi 2010の開発者ミーティングで
> > 出てましたよ。
> > 議事録には Before Jul, 2011 (RubyKaigi? RubyConf?) と...
znz (Kazuhiro NISHIYAMA)
04:23 PM Bug #3990: tests of rexml/rss reports many errors and failures without iconv
=begin
西山和広です。

At Thu, 3 Mar 2011 19:25:34 +0900,
SASADA Koichi wrote:
>
> (2011/03/03 19:12), U.Nakamura wrote:
> > ささださんもいたはずの、RubyKaigi 2010の開発者ミーティングで
> > 出てましたよ。
> > 議事録には Before Jul, 2011 (RubyKaigi? RubyConf?) と...
znz (Kazuhiro NISHIYAMA)
04:22 PM Bug #4491 (Closed): Some methods of Dir/File do not encode dirname/filename transparently
=begin
This issue was solved with changeset r31372.
Joey, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* win32/{win32.c,dir.h} (rb_w32_uopendir): new API to pass...
usa (Usaku NAKAMURA)
02:53 PM Bug #4491: Some methods of Dir/File do not encode dirname/filename transparently
=begin
We now consider that this is a bug.
Current code is too complex, so to judge the reason why somebody wrote such code is difficult.
We want to get time a little more, sorry.
=end
usa (Usaku NAKAMURA)
02:15 PM Bug #4491: Some methods of Dir/File do not encode dirname/filename transparently
=begin
=end
naruse (Yui NARUSE)
02:54 PM Bug #4619 (Assigned): io.c is broken on Windows
=begin
test-allのエラーはまったく直ってないので、再オープンしときます。
現状、これに起因すると思われるエラーが私の手元では95個あります。
=end
usa (Usaku NAKAMURA)
06:07 AM Bug #4619 (Closed): io.c is broken on Windows
=begin
This issue was solved with changeset r31367.
Usaku, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* io.c (rb_io_extract_modeenc, rb_f_backquote): set defau...
nobu (Nobuyoshi Nakada)
02:23 PM Feature #4602: naming ruby dll (win32/64)
=begin
こんにちは、なかむら(う)です。

In message "[ruby-dev:43449] Re: [Ruby 1.9 - Feature #4602] naming ruby dll (win32/64)"
on Apr.28,2011 04:35:41, <kosaki.motohiro@gmail.com> wrote:
> > # Feature の場合、この後はどうするのが良いのでしょう? しばらく寝かしておいてある日...
usa (Usaku NAKAMURA)
02:23 PM Feature #4602: naming ruby dll (win32/64)
=begin
こんにちは、なかむら(う)です。

In message "[ruby-dev:43449] Re: [Ruby 1.9 - Feature #4602] naming ruby dll (win32/64)"
on Apr.28,2011 04:35:41, <kosaki.motohiro@gmail.com> wrote:
> > # Feature の場合、この後はどうするのが良いのでしょう? しばらく寝かしておいてある日...
usa (Usaku NAKAMURA)
05:23 AM Feature #4602: naming ruby dll (win32/64)
=begin
> artonです。
>
> なかむら(う)さんの案に賛成します。
> # Feature の場合、この後はどうするのが良いのでしょう? しばらく寝かしておいてある日パッチを入れるとか、いきなりパッチしてしまうとか?

- 言語仕様に関わる部分ではない
- x64ユーザ数を考えるとミスってても、あとから変えてしまったところでたいして苦情はでなさそう

とか考えるといきなり入れてしまっていいのではないでしょうか。
=end
kosaki (Motohiro KOSAKI)
05:23 AM Feature #4602: naming ruby dll (win32/64)
=begin
> artonです。
>
> なかむら(う)さんの案に賛成します。
> # Feature の場合、この後はどうするのが良いのでしょう? しばらく寝かしておいてある日パッチを入れるとか、いきなりパッチしてしまうとか?

- 言語仕様に関わる部分ではない
- x64ユーザ数を考えるとミスってても、あとから変えてしまったところでたいして苦情はでなさそう

とか考えるといきなり入れてしまっていいのではないでしょうか。
=end
kosaki (Motohiro KOSAKI)
01:08 AM Feature #4602: naming ruby dll (win32/64)
=begin
artonです。
なかむら(う)さんの案に賛成します。
# Feature の場合、この後はどうするのが良いのでしょう? しばらく寝かしておいてある日パッチを入れるとか、いきなりパッチしてしまうとか?
=end
arton (Akio Tajima)
07:22 AM Revision 22d5cf92 (git): * win32/{win32.c,dir.h} (rb_w32_uopendir): new API to pass UTF-8 path.
* win32/win32.c (opendir_internal, rb_w32_opendir): extract and merge
common part of rb_w32_opendir() and rb_w32_uopendir().
* dir.c (do_opendir, glob_helper): encoding.
* dir.c (dir_initialize, do_opendir): convert path to UTF-8 and...
U.Nakamura
07:16 AM Bug #4623 (Rejected): Consistent crash related to action_mailer
ruby -Itest test/functional/documents_controller_test.rb
Loaded suite test/functional/documents_controller_test
Started
/Users/alex/.rvm/gems/ruby-1.9.2-p180/gems/mail-2.2.15/lib/mail/fields/content_type_field.rb:37: [BUG] Segmentat...
alexneth (Alex Neth)
06:34 AM Revision e269a71e (git): * test/dl/test_base.rb (DL::LIBC_SO): its always msvc*.dll on
mswin/mingw.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31371 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura
06:07 AM Bug #4603 (Closed): lib/csv.rb: when the :encoding parameter is not provided, the encoding of CSV data is treated as ASCII-8BIT
=begin
This issue was solved with changeset r31370.
yu, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
----------
* lib/csv.rb (CSV::open): suppress universal newline decorat...
nobu (Nobuyoshi Nakada)
12:09 AM Bug #4617: incorrect RbConfig::CONFIG["STRIP"] values
=begin
Just tested that the changeset works perfectly in all 3 configurations originally mentioned, thank you.
Should I make a separate request to backport to both ruby_1_9_2 and ruby_1_8_7?
Jon
=end
jonforums (Jon Forums)
 

Also available in: Atom