Project

General

Profile

Actions

Feature #10173

closed

Remove meaningless ensure

Feature #10173: Remove meaningless ensure

Added by gogotanaka (Kazuki Tanaka) about 11 years ago. Updated about 11 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:64583]

Description

I suppose 'empty ensure' like that ↓ has no meaning,

begin r.document args rescue Errno::EACCES => e dirname = File.dirname e.message.split("-")[1].strip raise Gem::FilePermissionError, dirname rescue Interrupt => e raise e rescue Exception => ex alert_error "While generating documentation for #{@spec.full_name}" ui.errs.puts "... MESSAGE: #{ex}" ui.errs.puts "... RDOC args: #{args.join(' ')}" ui.backtrace ex ui.errs.puts "(continuing with the rest of the installation)" ensure end 

So I remove that.


Files

EmptyEnsure.PATCH (385 Bytes) EmptyEnsure.PATCH gogotanaka (Kazuki Tanaka), 08/27/2014 09:22 AM

Updated by nagachika (Tomoyuki Chikanaga) about 11 years ago Actions #1 [ruby-core:64673]

The patch looks good to me.
But rubygems has upstream repository.

https://github.com/rubygems/rubygems/

Please report to it first.

Updated by gogotanaka (Kazuki Tanaka) about 11 years ago Actions #2 [ruby-core:64754]

@ Tomoyuki Chikanaga san

Thank you for letting me know.

I have reported to "https://github.com/rubygems/rubygems/" as you said.

https://github.com/rubygems/rubygems/pull/1003

Thanks, gogo.

Updated by hsbt (Hiroshi SHIBATA) about 11 years ago Actions #3 [ruby-core:65084]

  • Status changed from Open to Closed

I merged latest rubygems at r47582

Actions

Also available in: PDF Atom